122620 2013-10-10 13:35:49 -0700 currentThis and currentArguments crash if called from outside a callback 2013-10-10 15:01:56 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg commit-queue oldest_to_newest 938520 0 mhahnenberg 2013-10-10 13:35:49 -0700 The documentation for these methods claim that they will return nil if called from somewhere other than an API callback, but currently they both crash. 938531 1 213925 mhahnenberg 2013-10-10 13:51:20 -0700 Created attachment 213925 Patch 938562 2 213925 commit-queue 2013-10-10 15:01:55 -0700 Comment on attachment 213925 Patch Clearing flags on attachment: 213925 Committed r157258: <http://trac.webkit.org/changeset/157258> 938563 3 commit-queue 2013-10-10 15:01:56 -0700 All reviewed patches have been landed. Closing bug. 213925 2013-10-10 13:51:20 -0700 2013-10-10 15:01:54 -0700 Patch bug-122620-20131010135119.patch text/plain 2570 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU3MjQ5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEzLTEwLTEwICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgY3VycmVudFRoaXMgYW5kIGN1cnJlbnRBcmd1bWVudHMgY3Jhc2ggaWYgY2FsbGVk IGZyb20gb3V0c2lkZSBhIGNhbGxiYWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMjI2MjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGUgZG9jdW1lbnRhdGlvbiBmb3IgdGhlc2UgbWV0aG9kcyBjbGFp bXMgdGhhdCB0aGV5IHdpbGwgcmV0dXJuIG5pbCBpZiBjYWxsZWQgCisgICAgICAgIGZyb20gc29t ZXdoZXJlIG90aGVyIHRoYW4gYW4gQVBJIGNhbGxiYWNrLCBidXQgY3VycmVudGx5IHRoZXkgYm90 aCBjcmFzaC4KKworICAgICAgICAqIEFQSS9KU0NvbnRleHQubW06CisgICAgICAgICgrW0pTQ29u dGV4dCBjdXJyZW50VGhpc10pOgorICAgICAgICAoK1tKU0NvbnRleHQgY3VycmVudEFyZ3VtZW50 c10pOgorICAgICAgICAqIEFQSS90ZXN0cy90ZXN0YXBpLm1tOgorCiAyMDEzLTEwLTEwICBNYXJr IEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgQ2FsbGJhY2tE YXRhIHVubmVjZXNzYXJpbHkgY2FjaGVzIHRoZSBKU1ZhbHVlIGZvciBjdXJyZW50VGhpcwpJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU0NvbnRleHQubW0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU0NvbnRleHQubW0JKHJldmlzaW9uIDE1NzI0OSkK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNDb250ZXh0Lm1tCSh3b3JraW5nIGNvcHkp CkBAIC0xMzYsNiArMTM2LDggQEAgKyAoSlNWYWx1ZSAqKWN1cnJlbnRUaGlzCiB7CiAgICAgV1RG VGhyZWFkRGF0YSYgdGhyZWFkRGF0YSA9IHd0ZlRocmVhZERhdGEoKTsKICAgICBDYWxsYmFja0Rh dGEgKmVudHJ5ID0gKENhbGxiYWNrRGF0YSAqKXRocmVhZERhdGEubV9hcGlEYXRhOworICAgIGlm ICghZW50cnkpCisgICAgICAgIHJldHVybiBuaWw7CiAgICAgcmV0dXJuIFtKU1ZhbHVlIHZhbHVl V2l0aEpTVmFsdWVSZWY6ZW50cnktPnRoaXNWYWx1ZSBpbkNvbnRleHQ6W0pTQ29udGV4dCBjdXJy ZW50Q29udGV4dF1dOwogfQogCkBAIC0xNDQsNiArMTQ2LDkgQEAgKyAoTlNBcnJheSAqKWN1cnJl bnRBcmd1bWVudHMKICAgICBXVEZUaHJlYWREYXRhJiB0aHJlYWREYXRhID0gd3RmVGhyZWFkRGF0 YSgpOwogICAgIENhbGxiYWNrRGF0YSAqZW50cnkgPSAoQ2FsbGJhY2tEYXRhICopdGhyZWFkRGF0 YS5tX2FwaURhdGE7CiAKKyAgICBpZiAoIWVudHJ5KQorICAgICAgICByZXR1cm4gbmlsOworCiAg ICAgaWYgKCFlbnRyeS0+Y3VycmVudEFyZ3VtZW50cykgewogICAgICAgICBKU0NvbnRleHQgKmNv bnRleHQgPSBbSlNDb250ZXh0IGN1cnJlbnRDb250ZXh0XTsKICAgICAgICAgc2l6ZV90IGNvdW50 ID0gZW50cnktPmFyZ3VtZW50Q291bnQ7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJ L3Rlc3RzL3Rlc3RhcGkubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0FQ SS90ZXN0cy90ZXN0YXBpLm1tCShyZXZpc2lvbiAxNTcyNDkpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvQVBJL3Rlc3RzL3Rlc3RhcGkubW0JKHdvcmtpbmcgY29weSkKQEAgLTk1Niw2ICs5NTYs MTEgQEAgdm9pZCB0ZXN0T2JqZWN0aXZlQ0FQSSgpCiAgICAgICAgIGNoZWNrUmVzdWx0KEAiZXhj ZXB0aW9uLm1lc3NhZ2UgaXMgY29ycmVjdCciLCBjb250ZXh0LmV4Y2VwdGlvbiAKICAgICAgICAg ICAgICYmIFtAIk9iamVjdGl2ZS1DIGJsb2NrcyBjYWxsZWQgYXMgY29uc3RydWN0b3JzIG11c3Qg cmV0dXJuIGFuIG9iamVjdC4iIGlzRXF1YWxUb1N0cmluZzpbY29udGV4dC5leGNlcHRpb25bQCJt ZXNzYWdlIl0gdG9TdHJpbmddXSk7CiAgICAgfQorCisgICAgQGF1dG9yZWxlYXNlcG9vbCB7Cisg ICAgICAgIGNoZWNrUmVzdWx0KEAiW0pTQ29udGV4dCBjdXJyZW50VGhpc10gPT0gbmlsIG91dHNp ZGUgb2YgY2FsbGJhY2siLCAhW0pTQ29udGV4dCBjdXJyZW50VGhpc10pOworICAgICAgICBjaGVj a1Jlc3VsdChAIltKU0NvbnRleHQgY3VycmVudEFyZ3VtZW50c10gPT0gbmlsIG91dHNpZGUgb2Yg Y2FsbGJhY2siLCAhW0pTQ29udGV4dCBjdXJyZW50QXJndW1lbnRzXSk7CisgICAgfQogfQogCiAj ZWxzZQo=