122616 2013-10-10 13:01:26 -0700 CallbackData unnecessarily caches the JSValue for currentThis 2013-10-10 13:48:50 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg commit-queue oldest_to_newest 938498 0 mhahnenberg 2013-10-10 13:01:26 -0700 CallbackData implements its own version of caching the JSValue* for the JSValueRef it stores. +[JSValue valueWithJSValueRef:inContext:] already does caching, thus obviating the need for CallbackData to do its own caching. 938506 1 213919 mhahnenberg 2013-10-10 13:08:04 -0700 Created attachment 213919 Patch 938528 2 213919 commit-queue 2013-10-10 13:48:48 -0700 Comment on attachment 213919 Patch Clearing flags on attachment: 213919 Committed r157249: <http://trac.webkit.org/changeset/157249> 938529 3 commit-queue 2013-10-10 13:48:50 -0700 All reviewed patches have been landed. Closing bug. 213919 2013-10-10 13:08:04 -0700 2013-10-10 13:48:48 -0700 Patch bug-122616-20131010130804.patch text/plain 3156 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU3MjQ2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDEzLTEwLTEwICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgQ2FsbGJhY2tEYXRhIHVubmVjZXNzYXJpbHkgY2FjaGVzIHRoZSBKU1ZhbHVlIGZv ciBjdXJyZW50VGhpcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTIyNjE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQ2FsbGJhY2tEYXRhIGltcGxlbWVudHMgaXRzIG93biB2ZXJzaW9uIG9mIGNhY2hpbmcg dGhlIEpTVmFsdWUqIGZvciB0aGUgSlNWYWx1ZVJlZiBpdCBzdG9yZXMuIAorICAgICAgICArW0pT VmFsdWUgdmFsdWVXaXRoSlNWYWx1ZVJlZjppbkNvbnRleHQ6XSBhbHJlYWR5IGRvZXMgY2FjaGlu ZywgdGh1cyBvYnZpYXRpbmcgdGhlIG5lZWQgZm9yIAorICAgICAgICBDYWxsYmFja0RhdGEgdG8g ZG8gaXRzIG93biBjYWNoaW5nLgorCisgICAgICAgICogQVBJL0pTQ29udGV4dC5tbToKKyAgICAg ICAgKCtbSlNDb250ZXh0IGN1cnJlbnRUaGlzXSk6CisgICAgICAgICgtW0pTQ29udGV4dCBiZWdp bkNhbGxiYWNrV2l0aERhdGE6dGhpc1ZhbHVlOmFyZ3VtZW50Q291bnQ6YXJndW1lbnRzOl0pOgor ICAgICAgICAoLVtKU0NvbnRleHQgZW5kQ2FsbGJhY2tXaXRoRGF0YTpdKToKKyAgICAgICAgKiBB UEkvSlNDb250ZXh0SW50ZXJuYWwuaDoKKwogMjAxMy0xMC0xMCAgRmlsaXAgUGl6bG8gIDxmcGl6 bG9AYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGwgb3V0IHIxNTcxOTMuIEl0 IGJyb2tlIHNvbWUgYnVpbGRzLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU0Nv bnRleHQubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU0NvbnRl eHQubW0JKHJldmlzaW9uIDE1NzI0MikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlND b250ZXh0Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xMzYsMTEgKzEzNiw3IEBAICsgKEpTVmFsdWUg KiljdXJyZW50VGhpcwogewogICAgIFdURlRocmVhZERhdGEmIHRocmVhZERhdGEgPSB3dGZUaHJl YWREYXRhKCk7CiAgICAgQ2FsbGJhY2tEYXRhICplbnRyeSA9IChDYWxsYmFja0RhdGEgKil0aHJl YWREYXRhLm1fYXBpRGF0YTsKLQotICAgIGlmICghZW50cnktPmN1cnJlbnRUaGlzKQotICAgICAg ICBlbnRyeS0+Y3VycmVudFRoaXMgPSBbW0pTVmFsdWUgYWxsb2NdIGluaXRXaXRoVmFsdWU6ZW50 cnktPnRoaXNWYWx1ZSBpbkNvbnRleHQ6W0pTQ29udGV4dCBjdXJyZW50Q29udGV4dF1dOwotCi0g ICAgcmV0dXJuIGVudHJ5LT5jdXJyZW50VGhpczsKKyAgICByZXR1cm4gW0pTVmFsdWUgdmFsdWVX aXRoSlNWYWx1ZVJlZjplbnRyeS0+dGhpc1ZhbHVlIGluQ29udGV4dDpbSlNDb250ZXh0IGN1cnJl bnRDb250ZXh0XV07CiB9CiAKICsgKE5TQXJyYXkgKiljdXJyZW50QXJndW1lbnRzCkBAIC0yMjYs NyArMjIyLDcgQEAgLSAodm9pZCliZWdpbkNhbGxiYWNrV2l0aERhdGE6KENhbGxiYWNrRAogICAg IFdURlRocmVhZERhdGEmIHRocmVhZERhdGEgPSB3dGZUaHJlYWREYXRhKCk7CiAgICAgW3NlbGYg cmV0YWluXTsKICAgICBDYWxsYmFja0RhdGEgKnByZXZTdGFjayA9IChDYWxsYmFja0RhdGEgKil0 aHJlYWREYXRhLm1fYXBpRGF0YTsKLSAgICAqY2FsbGJhY2tEYXRhID0gKENhbGxiYWNrRGF0YSl7 IHByZXZTdGFjaywgc2VsZiwgW3NlbGYuZXhjZXB0aW9uIHJldGFpbl0sIHRoaXNWYWx1ZSwgbmls LCBhcmd1bWVudENvdW50LCBhcmd1bWVudHMsIG5pbCB9OworICAgICpjYWxsYmFja0RhdGEgPSAo Q2FsbGJhY2tEYXRhKXsgcHJldlN0YWNrLCBzZWxmLCBbc2VsZi5leGNlcHRpb24gcmV0YWluXSwg dGhpc1ZhbHVlLCBhcmd1bWVudENvdW50LCBhcmd1bWVudHMsIG5pbCB9OwogICAgIHRocmVhZERh dGEubV9hcGlEYXRhID0gY2FsbGJhY2tEYXRhOwogICAgIHNlbGYuZXhjZXB0aW9uID0gbmlsOwog fQpAQCAtMjM2LDcgKzIzMiw2IEBAIC0gKHZvaWQpZW5kQ2FsbGJhY2tXaXRoRGF0YTooQ2FsbGJh Y2tEYXQKICAgICBXVEZUaHJlYWREYXRhJiB0aHJlYWREYXRhID0gd3RmVGhyZWFkRGF0YSgpOwog ICAgIHNlbGYuZXhjZXB0aW9uID0gY2FsbGJhY2tEYXRhLT5wcmVzZXJ2ZWRFeGNlcHRpb247CiAg ICAgW2NhbGxiYWNrRGF0YS0+cHJlc2VydmVkRXhjZXB0aW9uIHJlbGVhc2VdOwotICAgIFtjYWxs YmFja0RhdGEtPmN1cnJlbnRUaGlzIHJlbGVhc2VdOwogICAgIFtjYWxsYmFja0RhdGEtPmN1cnJl bnRBcmd1bWVudHMgcmVsZWFzZV07CiAgICAgdGhyZWFkRGF0YS5tX2FwaURhdGEgPSBjYWxsYmFj a0RhdGEtPm5leHQ7CiAgICAgW3NlbGYgcmVsZWFzZV07CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvQVBJL0pTQ29udGV4dEludGVybmFsLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL0FQSS9KU0NvbnRleHRJbnRlcm5hbC5oCShyZXZpc2lvbiAxNTcyNDIpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTQ29udGV4dEludGVybmFsLmgJKHdvcmtpbmcgY29w eSkKQEAgLTM3LDcgKzM3LDYgQEAgc3RydWN0IENhbGxiYWNrRGF0YSB7CiAgICAgSlNDb250ZXh0 ICpjb250ZXh0OwogICAgIEpTVmFsdWUgKnByZXNlcnZlZEV4Y2VwdGlvbjsKICAgICBKU1ZhbHVl UmVmIHRoaXNWYWx1ZTsKLSAgICBKU1ZhbHVlICpjdXJyZW50VGhpczsKICAgICBzaXplX3QgYXJn dW1lbnRDb3VudDsKICAgICBjb25zdCBKU1ZhbHVlUmVmICphcmd1bWVudHM7CiAgICAgTlNBcnJh eSAqY3VycmVudEFyZ3VtZW50czsK