122612 2013-10-10 12:01:00 -0700 Making the base implementation of isAudioStreamSource, in MediaStreamSource, return the correct value 2013-10-10 17:39:26 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 thiago.lacerda webkit-unassigned commit-queue eric.carlson glenn hta jer.noble mrobinson pnormand tommyw oldest_to_newest 938462 0 thiago.lacerda 2013-10-10 12:01:00 -0700 There is no reason for this implementation, in the base class, to always return false if we already have the information about the type of the source. 938468 1 213911 thiago.lacerda 2013-10-10 12:06:14 -0700 Created attachment 213911 Patch 938572 2 jer.noble 2013-10-10 15:25:10 -0700 This is great, but it doesn't go far enough. :) Could you also remove the isAudioStreamSource() method from MediaStreamAudioSource and make this method non-virtual? 938616 3 213948 thiago.lacerda 2013-10-10 17:00:25 -0700 Created attachment 213948 Patch 938619 4 213948 jer.noble 2013-10-10 17:13:26 -0700 Comment on attachment 213948 Patch r=me. 938623 5 213948 commit-queue 2013-10-10 17:39:23 -0700 Comment on attachment 213948 Patch Clearing flags on attachment: 213948 Committed r157280: <http://trac.webkit.org/changeset/157280> 938624 6 commit-queue 2013-10-10 17:39:26 -0700 All reviewed patches have been landed. Closing bug. 213911 2013-10-10 12:06:14 -0700 2013-10-10 17:00:18 -0700 Patch bug-122612-20131010160613.patch text/plain 1624 thiago.lacerda U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3MjM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmJmMzk1MzU4YjM4YTNh MDFkNDc2OGUxMWUxMDdjMDdmY2M5ZmEzOS4uMTBlYTUyZWRmYzQ0MTc5M2IxZWU4NzdlNGMzOGQ2 NGZlYTk3MDU3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTEwLTEwICBUaGlh Z28gZGUgQmFycm9zIExhY2VyZGEgIDx0aGlhZ28ubGFjZXJkYUBvcGVuYm9zc2Eub3JnPgorCisg ICAgICAgIE1ha2luZyB0aGUgYmFzZSBpbXBsZW1lbnRhdGlvbiBvZiBpc0F1ZGlvU3RyZWFtU291 cmNlLCBpbiBNZWRpYVN0cmVhbVNvdXJjZSwgcmV0dXJuIHRoZSBjb3JyZWN0IHZhbHVlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjI2MTIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSBpcyBubyBy ZWFzb24gZm9yIHRoaXMgaW1wbGVtZW50YXRpb24sIGluIHRoZSBiYXNlIGNsYXNzLCB0byBhbHdh eXMgcmV0dXJuIGZhbHNlCisgICAgICAgIGlmIHdlIGFscmVhZHkgaGF2ZSB0aGUgaW5mb3JtYXRp b24gYWJvdXQgdGhlIHR5cGUgb2YgdGhlIHNvdXJjZS4KKworICAgICAgICBObyBuZXcgdGVzdHMg bmVlZGVkLgorCisgICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW1Tb3Vy Y2UuaDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhU3RyZWFtU291cmNlOjppc0F1ZGlvU3RyZWFt U291cmNlKToKKwogMjAxMy0xMC0xMCAgQmVtIEpvbmVzLUJleSAgPGJqb25lc2JlQGFkb2JlLmNv bT4KIAogICAgICAgICBbQ1NTIFNoYXBlc10gTmV3IHBvc2l0aW9uaW5nIG1vZGVsOiBTaGFwZSBj cm9wcGVkIHRvIG1hcmdpbiBib3gKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L21lZGlhc3RyZWFtL01lZGlhU3RyZWFtU291cmNlLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbVNvdXJjZS5oCmluZGV4IDMyOGE4OTU3YzM2ZDNlZWU1 MzhjOGNkZjRmNjU3MDlkZjlmOGI1NDUuLjYzMWUyNDU2YzYxNmE4YzU5NTI5MjFmODVmN2MwYmNk MmJmMzNkZTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFt L01lZGlhU3RyZWFtU291cmNlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFz dHJlYW0vTWVkaWFTdHJlYW1Tb3VyY2UuaApAQCAtNjUsNyArNjUsNyBAQCBwdWJsaWM6CiAKICAg ICB2aXJ0dWFsIH5NZWRpYVN0cmVhbVNvdXJjZSgpIHsgfQogCi0gICAgdmlydHVhbCBib29sIGlz QXVkaW9TdHJlYW1Tb3VyY2UoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQorICAgIHZpcnR1YWwg Ym9vbCBpc0F1ZGlvU3RyZWFtU291cmNlKCkgY29uc3QgeyByZXR1cm4gdHlwZSgpID09IEF1ZGlv OyB9CiAgICAgdmlydHVhbCBib29sIHVzZUlERm9yVHJhY2tJRCgpIGNvbnN0IHsgcmV0dXJuIGZh bHNlOyB9CiAKICAgICB2b2lkIHJlc2V0KCk7Cg== 213948 2013-10-10 17:00:25 -0700 2013-10-10 17:39:23 -0700 Patch bug-122612-20131010210023.patch text/plain 2356 thiago.lacerda U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3MjczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjM1NzU4ZDRlNjc0YTNl NDg0N2YwNTI3ZmU5ODEyMjVhMDg4NTg4OC4uNGUyMzk3ZjU1NTNlODgxMGM0YTg4YzUwZmU5Yjll ZjBlMmFkYjkxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEzLTEwLTEwICBUaGlh Z28gZGUgQmFycm9zIExhY2VyZGEgIDx0aGlhZ28ubGFjZXJkYUBvcGVuYm9zc2Eub3JnPgogCisg ICAgICAgIE1ha2luZyB0aGUgYmFzZSBpbXBsZW1lbnRhdGlvbiBvZiBpc0F1ZGlvU3RyZWFtU291 cmNlLCBpbiBNZWRpYVN0cmVhbVNvdXJjZSwgcmV0dXJuIHRoZSBjb3JyZWN0IHZhbHVlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjI2MTIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSBpcyBubyBy ZWFzb24gZm9yIHRoaXMgaW1wbGVtZW50YXRpb24sIGluIHRoZSBiYXNlIGNsYXNzLCB0byBhbHdh eXMgcmV0dXJuIGZhbHNlCisgICAgICAgIGlmIHdlIGFscmVhZHkgaGF2ZSB0aGUgaW5mb3JtYXRp b24gYWJvdXQgdGhlIHR5cGUgb2YgdGhlIHNvdXJjZS4KKworICAgICAgICBObyBuZXcgdGVzdHMg bmVlZGVkLgorCisgICAgICAgICogTW9kdWxlcy93ZWJhdWRpby9NZWRpYVN0cmVhbUF1ZGlvU291 cmNlLmg6CisgICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW1Tb3VyY2Uu aDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhU3RyZWFtU291cmNlOjppc0F1ZGlvU3RyZWFtU291 cmNlKToKKworMjAxMy0xMC0xMCAgVGhpYWdvIGRlIEJhcnJvcyBMYWNlcmRhICA8dGhpYWdvLmxh Y2VyZGFAb3BlbmJvc3NhLm9yZz4KKwogICAgICAgICBbTWVkaWFTdHJlYW0gQVBJXSB1cGRhdGUg TWVkaWFTdHJlYW0gb2JqZWN0IHRvIG1hdGNoIHNwZWMKICAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTkzOQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL3dlYmF1ZGlvL01lZGlhU3RyZWFtQXVkaW9Tb3VyY2UuaCBiL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vTWVkaWFTdHJlYW1BdWRpb1NvdXJjZS5oCmluZGV4IDY0 MTAxZDRjODQwNzU2NTRjNTQ4ZDllYmEyYTMyYmIzNzAzMTNhZmYuLjJiZTgzMTk3NTczMzI4ZWI2 YTFkNWExOTI3M2E0OTc2NGVmYmQ5YTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvd2ViYXVkaW8vTWVkaWFTdHJlYW1BdWRpb1NvdXJjZS5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvd2ViYXVkaW8vTWVkaWFTdHJlYW1BdWRpb1NvdXJjZS5oCkBAIC00NSw3ICs0NSw2 IEBAIHB1YmxpYzoKIAogICAgIH5NZWRpYVN0cmVhbUF1ZGlvU291cmNlKCkgeyB9CiAKLSAgICB2 aXJ0dWFsIGJvb2wgaXNBdWRpb1N0cmVhbVNvdXJjZSgpIGNvbnN0IHsgcmV0dXJuIHRydWU7IH0K ICAgICB2aXJ0dWFsIGJvb2wgdXNlSURGb3JUcmFja0lEKCkgY29uc3QgeyByZXR1cm4gdHJ1ZTsg fQogCiAgICAgdmlydHVhbCBSZWZQdHI8TWVkaWFTdHJlYW1Tb3VyY2VDYXBhYmlsaXRpZXM+IGNh cGFiaWxpdGllcygpIGNvbnN0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bWVkaWFzdHJlYW0vTWVkaWFTdHJlYW1Tb3VyY2UuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L21lZGlhc3RyZWFtL01lZGlhU3RyZWFtU291cmNlLmgKaW5kZXggMzI4YTg5NTdjMzZkM2VlZTUz OGM4Y2RmNGY2NTcwOWRmOWY4YjU0NS4uZDY5ZTE0OTcyZGMzZWFhMTg3OWY5NTI4YmJlN2NhMGU0 NTQwNzFjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0v TWVkaWFTdHJlYW1Tb3VyY2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0 cmVhbS9NZWRpYVN0cmVhbVNvdXJjZS5oCkBAIC02NSw3ICs2NSw3IEBAIHB1YmxpYzoKIAogICAg IHZpcnR1YWwgfk1lZGlhU3RyZWFtU291cmNlKCkgeyB9CiAKLSAgICB2aXJ0dWFsIGJvb2wgaXNB dWRpb1N0cmVhbVNvdXJjZSgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CisgICAgYm9vbCBpc0F1 ZGlvU3RyZWFtU291cmNlKCkgY29uc3QgeyByZXR1cm4gdHlwZSgpID09IEF1ZGlvOyB9CiAgICAg dmlydHVhbCBib29sIHVzZUlERm9yVHJhY2tJRCgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CiAK ICAgICB2b2lkIHJlc2V0KCk7Cg==