122609 2013-10-10 11:40:25 -0700 REGRESSION (r157205?): Leaks in XPath 2013-10-10 20:50:15 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap darin commit-queue darin oldest_to_newest 938443 0 ap 2013-10-10 11:40:25 -0700 I started seeing leaks in XPath recently, looks like this broke yesterday or the day before. The bot <http://build.webkit.org/LeaksViewer/> sees them, and I could reproduce locally with: run-webkit-tests --child-processes=1 --leaks fast/xpath 938467 1 darin 2013-10-10 12:05:50 -0700 I plan to work on this tonight. 938661 2 213960 darin 2013-10-10 20:11:46 -0700 Created attachment 213960 Patch 938662 3 213960 kling 2013-10-10 20:15:38 -0700 Comment on attachment 213960 Patch LGTM 938668 4 213960 commit-queue 2013-10-10 20:50:13 -0700 Comment on attachment 213960 Patch Clearing flags on attachment: 213960 Committed r157287: <http://trac.webkit.org/changeset/157287> 938669 5 commit-queue 2013-10-10 20:50:15 -0700 All reviewed patches have been landed. Closing bug. 213960 2013-10-10 20:11:46 -0700 2013-10-10 20:50:13 -0700 Patch bug-122609-20131010201144.patch text/plain 3250 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3Mjg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmUxYjAyM2Q2NmY2YWY0 NjRiNTQ0Y2YwNjI1MThkMmYzNGUxNWMxYi4uYTUzZjUyMzJhZmI0YjYxNDcyNWQxMDFhOWU5MjNh MWNjY2Y4MjA2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTEwLTEwICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTU3MjA1 Pyk6IExlYWtzIGluIFhQYXRoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMjI2MDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIHhtbC9YUGF0aEdyYW1tYXIueTogRml4ZWQgd2FybmluZ3MgYnkgYWRkaW5n IG1pc3NpbmcgIiQkID0gJDEiIHRvIHZhcmlvdXMgcnVsZXMuCisgICAgICAgIEFkZGVkIGxvY2Fs IHVuaXF1ZV9wdHIgZm9yIE5vZGVUZXN0IGFuZCBBcmd1bWVudExpc3QgaW4gdGhyZWUgcnVsZXMs IHNvIHRoZXkKKyAgICAgICAgd29uJ3QgYmUgbGVha2VkLgorCiAyMDEzLTEwLTEwICBBbmRyZWFz IEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBLaWxsIFdlYkNvcmU6OkJpbmRp bmdTdGF0ZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3htbC9YUGF0aEdyYW1tYXIueSBi L1NvdXJjZS9XZWJDb3JlL3htbC9YUGF0aEdyYW1tYXIueQppbmRleCAxMDFhZTQ2OWNmNmExMGEz NjUzYjlmYjg3OWI0NmM0N2I2MjhjZGE1Li5hMzQwYTY5MjllZTBhMGFkMDkyZjUwMmI4ZGU5MWE5 NjE5MDhhMjhkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS94bWwvWFBhdGhHcmFtbWFyLnkK KysrIGIvU291cmNlL1dlYkNvcmUveG1sL1hQYXRoR3JhbW1hci55CkBAIC0xMTQsNiArMTE0LDcg QEAgRXhwcjoKIExvY2F0aW9uUGF0aDoKICAgICBBYnNvbHV0ZUxvY2F0aW9uUGF0aAogICAgIHsK KyAgICAgICAgJCQgPSAkMTsKICAgICAgICAgJCQtPnNldEFic29sdXRlKCk7CiAgICAgfQogICAg IHwKQEAgLTE0NywxMSArMTQ4LDEzIEBAIFJlbGF0aXZlTG9jYXRpb25QYXRoOgogICAgIHwKICAg ICBSZWxhdGl2ZUxvY2F0aW9uUGF0aCAnLycgU3RlcAogICAgIHsKKyAgICAgICAgJCQgPSAkMTsK ICAgICAgICAgJCQtPmFwcGVuZFN0ZXAoc3RkOjp1bmlxdWVfcHRyPFN0ZXA+KCQzKSk7CiAgICAg fQogICAgIHwKICAgICBSZWxhdGl2ZUxvY2F0aW9uUGF0aCBEZXNjZW5kYW50T3JTZWxmIFN0ZXAK ICAgICB7CisgICAgICAgICQkID0gJDE7CiAgICAgICAgICQkLT5hcHBlbmRTdGVwKHN0ZDo6dW5p cXVlX3B0cjxTdGVwPigkMikpOwogICAgICAgICAkJC0+YXBwZW5kU3RlcChzdGQ6OnVuaXF1ZV9w dHI8U3RlcD4oJDMpKTsKICAgICB9CkBAIC0xNjAsMTEgKzE2MywxMiBAQCBSZWxhdGl2ZUxvY2F0 aW9uUGF0aDoKIFN0ZXA6CiAgICAgTm9kZVRlc3QgT3B0aW9uYWxQcmVkaWNhdGVMaXN0CiAgICAg eworICAgICAgICBzdGQ6OnVuaXF1ZV9wdHI8U3RlcDo6Tm9kZVRlc3Q+IG5vZGVUZXN0KCQxKTsK ICAgICAgICAgc3RkOjp1bmlxdWVfcHRyPFZlY3RvcjxzdGQ6OnVuaXF1ZV9wdHI8RXhwcmVzc2lv bj4+PiBwcmVkaWNhdGVMaXN0KCQyKTsKICAgICAgICAgaWYgKHByZWRpY2F0ZUxpc3QpCi0gICAg ICAgICAgICAkJCA9IG5ldyBTdGVwKFN0ZXA6OkNoaWxkQXhpcywgc3RkOjptb3ZlKCokMSksIHN0 ZDo6bW92ZSgqcHJlZGljYXRlTGlzdCkpOworICAgICAgICAgICAgJCQgPSBuZXcgU3RlcChTdGVw OjpDaGlsZEF4aXMsIHN0ZDo6bW92ZSgqbm9kZVRlc3QpLCBzdGQ6Om1vdmUoKnByZWRpY2F0ZUxp c3QpKTsKICAgICAgICAgZWxzZQotICAgICAgICAgICAgJCQgPSBuZXcgU3RlcChTdGVwOjpDaGls ZEF4aXMsIHN0ZDo6bW92ZSgqJDEpKTsKKyAgICAgICAgICAgICQkID0gbmV3IFN0ZXAoU3RlcDo6 Q2hpbGRBeGlzLCBzdGQ6Om1vdmUoKm5vZGVUZXN0KSk7CiAgICAgfQogICAgIHwKICAgICBOQU1F VEVTVCBPcHRpb25hbFByZWRpY2F0ZUxpc3QKQEAgLTE4NywxMiArMTkxLDEzIEBAIFN0ZXA6CiAg ICAgfAogICAgIEF4aXNTcGVjaWZpZXIgTm9kZVRlc3QgT3B0aW9uYWxQcmVkaWNhdGVMaXN0CiAg ICAgeworICAgICAgICBzdGQ6OnVuaXF1ZV9wdHI8U3RlcDo6Tm9kZVRlc3Q+IG5vZGVUZXN0KCQy KTsKICAgICAgICAgc3RkOjp1bmlxdWVfcHRyPFZlY3RvcjxzdGQ6OnVuaXF1ZV9wdHI8RXhwcmVz c2lvbj4+PiBwcmVkaWNhdGVMaXN0KCQzKTsKIAogICAgICAgICBpZiAocHJlZGljYXRlTGlzdCkK LSAgICAgICAgICAgICQkID0gbmV3IFN0ZXAoJDEsIHN0ZDo6bW92ZSgqJDIpLCBzdGQ6Om1vdmUo KnByZWRpY2F0ZUxpc3QpKTsKKyAgICAgICAgICAgICQkID0gbmV3IFN0ZXAoJDEsIHN0ZDo6bW92 ZSgqbm9kZVRlc3QpLCBzdGQ6Om1vdmUoKnByZWRpY2F0ZUxpc3QpKTsKICAgICAgICAgZWxzZQot ICAgICAgICAgICAgJCQgPSBuZXcgU3RlcCgkMSwgc3RkOjptb3ZlKCokMikpOworICAgICAgICAg ICAgJCQgPSBuZXcgU3RlcCgkMSwgc3RkOjptb3ZlKCpub2RlVGVzdCkpOwogICAgIH0KICAgICB8 CiAgICAgQXhpc1NwZWNpZmllciBOQU1FVEVTVCBPcHRpb25hbFByZWRpY2F0ZUxpc3QKQEAgLTM0 MSw3ICszNDYsOCBAQCBGdW5jdGlvbkNhbGw6CiAgICAgRlVOQ1RJT05OQU1FICcoJyBBcmd1bWVu dExpc3QgJyknCiAgICAgewogICAgICAgICBTdHJpbmcgbmFtZSA9IGFkb3B0UmVmKCQxKTsKLSAg ICAgICAgJCQgPSBYUGF0aDo6RnVuY3Rpb246OmNyZWF0ZShuYW1lLCBzdGQ6Om1vdmUoKiQzKSku cmVsZWFzZSgpOworICAgICAgICBzdGQ6OnVuaXF1ZV9wdHI8VmVjdG9yPHN0ZDo6dW5pcXVlX3B0 cjxFeHByZXNzaW9uPj4+IGFyZ3VtZW50TGlzdCgkMyk7CisgICAgICAgICQkID0gWFBhdGg6OkZ1 bmN0aW9uOjpjcmVhdGUobmFtZSwgc3RkOjptb3ZlKCphcmd1bWVudExpc3QpKS5yZWxlYXNlKCk7 CiAgICAgICAgIGlmICghJCQpCiAgICAgICAgICAgICBZWUFCT1JUOwogICAgIH0KQEAgLTM3Niw2 ICszODIsOSBAQCBVbmlvbkV4cHI6CiAKIFBhdGhFeHByOgogICAgIExvY2F0aW9uUGF0aAorICAg IHsKKyAgICAgICAgJCQgPSAkMTsKKyAgICB9CiAgICAgfAogICAgIEZpbHRlckV4cHIKICAgICB8 Cg==