122601 2013-10-10 08:34:24 -0700 [CSS Shapes] clampToUnsigned() should return unsigned, not int 2013-10-10 12:21:29 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 121619 1 giles_joplin giles_joplin benjamin cmarcelo commit-queue esprehn+autocc glenn kling kondapallykalyan oldest_to_newest 938357 0 giles_joplin 2013-10-10 08:34:24 -0700 The patch for https://bugs.webkit.org/show_bug.cgi?id=121619 included a MathExtras.h clampToUnsigned() inline. I'd mistakenly given it an "int" return type. Of course the return type should be unsigned. 938391 1 213893 giles_joplin 2013-10-10 09:47:48 -0700 Created attachment 213893 Patch Corrected clampToUnsigned(). 938478 2 213893 commit-queue 2013-10-10 12:21:27 -0700 Comment on attachment 213893 Patch Clearing flags on attachment: 213893 Committed r157238: <http://trac.webkit.org/changeset/157238> 938479 3 commit-queue 2013-10-10 12:21:29 -0700 All reviewed patches have been landed. Closing bug. 213893 2013-10-10 09:47:48 -0700 2013-10-10 12:21:27 -0700 Patch tmp.patch text/plain 2690 giles_joplin ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggZDdjMjlmZS4uMTVlMTI0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMy0xMC0xMCAg SGFucyBNdWxsZXIgIDxobXVsbGVyQGFkb2JlLmNvbT4KKworICAgICAgICBbQ1NTIFNoYXBlc10g Y2xhbXBUb1Vuc2lnbmVkKCkgc2hvdWxkIHJldHVybiB1bnNpZ25lZCwgbm90IGludAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIyNjAxCisKKyAgICAg ICAgQ29ycmVjdGVkIHRoZSByZXR1cm4gdHlwZSBmb3IgY2xhbXBUb1Vuc2lnbmVkKCkgaW4gTWF0 aEV4dHJhcy5oLiBJdCdzIG5vdyB1bnNpZ25lZC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9NYXRoRXh0cmFzLmg6CisgICAgICAgIChjbGFt cFRvVW5zaWduZWQpOgorCiAyMDEzLTEwLTA4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5j b20+CiAKICAgICAgICAgRlRMIHNob3VsZCBiZSBhYmxlIHRvIGRvIHNpbXBsZSBPU1IgZXhpdHMg dXNpbmcgbGx2bS53ZWJraXQuc3RhY2ttYXAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL01h dGhFeHRyYXMuaCBiL1NvdXJjZS9XVEYvd3RmL01hdGhFeHRyYXMuaAppbmRleCA5YjIyM2E1Li5h MzhkMmU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9NYXRoRXh0cmFzLmgKKysrIGIvU291 cmNlL1dURi93dGYvTWF0aEV4dHJhcy5oCkBAIC0yOTYsNyArMjk2LDcgQEAgaW5saW5lIGludCBj bGFtcFRvSW50ZWdlcihkb3VibGUgdmFsdWUpCiAgICAgcmV0dXJuIGNsYW1wVG88aW50Pih2YWx1 ZSk7CiB9CiAKLWlubGluZSBpbnQgY2xhbXBUb1Vuc2lnbmVkKGRvdWJsZSB2YWx1ZSkKK2lubGlu ZSB1bnNpZ25lZCBjbGFtcFRvVW5zaWduZWQoZG91YmxlIHZhbHVlKQogewogICAgIHJldHVybiBj bGFtcFRvPHVuc2lnbmVkPih2YWx1ZSk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmNlOGIzOC4uM2JhZmQ0 MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTEwLTEwICBIYW5zIE11bGxlciAg PGhtdWxsZXJAYWRvYmUuY29tPgorCisgICAgICAgIFtDU1MgU2hhcGVzXSBjbGFtcFRvVW5zaWdu ZWQoKSBzaG91bGQgcmV0dXJuIHVuc2lnbmVkLCBub3QgaW50CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjI2MDEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3JyZWN0ZWQgdGhlIHJldHVybiB0eXBlIGZv ciBjbGFtcFRvVW5zaWduZWQoKSBpbiBNYXRoRXh0cmFzLmguIEl0J3Mgbm93IHVuc2lnbmVkLgor ICAgICAgICBObyBuZXcgdGVzdHMgc2luY2UgdGhpcyBpcyBqdXN0IGFuIGludGVybmFsIHJlZmFj dG9yaW5nIG9mIGV4aXN0aW5nIGNvZGUuCisKKyAgICAgICAgKiByZW5kZXJpbmcvc2hhcGVzL1Jh c3RlclNoYXBlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJhc3RlclNoYXBlOjptYXJnaW5JbnRl cnZhbHMpOiBVc2UgdGhlIHJlZGVmaW5lZCBjbGFtcFRvVW5zaWduZWQgbWV0aG9kLgorCiAyMDEz LTEwLTEwICBTZXJnaW8gQ29ycmVpYSAgPHNlcmdpby5jb3JyZWlhQG9wZW5ib3NzYS5vcmc+CiAK ICAgICAgICAgTWFrZSBYUGF0aEdyYW1tYXIueSBiaXNvbjMtZnJpZW5kbHkgYWdhaW4gYWZ0ZXIg cjE1NzIwNQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3NoYXBlcy9SYXN0 ZXJTaGFwZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc2hhcGVzL1Jhc3RlclNoYXBl LmNwcAppbmRleCAwNzA1NTVkLi5kYmVkYTAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvc2hhcGVzL1Jhc3RlclNoYXBlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvc2hhcGVzL1Jhc3RlclNoYXBlLmNwcApAQCAtMjQ0LDcgKzI0NCw3IEBAIGNvbnN0IFJh c3RlclNoYXBlSW50ZXJ2YWxzJiBSYXN0ZXJTaGFwZTo6bWFyZ2luSW50ZXJ2YWxzKCkgY29uc3QK ICAgICBpZiAoIXNoYXBlTWFyZ2luKCkpCiAgICAgICAgIHJldHVybiAqbV9pbnRlcnZhbHM7CiAK LSAgICB1bnNpZ25lZCBtYXJnaW5Cb3VuZGFyeVJhZGl1cyA9IHN0ZDo6bWluKGNsYW1wVG9VbnNp Z25lZChjZWlsKHNoYXBlTWFyZ2luKCkpKSwgc3RkOjptYXgobV9pbWFnZVNpemUud2lkdGgoKSwg bV9pbWFnZVNpemUuaGVpZ2h0KCkpKTsKKyAgICB1bnNpZ25lZCBtYXJnaW5Cb3VuZGFyeVJhZGl1 cyA9IHN0ZDo6bWluKGNsYW1wVG9VbnNpZ25lZChjZWlsKHNoYXBlTWFyZ2luKCkpKSwgc3RkOjpt YXg8dW5zaWduZWQ+KG1faW1hZ2VTaXplLndpZHRoKCksIG1faW1hZ2VTaXplLmhlaWdodCgpKSk7 CiAgICAgaWYgKCFtX21hcmdpbkludGVydmFscykKICAgICAgICAgbV9tYXJnaW5JbnRlcnZhbHMg PSBtX2ludGVydmFscy0+Y29tcHV0ZVNoYXBlTWFyZ2luSW50ZXJ2YWxzKG1hcmdpbkJvdW5kYXJ5 UmFkaXVzKTsKIAo=