122600 2013-10-10 08:09:22 -0700 [ATK] Missing checks in returnIfWebKitAccessibleIsInvalid 2013-10-10 09:18:22 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 mario webkit-unassigned aboxhall apinheiro cfleizach commit-queue dmazzoni jdiggs webkit-bug-importer oldest_to_newest 938349 0 mario 2013-10-10 08:09:22 -0700 Besides checking if an ATK wrapper has been detached to determine whether it's invalid or not, we also need to check if the coreObject's document is null, since that might have been invalidated even before we called any function of the ATK API. Actually, this additional check can save us from calling updateBackingStore, so bonus points 938350 1 webkit-bug-importer 2013-10-10 08:09:45 -0700 <rdar://problem/15197317> 938353 2 213886 mario 2013-10-10 08:15:08 -0700 Created attachment 213886 Patch proposal 938363 3 213886 cfleizach 2013-10-10 08:51:50 -0700 Comment on attachment 213886 Patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=213886&action=review > Source/WebCore/accessibility/atk/WebKitAccessibleUtil.h:46 > if (webkitAccessibleIsDetached(webkitAccessible)) \ does webkitAccessibleIsDetached also check if the document is null? 938365 4 mario 2013-10-10 08:55:40 -0700 (In reply to comment #3) > (From update of attachment 213886 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=213886&action=review > > > Source/WebCore/accessibility/atk/WebKitAccessibleUtil.h:46 > > if (webkitAccessibleIsDetached(webkitAccessible)) \ > > does webkitAccessibleIsDetached also check if the document is null? No. Only if the wrapped object is no longer a valid AccessibilityObject 938369 5 213886 commit-queue 2013-10-10 09:18:20 -0700 Comment on attachment 213886 Patch proposal Clearing flags on attachment: 213886 Committed r157227: <http://trac.webkit.org/changeset/157227> 938371 6 commit-queue 2013-10-10 09:18:22 -0700 All reviewed patches have been landed. Closing bug. 213886 2013-10-10 08:15:08 -0700 2013-10-10 09:18:20 -0700 Patch proposal 0001-2013-10-10-Mario-Sanchez-Prada-mario.prada-samsung.c.patch text/plain 3167 mario RnJvbSAwNjI3M2E0NmY5MjUwYjEzN2EyMDMwMmI4MDdkZTYzNTAxODA2YjI3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtYXJpby5wcmFkYUBzYW1z dW5nLmNvbT4KRGF0ZTogVGh1LCAxMCBPY3QgMjAxMyAxNjoxMjo0OSArMDEwMApTdWJqZWN0OiBb UEFUQ0hdIDIwMTMtMTAtMTAgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtYXJpby5wcmFkYUBzYW1z dW5nLmNvbT4KCiAgICAgICAgW0FUS10gTWlzc2luZyBjaGVja3MgaW4gcmV0dXJuSWZXZWJLaXRB Y2Nlc3NpYmxlSXNJbnZhbGlkCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyMjYwMAoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAg ICAgICAgQ2hlY2sgdGhhdCB0aGUgQWNjZXNzaWJpbGl0eU9iamVjdCBhc3NvY2lhdGVkIHRvIHRo ZSBBVEsgd3JhcHBlcgogICAgICAgIGlzIG5vdCBOVUxMIGFuZCBjb250YWlucyBhIHZhbGlkIHJl ZmVyZW5jZSB0byB0aGUgZG9jdW1lbnQgYmVmb3JlCiAgICAgICAgY2FsbGluZyBBY2Nlc3NpYmls aXR5T2JqZWN0Ojp1cGRhdGVCYWNraW5nU3RvcmUoKS4KCiAgICAgICAgKiBhY2Nlc3NpYmlsaXR5 L2F0ay9XZWJLaXRBY2Nlc3NpYmxlVXRpbC5oOiBBZGQgZXh0cmEgY2hlY2tzLgotLS0KIFNvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDEz ICsrKysrKysrKysrKysKIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFj Y2Vzc2libGVVdGlsLmggfCAgIDEwICsrKysrKysrLS0KIDIgZmlsZXMgY2hhbmdlZCwgMjEgaW5z ZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmNlOGIzOC4uZmUyZTg0 MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTEwLTEwICBNYXJpbyBTYW5jaGV6 IFByYWRhICA8bWFyaW8ucHJhZGFAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0FUS10gTWlzc2lu ZyBjaGVja3MgaW4gcmV0dXJuSWZXZWJLaXRBY2Nlc3NpYmxlSXNJbnZhbGlkCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjI2MDAKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGVjayB0aGF0IHRoZSBBY2Nl c3NpYmlsaXR5T2JqZWN0IGFzc29jaWF0ZWQgdG8gdGhlIEFUSyB3cmFwcGVyCisgICAgICAgIGlz IG5vdCBOVUxMIGFuZCBjb250YWlucyBhIHZhbGlkIHJlZmVyZW5jZSB0byB0aGUgZG9jdW1lbnQg YmVmb3JlCisgICAgICAgIGNhbGxpbmcgQWNjZXNzaWJpbGl0eU9iamVjdDo6dXBkYXRlQmFja2lu Z1N0b3JlKCkuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxl VXRpbC5oOiBBZGQgZXh0cmEgY2hlY2tzLgorCiAyMDEzLTEwLTEwICBTZXJnaW8gQ29ycmVpYSAg PHNlcmdpby5jb3JyZWlhQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgTWFrZSBYUGF0aEdyYW1t YXIueSBiaXNvbjMtZnJpZW5kbHkgYWdhaW4gYWZ0ZXIgcjE1NzIwNQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZVV0aWwuaCBiL1Nv dXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVVdGlsLmgKaW5k ZXggYmM3MDY1Zi4uZDAzMTJkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJp bGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZVV0aWwuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nl c3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlVXRpbC5oCkBAIC0zOSw3ICszOSwxMCBAQCBj bGFzcyBWaXNpYmxlU2VsZWN0aW9uOwogICAgIGlmICghd2Via2l0QWNjZXNzaWJsZSB8fCB3ZWJr aXRBY2Nlc3NpYmxlSXNEZXRhY2hlZCh3ZWJraXRBY2Nlc3NpYmxlKSkgeyBcCiAgICAgICAgIHJl dHVybjsgXAogICAgIH0gZWxzZSB7IFwKLSAgICAgICAgd2Via2l0QWNjZXNzaWJsZUdldEFjY2Vz c2liaWxpdHlPYmplY3Qod2Via2l0QWNjZXNzaWJsZSktPnVwZGF0ZUJhY2tpbmdTdG9yZSgpOyBc CisgICAgICAgIEFjY2Vzc2liaWxpdHlPYmplY3QqIGNvcmVPYmplY3QgPSB3ZWJraXRBY2Nlc3Np YmxlR2V0QWNjZXNzaWJpbGl0eU9iamVjdCh3ZWJraXRBY2Nlc3NpYmxlKTsgXAorICAgICAgICBp ZiAoIWNvcmVPYmplY3QgfHwgIWNvcmVPYmplY3QtPmRvY3VtZW50KCkpIFwKKyAgICAgICAgICAg IHJldHVybjsgXAorICAgICAgICBjb3JlT2JqZWN0LT51cGRhdGVCYWNraW5nU3RvcmUoKTsgXAog ICAgICAgICBpZiAod2Via2l0QWNjZXNzaWJsZUlzRGV0YWNoZWQod2Via2l0QWNjZXNzaWJsZSkp IFwKICAgICAgICAgICAgIHJldHVybjsgXAogICAgIH07IH0gR19TVE1UX0VORApAQCAtNDgsNyAr NTEsMTAgQEAgY2xhc3MgVmlzaWJsZVNlbGVjdGlvbjsKICAgICBpZiAoIXdlYmtpdEFjY2Vzc2li bGUgfHwgd2Via2l0QWNjZXNzaWJsZUlzRGV0YWNoZWQod2Via2l0QWNjZXNzaWJsZSkpIHsgXAog ICAgICAgICByZXR1cm4gKHZhbCk7IFwKICAgICB9IGVsc2UgeyBcCi0gICAgICAgIHdlYmtpdEFj Y2Vzc2libGVHZXRBY2Nlc3NpYmlsaXR5T2JqZWN0KHdlYmtpdEFjY2Vzc2libGUpLT51cGRhdGVC YWNraW5nU3RvcmUoKTsgXAorICAgICAgICBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBjb3JlT2JqZWN0 ID0gd2Via2l0QWNjZXNzaWJsZUdldEFjY2Vzc2liaWxpdHlPYmplY3Qod2Via2l0QWNjZXNzaWJs ZSk7IFwKKyAgICAgICAgaWYgKCFjb3JlT2JqZWN0IHx8ICFjb3JlT2JqZWN0LT5kb2N1bWVudCgp KSBcCisgICAgICAgICAgICByZXR1cm4gKHZhbCk7IFwKKyAgICAgICAgY29yZU9iamVjdC0+dXBk YXRlQmFja2luZ1N0b3JlKCk7IFwKICAgICAgICAgaWYgKHdlYmtpdEFjY2Vzc2libGVJc0RldGFj aGVkKHdlYmtpdEFjY2Vzc2libGUpKSBcCiAgICAgICAgICAgICByZXR1cm4gKHZhbCk7IFwKICAg ICB9OyB9IEdfU1RNVF9FTkQKLS0gCjEuNy4xMC40Cgo=