12258 2007-01-13 09:50:05 -0800 fast/tokenizer/002 test broken 2007-01-14 10:28:34 -0800 1 1 1 Unclassified WebKit Page Loading 420+ Mac OS X 10.4 RESOLVED FIXED LayoutTestFailure, Regression P1 Normal --- 1 ap ap oldest_to_newest 35223 0 ap 2007-01-13 09:50:05 -0800 r18833, my fault. -layer at (0,0) size 800x600 - RenderBlock {HTML} at (0,0) size 800x600 - RenderBody {BODY} at (8,8) size 784x584 +layer at (0,0) size 800x34 + RenderBlock {HTML} at (0,0) size 800x34 + RenderBody {BODY} at (8,8) size 784x18 35212 1 12417 ap 2007-01-13 10:10:08 -0800 Created attachment 12417 proposed fix I couldn't run all the tests due to bug 12251, so I suppose there will be more inconsequential changes to results outside fast/tokenizer. 35136 2 ddkilzer 2007-01-13 15:00:30 -0800 (In reply to comment #1) > I couldn't run all the tests due to bug 12251, so I suppose there will be more > inconsequential changes to results outside fast/tokenizer. The run-webkit-tests script supports an ignore test option just for this type of issue: -i|--ignore-tests Comma-separated list of directories or tests to ignore 35064 3 12417 darin 2007-01-14 06:11:09 -0800 Comment on attachment 12417 proposed fix Looks great. I don't like that this calls writeRawData even if len is 0, though. It's also a bit unfortunate that we need to create a TextResourceDecoder even if there was no data to decode. I'm not sure either of those is a problem. I think I'll still say r=me. 34985 4 ap 2007-01-14 10:28:34 -0800 Committed revision 18844. Ran the tests with the assertion disabled (proposed fix for bug 12251). 12417 2007-01-13 10:10:08 -0800 2007-01-14 06:11:09 -0800 proposed fix 12258r1_patch.txt text/plain 4103 ap SW5kZXg6IExheW91dFRlc3RzL2Zhc3QvdG9rZW5pemVyL2V4dGVybmFsLXNjcmlwdC1kb2N1bWVu dC13cml0ZS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC90b2tl bml6ZXIvZXh0ZXJuYWwtc2NyaXB0LWRvY3VtZW50LXdyaXRlLWV4cGVjdGVkLnR4dAkocmV2aXNp b24gMTg4MzApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3Rva2VuaXplci9leHRlcm5hbC1zY3JpcHQt ZG9jdW1lbnQtd3JpdGUtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDggKzEsOCBA QAogbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCiAgIFJlbmRlclZpZXcgYXQgKDAsMCkgc2l6 ZSA4MDB4NjAwCi1sYXllciBhdCAoMCwwKSBzaXplIDgwMHgzNAotICBSZW5kZXJCbG9jayB7SFRN TH0gYXQgKDAsMCkgc2l6ZSA4MDB4MzQKLSAgICBSZW5kZXJCb2R5IHtCT0RZfSBhdCAoOCw4KSBz aXplIDc4NHgxOAorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgIFJlbmRlckJsb2NrIHtI VE1MfSBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgICBSZW5kZXJCb2R5IHtCT0RZfSBhdCAoOCw4 KSBzaXplIDc4NHg1ODQKICAgICAgIFJlbmRlcklubGluZSB7U1BBTn0gYXQgKDAsMCkgc2l6ZSAw eDAKICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXplIDI5NXgxOAogICAgICAg ICB0ZXh0IHJ1biBhdCAoMCwwKSB3aWR0aCAyOTU6ICJUaGlzIHNob3VsZCBiZSBhIHNwYW46IFtv YmplY3QgSFRNTEVsZW1lbnRdIgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC90b2tlbml6ZXIvbWlz c2luZy10aXRsZS1lbmQtdGFnLTEtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL2Zhc3QvdG9rZW5pemVyL21pc3NpbmctdGl0bGUtZW5kLXRhZy0xLWV4cGVjdGVkLnR4dAko cmV2aXNpb24gMTg4MzApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3Rva2VuaXplci9taXNzaW5nLXRp dGxlLWVuZC10YWctMS1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTEsOCArMSw4IEBA CiBsYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKICAgUmVuZGVyVmlldyBhdCAoMCwwKSBzaXpl IDgwMHg2MDAKLWxheWVyIGF0ICgwLDApIHNpemUgODAweDUyCi0gIFJlbmRlckJsb2NrIHtIVE1M fSBhdCAoMCwwKSBzaXplIDgwMHg1MgotICAgIFJlbmRlckJvZHkge0JPRFl9IGF0ICg4LDgpIHNp emUgNzg0eDM2CitsYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVyQmxvY2sge0hU TUx9IGF0ICgwLDApIHNpemUgODAweDYwMAorICAgIFJlbmRlckJvZHkge0JPRFl9IGF0ICg4LDgp IHNpemUgNzg0eDU4NAogICAgICAgUmVuZGVyQmxvY2sge0RJVn0gYXQgKDAsMCkgc2l6ZSA3ODR4 MzYKICAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDApIHNpemUgNzczeDM2CiAgICAg ICAgICAgdGV4dCBydW4gYXQgKDAsMCkgd2lkdGggMzI2OiAiVGhpcyBkb2N1bWVudCBpcyBtaXNz aW5nIGl0cyA8L3RpdGxlPiB0YWcgaW4gaXRzIGhlYWQuICIKSW5kZXg6IFdlYkNvcmUvQ2hhbmdl TG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAxODgzMykKKysr IFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDct MDEtMTMgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJraXQub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogbG9hZGVyL0ZyYW1lTG9hZGVy Lmg6IEFkZGVkIGEgZmx1c2ggcGFyYW1ldGVyIHRvIHdyaXRlKCkuCisgICAgICAgICogbG9hZGVy L0ZyYW1lTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyOjp3cml0ZSk6 IERpdHRvLgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OmVuZElmTm90TG9hZGluZyk6 IEluc3RlYWQgb2YgcG9vcmx5IGR1cGxpY2F0aW5nIHRoZSBsb2dpYyBpbiB3cml0ZSgpLAorICAg ICAgICBjYWxsIGl0IGRpcmVjdGx5LgorCiAyMDA3LTAxLTEzICBBbGV4ZXkgUHJvc2t1cnlha292 ICA8YXBAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbi4KSW5kZXg6IFdl YkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2xvYWRl ci9GcmFtZUxvYWRlci5jcHAJKHJldmlzaW9uIDE4ODMwKQorKysgV2ViQ29yZS9sb2FkZXIvRnJh bWVMb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04NDIsOSArODQyLDkgQEAgdm9pZCBGcmFt ZUxvYWRlcjo6YmVnaW4oY29uc3QgS1VSTCYgdXJsKQogICAgICAgICBtX2ZyYW1lLT52aWV3KCkt PnJlc2l6ZUNvbnRlbnRzKDAsIDApOwogfQogCi12b2lkIEZyYW1lTG9hZGVyOjp3cml0ZShjb25z dCBjaGFyKiBzdHIsIGludCBsZW4pCit2b2lkIEZyYW1lTG9hZGVyOjp3cml0ZShjb25zdCBjaGFy KiBzdHIsIGludCBsZW4sIGJvb2wgZmx1c2gpCiB7Ci0gICAgaWYgKGxlbiA9PSAwKQorICAgIGlm IChsZW4gPT0gMCAmJiAhZmx1c2gpCiAgICAgICAgIHJldHVybjsKICAgICAKICAgICBpZiAobGVu ID09IC0xKQpAQCAtODY2LDYgKzg2Niw4IEBAIHZvaWQgRnJhbWVMb2FkZXI6OndyaXRlKGNvbnN0 IGNoYXIqIHN0ciwKICAgICB9CiAKICAgICBTdHJpbmcgZGVjb2RlZCA9IG1fZGVjb2Rlci0+ZGVj b2RlKHN0ciwgbGVuKTsKKyAgICBpZiAoZmx1c2gpCisgICAgICAgIGRlY29kZWQgKz0gbV9kZWNv ZGVyLT5mbHVzaCgpOwogICAgIGlmIChkZWNvZGVkLmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJu OwogCkBAIC05MTUsMTQgKzkxNyw3IEBAIHZvaWQgRnJhbWVMb2FkZXI6OmVuZElmTm90TG9hZGlu ZygpCiAKICAgICAvLyBtYWtlIHN1cmUgbm90aGluZydzIGxlZnQgaW4gdGhlcmUKICAgICBpZiAo bV9mcmFtZS0+ZG9jdW1lbnQoKSkgewotICAgICAgICBpZiAobV9kZWNvZGVyKSB7Ci0gICAgICAg ICAgICBTdHJpbmcgZGVjb2RlZCA9IG1fZGVjb2Rlci0+Zmx1c2goKTsKLSAgICAgICAgICAgIGlm ICghbV9yZWNlaXZlZERhdGEpIHsKLSAgICAgICAgICAgICAgICBtX3JlY2VpdmVkRGF0YSA9IHRy dWU7Ci0gICAgICAgICAgICAgICAgbV9mcmFtZS0+ZG9jdW1lbnQoKS0+ZGV0ZXJtaW5lUGFyc2VN b2RlKGRlY29kZWQpOwotICAgICAgICAgICAgfQotICAgICAgICAgICAgd3JpdGUoZGVjb2RlZCk7 Ci0gICAgICAgIH0KKyAgICAgICAgd3JpdGUoMCwgMCwgdHJ1ZSk7CiAgICAgICAgIG1fZnJhbWUt PmRvY3VtZW50KCktPmZpbmlzaFBhcnNpbmcoKTsKICAgICB9IGVsc2UKICAgICAgICAgLy8gV2Vi S2l0IHBhcnRpYWxseSB1c2VzIFdlYkNvcmUgd2hlbiBsb2FkaW5nIG5vbi1IVE1MIGRvY3MuICBJ biB0aGVzZSBjYXNlcyBkb2M9PW5pbCwgYnV0CkluZGV4OiBXZWJDb3JlL2xvYWRlci9GcmFtZUxv YWRlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmgJKHJldmlz aW9uIDE4ODMwKQorKysgV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuaAkod29ya2luZyBjb3B5 KQpAQCAtMzE2LDcgKzMxNiw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogICAgICAgICB2b2lk IGJlZ2luKCk7CiAgICAgICAgIHZvaWQgYmVnaW4oY29uc3QgS1VSTCYpOwotICAgICAgICB2b2lk IHdyaXRlKGNvbnN0IGNoYXIqIHN0ciwgaW50IGxlbiA9IC0xKTsKKyAgICAgICAgdm9pZCB3cml0 ZShjb25zdCBjaGFyKiBzdHIsIGludCBsZW4gPSAtMSwgYm9vbCBmbHVzaCA9IGZhbHNlKTsKICAg ICAgICAgdm9pZCB3cml0ZShjb25zdCBTdHJpbmcmKTsKICAgICAgICAgdm9pZCBlbmQoKTsKIAo=