122557 2013-10-09 10:00:39 -0700 Change to std::unique_ptr breaks wtf/DataLog.cpp when DATA_LOG_TO_FILE set to 1 2013-10-09 11:20:51 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff benjamin cmarcelo commit-queue oldest_to_newest 937968 0 msaboff 2013-10-09 10:00:39 -0700 After the recent change to std::unique_ptr, leakPtr() is no longer valid on the line: file = FilePrintStream::open(actualFilename, "w").leakPtr(); 937971 1 213789 msaboff 2013-10-09 10:03:53 -0700 Created attachment 213789 Patch 938002 2 msaboff 2013-10-09 11:20:51 -0700 Committed r157176: <http://trac.webkit.org/changeset/157176> 213789 2013-10-09 10:03:53 -0700 2013-10-09 10:14:13 -0700 Patch 122557.patch text/plain 1207 msaboff SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNTcxNzIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTEwLTA5ICBNaWNoYWVsIFNhYm9mZiAgPG1z YWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIENoYW5nZSB0byBzdGQ6OnVuaXF1ZV9wdHIgYnJl YWtzIHd0Zi9EYXRhTG9nLmNwcCB3aGVuIERBVEFfTE9HX1RPX0ZJTEUgc2V0IHRvIDEKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMjU1NworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoYW5nZWQgdGhlIGxl YWtQdHIoKSB0byByZWxlYXNlKCkuCisKKyAgICAgICAgKiB3dGYvRGF0YUxvZy5jcHA6CisgICAg ICAgIChXVEY6OmluaXRpYWxpemVMb2dGaWxlT25jZSk6CisKIDIwMTMtMTAtMDggIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgVHVybiB0aHJlYWRlZCBz Y3JvbGxpbmcgb24gZm9yIGFsbCBNYWMgcG9ydHMuCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9EYXRh TG9nLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9EYXRhTG9nLmNwcAkocmV2aXNp b24gMTU3MTY0KQorKysgU291cmNlL1dURi93dGYvRGF0YUxvZy5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTc1LDcgKzc1LDcgQEAgc3RhdGljIHZvaWQgaW5pdGlhbGl6ZUxvZ0ZpbGVPbmNlKCkKICNl bmRpZgogCiAgICAgaWYgKGZpbGVuYW1lKSB7Ci0gICAgICAgIGZpbGUgPSBGaWxlUHJpbnRTdHJl YW06Om9wZW4oYWN0dWFsRmlsZW5hbWUsICJ3IikubGVha1B0cigpOworICAgICAgICBmaWxlID0g RmlsZVByaW50U3RyZWFtOjpvcGVuKGFjdHVhbEZpbGVuYW1lLCAidyIpLnJlbGVhc2UoKTsKICAg ICAgICAgaWYgKCFmaWxlKQogICAgICAgICAgICAgZnByaW50ZihzdGRlcnIsICJXYXJuaW5nOiBD b3VsZCBub3Qgb3BlbiBsb2cgZmlsZSAlcyBmb3Igd3JpdGluZy5cbiIsIGFjdHVhbEZpbGVuYW1l KTsKICAgICB9Cg==