122555 2013-10-09 09:31:10 -0700 [arm] Inverted src and dest FP registers in DFG speculative JIT when using hardfp 2013-10-09 11:03:47 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108645 1 jbriance webkit-unassigned commit-queue fpizlo msaboff ossy rgabor simon.fraser oldest_to_newest 937943 0 jbriance 2013-10-09 09:31:10 -0700 I think that the src and dest registers in moveDouble() call are inverted when CPU(ARM) and CPU(ARM_HARDFP). 937946 1 213784 jbriance 2013-10-09 09:33:16 -0700 Created attachment 213784 Fix src and dest FP registers inversion when CPU(ARM) && CPU(ARM_HARDFP). 937950 2 213784 jbriance 2013-10-09 09:35:36 -0700 Comment on attachment 213784 Fix src and dest FP registers inversion when CPU(ARM) && CPU(ARM_HARDFP). Please note that I found this by reading the code and I don't have an ARM environment to validate this patch. 937969 3 213784 commit-queue 2013-10-09 10:01:07 -0700 Comment on attachment 213784 Fix src and dest FP registers inversion when CPU(ARM) && CPU(ARM_HARDFP). Clearing flags on attachment: 213784 Committed r157173: <http://trac.webkit.org/changeset/157173> 937970 4 commit-queue 2013-10-09 10:01:10 -0700 All reviewed patches have been landed. Closing bug. 213784 2013-10-09 09:33:16 -0700 2013-10-09 10:01:07 -0700 Fix src and dest FP registers inversion when CPU(ARM) && CPU(ARM_HARDFP). bug-122555.patch text/plain 1674 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU3MTcwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDEzLTEwLTA5ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIFthcm1dIEludmVydGVkIHNyYyBhbmQgZGVzdCBGUCByZWdpc3RlcnMgaW4gREZHIHNw ZWN1bGF0aXZlIEpJVCB3aGVuIHVzaW5nIGhhcmRmcC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMjU1NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogZGZnL0RGR1NwZWN1bGF0aXZlSklULmg6CisgICAg ICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmFwcGVuZENhbGxXaXRoRXhjZXB0aW9uQ2hl Y2tTZXRSZXN1bHQpOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1bGF0aXZlSklUOjphcHBlbmRD YWxsU2V0UmVzdWx0KToKKwogMjAxMy0xMC0wOCAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFw cGxlLmNvbT4KIAogICAgICAgICBUcmFuc2l0aW9uIGNhbGwgYW5kIGNvbnN0cnVjdCBKSVRTdHVi cyB0byBDQ2FsbEhlbHBlciBmdW5jdGlvbnMKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHU3BlY3VsYXRpdmVKSVQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmgJKHJldmlzaW9uIDE1NzE2NCkKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuaAkod29ya2luZyBjb3B5KQpAQCAt MTgwMSwxNCArMTgwMSwxNCBAQCBwdWJsaWM6CiAgICAgewogICAgICAgICBKSVRDb21waWxlcjo6 Q2FsbCBjYWxsID0gYXBwZW5kQ2FsbFdpdGhFeGNlcHRpb25DaGVjayhmdW5jdGlvbik7CiAgICAg ICAgIGlmIChyZXN1bHQgIT0gSW52YWxpZEZQUlJlZykKLSAgICAgICAgICAgIG1faml0Lm1vdmVE b3VibGUocmVzdWx0LCBGUFJJbmZvOjphcmd1bWVudEZQUjApOworICAgICAgICAgICAgbV9qaXQu bW92ZURvdWJsZShGUFJJbmZvOjphcmd1bWVudEZQUjAsIHJlc3VsdCk7CiAgICAgICAgIHJldHVy biBjYWxsOwogICAgIH0KICAgICBKSVRDb21waWxlcjo6Q2FsbCBhcHBlbmRDYWxsU2V0UmVzdWx0 KGNvbnN0IEZ1bmN0aW9uUHRyJiBmdW5jdGlvbiwgRlBSUmVnIHJlc3VsdCkKICAgICB7CiAgICAg ICAgIEpJVENvbXBpbGVyOjpDYWxsIGNhbGwgPSBhcHBlbmRDYWxsKGZ1bmN0aW9uKTsKICAgICAg ICAgaWYgKHJlc3VsdCAhPSBJbnZhbGlkRlBSUmVnKQotICAgICAgICAgICAgbV9qaXQubW92ZURv dWJsZShyZXN1bHQsIEZQUkluZm86OmFyZ3VtZW50RlBSMCk7CisgICAgICAgICAgICBtX2ppdC5t b3ZlRG91YmxlKEZQUkluZm86OmFyZ3VtZW50RlBSMCwgcmVzdWx0KTsKICAgICAgICAgcmV0dXJu IGNhbGw7CiAgICAgfQogI2Vsc2UK