122549 2013-10-09 06:17:03 -0700 [Win] BeginPaint should only be called in response to WM_PAINT. 2013-10-09 10:04:12 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Unspecified RESOLVED FIXED InRadar P2 Normal --- 0 peavo webkit-unassigned bfulgham commit-queue webkit-bug-importer oldest_to_newest 937897 0 peavo 2013-10-09 06:17:03 -0700 According to the documentation (http://msdn.microsoft.com/en-us/library/windows/desktop/dd183362(v=vs.85).aspx), the Win32 api functions BeginPaint and EndPaint should only be called in response to a WM_PAINT message. Currently, the WebView window procedure might call these functions (via WebView::paint(0, 0)) for all types of messages. Also, there is potential double drawing. If some message is dispatched before WM_PAINT, WebView::paint(0, 0) will be called. This call does not validate the area drawn, so later the WM_PAINT will arrive, drawing the same area. 937901 1 213770 peavo 2013-10-09 06:28:52 -0700 Created attachment 213770 Patch 937936 2 213770 bfulgham 2013-10-09 09:10:10 -0700 Comment on attachment 213770 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213770&action=review > Source/WebKit/win/WebView.cpp:2467 > + ::UpdateWindow(hWnd); Will this trigger the logic in webView->performLayeredWIndowUpdate()? 937951 3 peavo 2013-10-09 09:36:54 -0700 (In reply to comment #2) > (From update of attachment 213770 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=213770&action=review > > > Source/WebKit/win/WebView.cpp:2467 > > + ::UpdateWindow(hWnd); > > Will this trigger the logic in webView->performLayeredWIndowUpdate()? Yes, UpdateWindow will send the WM_PAINT message (synchronously) if there is an invalid area. 937953 4 213770 bfulgham 2013-10-09 09:40:24 -0700 Comment on attachment 213770 Patch r=me 937955 5 webkit-bug-importer 2013-10-09 09:41:06 -0700 <rdar://problem/15187300> 937960 6 peavo 2013-10-09 09:44:18 -0700 (In reply to comment #4) > (From update of attachment 213770 [details]) > r=me Thanks for reviewing! 937972 7 213770 commit-queue 2013-10-09 10:04:10 -0700 Comment on attachment 213770 Patch Clearing flags on attachment: 213770 Committed r157174: <http://trac.webkit.org/changeset/157174> 937973 8 commit-queue 2013-10-09 10:04:12 -0700 All reviewed patches have been landed. Closing bug. 213770 2013-10-09 06:28:52 -0700 2013-10-09 10:04:10 -0700 Patch bug-122549-20131009152832.patch text/plain 1937 peavo SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NzE2MykKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEzLTEwLTA5 ICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5d IEJlZ2luUGFpbnQgc2hvdWxkIG9ubHkgYmUgY2FsbGVkIGluIHJlc3BvbnNlIHRvIFdNX1BBSU5U LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIyNTQ5 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWNjb3Jk aW5nIHRvIHRoZSBkb2N1bWVudGF0aW9uLCB0aGUgV2luMzIgYXBpIGZ1bmN0aW9uIEJlZ2luUGFp bnQgc2hvdWxkIG9ubHkgYmUgY2FsbGVkIGluIHJlc3BvbnNlIHRvIGEgV01fUEFJTlQgbWVzc2Fn ZS4KKyAgICAgICAgQ3VycmVudGx5LCB0aGUgV2ViVmlldyB3aW5kb3cgcHJvY2VkdXJlIG1pZ2h0 IGNhbGwgdGhpcyBmdW5jdGlvbiAodmlhIFdlYlZpZXc6OnBhaW50KDAsIDApKSBmb3IgYWxsIHR5 cGVzIG9mIG1lc3NhZ2VzLgorICAgICAgICBBbHNvLCB0aGVyZSBpcyBwb3RlbnRpYWwgZm9yIGRv dWJsZSBkcmF3aW5nLiBJZiBzb21lIG1lc3NhZ2UgaXMgZGlzcGF0Y2hlZCBiZWZvcmUgV01fUEFJ TlQsIFdlYlZpZXc6OnBhaW50KDAsIDApIHdpbGwgYmUgY2FsbGVkLgorICAgICAgICBUaGlzIGNh bGwgZG9lcyBub3QgdmFsaWRhdGUgdGhlIGFyZWEgZHJhd24sIHNvIGxhdGVyIHRoZSBXTV9QQUlO VCB3aWxsIGFycml2ZSwgZHJhd2luZyB0aGUgc2FtZSBhcmVhLgorICAgICAgICBUaGlzIGNhbiBi ZSBmaXhlZCBieSBjYWxsaW5nIHRoZSBXaW4zMiBmdW5jdGlvbiBVcGRhdGVXaW5kb3coKSwgd2hp Y2ggd2lsbCBkbyBhIHN5bmNocm9ub3VzIHdpbmRvdyB1cGRhdGUsIGFuZCB2YWxpZGF0ZSB0aGUg YXJlYS4KKworICAgICAgICAqIFdlYlZpZXcuY3BwOgorICAgICAgICAoV2ViVmlldzo6V2ViVmll d1duZFByb2MpOiBVc2UgV2luMzIgZnVuY3Rpb24gVXBkYXRlV2luZG93KCkgdG8gZHJhdyBpbnZh bGlkIGFyZWEuCisKIDIwMTMtMTAtMDcgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAog ICAgICAgICBDb25zb2xpZGF0ZSBmaW5kU3RyaW5nIGZ1bmN0aW9ucwpJbmRleDogU291cmNlL1dl YktpdC93aW4vV2ViVmlldy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC93aW4vV2Vi Vmlldy5jcHAJKHJldmlzaW9uIDE1NzE1OCkKKysrIFNvdXJjZS9XZWJLaXQvd2luL1dlYlZpZXcu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNDYzLDExICsyNDYzLDggQEAgTFJFU1VMVCBDQUxMQkFD SyBXZWJWaWV3OjpXZWJWaWV3V25kUHJvYwogICAgICAgICAgICAgYnJlYWs7CiAgICAgfQogCi0g ICAgaWYgKHdlYlZpZXctPm5lZWRzRGlzcGxheSgpKSB7Ci0gICAgICAgIHdlYlZpZXctPnBhaW50 KDAsIDApOwotICAgICAgICBpZiAod2ViVmlldy0+dXNlc0xheWVyZWRXaW5kb3coKSkKLSAgICAg ICAgICAgIHdlYlZpZXctPnBlcmZvcm1MYXllcmVkV2luZG93VXBkYXRlKCk7Ci0gICAgfQorICAg IGlmICh3ZWJWaWV3LT5uZWVkc0Rpc3BsYXkoKSAmJiBtZXNzYWdlICE9IFdNX1BBSU5UKQorICAg ICAgICA6OlVwZGF0ZVdpbmRvdyhoV25kKTsKIAogICAgIGlmICghaGFuZGxlZCkKICAgICAgICAg bFJlc3VsdCA9IERlZldpbmRvd1Byb2MoaFduZCwgbWVzc2FnZSwgd1BhcmFtLCBsUGFyYW0pOwo=