122540 2013-10-08 23:50:12 -0700 AX: VoiceOver does not speak aria-expanded state on iOS 2013-10-09 09:32:24 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach aboxhall apinheiro commit-queue dmazzoni faulkner.steve jdiggs mario webkit-bug-importer oldest_to_newest 937824 0 cfleizach 2013-10-08 23:50:12 -0700 See http://pauljadam.com/demos/aria-expanded.html <rdar://problem/15176155> 937825 1 213756 cfleizach 2013-10-08 23:52:09 -0700 Created attachment 213756 patch 937840 2 213756 mario 2013-10-09 01:29:02 -0700 Comment on attachment 213756 patch I've observed you're not exposing canSetExpandedAttribute() at all in this IOS wrapper, which is something you do in the Mac one by means of the attributeName() method: - (BOOL)accessibilityIsAttributeSettable:(NSString*)attributeName { [...] if ([attributeName isEqualToString:NSAccessibilityDisclosingAttribute]) return m_object->canSetExpandedAttribute(); [...] } In ATK we expose the very same thing with ATK_STATE_EXPANDABLE, so that's it got my attention. Anyway, just pointing it out in case it was not intentional. The current patch is Ok in any case. 937932 3 cfleizach 2013-10-09 08:53:01 -0700 (In reply to comment #2) > (From update of attachment 213756 [details]) > I've observed you're not exposing canSetExpandedAttribute() at all in this IOS wrapper, which is something you do in the Mac one by means of the attributeName() method: > > - (BOOL)accessibilityIsAttributeSettable:(NSString*)attributeName > { > [...] > if ([attributeName isEqualToString:NSAccessibilityDisclosingAttribute]) > return m_object->canSetExpandedAttribute(); > [...] > } > > In ATK we expose the very same thing with ATK_STATE_EXPANDABLE, so that's it got my attention. > > Anyway, just pointing it out in case it was not intentional. The current patch is Ok in any case. Thanks for looking at this. On iOS, we don't have a notion of attribute names. Properties are just exposed and queried for when desired 937937 4 213756 commit-queue 2013-10-09 09:15:05 -0700 Comment on attachment 213756 patch Clearing flags on attachment: 213756 Committed r157171: <http://trac.webkit.org/changeset/157171> 937938 5 commit-queue 2013-10-09 09:15:07 -0700 All reviewed patches have been landed. Closing bug. 937944 6 mario 2013-10-09 09:32:24 -0700 (In reply to comment #3) > [...] > Thanks for looking at this. On iOS, we don't have a notion of attribute names. > Properties are just exposed and queried for when desired Ah! That explains why you don't have a attributeName() method in the IOS wrapper :) 213756 2013-10-08 23:52:09 -0700 2013-10-09 09:15:05 -0700 patch patch text/plain 1346 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NzE1OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTEwLTA4ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IFZvaWNlT3ZlciBk b2VzIG5vdCBzcGVhayBhcmlhLWV4cGFuZGVkIHN0YXRlIG9uIGlPUworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIyNTQwCisKKyAgICAgICAgRXhwb3Nl IGFyaWEtcHJlc3NlZCBzdGF0ZSBmb3IgaU9TLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9pb3MvV2ViQWNjZXNzaWJpbGl0 eU9iamVjdFdyYXBwZXJJT1MubW06CisgICAgICAgICgtW1dlYkFjY2Vzc2liaWxpdHlPYmplY3RX cmFwcGVyIGFjY2Vzc2liaWxpdHlJc0V4cGFuZGVkXSk6CisKIDIwMTMtMTAtMDggIEd5dXlvdW5n IEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBG aXggRUZMIGJ1aWxkYnJlYWsgc2luY2UgcjE1NzE1Mi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Fj Y2Vzc2liaWxpdHkvaW9zL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVySU9TLm1tCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvaW9zL1dlYkFjY2Vzc2liaWxp dHlPYmplY3RXcmFwcGVySU9TLm1tCShyZXZpc2lvbiAxNTY4MjgpCisrKyBTb3VyY2UvV2ViQ29y ZS9hY2Nlc3NpYmlsaXR5L2lvcy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlcklPUy5tbQko d29ya2luZyBjb3B5KQpAQCAtMjAyNyw2ICsyMDI3LDE0IEBACiAgICAgcmV0dXJuIG1fb2JqZWN0 LT5hcmlhTGl2ZVJlZ2lvbkF0b21pYygpOwogfQogCistIChCT09MKWFjY2Vzc2liaWxpdHlJc0V4 cGFuZGVkCit7CisgICAgaWYgKCFbc2VsZiBfcHJlcGFyZUFjY2Vzc2liaWxpdHlDYWxsXSkKKyAg ICAgICAgcmV0dXJuIE5POworCisgICAgcmV0dXJuIG1fb2JqZWN0LT5pc0V4cGFuZGVkKCk7Cit9 CisKIC0gKE5TU3RyaW5nICopYWNjZXNzaWJpbGl0eUludmFsaWRTdGF0dXMKIHsKICAgICBpZiAo IVtzZWxmIF9wcmVwYXJlQWNjZXNzaWJpbGl0eUNhbGxdKQo=