122519 2013-10-08 13:05:52 -0700 Fix ruby LoadError when running run-javascriptcore-tests 2013-10-08 13:25:52 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam fpizlo mhahnenberg oldest_to_newest 937636 0 mark.lam 2013-10-08 13:05:52 -0700 On MountainLion running ruby 1.8.7, run-javascriptcore-tests produced the following error: Running: /usr/bin/env ruby Tools/Scripts/run-jsc-stress-tests -j /Volumes/Data/ws7/OpenSource/WebKitBuild/Debug/jsc -o /Volumes/Data/ws7/OpenSource/WebKitBuild/Debug/jsc-stress-results PerformanceTests/SunSpider/tests/sunspider-1.0 PerformanceTests/SunSpider/tests/v8-v6 Source/JavaScriptCore/tests/mozilla/mozilla-tests.yaml LayoutTests/js/regress/script-tests PerformanceTests/SunSpider/profiler-test.yaml LayoutTests/jsc-layout-tests.yaml Warning: did not find json or highline; some features will be disabled. Error: #<LoadError: no such file to load -- json> This in spite of the json and highline gems both already installed. The issue is that for earlier versions of ruby (probably before 1.9), we need to explicitly require "rubygems". Adding this to the relevant scripts fixes the issue. 937643 1 213712 mark.lam 2013-10-08 13:20:34 -0700 Created attachment 213712 the patch. 937645 2 213712 mhahnenberg 2013-10-08 13:22:02 -0700 Comment on attachment 213712 the patch. r=me. Did you test how this affects newer versions of ruby? 937648 3 mark.lam 2013-10-08 13:22:55 -0700 (In reply to comment #2) > (From update of attachment 213712 [details]) > r=me. Did you test how this affects newer versions of ruby? Thanks for the review. Yes, I tested it. Works fine on newer versions of ruby. 937650 4 mark.lam 2013-10-08 13:25:52 -0700 Landed in r157131: <http://trac.webkit.org/r157131>. 213712 2013-10-08 13:20:34 -0700 2013-10-08 13:22:02 -0700 the patch. bug-122519.patch text/plain 1660 mark.lam SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE1NzEyOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDEzLTEwLTA4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKwor ICAgICAgICBGaXggcnVieSBMb2FkRXJyb3Igd2hlbiBydW5uaW5nIHJ1bi1qYXZhc2NyaXB0Y29y ZS10ZXN0cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyMjUxOS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGUgc2NyaXB0cyBuZWVkZWQgdG8gZXhwbGljaXRseSByZXF1aXJlICdydWJ5Z2VtcycgZm9y IG9sZGVyIHZlcnNpb25zIG9mIHJ1YnkKKyAgICAgICAgKHZlcnNpb25zIGJlZm9yZSAxLjkpLgor CisgICAgICAgICogU2NyaXB0cy9qc2Mtc3RyZXNzLXRlc3QtaGVscGVycy9wcm9maWxlci10ZXN0 LWhlbHBlcjoKKyAgICAgICAgKiBTY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzOgorCiAyMDEz LTEwLTA4ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2guZHVtZXpAc2lzYS5zYW1zdW5nLmNvbT4KIAog ICAgICAgICBVbnJldmlld2VkLCBhZGQgbXkgbmV3IGVtYWlsIHRvIGNvbnRyaWJ1dG9ycy5qc29u LgpJbmRleDogVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzCShyZXZpc2lvbiAxNTcxMjUpCisr KyBUb29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC00 OCw2ICs0OCw3IEBAIGVuZAogJGNhblJ1bkRpc3BsYXlQcm9maWxlck91dHB1dCA9IGZhbHNlCiAK IGJlZ2luCisgICAgcmVxdWlyZSAncnVieWdlbXMnCiAgICAgcmVxdWlyZSAnanNvbicKICAgICBy ZXF1aXJlICdoaWdobGluZScKICAgICAkY2FuUnVuRGlzcGxheVByb2ZpbGVyT3V0cHV0ID0gdHJ1 ZQpJbmRleDogVG9vbHMvU2NyaXB0cy9qc2Mtc3RyZXNzLXRlc3QtaGVscGVycy9wcm9maWxlci10 ZXN0LWhlbHBlcgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2pzYy1zdHJlc3MtdGVzdC1o ZWxwZXJzL3Byb2ZpbGVyLXRlc3QtaGVscGVyCShyZXZpc2lvbiAxNTcxMjUpCisrKyBUb29scy9T Y3JpcHRzL2pzYy1zdHJlc3MtdGVzdC1oZWxwZXJzL3Byb2ZpbGVyLXRlc3QtaGVscGVyCSh3b3Jr aW5nIGNvcHkpCkBAIC0yMyw2ICsyMyw3IEBACiAjIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBP VEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRSBPRgogIyBUSElTIFNP RlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdF LgogCityZXF1aXJlICdydWJ5Z2VtcycKIHJlcXVpcmUgJ2pzb24nCiByZXF1aXJlICdzaGVsbHdv cmRzJwogCg==