122517 2013-10-08 12:47:33 -0700 [MediaStream] Fix segfault in initializeMockSources() 2013-10-08 13:29:12 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 lauro.neto lauro.neto commit-queue eric.carlson glenn jer.noble oldest_to_newest 937624 0 lauro.neto 2013-10-08 12:47:33 -0700 MockMediaStreamCenter.cpp initializeMockSources() tries to add a RefPtr<MockSource> to a HashMap by releasing it and also access a member function (id) in the same call. If the release() is evaluated before id(), a segfault occurs. 937628 1 213709 lauro.neto 2013-10-08 12:52:42 -0700 Created attachment 213709 Patch 937652 2 213709 commit-queue 2013-10-08 13:29:10 -0700 Comment on attachment 213709 Patch Clearing flags on attachment: 213709 Committed r157132: <http://trac.webkit.org/changeset/157132> 937653 3 commit-queue 2013-10-08 13:29:12 -0700 All reviewed patches have been landed. Closing bug. 213709 2013-10-08 12:52:42 -0700 2013-10-08 13:29:10 -0700 Patch bug-122517-20131008165252.patch text/plain 2327 lauro.neto U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3MTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjk0ODE1ZGY3ZmRhMmM3 NmFhZDYzZWFjOTk5NWUxZDgwMWZhNGZhNi4uNGNhMjBmOGY3YzMzZDk3NzYzZDI1YWM0OTE1ZTc4 NGRhNGE3NjJjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTEwLTA4ICBMYXVy byBOZXRvICA8bGF1cm8ubmV0b0BvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFtNZWRpYVN0cmVh bV0gRml4IHNlZ2ZhdWx0IGluIGluaXRpYWxpemVNb2NrU291cmNlcygpCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjI1MTcKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDYWxsaW5nIHJlbGVhc2UoKSBhbmQg YSBtZW1iZXIgZnVuY3Rpb24gb24gdGhlIHNhbWUgUmVmUHRyCisgICAgICAgIGFzIGFyZ3VtZW50 cyB0byBhIGZ1bmN0aW9uIGNhbiBsZWFkIHRvIHNlZ2ZhdWx0cyBpZiB0aGUgcmVsZWFzZQorICAg ICAgICBjYWxsIGlzIGV2YWx1YXRlZCBmaXJzdC4KKworICAgICAgICAqIHBsYXRmb3JtL21vY2sv TW9ja01lZGlhU3RyZWFtQ2VudGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmluaXRpYWxpemVN b2NrU291cmNlcyk6CisKIDIwMTMtMTAtMDggIFRoaWFnbyBkZSBCYXJyb3MgTGFjZXJkYSAgPHRo aWFnby5sYWNlcmRhQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgR2V0IEVGTCBhbmQgR1RLIGNv bXBpbGluZyB3aXRoIG1lZGlhIHN0cmVhbSBlbmFibGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9tb2NrL01vY2tNZWRpYVN0cmVhbUNlbnRlci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9tb2NrL01vY2tNZWRpYVN0cmVhbUNlbnRlci5jcHAKaW5kZXggYzhlNzQ0 NzVhMDc3YTk0NDI3NzhkZDkzZWU5ZWU3MDBjNmY3NTQ1MC4uYzE5NDY3ODA3MzFjNGU3MzRiNjRj Njg3Mjc1MmRjNmY2OWNhMjc1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bW9jay9Nb2NrTWVkaWFTdHJlYW1DZW50ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL21vY2svTW9ja01lZGlhU3RyZWFtQ2VudGVyLmNwcApAQCAtOTksNyArOTksOCBAQCBzdGF0 aWMgdm9pZCBpbml0aWFsaXplTW9ja1NvdXJjZXMoKQogICAgIG1vY2tTb3VyY2UxLT5tX2N1cnJl bnRTdGF0ZXMuZnJhbWVSYXRlID0gMzA7CiAgICAgbW9ja1NvdXJjZTEtPm1fY3VycmVudFN0YXRl cy5hc3BlY3RSYXRpbyA9IDE2IC8gOS4wZjsKICAgICBtb2NrU291cmNlMS0+bV9jdXJyZW50U3Rh dGVzLnZvbHVtZSA9IDcwOwotICAgIG1vY2tTb3VyY2VNYXAoKS5hZGQobW9ja1NvdXJjZTEtPmlk KCksIG1vY2tTb3VyY2UxLnJlbGVhc2UoKSk7CisgICAgU3RyaW5nIG1vY2tTb3VyY2UxaWQgPSBt b2NrU291cmNlMS0+aWQoKTsKKyAgICBtb2NrU291cmNlTWFwKCkuYWRkKG1vY2tTb3VyY2UxaWQs IG1vY2tTb3VyY2UxLnJlbGVhc2UoKSk7CiAKICAgICBSZWZQdHI8TW9ja1NvdXJjZT4gbW9ja1Nv dXJjZTIgPSBhZG9wdFJlZihuZXcgTW9ja1NvdXJjZShtb2NrQXVkaW9Tb3VyY2VJRCgpLCAiTW9j ayBhdWRpbyBkZXZpY2UiLCBNZWRpYVN0cmVhbVNvdXJjZTo6QXVkaW8pKTsKICAgICBtb2NrU291 cmNlMi0+bV9jYXBhYmlsaXRpZXMgPSBNZWRpYVN0cmVhbVNvdXJjZUNhcGFiaWxpdGllczo6Y3Jl YXRlKCk7CkBAIC0xMDksNyArMTEwLDggQEAgc3RhdGljIHZvaWQgaW5pdGlhbGl6ZU1vY2tTb3Vy Y2VzKCkKICAgICBtb2NrU291cmNlMi0+bV9jdXJyZW50U3RhdGVzLnNvdXJjZVR5cGUgPSBNZWRp YVN0cmVhbVNvdXJjZVN0YXRlczo6TWljcm9waG9uZTsKICAgICBtb2NrU291cmNlMi0+bV9jdXJy ZW50U3RhdGVzLnNvdXJjZUlkID0gbW9ja1NvdXJjZTItPmlkKCk7CiAgICAgbW9ja1NvdXJjZTIt Pm1fY3VycmVudFN0YXRlcy52b2x1bWUgPSA1MDsKLSAgICBtb2NrU291cmNlTWFwKCkuYWRkKG1v Y2tTb3VyY2UyLT5pZCgpLCBtb2NrU291cmNlMi5yZWxlYXNlKCkpOworICAgIFN0cmluZyBtb2Nr U291cmNlMmlkID0gbW9ja1NvdXJjZTItPmlkKCk7CisgICAgbW9ja1NvdXJjZU1hcCgpLmFkZCht b2NrU291cmNlMmlkLCBtb2NrU291cmNlMi5yZWxlYXNlKCkpOwogfQogCiB2b2lkIE1vY2tNZWRp YVN0cmVhbUNlbnRlcjo6cmVnaXN0ZXJNb2NrTWVkaWFTdHJlYW1DZW50ZXIoKQo=