122441 2013-10-07 01:44:33 -0700 -webkit-cross-fade paints SVGs at full opacity during cross-fade 2013-10-07 09:47:21 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton commit-queue dino simon.fraser oldest_to_newest 937003 0 thorton 2013-10-07 01:44:33 -0700 Cross-fade is broken with SVGImages, because SVGImage resets the context's opacity before the image is drawn, so the opacity that we set does not take effect. We can use a transparency layer to get around this, but due to the performance cost, we should only do this when painting an SVG image. I have a patch. <rdar://problem/13973162> 937004 1 213572 thorton 2013-10-07 01:50:35 -0700 Created attachment 213572 patch 937005 2 commit-queue 2013-10-07 01:52:25 -0700 Attachment 213572 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/css3/images/cross-fade-svg-with-opacity-expected.html', u'LayoutTests/css3/images/cross-fade-svg-with-opacity.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/CrossfadeGeneratedImage.cpp']" exit_code: 1 Source/WebCore/platform/graphics/CrossfadeGeneratedImage.cpp:64: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 937008 3 213572 thorton 2013-10-07 01:56:23 -0700 Comment on attachment 213572 patch View in context: https://bugs.webkit.org/attachment.cgi?id=213572&action=review >> Source/WebCore/platform/graphics/CrossfadeGeneratedImage.cpp:64 >> + static_cast<float>(targetSize.height()) / imageSize.height())); > > Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Hmm, I just moved this, but it does look wrong. 937103 4 thorton 2013-10-07 09:47:21 -0700 http://trac.webkit.org/changeset/157045 213572 2013-10-07 01:50:35 -0700 2013-10-07 08:11:39 -0700 patch crossfade.diff text/plain 7068 thorton ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhNmE0MmU2Li4wOWQyNWU4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMTAt MDcgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgLXdl YmtpdC1jcm9zcy1mYWRlIHBhaW50cyBTVkdzIGF0IGZ1bGwgb3BhY2l0eSBkdXJpbmcgY3Jvc3Mt ZmFkZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIy NDQxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMzk3MzE2Mj4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSB0ZXN0IHRoYXQgZW5zdXJlcyB0 aGF0IC1jcm9zcy1mYWRlIHdpdGggU1ZHIGltYWdlcyBkcmF3cyBjb3JyZWN0bHkuCisKKyAgICAg ICAgKiBjc3MzL2ltYWdlcy9jcm9zcy1mYWRlLXN2Zy13aXRoLW9wYWNpdHktZXhwZWN0ZWQuaHRt bDogQWRkZWQuCisgICAgICAgICogY3NzMy9pbWFnZXMvY3Jvc3MtZmFkZS1zdmctd2l0aC1vcGFj aXR5Lmh0bWw6IEFkZGVkLgorCiAyMDEzLTEwLTA2ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0 b25AYXBwbGUuY29tPgogCiAgICAgICAgIHJlc3VsdHMuaHRtbCBkb2Vzbid0IHN1cHBvcnQgbm9u LUhUTUwgcmVmZXJlbmNlIHRlc3RzIG9yIHJlZmVyZW5jZXMgd2l0aCBleHRlcm5hbCByZXNvdXJj ZXMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NzczMvaW1hZ2VzL2Nyb3NzLWZhZGUtc3ZnLXdp dGgtb3BhY2l0eS1leHBlY3RlZC5odG1sIGIvTGF5b3V0VGVzdHMvY3NzMy9pbWFnZXMvY3Jvc3Mt ZmFkZS1zdmctd2l0aC1vcGFjaXR5LWV4cGVjdGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMC4uM2UyYTAzMQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Nz czMvaW1hZ2VzL2Nyb3NzLWZhZGUtc3ZnLXdpdGgtb3BhY2l0eS1leHBlY3RlZC5odG1sCkBAIC0w LDAgKzEsMjQgQEAKKzxodG1sPgorPGhlYWQ+CisgICAgPHRpdGxlPlR3byBpZGVudGljYWwgZ3Jh eSBzcXVhcmVzIHNob3VsZCBhcHBlYXIgYmVsb3cuPC90aXRsZT4KKyAgICA8c3R5bGU+CisgICAg ZGl2IHsKKyAgICAgICAgd2lkdGg6IDEwMHB4OworICAgICAgICBoZWlnaHQ6IDEwMHB4OworICAg ICAgICBtYXJnaW46IDhweCAwcHg7CisgICAgfQorCisgICAgI2Nyb3NzZmFkZSB7CisgICAgICAg IGJhY2tncm91bmQtaW1hZ2U6IC13ZWJraXQtY3Jvc3MtZmFkZSh1cmwoImRhdGE6aW1hZ2Uvc3Zn K3htbCw8c3ZnIHhtbG5zPSdodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2Zyc+PHJlY3QgZmlsbD0n d2hpdGUnIHdpZHRoPScxMDAnIGhlaWdodD0nMTAwJz48L3JlY3Q+PC9zdmc+IiksIHVybCgiZGF0 YTppbWFnZS9zdmcreG1sLDxzdmcgeG1sbnM9J2h0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnJz48 cmVjdCBmaWxsPSdibGFjaycgd2lkdGg9JzEwMCcgaGVpZ2h0PScxMDAnPjwvcmVjdD48L3N2Zz4i KSwgNTAlKTsKKyAgICB9CisKKyAgICAjcmVmZXJlbmNlIHsKKyAgICAgICAgYmFja2dyb3VuZC1j b2xvcjogIzgwODA4MDsKKyAgICB9CisgICAgPC9zdHlsZT4KKzwvaGVhZD4KKzxib2R5PgorICAg IDxkaXYgaWQ9InJlZmVyZW5jZSI+PC9kaXY+CisgICAgPGRpdiBpZD0iY3Jvc3NmYWRlIj48L2Rp dj4KKzwvYm9keT4KKzwvaHRtbD4KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9jc3MzL2ltYWdlcy9jcm9zcy1mYWRlLXN2Zy13aXRoLW9wYWNpdHku aHRtbCBiL0xheW91dFRlc3RzL2NzczMvaW1hZ2VzL2Nyb3NzLWZhZGUtc3ZnLXdpdGgtb3BhY2l0 eS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjllYWM1ZmYKLS0tIC9k ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9jc3MzL2ltYWdlcy9jcm9zcy1mYWRlLXN2Zy13aXRo LW9wYWNpdHkuaHRtbApAQCAtMCwwICsxLDI0IEBACis8aHRtbD4KKzxoZWFkPgorICAgIDx0aXRs ZT5Ud28gaWRlbnRpY2FsIGdyYXkgc3F1YXJlcyBzaG91bGQgYXBwZWFyIGJlbG93LjwvdGl0bGU+ CisgICAgPHN0eWxlPgorICAgIGRpdiB7CisgICAgICAgIHdpZHRoOiAxMDBweDsKKyAgICAgICAg aGVpZ2h0OiAxMDBweDsKKyAgICAgICAgbWFyZ2luOiA4cHggMHB4OworICAgIH0KKworICAgICNj cm9zc2ZhZGUgeworICAgICAgICBiYWNrZ3JvdW5kLWltYWdlOiAtd2Via2l0LWNyb3NzLWZhZGUo dXJsKCJkYXRhOmltYWdlL3N2Zyt4bWwsPHN2ZyB4bWxucz0naHR0cDovL3d3dy53My5vcmcvMjAw MC9zdmcnPjxyZWN0IGZpbGw9J3doaXRlJyB3aWR0aD0nMTAwJyBoZWlnaHQ9JzEwMCc+PC9yZWN0 Pjwvc3ZnPiIpLCB1cmwoImRhdGE6aW1hZ2Uvc3ZnK3htbCw8c3ZnIHhtbG5zPSdodHRwOi8vd3d3 LnczLm9yZy8yMDAwL3N2Zyc+PHJlY3QgZmlsbD0nYmxhY2snIHdpZHRoPScxMDAnIGhlaWdodD0n MTAwJz48L3JlY3Q+PC9zdmc+IiksIDUwJSk7CisgICAgfQorCisgICAgI3JlZmVyZW5jZSB7Cisg ICAgICAgIGJhY2tncm91bmQtY29sb3I6ICM4MDgwODA7CisgICAgfQorICAgIDwvc3R5bGU+Cis8 L2hlYWQ+Cis8Ym9keT4KKyAgICA8ZGl2IGlkPSJjcm9zc2ZhZGUiPjwvZGl2PgorICAgIDxkaXYg aWQ9InJlZmVyZW5jZSI+PC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+ClwgTm8gbmV3bGluZSBhdCBl bmQgb2YgZmlsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDgwYjBjZTYuLjZlNGNhOTkgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwyMSBAQAorMjAxMy0xMC0wNyAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFw cGxlLmNvbT4KKworICAgICAgICAtd2Via2l0LWNyb3NzLWZhZGUgcGFpbnRzIFNWR3MgYXQgZnVs bCBvcGFjaXR5IGR1cmluZyBjcm9zcy1mYWRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMjI0NDEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEzOTcz MTYyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRl c3Q6IGNzczMvaW1hZ2VzL2Nyb3NzLWZhZGUtc3ZnLXdpdGgtb3BhY2l0eS5odG1sCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9Dcm9zc2ZhZGVHZW5lcmF0ZWRJbWFnZS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpkcmF3Q3Jvc3NmYWRlU3ViaW1hZ2UpOgorICAgICAgICAoV2ViQ29yZTo6 Q3Jvc3NmYWRlR2VuZXJhdGVkSW1hZ2U6OmRyYXdDcm9zc2ZhZGUpOgorICAgICAgICBGYWN0b3Ig dGhlIGltYWdlIHBhaW50aW5nIG91dCBpbnRvIGEgZnVuY3Rpb24uCisgICAgICAgIENvbmRpdGlv bmFsbHkgdXNlIGEgdHJhbnNwYXJlbmN5IGxheWVyIGFyb3VuZCBwYWludGluZyBpZiB0aGUgaW1h Z2UKKyAgICAgICAgd2UncmUgZHJhd2luZyBpcyBhbiBTVkcgKFNWR0ltYWdlIGlzIHRoZSBvbmx5 IEltYWdlIHN1YmNsYXNzIHRoYXQgd2lsbAorICAgICAgICBub3QgcmVzcGVjdCB0aGUgY29udGV4 dCdzIG9wYWNpdHkpLgorCiAyMDEzLTEwLTA2ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxl LmNvbT4KIAogICAgICAgICBSYW5nZSBjb25zdHJ1Y3RvcnMgc2hvdWxkIHRha2UgYSBEb2N1bWVu dCYuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Dcm9zc2Zh ZGVHZW5lcmF0ZWRJbWFnZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9D cm9zc2ZhZGVHZW5lcmF0ZWRJbWFnZS5jcHAKaW5kZXggMTUxMzU2My4uMmY3MzdlMyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQ3Jvc3NmYWRlR2VuZXJhdGVk SW1hZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Nyb3NzZmFk ZUdlbmVyYXRlZEltYWdlLmNwcApAQCAtNDMsMTMgKzQzLDMzIEBAIENyb3NzZmFkZUdlbmVyYXRl ZEltYWdlOjpDcm9zc2ZhZGVHZW5lcmF0ZWRJbWFnZShJbWFnZSogZnJvbUltYWdlLCBJbWFnZSog dG9JbWFnCiAgICAgc2V0Q29udGFpbmVyU2l6ZShzaXplKTsKIH0KIAotdm9pZCBDcm9zc2ZhZGVH ZW5lcmF0ZWRJbWFnZTo6ZHJhd0Nyb3NzZmFkZShHcmFwaGljc0NvbnRleHQqIGNvbnRleHQpCitz dGF0aWMgdm9pZCBkcmF3Q3Jvc3NmYWRlU3ViaW1hZ2UoR3JhcGhpY3NDb250ZXh0KiBjb250ZXh0 LCBJbWFnZSogaW1hZ2UsIENvbXBvc2l0ZU9wZXJhdG9yIG9wZXJhdGlvbiwgZmxvYXQgb3BhY2l0 eSwgSW50U2l6ZSB0YXJnZXRTaXplKQogewotICAgIGZsb2F0IGludmVyc2VQZXJjZW50YWdlID0g MSAtIG1fcGVyY2VudGFnZTsKKyAgICBJbnRTaXplIGltYWdlU2l6ZSA9IGltYWdlLT5zaXplKCk7 CisKKyAgICAvLyBTVkdJbWFnZSByZXNldHMgdGhlIG9wYWNpdHkgd2hlbiBwYWludGluZywgc28g d2UgaGF2ZSB0byB1c2UgdHJhbnNwYXJlbmN5IGxheWVycyB0byBhY2N1cmF0ZWx5IHBhaW50IG9u ZSBhdCBhIGdpdmVuIG9wYWNpdHkuCisgICAgYm9vbCB1c2VUcmFuc3BhcmVuY3lMYXllciA9IGlt YWdlLT5pc1NWR0ltYWdlKCk7CisKKyAgICBHcmFwaGljc0NvbnRleHRTdGF0ZVNhdmVyIHN0YXRl U2F2ZXIoKmNvbnRleHQpOworCisgICAgY29udGV4dC0+c2V0Q29tcG9zaXRlT3BlcmF0aW9uKG9w ZXJhdGlvbik7CisKKyAgICBpZiAodXNlVHJhbnNwYXJlbmN5TGF5ZXIpCisgICAgICAgIGNvbnRl eHQtPmJlZ2luVHJhbnNwYXJlbmN5TGF5ZXIob3BhY2l0eSk7CisgICAgZWxzZQorICAgICAgICBj b250ZXh0LT5zZXRBbHBoYShvcGFjaXR5KTsKIAotICAgIEludFNpemUgZnJvbUltYWdlU2l6ZSA9 IG1fZnJvbUltYWdlLT5zaXplKCk7Ci0gICAgSW50U2l6ZSB0b0ltYWdlU2l6ZSA9IG1fdG9JbWFn ZS0+c2l6ZSgpOworICAgIGlmICh0YXJnZXRTaXplICE9IGltYWdlU2l6ZSkKKyAgICAgICAgY29u dGV4dC0+c2NhbGUoRmxvYXRTaXplKHN0YXRpY19jYXN0PGZsb2F0Pih0YXJnZXRTaXplLndpZHRo KCkpIC8gaW1hZ2VTaXplLndpZHRoKCksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBzdGF0aWNfY2FzdDxmbG9hdD4odGFyZ2V0U2l6ZS5oZWlnaHQoKSkgLyBpbWFnZVNpemUuaGVp Z2h0KCkpKTsKKyAgICBjb250ZXh0LT5kcmF3SW1hZ2UoaW1hZ2UsIENvbG9yU3BhY2VEZXZpY2VS R0IsIEludFBvaW50KCkpOwogCisgICAgaWYgKHVzZVRyYW5zcGFyZW5jeUxheWVyKQorICAgICAg ICBjb250ZXh0LT5lbmRUcmFuc3BhcmVuY3lMYXllcigpOworfQorCit2b2lkIENyb3NzZmFkZUdl bmVyYXRlZEltYWdlOjpkcmF3Q3Jvc3NmYWRlKEdyYXBoaWNzQ29udGV4dCogY29udGV4dCkKK3sK ICAgICAvLyBEcmF3IG5vdGhpbmcgaWYgZWl0aGVyIG9mIHRoZSBpbWFnZXMgaGFzbid0IGxvYWRl ZCB5ZXQuCiAgICAgaWYgKG1fZnJvbUltYWdlID09IEltYWdlOjpudWxsSW1hZ2UoKSB8fCBtX3Rv SW1hZ2UgPT0gSW1hZ2U6Om51bGxJbWFnZSgpKQogICAgICAgICByZXR1cm47CkBAIC01OCwyNCAr NzgsOSBAQCB2b2lkIENyb3NzZmFkZUdlbmVyYXRlZEltYWdlOjpkcmF3Q3Jvc3NmYWRlKEdyYXBo aWNzQ29udGV4dCogY29udGV4dCkKIAogICAgIGNvbnRleHQtPmNsaXAoSW50UmVjdChJbnRQb2lu dCgpLCBtX2Nyb3NzZmFkZVNpemUpKTsKICAgICBjb250ZXh0LT5iZWdpblRyYW5zcGFyZW5jeUxh eWVyKDEpOwotICAgIAotICAgIC8vIERyYXcgdGhlIGltYWdlIHdlJ3JlIGZhZGluZyBhd2F5IGZy b20uCi0gICAgY29udGV4dC0+c2F2ZSgpOwotICAgIGlmIChtX2Nyb3NzZmFkZVNpemUgIT0gZnJv bUltYWdlU2l6ZSkKLSAgICAgICAgY29udGV4dC0+c2NhbGUoRmxvYXRTaXplKHN0YXRpY19jYXN0 PGZsb2F0PihtX2Nyb3NzZmFkZVNpemUud2lkdGgoKSkgLyBmcm9tSW1hZ2VTaXplLndpZHRoKCks Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdGF0aWNfY2FzdDxmbG9hdD4obV9j cm9zc2ZhZGVTaXplLmhlaWdodCgpKSAvIGZyb21JbWFnZVNpemUuaGVpZ2h0KCkpKTsKLSAgICBj b250ZXh0LT5zZXRBbHBoYShpbnZlcnNlUGVyY2VudGFnZSk7Ci0gICAgY29udGV4dC0+ZHJhd0lt YWdlKG1fZnJvbUltYWdlLCBDb2xvclNwYWNlRGV2aWNlUkdCLCBJbnRQb2ludCgpKTsKLSAgICBj b250ZXh0LT5yZXN0b3JlKCk7Ci0KLSAgICAvLyBEcmF3IHRoZSBpbWFnZSB3ZSdyZSBmYWRpbmcg dG93YXJkcy4KLSAgICBjb250ZXh0LT5zYXZlKCk7Ci0gICAgaWYgKG1fY3Jvc3NmYWRlU2l6ZSAh PSB0b0ltYWdlU2l6ZSkKLSAgICAgICAgY29udGV4dC0+c2NhbGUoRmxvYXRTaXplKHN0YXRpY19j YXN0PGZsb2F0PihtX2Nyb3NzZmFkZVNpemUud2lkdGgoKSkgLyB0b0ltYWdlU2l6ZS53aWR0aCgp LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RhdGljX2Nhc3Q8ZmxvYXQ+KG1f Y3Jvc3NmYWRlU2l6ZS5oZWlnaHQoKSkgLyB0b0ltYWdlU2l6ZS5oZWlnaHQoKSkpOwotICAgIGNv bnRleHQtPnNldEFscGhhKG1fcGVyY2VudGFnZSk7Ci0gICAgY29udGV4dC0+ZHJhd0ltYWdlKG1f dG9JbWFnZSwgQ29sb3JTcGFjZURldmljZVJHQiwgSW50UG9pbnQoKSwgQ29tcG9zaXRlUGx1c0xp Z2h0ZXIpOwotICAgIGNvbnRleHQtPnJlc3RvcmUoKTsKKworICAgIGRyYXdDcm9zc2ZhZGVTdWJp bWFnZShjb250ZXh0LCBtX2Zyb21JbWFnZSwgQ29tcG9zaXRlU291cmNlT3ZlciwgMSAtIG1fcGVy Y2VudGFnZSwgbV9jcm9zc2ZhZGVTaXplKTsKKyAgICBkcmF3Q3Jvc3NmYWRlU3ViaW1hZ2UoY29u dGV4dCwgbV90b0ltYWdlLCBDb21wb3NpdGVQbHVzTGlnaHRlciwgbV9wZXJjZW50YWdlLCBtX2Ny b3NzZmFkZVNpemUpOwogCiAgICAgY29udGV4dC0+ZW5kVHJhbnNwYXJlbmN5TGF5ZXIoKTsKIH0K