122440 2013-10-07 00:47:29 -0700 JavaScriptCore fails to build 2013-10-08 02:40:08 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 r.plociennik webkit-unassigned commit-queue mark.lam mrowe oliver oldest_to_newest 936997 0 r.plociennik 2013-10-07 00:47:29 -0700 Compilation fails in debug due to 'comparison of unsigned expression >= 0 is always true'. 936999 1 213570 r.plociennik 2013-10-07 00:50:52 -0700 Created attachment 213570 Proposed patch 937075 2 213570 mark.lam 2013-10-07 08:59:33 -0700 Comment on attachment 213570 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=213570&action=review > Source/JavaScriptCore/debugger/DebuggerCallFrame.cpp:186 > + ASSERT(!callFrame->codeBlock()); > + ASSERT(!callFrame->codeBlock()); These asserts are meaningless without the line and column checks. But you are right that the line and column checks are not valid. Please remove the 2 asserts completely. 937389 3 213657 r.plociennik 2013-10-07 23:17:48 -0700 Created attachment 213657 Proposed patch Hasty patch on my part... Updated accordingly. 937393 4 213657 mark.lam 2013-10-07 23:27:15 -0700 Comment on attachment 213657 Proposed patch LGTM, but I'll need a reviewer to r+ the patch. 937475 5 213657 commit-queue 2013-10-08 02:40:06 -0700 Comment on attachment 213657 Proposed patch Clearing flags on attachment: 213657 Committed r157093: <http://trac.webkit.org/changeset/157093> 937476 6 commit-queue 2013-10-08 02:40:08 -0700 All reviewed patches have been landed. Closing bug. 213570 2013-10-07 00:50:52 -0700 2013-10-07 23:17:48 -0700 Proposed patch 122440.patch text/plain 1511 r.plociennik ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDUwYTU5YjguLjI5M2FkOTggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTEwLTA3ICBSb2JlcnQgUGxvY2ll bm5payAgPHIucGxvY2llbm5pa0BzYW1zdW5nLmNvbT4KKworICAgICAgICBKYXZhU2NyaXB0Q29y ZSBmYWlscyB0byBidWlsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTIyNDQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQ29tcGlsYXRpb24gZmFpbHMgaW4gZGVidWcgZHVlIHRvICdjb21wYXJpc29uIG9m IHVuc2lnbmVkIGV4cHJlc3Npb24gPj0gMCBpcworICAgICAgICBhbHdheXMgdHJ1ZScuCisKKyAg ICAgICAgKiBkZWJ1Z2dlci9EZWJ1Z2dlckNhbGxGcmFtZS5jcHA6CisgICAgICAgIChKU0M6OkRl YnVnZ2VyQ2FsbEZyYW1lOjpwb3NpdGlvbkZvckNhbGxGcmFtZSk6IFJlbW92ZWQgdGhlIGVycm9u ZW91cyBjb25kaXRpb24uCisKIDIwMTMtMTAtMDYgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxl LmNvbT4KIAogICAgICAgICBVbmlmaWVkIHRlc3QgaW5mcmFzdHJ1Y3R1cmUgdmlhIHRoZSBqc2Mg c2hlbGwKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZWJ1Z2dlci9EZWJ1Z2dl ckNhbGxGcmFtZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGVidWdnZXIvRGVidWdnZXJD YWxsRnJhbWUuY3BwCmluZGV4IGNjZDA0ODYuLjM2ODMzNWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZWJ1Z2dlci9EZWJ1Z2dlckNhbGxGcmFtZS5jcHAKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2RlYnVnZ2VyL0RlYnVnZ2VyQ2FsbEZyYW1lLmNwcApAQCAtMTgyLDgg KzE4Miw4IEBAIFRleHRQb3NpdGlvbiBEZWJ1Z2dlckNhbGxGcmFtZTo6cG9zaXRpb25Gb3JDYWxs RnJhbWUoQ2FsbEZyYW1lKiBjYWxsRnJhbWUpCiAKICAgICBMaW5lQW5kQ29sdW1uRnVuY3RvciBm dW5jdG9yOwogICAgIGNhbGxGcmFtZS0+aXRlcmF0ZShmdW5jdG9yKTsKLSAgICBBU1NFUlQoIWNh bGxGcmFtZS0+Y29kZUJsb2NrKCkgfHwgZnVuY3Rvci5saW5lKCkgPj0gMCk7Ci0gICAgQVNTRVJU KCFjYWxsRnJhbWUtPmNvZGVCbG9jaygpIHx8IGZ1bmN0b3IuY29sdW1uKCkgPj0gMCk7CisgICAg QVNTRVJUKCFjYWxsRnJhbWUtPmNvZGVCbG9jaygpKTsKKyAgICBBU1NFUlQoIWNhbGxGcmFtZS0+ Y29kZUJsb2NrKCkpOwogICAgIHJldHVybiBUZXh0UG9zaXRpb24oT3JkaW5hbE51bWJlcjo6ZnJv bU9uZUJhc2VkSW50KGZ1bmN0b3IubGluZSgpKSwgT3JkaW5hbE51bWJlcjo6ZnJvbU9uZUJhc2Vk SW50KGZ1bmN0b3IuY29sdW1uKCkpKTsKIH0KIAo= 213657 2013-10-07 23:17:48 -0700 2013-10-08 02:40:06 -0700 Proposed patch 122440.patch text/plain 1448 r.plociennik ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGJmOTJhMmUuLmNiMGY0ZmEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTEwLTA3ICBSb2JlcnQgUGxvY2ll bm5payAgPHIucGxvY2llbm5pa0BzYW1zdW5nLmNvbT4KKworICAgICAgICBKYXZhU2NyaXB0Q29y ZSBmYWlscyB0byBidWlsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTIyNDQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQ29tcGlsYXRpb24gZmFpbHMgaW4gZGVidWcgZHVlIHRvICdjb21wYXJpc29uIG9m IHVuc2lnbmVkIGV4cHJlc3Npb24gPj0gMCBpcworICAgICAgICBhbHdheXMgdHJ1ZScuCisKKyAg ICAgICAgKiBkZWJ1Z2dlci9EZWJ1Z2dlckNhbGxGcmFtZS5jcHA6CisgICAgICAgIChKU0M6OkRl YnVnZ2VyQ2FsbEZyYW1lOjpwb3NpdGlvbkZvckNhbGxGcmFtZSk6IFJlbW92ZWQgdGhlIG9mZmVu ZGluZyBBU1NFUlRTLgorCiAyMDEzLTEwLTA3ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxl LmNvbT4KIAogICAgICAgICBQYXNzIFZNIGluc3RlYWQgb2YgRXhlY1N0YXRlIHRvIEpTTm90QW5P YmplY3QgY29uc3RydWN0b3IuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGVi dWdnZXIvRGVidWdnZXJDYWxsRnJhbWUuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RlYnVn Z2VyL0RlYnVnZ2VyQ2FsbEZyYW1lLmNwcAppbmRleCBjY2QwNDg2Li5mM2VkM2RmIDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGVidWdnZXIvRGVidWdnZXJDYWxsRnJhbWUuY3Bw CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZWJ1Z2dlci9EZWJ1Z2dlckNhbGxGcmFtZS5j cHAKQEAgLTE4Miw4ICsxODIsNiBAQCBUZXh0UG9zaXRpb24gRGVidWdnZXJDYWxsRnJhbWU6OnBv c2l0aW9uRm9yQ2FsbEZyYW1lKENhbGxGcmFtZSogY2FsbEZyYW1lKQogCiAgICAgTGluZUFuZENv bHVtbkZ1bmN0b3IgZnVuY3RvcjsKICAgICBjYWxsRnJhbWUtPml0ZXJhdGUoZnVuY3Rvcik7Ci0g ICAgQVNTRVJUKCFjYWxsRnJhbWUtPmNvZGVCbG9jaygpIHx8IGZ1bmN0b3IubGluZSgpID49IDAp OwotICAgIEFTU0VSVCghY2FsbEZyYW1lLT5jb2RlQmxvY2soKSB8fCBmdW5jdG9yLmNvbHVtbigp ID49IDApOwogICAgIHJldHVybiBUZXh0UG9zaXRpb24oT3JkaW5hbE51bWJlcjo6ZnJvbU9uZUJh c2VkSW50KGZ1bmN0b3IubGluZSgpKSwgT3JkaW5hbE51bWJlcjo6ZnJvbU9uZUJhc2VkSW50KGZ1 bmN0b3IuY29sdW1uKCkpKTsKIH0KIAo=