122432 2013-10-06 17:03:01 -0700 Improve HashMap::add comment and other similar comments 2019-05-03 19:21:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 darin darin benjamin cmarcelo commit-queue markcarltonn oldest_to_newest 936889 0 darin 2013-10-06 17:03:01 -0700 Improve HashMap::add comment and other similar comments 936890 1 213542 darin 2013-10-06 17:03:31 -0700 Created attachment 213542 Patch 936896 2 213542 kling 2013-10-06 17:34:22 -0700 Comment on attachment 213542 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213542&action=review r=me with some suggestions from a non-native speaker: > Source/WTF/wtf/HashCountedSet.h:60 > + // Increases the count if an equal value is already present. Increases -> Increments > Source/WTF/wtf/HashCountedSet.h:62 > + // and an isNewEntry bool that indicates if it is a new or existing entry. I'd say "indicates whether" rather than "indicates if" > Source/WTF/wtf/HashCountedSet.h:65 > + // Reduces the count of the value, and removes it if count goes down to zero. Reduces -> Decrements 937323 3 darin 2013-10-07 18:57:58 -0700 Committed r157077: <http://trac.webkit.org/changeset/157077> 213542 2013-10-06 17:03:31 -0700 2013-10-06 17:34:22 -0700 Patch bug-122432-20131006170331.patch text/plain 4390 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3MDEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDk3MzM4MTQxM2JmMmEwMzBhYTY1MGZh NGQzMGQ1MDhlZmI2ZDQ3NzAuLjFiY2VjZjJlYzM1MTBiOWM2MTg1Y2NhNTg5YzQxOWYwNTM2OWUz MzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMTAtMDYgIERhcmluIEFkbGVyICA8ZGFyaW5A YXBwbGUuY29tPgorCisgICAgICAgIEltcHJvdmUgSGFzaE1hcDo6YWRkIGNvbW1lbnQgYW5kIG90 aGVyIHNpbWlsYXIgY29tbWVudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyMjQzMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogd3RmL0hhc2hDb3VudGVkU2V0Lmg6CisgICAgICAgICogd3RmL0hhc2hN YXAuaDoKKyAgICAgICAgKiB3dGYvSGFzaFNldC5oOgorICAgICAgICBVcGRhdGVkIGNvbW1lbnQg d29yZGluZy4gVGhleSB3ZXJlIGEgYml0IG9sZCBhbmQgb3V0IG9mIGRhdGUuCisgICAgICAgIFRo ZXkgYWxzbyBmZWF0dXJlZCB0aGUgd29yZCAiaW50ZXJhdG9yIi4KKwogMjAxMy0xMC0wNSAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIENsZWFuIHVwIE1l c3NhZ2VRdWV1ZS5oCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9IYXNoQ291bnRlZFNldC5o IGIvU291cmNlL1dURi93dGYvSGFzaENvdW50ZWRTZXQuaAppbmRleCAzNjczNjg4MDEwMWFlNzBi ODIxMDNkMjk1MTU1YjE5YjM0NmEyMWEwLi5hNDMxZmJiNDBlMWZiZDAyZTkwNzg2OWRmYTBiOTI2 YmNmOTU2NmU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9IYXNoQ291bnRlZFNldC5oCisr KyBiL1NvdXJjZS9XVEYvd3RmL0hhc2hDb3VudGVkU2V0LmgKQEAgLTU3LDE3ICs1NywxOCBAQCBu YW1lc3BhY2UgV1RGIHsKICAgICAgICAgYm9vbCBjb250YWlucyhjb25zdCBWYWx1ZVR5cGUmKSBj b25zdDsKICAgICAgICAgdW5zaWduZWQgY291bnQoY29uc3QgVmFsdWVUeXBlJikgY29uc3Q7CiAK LSAgICAgICAgLy8gSW5jcmVhc2VzIHRoZSBjb3VudCBpZiBhbiBlcXVhbCB2YWx1ZSBpcyBhbHJl YWR5IHByZXNlbnQKLSAgICAgICAgLy8gdGhlIHJldHVybiB2YWx1ZSBpcyBhIHBhaXIgb2YgYW4g aW50ZXJhdG9yIHRvIHRoZSBuZXcgdmFsdWUncyAKLSAgICAgICAgLy8gbG9jYXRpb24sIGFuZCBh IGJvb2wgdGhhdCBpcyB0cnVlIGlmIGFuIG5ldyBlbnRyeSB3YXMgYWRkZWQuCisgICAgICAgIC8v IEluY3JlYXNlcyB0aGUgY291bnQgaWYgYW4gZXF1YWwgdmFsdWUgaXMgYWxyZWFkeSBwcmVzZW50 LgorICAgICAgICAvLyBUaGUgcmV0dXJuIHZhbHVlIGluY2x1ZGVzIGJvdGggYW4gaXRlcmF0b3Ig dG8gdGhlIHZhbHVlJ3MgbG9jYXRpb24sCisgICAgICAgIC8vIGFuZCBhbiBpc05ld0VudHJ5IGJv b2wgdGhhdCBpbmRpY2F0ZXMgaWYgaXQgaXMgYSBuZXcgb3IgZXhpc3RpbmcgZW50cnkuCiAgICAg ICAgIEFkZFJlc3VsdCBhZGQoY29uc3QgVmFsdWVUeXBlJik7CiAgICAgICAgIAotICAgICAgICAv LyBSZWR1Y2VzIHRoZSBjb3VudCBvZiB0aGUgdmFsdWUsIGFuZCByZW1vdmVzIGl0IGlmIGNvdW50 Ci0gICAgICAgIC8vIGdvZXMgZG93biB0byB6ZXJvLCByZXR1cm5zIHRydWUgaWYgdGhlIHZhbHVl IGlzIHJlbW92ZWQuCisgICAgICAgIC8vIFJlZHVjZXMgdGhlIGNvdW50IG9mIHRoZSB2YWx1ZSwg YW5kIHJlbW92ZXMgaXQgaWYgY291bnQgZ29lcyBkb3duIHRvIHplcm8uCisgICAgICAgIC8vIFJl dHVybnMgdHJ1ZSBpZiB0aGUgdmFsdWUgaXMgcmVtb3ZlZC4KICAgICAgICAgYm9vbCByZW1vdmUo Y29uc3QgVmFsdWVUeXBlJik7CiAgICAgICAgIGJvb2wgcmVtb3ZlKGl0ZXJhdG9yKTsKICAKICAg ICAgICAgLy8gUmVtb3ZlcyB0aGUgdmFsdWUsIHJlZ2FyZGxlc3Mgb2YgaXRzIGNvdW50LgorICAg ICAgICAvLyBSZXR1cm5zIHRydWUgaWYgYSB2YWx1ZSB3YXMgcmVtb3ZlZC4KICAgICAgICAgYm9v bCByZW1vdmVBbGwoaXRlcmF0b3IpOwogICAgICAgICBib29sIHJlbW92ZUFsbChjb25zdCBWYWx1 ZVR5cGUmKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvSGFzaE1hcC5oIGIvU291cmNl L1dURi93dGYvSGFzaE1hcC5oCmluZGV4IGVlMjc4MDdhNDYwZGQyYWQ1NmM0ZWM0YjlmNDA5YTBk ZGE1YmViNDYuLmRmNTNkYTY4YjA3NmRkN2EwNWE3OGVmYzhmMWQ1OGM4Njk4ZWY0MjEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0hhc2hNYXAuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9IYXNo TWFwLmgKQEAgLTkwLDE1ICs5MCwxNSBAQCBwdWJsaWM6CiAgICAgYm9vbCBjb250YWlucyhjb25z dCBLZXlUeXBlJikgY29uc3Q7CiAgICAgTWFwcGVkUGVla1R5cGUgZ2V0KGNvbnN0IEtleVR5cGUm KSBjb25zdDsKIAotICAgIC8vIHJlcGxhY2VzIHZhbHVlIGJ1dCBub3Qga2V5IGlmIGtleSBpcyBh bHJlYWR5IHByZXNlbnQKLSAgICAvLyByZXR1cm4gdmFsdWUgaXMgYSBwYWlyIG9mIHRoZSBpdGVy YXRvciB0byB0aGUga2V5IGxvY2F0aW9uLCAKLSAgICAvLyBhbmQgYSBib29sZWFuIHRoYXQncyB0 cnVlIGlmIGEgbmV3IHZhbHVlIHdhcyBhY3R1YWxseSBhZGRlZAorICAgIC8vIFJlcGxhY2VzIHRo ZSB2YWx1ZSBidXQgbm90IHRoZSBrZXkgaWYgdGhlIGtleSBpcyBhbHJlYWR5IHByZXNlbnQuCisg ICAgLy8gUmV0dXJuIHZhbHVlIGluY2x1ZGVzIGJvdGggYW4gaXRlcmF0b3IgdG8gdGhlIGtleSBs b2NhdGlvbiwKKyAgICAvLyBhbmQgYW4gaXNOZXdFbnRyeSBib29sZWFuIHRoYXQncyB0cnVlIGlm IGEgbmV3IGVudHJ5IHdhcyBhZGRlZC4KICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBWPiBBZGRSZXN1 bHQgc2V0KGNvbnN0IEtleVR5cGUmLCBWJiYpOwogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFY+IEFk ZFJlc3VsdCBzZXQoS2V5VHlwZSYmLCBWJiYpOwogCi0gICAgLy8gZG9lcyBub3RoaW5nIGlmIGtl eSBpcyBhbHJlYWR5IHByZXNlbnQKLSAgICAvLyByZXR1cm4gdmFsdWUgaXMgYSBwYWlyIG9mIHRo ZSBpdGVyYXRvciB0byB0aGUga2V5IGxvY2F0aW9uLCAKLSAgICAvLyBhbmQgYSBib29sZWFuIHRo YXQncyB0cnVlIGlmIGEgbmV3IHZhbHVlIHdhcyBhY3R1YWxseSBhZGRlZAorICAgIC8vIERvZXMg bm90aGluZyBpZiB0aGUga2V5IGlzIGFscmVhZHkgcHJlc2VudC4KKyAgICAvLyBSZXR1cm4gdmFs dWUgaW5jbHVkZXMgYm90aCBhbiBpdGVyYXRvciB0byB0aGUga2V5IGxvY2F0aW9uLAorICAgIC8v IGFuZCBhbiBpc05ld0VudHJ5IGJvb2xlYW4gdGhhdCdzIHRydWUgaWYgYSBuZXcgZW50cnkgd2Fz IGFkZGVkLgogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFY+IEFkZFJlc3VsdCBhZGQoY29uc3QgS2V5 VHlwZSYsIFYmJik7CiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVj4gQWRkUmVzdWx0IGFkZChLZXlU eXBlJiYsIFYmJik7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0hhc2hTZXQuaCBiL1Nv dXJjZS9XVEYvd3RmL0hhc2hTZXQuaAppbmRleCAwMmRiZTA2ZGMyYzIwMzE0NzViMzYwN2JmYTM1 NTRlYzdmMjNjZWNhLi44MTEzYjc5YTY0N2IzMjIxMDFjMmY5YTMwY2E4Y2ZhY2M1MDk0YTBhIDEw MDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9IYXNoU2V0LmgKKysrIGIvU291cmNlL1dURi93dGYv SGFzaFNldC5oCkBAIC03MSw4ICs3MSw4IEBAIG5hbWVzcGFjZSBXVEYgewogICAgICAgICB0ZW1w bGF0ZTx0eXBlbmFtZSBIYXNoVHJhbnNsYXRvciwgdHlwZW5hbWUgVD4gaXRlcmF0b3IgZmluZChj b25zdCBUJikgY29uc3Q7CiAgICAgICAgIHRlbXBsYXRlPHR5cGVuYW1lIEhhc2hUcmFuc2xhdG9y LCB0eXBlbmFtZSBUPiBib29sIGNvbnRhaW5zKGNvbnN0IFQmKSBjb25zdDsKIAotICAgICAgICAv LyBUaGUgcmV0dXJuIHZhbHVlIGlzIGEgcGFpciBvZiBhbiBpbnRlcmF0b3IgdG8gdGhlIG5ldyB2 YWx1ZSdzIGxvY2F0aW9uLCAKLSAgICAgICAgLy8gYW5kIGEgYm9vbCB0aGF0IGlzIHRydWUgaWYg YW4gbmV3IGVudHJ5IHdhcyBhZGRlZC4KKyAgICAgICAgLy8gVGhlIHJldHVybiB2YWx1ZSBpbmNs dWRlcyBib3RoIGFuIGl0ZXJhdG9yIHRvIHRoZSBhZGRlZCB2YWx1ZSdzIGxvY2F0aW9uLAorICAg ICAgICAvLyBhbmQgYW4gaXNOZXdFbnRyeSBib29sIHRoYXQgaW5kaWNhdGVzIGlmIGl0IGlzIGEg bmV3IG9yIGV4aXN0aW5nIGVudHJ5IGluIHRoZSBzZXQuCiAgICAgICAgIEFkZFJlc3VsdCBhZGQo Y29uc3QgVmFsdWVUeXBlJik7CiAgICAgICAgIEFkZFJlc3VsdCBhZGQoVmFsdWVUeXBlJiYpOwog Cg==