122429 2013-10-06 16:16:45 -0700 Make Vector::insert work for move-only types 2013-10-07 18:26:53 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 darin darin andersca ap benjamin bw80.lee cmarcelo commit-queue oldest_to_newest 936877 0 darin 2013-10-06 16:16:45 -0700 Make Vector::insert work for move-only types 936878 1 213536 darin 2013-10-06 16:18:08 -0700 Created attachment 213536 Patch 936879 2 commit-queue 2013-10-06 16:19:49 -0700 Attachment 213536 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Vector.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/history/HistoryItem.cpp']" exit_code: 1 Source/WTF/wtf/Vector.h:647: Missing spaces around && [whitespace/operators] [3] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 936917 3 213536 andersca 2013-10-06 18:59:51 -0700 Comment on attachment 213536 Patch Patch looks good, but where's the API test? 937109 4 ap 2013-10-07 10:04:00 -0700 Is there a requirement to have unit tests for WTF? I don't remember any discussion that resulted in support for such. 937111 5 andersca 2013-10-07 10:11:39 -0700 (In reply to comment #4) > Is there a requirement to have unit tests for WTF? I don't remember any discussion that resulted in support for such. I’ve been adding unit tests as I’ve been implementing the move-only functionality of WTF data structures. 937115 6 213536 darin 2013-10-07 10:20:46 -0700 Comment on attachment 213536 Patch OK, I’ll upload a new patch with unit tests when I have some time to work on this. 937299 7 213536 andersca 2013-10-07 18:03:54 -0700 Comment on attachment 213536 Patch Nah, let’s land this. It was blocking a change Samsung want to make to their WorkQueue implementation. 937313 8 213536 commit-queue 2013-10-07 18:26:51 -0700 Comment on attachment 213536 Patch Clearing flags on attachment: 213536 Committed r157074: <http://trac.webkit.org/changeset/157074> 937314 9 commit-queue 2013-10-07 18:26:53 -0700 All reviewed patches have been landed. Closing bug. 213536 2013-10-06 16:18:08 -0700 2013-10-07 18:26:51 -0700 Patch bug-122429-20131006161807.patch text/plain 4357 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3MDExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDk3MzM4MTQxM2JmMmEwMzBhYTY1MGZh NGQzMGQ1MDhlZmI2ZDQ3NzAuLjE0YWE4MDIxNmY0NThmYzIzNzUwNDlmZWQ3ZTU2MjMxZDk3Yzc5 ZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMTAtMDYgIERhcmluIEFkbGVyICA8ZGFyaW5A YXBwbGUuY29tPgorCisgICAgICAgIE1ha2UgVmVjdG9yOjppbnNlcnQgd29yayBmb3IgbW92ZS1v bmx5IHR5cGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMjI0MjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHd0Zi9WZWN0b3IuaDoKKyAgICAgICAgKFdURjo6VmVjdG9yOjppbnNlcnQpOiBUYWtlIGFu IHJ2YWx1ZSByZWZlcmVuY2UgaW5zdGVhZCBvZiBhIGNvbnN0IHJlZmVyZW5jZS4KKyAgICAgICAg KFdURjo6VmVjdG9yOjppbnNlcnRWZWN0b3IpOiBSZW5hbWVkIHRvIGF2b2lkIG92ZXJsb2FkaW5n IHRyb3VibGVzLCBhbmFsb2dvdXMKKyAgICAgICAgdG8gd2hhdCB3ZSBkaWQgZm9yIGFwcGVuZFZl Y3Rvci4KKwogMjAxMy0xMC0wNSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29t PgogCiAgICAgICAgIENsZWFuIHVwIE1lc3NhZ2VRdWV1ZS5oCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDdkZmUw YmM3YjAzZjNlNmVkNjhjMjA2MzUxZDY4ZTVhNzUyZGJjMi4uYTEzN2Q5OTFjZDdhZWExMTc1MWIw NWM3N2VhOWEwZTBiY2U4NzBlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTEw LTA2ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIFZlY3Rv cjo6aW5zZXJ0IHdvcmsgZm9yIG1vdmUtb25seSB0eXBlcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIyNDI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBoaXN0b3J5L0hpc3RvcnlJdGVtLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6Okhpc3RvcnlJdGVtOjpwYWREYWlseUNvdW50c0Zvck5ld1Zpc2l0KTog Q2FsbCBpbnNlcnRWZWN0b3IuCisgICAgICAgIEFsc28gYWRkZWQgc29tZSBpbmxpbmUgY2FwYWNp dHksIHdoaWNoIHNob3VsZCBtYWtlIHRoaXMgZmFzdGVyLgorCiAyMDEzLTEwLTA2ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBNb3ZlIHBhaW50KCkgdG8gUmVu ZGVyRWxlbWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvVmVjdG9yLmggYi9Tb3VyY2Uv V1RGL3d0Zi9WZWN0b3IuaAppbmRleCBhMWEyNDJjOGFkZWEzMTBkYTM0ZjllN2YxYzQxZjNhYTA1 MWUzZjgyLi5kZjQzY2ZhYTYwMzlkNWEzNmIzOTA4MTI1Y2Y1NmRmMjk1M2NlZDY3IDEwMDY0NAot LS0gYS9Tb3VyY2UvV1RGL3d0Zi9WZWN0b3IuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9WZWN0b3Iu aApAQCAtNjQ0LDggKzY0NCw4IEBAIHB1YmxpYzoKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBVPiBi b29sIHRyeUFwcGVuZChjb25zdCBVKiwgc2l6ZV90KTsKIAogICAgIHRlbXBsYXRlPHR5cGVuYW1l IFU+IHZvaWQgaW5zZXJ0KHNpemVfdCBwb3NpdGlvbiwgY29uc3QgVSosIHNpemVfdCk7Ci0gICAg dGVtcGxhdGU8dHlwZW5hbWUgVT4gdm9pZCBpbnNlcnQoc2l6ZV90IHBvc2l0aW9uLCBjb25zdCBV Jik7Ci0gICAgdGVtcGxhdGU8dHlwZW5hbWUgVSwgc2l6ZV90IGM+IHZvaWQgaW5zZXJ0KHNpemVf dCBwb3NpdGlvbiwgY29uc3QgVmVjdG9yPFUsIGM+Jik7CisgICAgdGVtcGxhdGU8dHlwZW5hbWUg VT4gdm9pZCBpbnNlcnQoc2l6ZV90IHBvc2l0aW9uLCBVJiYpOworICAgIHRlbXBsYXRlPHR5cGVu YW1lIFUsIHNpemVfdCBjPiB2b2lkIGluc2VydFZlY3RvcihzaXplX3QgcG9zaXRpb24sIGNvbnN0 IFZlY3RvcjxVLCBjPiYpOwogCiAgICAgdm9pZCByZW1vdmUoc2l6ZV90IHBvc2l0aW9uKTsKICAg ICB2b2lkIHJlbW92ZShzaXplX3QgcG9zaXRpb24sIHNpemVfdCBsZW5ndGgpOwpAQCAtMTA5MSwy MiArMTA5MSwyNCBAQCB2b2lkIFZlY3RvcjxULCBpbmxpbmVDYXBhY2l0eSwgT3ZlcmZsb3dIYW5k bGVyPjo6aW5zZXJ0KHNpemVfdCBwb3NpdGlvbiwgY29uc3QgVQogfQogIAogdGVtcGxhdGU8dHlw ZW5hbWUgVCwgc2l6ZV90IGlubGluZUNhcGFjaXR5LCB0eXBlbmFtZSBPdmVyZmxvd0hhbmRsZXI+ IHRlbXBsYXRlPHR5cGVuYW1lIFU+Ci1pbmxpbmUgdm9pZCBWZWN0b3I8VCwgaW5saW5lQ2FwYWNp dHksIE92ZXJmbG93SGFuZGxlcj46Omluc2VydChzaXplX3QgcG9zaXRpb24sIGNvbnN0IFUmIHZh bCkKK2lubGluZSB2b2lkIFZlY3RvcjxULCBpbmxpbmVDYXBhY2l0eSwgT3ZlcmZsb3dIYW5kbGVy Pjo6aW5zZXJ0KHNpemVfdCBwb3NpdGlvbiwgVSYmIHZhbHVlKQogewogICAgIEFTU0VSVF9XSVRI X1NFQ1VSSVRZX0lNUExJQ0FUSU9OKHBvc2l0aW9uIDw9IHNpemUoKSk7Ci0gICAgY29uc3QgVSog ZGF0YSA9ICZ2YWw7CisKKyAgICBhdXRvIHB0ciA9IGNvbnN0X2Nhc3Q8dHlwZW5hbWUgc3RkOjpy ZW1vdmVfY29uc3Q8dHlwZW5hbWUgc3RkOjpyZW1vdmVfcmVmZXJlbmNlPFU+Ojp0eXBlPjo6dHlw ZSo+KHN0ZDo6YWRkcmVzc29mKHZhbHVlKSk7CiAgICAgaWYgKHNpemUoKSA9PSBjYXBhY2l0eSgp KSB7Ci0gICAgICAgIGRhdGEgPSBleHBhbmRDYXBhY2l0eShzaXplKCkgKyAxLCBkYXRhKTsKKyAg ICAgICAgcHRyID0gZXhwYW5kQ2FwYWNpdHkoc2l6ZSgpICsgMSwgcHRyKTsKICAgICAgICAgQVNT RVJUKGJlZ2luKCkpOwogICAgIH0KKwogICAgIFQqIHNwb3QgPSBiZWdpbigpICsgcG9zaXRpb247 CiAgICAgVHlwZU9wZXJhdGlvbnM6Om1vdmVPdmVybGFwcGluZyhzcG90LCBlbmQoKSwgc3BvdCAr IDEpOwotICAgIG5ldyAoTm90TnVsbCwgc3BvdCkgVCgqZGF0YSk7CisgICAgbmV3IChOb3ROdWxs LCBzcG90KSBUKHN0ZDo6Zm9yd2FyZDxVPigqcHRyKSk7CiAgICAgKyttX3NpemU7CiB9CiAKIHRl bXBsYXRlPHR5cGVuYW1lIFQsIHNpemVfdCBpbmxpbmVDYXBhY2l0eSwgdHlwZW5hbWUgT3ZlcmZs b3dIYW5kbGVyPiB0ZW1wbGF0ZTx0eXBlbmFtZSBVLCBzaXplX3QgYz4KLWlubGluZSB2b2lkIFZl Y3RvcjxULCBpbmxpbmVDYXBhY2l0eSwgT3ZlcmZsb3dIYW5kbGVyPjo6aW5zZXJ0KHNpemVfdCBw b3NpdGlvbiwgY29uc3QgVmVjdG9yPFUsIGM+JiB2YWwpCitpbmxpbmUgdm9pZCBWZWN0b3I8VCwg aW5saW5lQ2FwYWNpdHksIE92ZXJmbG93SGFuZGxlcj46Omluc2VydFZlY3RvcihzaXplX3QgcG9z aXRpb24sIGNvbnN0IFZlY3RvcjxVLCBjPiYgdmFsKQogewogICAgIGluc2VydChwb3NpdGlvbiwg dmFsLmJlZ2luKCksIHZhbC5zaXplKCkpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv aGlzdG9yeS9IaXN0b3J5SXRlbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9oaXN0b3J5L0hpc3RvcnlJ dGVtLmNwcAppbmRleCBiNGYwNWRmMjllYWY3NjQ0NmNjNDk4YjYxMWE5YzM2MmZkMDIxNDFmLi5l MTQ4MDQ4ZDE0NjNhN2VjZTA0YjgzNDlhNDQwNzdmM2EzNTEzYWY0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9oaXN0b3J5L0hpc3RvcnlJdGVtLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9o aXN0b3J5L0hpc3RvcnlJdGVtLmNwcApAQCAtMzMxLDExICszMzEsMTEgQEAgdm9pZCBIaXN0b3J5 SXRlbTo6cGFkRGFpbHlDb3VudHNGb3JOZXdWaXNpdChkb3VibGUgdGltZSkKICAgICBpbnQgZGF5 c0VsYXBzZWQgPSB0aW1lVG9EYXkodGltZSkgLSB0aW1lVG9EYXkobV9sYXN0VmlzaXRlZFRpbWUp OwogCiAgICAgaWYgKGRheXNFbGFwc2VkIDwgMCkKLSAgICAgIGRheXNFbGFwc2VkID0gMDsKKyAg ICAgICAgZGF5c0VsYXBzZWQgPSAwOwogCi0gICAgVmVjdG9yPGludD4gcGFkZGluZzsKKyAgICBW ZWN0b3I8aW50LCAzMj4gcGFkZGluZzsKICAgICBwYWRkaW5nLmZpbGwoMCwgZGF5c0VsYXBzZWQp OwotICAgIG1fZGFpbHlWaXNpdENvdW50cy5pbnNlcnQoMCwgcGFkZGluZyk7CisgICAgbV9kYWls eVZpc2l0Q291bnRzLmluc2VydFZlY3RvcigwLCBwYWRkaW5nKTsKIH0KIAogc3RhdGljIGNvbnN0 IHNpemVfdCBkYXlzUGVyV2VlayA9IDc7Cg==