122414 2013-10-06 10:22:48 -0700 context-menu-suggestions-multiword-selection.html and context-menu-suggestions-subword-selection.html are flaky after r156901 2013-10-08 02:56:53 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108370 113742 1 ap g.czajkowski g.czajkowski rniwa oldest_to_newest 936785 0 ap 2013-10-06 10:22:48 -0700 The following layout test is very flaky on Mac. editing/spelling/context-menu-suggestions-multiword-selection.html This started with <http://trac.webkit.org/changeset/156901>. http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=editing%2Fspelling%2Fcontext-menu-suggestions-multiword-selection.html 936787 1 ap 2013-10-06 10:28:15 -0700 Marked as flaky in r156990. 937019 2 g.czajkowski 2013-10-07 04:36:32 -0700 Committed r157034: <http://trac.webkit.org/changeset/157034> 937022 3 g.czajkowski 2013-10-07 04:49:24 -0700 Marked as flaky context-menu-suggestions-subword-selection.html too. It started failing for Mac similarly to context-menu-suggestions-multiword-selection.html. 937037 4 213579 g.czajkowski 2013-10-07 07:18:52 -0700 Created attachment 213579 Patch 937134 5 213579 rniwa 2013-10-07 11:02:43 -0700 Comment on attachment 213579 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213579&action=review > LayoutTests/editing/spelling/resources/util.js:28 > + }, true /* Doesn't produce logs on success. */ ); I think it's fine to output this. We just need to rebaseline the tests. 937159 6 g.czajkowski 2013-10-07 11:54:16 -0700 (In reply to comment #5) > (From update of attachment 213579 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=213579&action=review > > > LayoutTests/editing/spelling/resources/util.js:28 > > + }, true /* Doesn't produce logs on success. */ ); > > I think it's fine to output this. We just need to rebaseline the tests. Sure, will do that before landing. We should be aware that more spellchecking tests include utils.js and those need to be rebaselined too. 937478 7 g.czajkowski 2013-10-08 02:56:53 -0700 Committed r157094: <http://trac.webkit.org/changeset/157094> 213579 2013-10-07 07:18:52 -0700 2013-10-07 11:02:42 -0700 Patch bug-122414-20131007161850.patch text/plain 4999 g.czajkowski U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3MDM0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMjEyYTc1YjY4OTIwMTE1ZjY5YjJl ZDUyN2JjYThiNjk0NWQ3M2Q3Mi4uNjYwZTk4N2MyYzE5MWNhMmJiNjQ3ZGU5M2ViZDlkYWE5YmJj YTU1ZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI5IEBACiAyMDEzLTEwLTA3ICBHcnplZ29yeiBDemFqa293 c2tpICA8Zy5jemFqa293c2tpQHNhbXN1bmcuY29tPgogCisgICAgICAgIGNvbnRleHQtbWVudS1z dWdnZXN0aW9ucy1tdWx0aXdvcmQtc2VsZWN0aW9uLmh0bWwgYW5kIGNvbnRleHQtbWVudS1zdWdn ZXN0aW9ucy1zdWJ3b3JkLXNlbGVjdGlvbi5odG1sIGFyZSBmbGFreSBhZnRlciByMTU2OTAxCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjI0MTQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPbiBNYWMsIGZp cnN0IGNhbGwgb2YgJ2luaXRTcGVsbFRlc3QnIGZyb20gc3BlbGxpbmcvcmVzb3VyY2VzL3V0aWwu anMKKyAgICAgICAgb2Z0ZW4gZmFpbHMgd2hpbGUgY2hlY2tpbmcgc3BlbGxpbmcgbWFya2VyLgor ICAgICAgICBVc2Ugc2hvdWxkQmVjb21lRGlmZmVyZW50IGluc3RlYWQgb2YgY2FsbGluZyB0aW1l cnMgaW4gdGhlIHRlc3RzLgorICAgICAgICBJdCBzaG91bGQgaGF2ZSBiZWVuIGRvbmUgYXQgcjE1 NjEzNyB3aGVuIHNob3VsZEJlY29tZUVxdWFsL0RpZmZlcmVudAorICAgICAgICB3YXMgdXNlZCBp biBhc3luY2hyb25vdXMgc3BlbGwgY2hlY2tpbmcgdGVzdHMuCisKKyAgICAgICAgKiBlZGl0aW5n L3NwZWxsaW5nL3Jlc291cmNlcy91dGlsLmpzOgorICAgICAgICBVc2Ugc2hvdWxkQmVjb21lRGlm ZmVyZW50IGluc3RlYWQgb2YgdGltZXJzLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL1Rlc3RF eHBlY3RhdGlvbnM6CisgICAgICAgIE5vdyBjb250ZXh0LW1lbnUtc3VnZ2VzdGlvbnMtbXVsdGl3 b3JkLXNlbGVjdGlvbi5odG1sIGFuZAorICAgICAgICBjb250ZXh0LW1lbnUtc3VnZ2VzdGlvbnMt c3Vid29yZC1zZWxlY3Rpb24uaHRtbCBhcmUgcGFzc2luZyBmb3IgTWFjLgorCisgICAgICAgICog cmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzOgorICAgICAgICAoc2hvdWxkQmVjb21lRGlmZmVyZW50 KToKKyAgICAgICAgQWRkICdxdWlldCcgcGFyYW1ldGVyIHRvIHByZXZlbnQgb3V0cHV0dGluZyBs b2dzIG9uIHN1Y2Nlc3MuCisKKzIwMTMtMTAtMDcgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6 YWprb3dza2lAc2Ftc3VuZy5jb20+CisKICAgICAgICAgY29udGV4dC1tZW51LXN1Z2dlc3Rpb25z LW11bHRpd29yZC1zZWxlY3Rpb24uaHRtbCBhbmQgY29udGV4dC1tZW51LXN1Z2dlc3Rpb25zLXN1 YndvcmQtc2VsZWN0aW9uLmh0bWwgYXJlIGZsYWt5IGFmdGVyIHIxNTY5MDEuCiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjI0MTQKIApkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9zcGVsbGluZy9yZXNvdXJjZXMvdXRpbC5qcyBiL0xheW91 dFRlc3RzL2VkaXRpbmcvc3BlbGxpbmcvcmVzb3VyY2VzL3V0aWwuanMKaW5kZXggNjkzZmE1MTFm YzcxYzIxNGM3NmExOGUxMTE5MWEzOTI1ZGE5YWNmOS4uZGU3NzhiMzM3NThmMTMyOTliODRiNzVk NTQ3OTkxZTVhMTU2MTEwNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZWRpdGluZy9zcGVsbGlu Zy9yZXNvdXJjZXMvdXRpbC5qcworKysgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NwZWxsaW5nL3Jl c291cmNlcy91dGlsLmpzCkBAIC0zLDIxICszLDYgQEAgZnVuY3Rpb24gbG9nKG1zZykKICAgICBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY29uc29sZSIpLmlubmVySFRNTCArPSAobXNnICsgIlxu Iik7CiB9CiAKLWZ1bmN0aW9uIHZlcmlmeVNwZWxsVGVzdChucmV0cnkpCi17Ci0gICAgaWYgKCFu cmV0cnkpIHsKLSAgICAgICAgbG9nKCJGQUlMIFNwZWxsY2hlY2sgdGltZWQgb3V0Iik7Ci0gICAg ICAgIGZpbmlzaEpTVGVzdCgpCi0gICAgICAgIHJldHVybjsKLSAgICB9Ci0gICAgaWYgKCFpbnRl cm5hbHMubWFya2VyQ291bnRGb3JOb2RlKGRlc3RpbmF0aW9uLmNoaWxkTm9kZXNbMF0sICJzcGVs bGluZyIpKSB7Ci0gICAgICAgIHdpbmRvdy5zZXRUaW1lb3V0KGZ1bmN0aW9uKCkgeyB2ZXJpZnlT cGVsbFRlc3QobnJldHJ5IC0gMSk7IH0sIDApOwotICAgICAgICByZXR1cm47Ci0gICAgfQotICAg IHRlc3RGdW5jdGlvbkNhbGxiYWNrKGRlc3RpbmF0aW9uLmNoaWxkTm9kZXNbMF0pOwotICAgIGZp bmlzaEpTVGVzdCgpCi19Ci0KIGZ1bmN0aW9uIGluaXRTcGVsbFRlc3QodGVzdEVsZW1lbnRJZCwg dGVzdFRleHQsIHRlc3RGdW5jdGlvbikKIHsKICAgICBpZiAoIXdpbmRvdy5pbnRlcm5hbHMgfHwg IXdpbmRvdy50ZXN0UnVubmVyKSB7CkBAIC0zNyw1ICsyMiw4IEBAIGZ1bmN0aW9uIGluaXRTcGVs bFRlc3QodGVzdEVsZW1lbnRJZCwgdGVzdFRleHQsIHRlc3RGdW5jdGlvbikKICAgICB2YXIgZGVz dGluYXRpb24gPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCh0ZXN0RWxlbWVudElkKTsKICAgICBk ZXN0aW5hdGlvbi5mb2N1cygpOwogICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJJbnNlcnRUZXh0 IiwgZmFsc2UsIHRlc3RUZXh0KTsKLSAgICB3aW5kb3cuc2V0VGltZW91dChmdW5jdGlvbigpIHsg dmVyaWZ5U3BlbGxUZXN0KDEwKTsgfSwgMCk7CisgICAgc2hvdWxkQmVjb21lRGlmZmVyZW50KCdp bnRlcm5hbHMubWFya2VyQ291bnRGb3JOb2RlKGRlc3RpbmF0aW9uLmNoaWxkTm9kZXNbMF0sICJz cGVsbGluZyIpJywgJzAnLCBmdW5jdGlvbigpIHsKKyAgICAgICAgdGVzdEZ1bmN0aW9uQ2FsbGJh Y2soZGVzdGluYXRpb24uY2hpbGROb2Rlc1swXSk7CisgICAgICAgIGZpbmlzaEpTVGVzdCgpOwor ICAgIH0sIHRydWUgLyogRG9lc24ndCBwcm9kdWNlIGxvZ3Mgb24gc3VjY2Vzcy4gKi8gKTsKIH0K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zIGIv TGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggZTU4YTU5NDY3 ZjA4MTRkMzYzNGRlMjFkNGYxZGZjMzVjMDUwZDlhNi4uN2I1NjA4MzU4MGE1ZDNkYzNjNzc2Yjgz NzQwNzYyYmEyZDJhNTE4NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rl c3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3Rh dGlvbnMKQEAgLTU0MCw4ICs1NDAsNiBAQCB3ZWJraXQub3JnL2IvNjE2MzAgZmFzdC9ldmVudHMv ZHJvcHpvbmUtMDA1Lmh0bWwKIAogIyBTcGVsbGluZyB0ZXN0cyB0aGF0IGFyZSBmbGFrZXkuCiB3 ZWJraXQub3JnL2IvODI1NTUgZWRpdGluZy9zcGVsbGluZy9zcGVsbGNoZWNrLWFzeW5jLW11dGF0 aW9uLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzEyMjQxNCBlZGl0aW5nL3Nw ZWxsaW5nL2NvbnRleHQtbWVudS1zdWdnZXN0aW9ucy1tdWx0aXdvcmQtc2VsZWN0aW9uLmh0bWwg WyBQYXNzIEZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzEyMjQxNCBlZGl0aW5nL3NwZWxsaW5nL2Nv bnRleHQtbWVudS1zdWdnZXN0aW9ucy1zdWJ3b3JkLXNlbGVjdGlvbi5odG1sIFsgUGFzcyBGYWls dXJlIF0KIAogd2Via2l0Lm9yZy9iLzgyNjY1IGh0dHAvdGVzdHMvd2ViYXJjaGl2ZS90ZXN0LWNz cy11cmwtZW5jb2Rpbmctc2hpZnQtamlzLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi84 MjY2NSBodHRwL3Rlc3RzL3dlYmFyY2hpdmUvdGVzdC1jc3MtdXJsLWVuY29kaW5nLXV0Zi04Lmh0 bWwgWyBGYWlsdXJlIF0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3Jlc291cmNlcy9qcy10ZXN0 LXByZS5qcyBiL0xheW91dFRlc3RzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcwppbmRleCBlOTc0 MjQzYjcxOTJlMTkwZDFhODhiNGZhMjU2YzMzNTg2ODA1YWU3Li5hMzg2N2RhNGU0NDc4ZWQ0M2Ew OGY5OWRmNTdkOTllNThkNDkzYjRkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9yZXNvdXJjZXMv anMtdGVzdC1wcmUuanMKKysrIGIvTGF5b3V0VGVzdHMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpz CkBAIC0zODUsNyArMzg1LDcgQEAgZnVuY3Rpb24gc2hvdWxkTm90QmUoX2EsIF9iLCBxdWlldCkK ICAgICB0ZXN0RmFpbGVkKF9hICsgIiBzaG91bGQgbm90IGJlICIgKyBfYnYgKyAiLiIpOwogfQog Ci1mdW5jdGlvbiBzaG91bGRCZWNvbWVEaWZmZXJlbnQoX2EsIF9iLCBjb21wbGV0aW9uSGFuZGxl cikKK2Z1bmN0aW9uIHNob3VsZEJlY29tZURpZmZlcmVudChfYSwgX2IsIGNvbXBsZXRpb25IYW5k bGVyLCBxdWlldCkKIHsKICAgaWYgKHR5cGVvZiBfYSAhPSAic3RyaW5nIiB8fCB0eXBlb2YgX2Ig IT0gInN0cmluZyIpCiAgICAgZGVidWcoIldBUk46IHNob3VsZEJlY29tZURpZmZlcmVudCgpIGV4 cGVjdHMgc3RyaW5nIGFyZ3VtZW50cyIpOwpAQCAtNDAyLDcgKzQwMiw4IEBAIGZ1bmN0aW9uIHNo b3VsZEJlY29tZURpZmZlcmVudChfYSwgX2IsIGNvbXBsZXRpb25IYW5kbGVyKQogICAgIGlmIChl eGNlcHRpb24pCiAgICAgICB0ZXN0RmFpbGVkKF9hICsgIiBzaG91bGQgYmVjYW1lIG5vdCBlcXVh bCB0byAiICsgX2J2ICsgIi4gVGhyZXcgZXhjZXB0aW9uICIgKyBleGNlcHRpb24pOwogICAgIGlm ICghaXNSZXN1bHRDb3JyZWN0KF9hdiwgX2J2KSkgewotICAgICAgdGVzdFBhc3NlZChfYSArICIg YmVjYW1lIGRpZmZlcmVudCBmcm9tICIgKyBfYik7CisgICAgICBpZiAoIXF1aWV0KQorICAgICAg ICB0ZXN0UGFzc2VkKF9hICsgIiBiZWNhbWUgZGlmZmVyZW50IGZyb20gIiArIF9iKTsKICAgICAg IHJldHVybiB0cnVlOwogICAgIH0KICAgICByZXR1cm4gZmFsc2U7Cg==