122410 2013-10-06 05:02:55 -0700 Don't try to dispatch resize events for SVG images 2013-10-06 15:29:39 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 122371 1 koivisto webkit-unassigned commit-queue d-r esprehn+autocc fmalita glenn gyuyoung.kim kling kondapallykalyan pdr schenney zimmermann oldest_to_newest 936759 0 koivisto 2013-10-06 05:02:55 -0700 SVG images have scripting disabled but we still try to dispatch resize events. 936762 1 213509 koivisto 2013-10-06 05:14:02 -0700 Created attachment 213509 patch 936775 2 213509 darin 2013-10-06 09:32:31 -0700 Comment on attachment 213509 patch View in context: https://bugs.webkit.org/attachment.cgi?id=213509&action=review r=me if you add a null check for page or explain why it's not needed > Source/WebCore/page/FrameView.cpp:2773 > + if (frame().page()->chrome().client().isSVGImageChromeClient()) > + return; What guarantees that page is non-null? 936861 3 koivisto 2013-10-06 15:27:35 -0700 https://trac.webkit.org/r157010 936863 4 koivisto 2013-10-06 15:29:39 -0700 (In reply to comment #2) > What guarantees that page is non-null? Uh, some similar looking functions don't check it either... Added the check. 213509 2013-10-06 05:14:02 -0700 2013-10-06 09:32:31 -0700 patch svg-image-resize-event.patch text/plain 3275 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1Njk4NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEzLTEwLTA2ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBEb24ndCB0cnkgdG8gZGlzcGF0 Y2ggcmVzaXplIGV2ZW50cyBmb3IgU1ZHIGltYWdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIyNDEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdGVkIGJ5IGF2b2lkaW5nIGFzc2VydGlvbiBpbiBz dmcvY3VzdG9tL2xhcmdlLWltYWdlLXBhdHRlcm4tY3Jhc2guaHRtbAorCisgICAgICAgICogcGFn ZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3OjpzZW5kUmVzaXpl RXZlbnRJZk5lZWRlZCk6CisgICAgICAgIAorICAgICAgICAgICAgQmFpbCBvdXQgZm9yIFNWRyBp bWFnZXMuIFRoZXkgaGF2ZSBzY3JpcHRpbmcgZGlzYWJsZWQgc28gdGhlIGV2ZW50IHdvdWxkbid0 IGRvIGFueXRoaW5nIGFueXdheS4KKyAgICAgICAgICAgIFVzZSBvZiBGcmFtZVZpZXcgbWVjaGFu aXNtcyBpcyBqdXN0IGFuIGltcGxlbWVudGF0aW9uIGRldGFpbCBmb3IgU1ZHIGltYWdlcywgdGhl eSBhcmUgbm90CisgICAgICAgICAgICBtZWFudCB0byBhY3QgbGlrZSByZWFsIGZyYW1lcy4KKwor ICAgICAgICAqIHJlbmRlcmluZy9zdmcvUmVuZGVyU1ZHUmVzb3VyY2VQYXR0ZXJuLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlclNWR1Jlc291cmNlUGF0dGVybjo6Y3JlYXRlVGlsZUltYWdl KToKKyAgICAgICAgCisgICAgICAgICAgICBTd2l0Y2ggdG8gRWxlbWVudCBpdGVyYXRvci4gVGhp cyB3aWxsIHRha2UgTm9FdmVudERpc3BhdGNoQXNzZXJ0aW9uIHZlcmlmeWluZyB0aGUgY2hhbmdl LgorCiAyMDEzLTEwLTA2ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAg ICAgICBDVFRFOiBUZWFjaCBDb21wb3NpdGVFZGl0Q29tbWFuZCB0aGF0IGxpbmsgTm9kZXMgYXJl IGFsd2F5cyBFbGVtZW50cy4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAJKHJldmlz aW9uIDE1Njk4NykKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMjc2OSw2ICsyNzY5LDggQEAgdm9pZCBGcmFtZVZpZXc6OnNlbmRSZXNpemVF dmVudElmTmVlZGVkKAogICAgIFJlbmRlclZpZXcqIHJlbmRlclZpZXcgPSB0aGlzLT5yZW5kZXJW aWV3KCk7CiAgICAgaWYgKCFyZW5kZXJWaWV3IHx8IHJlbmRlclZpZXctPnByaW50aW5nKCkpCiAg ICAgICAgIHJldHVybjsKKyAgICBpZiAoZnJhbWUoKS5wYWdlKCktPmNocm9tZSgpLmNsaWVudCgp LmlzU1ZHSW1hZ2VDaHJvbWVDbGllbnQoKSkKKyAgICAgICAgcmV0dXJuOwogCiAgICAgSW50U2l6 ZSBjdXJyZW50U2l6ZTsKICAgICBpZiAodXNlRml4ZWRMYXlvdXQoKSAmJiAhZml4ZWRMYXlvdXRT aXplKCkuaXNFbXB0eSgpICYmIGRlbGVnYXRlc1Njcm9sbGluZygpKQpJbmRleDogU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdSZXNvdXJjZVBhdHRlcm4uY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVuZGVyU1ZHUmVzb3VyY2VQYXR0 ZXJuLmNwcAkocmV2aXNpb24gMTU2OTg3KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2 Zy9SZW5kZXJTVkdSZXNvdXJjZVBhdHRlcm4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMyw2ICsy Myw3IEBACiAjaWYgRU5BQkxFKFNWRykKICNpbmNsdWRlICJSZW5kZXJTVkdSZXNvdXJjZVBhdHRl cm4uaCIKIAorI2luY2x1ZGUgIkVsZW1lbnRJdGVyYXRvci5oIgogI2luY2x1ZGUgIkZyYW1lVmll dy5oIgogI2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4dC5oIgogI2luY2x1ZGUgIlBhdHRlcm5BdHRy aWJ1dGVzLmgiCkBAIC0yNzEsMTIgKzI3MiwxNCBAQCBQYXNzT3duUHRyPEltYWdlQnVmZmVyPiBS ZW5kZXJTVkdSZXNvdXJjCiAgICAgICAgIGNvbnRlbnRUcmFuc2Zvcm1hdGlvbiA9IHRpbGVJbWFn ZVRyYW5zZm9ybTsKIAogICAgIC8vIERyYXcgdGhlIGNvbnRlbnQgaW50byB0aGUgSW1hZ2VCdWZm ZXIuCi0gICAgZm9yIChOb2RlKiBub2RlID0gYXR0cmlidXRlcy5wYXR0ZXJuQ29udGVudEVsZW1l bnQoKS0+Zmlyc3RDaGlsZCgpOyBub2RlOyBub2RlID0gbm9kZS0+bmV4dFNpYmxpbmcoKSkgewot ICAgICAgICBpZiAoIW5vZGUtPmlzU1ZHRWxlbWVudCgpIHx8ICFub2RlLT5yZW5kZXJlcigpKQor ICAgIGF1dG8gY2hpbGRyZW4gPSBjaGlsZHJlbk9mVHlwZTxTVkdFbGVtZW50PihhdHRyaWJ1dGVz LnBhdHRlcm5Db250ZW50RWxlbWVudCgpKTsKKyAgICBmb3IgKGF1dG8gaXQgPSBjaGlsZHJlbi5i ZWdpbigpLCBlbmQgPSBjaGlsZHJlbi5lbmQoKTsgaXQgIT0gZW5kOyArK2l0KSB7CisgICAgICAg IGNvbnN0IFNWR0VsZW1lbnQmIGNoaWxkID0gKml0OworICAgICAgICBpZiAoIWNoaWxkLnJlbmRl cmVyKCkpCiAgICAgICAgICAgICBjb250aW51ZTsKLSAgICAgICAgaWYgKG5vZGUtPnJlbmRlcmVy KCktPm5lZWRzTGF5b3V0KCkpCisgICAgICAgIGlmIChjaGlsZC5yZW5kZXJlcigpLT5uZWVkc0xh eW91dCgpKQogICAgICAgICAgICAgcmV0dXJuIG51bGxwdHI7Ci0gICAgICAgIFNWR1JlbmRlcmlu Z0NvbnRleHQ6OnJlbmRlclN1YnRyZWVUb0ltYWdlQnVmZmVyKHRpbGVJbWFnZS5nZXQoKSwgbm9k ZS0+cmVuZGVyZXIoKSwgY29udGVudFRyYW5zZm9ybWF0aW9uKTsKKyAgICAgICAgU1ZHUmVuZGVy aW5nQ29udGV4dDo6cmVuZGVyU3VidHJlZVRvSW1hZ2VCdWZmZXIodGlsZUltYWdlLmdldCgpLCBj aGlsZC5yZW5kZXJlcigpLCBjb250ZW50VHJhbnNmb3JtYXRpb24pOwogICAgIH0KIAogICAgIHJl dHVybiB0aWxlSW1hZ2UucmVsZWFzZSgpOwo=