122363 2013-10-04 17:19:17 -0700 FTL: Optimize IsString(@2<String>) -> JSConst(true) + Phantom() 2013-10-07 15:07:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 nrotem webkit-unassigned commit-queue fpizlo ggaren oldest_to_newest 936443 0 nrotem 2013-10-04 17:19:17 -0700 FTL: Optimize IsString(@2<String) -> JSConst(true) + Phantom() 936444 1 213424 nrotem 2013-10-04 17:19:52 -0700 Created attachment 213424 Patch 936447 2 213424 darin 2013-10-04 17:28:44 -0700 Comment on attachment 213424 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213424&action=review > Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:894 > + case IsString: { > + if (node->child1().useKind() == StringUse) { > + m_insertionSet.insertNode(m_indexInBlock, SpecNone, Phantom, node->codeOrigin, > + Edge(node->child1().node(), StringUse)); > + node->convertToConstant(1); > + break; > + } > + } While I am not qualified to review this, I do have two small style comments: We should break rather than falling through at the end of this case. Also, there is no need for the outer braces around the if statement, so please remove them. 936455 3 213426 nrotem 2013-10-04 17:35:34 -0700 Created attachment 213426 Patch 937225 4 213617 nrotem 2013-10-07 14:34:47 -0700 Created attachment 213617 Patch 937229 5 213617 commit-queue 2013-10-07 15:07:26 -0700 Comment on attachment 213617 Patch Clearing flags on attachment: 213617 Committed r157059: <http://trac.webkit.org/changeset/157059> 937230 6 commit-queue 2013-10-07 15:07:29 -0700 All reviewed patches have been landed. Closing bug. 213424 2013-10-04 17:19:52 -0700 2013-10-04 17:35:32 -0700 Patch bug-122363-20131004171952.patch text/plain 1908 nrotem U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2OTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 MWQwZGJjYzJkZTZjMTBkOGNlM2Y0ZTRhZDJkZWZhZmJiM2FiMzMwLi44YmRmZjBlMzExYmQ1OWRj ZTE5YWQ0MTE0ZjM0MDg0YzhmYjk3MzZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxMy0xMC0wNCAgTmFkYXYgUm90ZW0gIDxucm90ZW1AYXBwbGUuY29tPgor CisgICAgICAgIEZUTDogT3B0aW1pemUgSXNTdHJpbmcoQDI8U3RyaW5nPikgLT4gSlNDb25zdCh0 cnVlKSArIFBoYW50b20oKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTIyMzYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBkZmcvREZHRml4dXBQaGFzZS5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6Rml4 dXBQaGFzZTo6Zml4dXBOb2RlKToKKwogMjAxMy0xMC0wNCAgTWljaGFlbCBTYWJvZmYgIDxtc2Fi b2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBGVEw6Ok9TUkV4aXQ6OmNvbnZlcnRUb0ZvcndhcmQo KSBzaG91bGRuJ3QgbWlzdXNlIE9wZXJhbmRzPD46Om9wZXJhdG9yW10KZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRml4dXBQaGFzZS5jcHAgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR0ZpeHVwUGhhc2UuY3BwCmluZGV4IDQ5OWY1NmY4NjdlNzE5M2Q2OWYw ZjQ3ZDU3Yzk1NzAzYzFiZWJjNWUuLjAwZmYxMzQxMDdkZGRlMTRmNGUzMTgxYzVjMWI4M2ViYzUz NDQ4NWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRml4dXBQaGFz ZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdGaXh1cFBoYXNlLmNwcApA QCAtODg0LDggKzg4NCwxNSBAQCBwcml2YXRlOgogICAgICAgICBjYXNlIEludDUyVG9WYWx1ZToK ICAgICAgICAgICAgIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgICAgICAgICBi cmVhazsKLSAgICAgICAgCi0jaWYgIUFTU0VSVF9ESVNBQkxFRCAgICAKKyAgICAgICAgY2FzZSBJ c1N0cmluZzogeworICAgICAgICAgICAgaWYgKG5vZGUtPmNoaWxkMSgpLnVzZUtpbmQoKSA9PSBT dHJpbmdVc2UpIHsKKyAgICAgICAgICAgICAgICBtX2luc2VydGlvblNldC5pbnNlcnROb2RlKG1f aW5kZXhJbkJsb2NrLCBTcGVjTm9uZSwgUGhhbnRvbSwgbm9kZS0+Y29kZU9yaWdpbiwKKyAgICAg ICAgICAgICAgICAgICAgRWRnZShub2RlLT5jaGlsZDEoKS5ub2RlKCksIFN0cmluZ1VzZSkpOwor ICAgICAgICAgICAgICAgIG5vZGUtPmNvbnZlcnRUb0NvbnN0YW50KDEpOworICAgICAgICAgICAg ICAgIGJyZWFrOworICAgICAgICAgICAgfQorICAgICAgICB9CisjaWYgIUFTU0VSVF9ESVNBQkxF RAogICAgICAgICAvLyBIYXZlIHRoZXNlIG5vLW9wIGNhc2VzIGhlcmUgdG8gZW5zdXJlIHRoYXQg bm9ib2R5IGZvcmdldHMgdG8gYWRkIGhhbmRsZXJzIGZvciBuZXcgb3Bjb2Rlcy4KICAgICAgICAg Y2FzZSBTZXRBcmd1bWVudDoKICAgICAgICAgY2FzZSBKU0NvbnN0YW50OgpAQCAtOTEyLDcgKzkx OSw2IEBAIHByaXZhdGU6CiAgICAgICAgIGNhc2UgSXNVbmRlZmluZWQ6CiAgICAgICAgIGNhc2Ug SXNCb29sZWFuOgogICAgICAgICBjYXNlIElzTnVtYmVyOgotICAgICAgICBjYXNlIElzU3RyaW5n OgogICAgICAgICBjYXNlIElzT2JqZWN0OgogICAgICAgICBjYXNlIElzRnVuY3Rpb246CiAgICAg ICAgIGNhc2UgQ3JlYXRlQWN0aXZhdGlvbjoK 213426 2013-10-04 17:35:34 -0700 2013-10-07 14:34:43 -0700 Patch bug-122363-20131004173533.patch text/plain 1847 nrotem U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2OTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 MWQwZGJjYzJkZTZjMTBkOGNlM2Y0ZTRhZDJkZWZhZmJiM2FiMzMwLi44YmRmZjBlMzExYmQ1OWRj ZTE5YWQ0MTE0ZjM0MDg0YzhmYjk3MzZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxMy0xMC0wNCAgTmFkYXYgUm90ZW0gIDxucm90ZW1AYXBwbGUuY29tPgor CisgICAgICAgIEZUTDogT3B0aW1pemUgSXNTdHJpbmcoQDI8U3RyaW5nPikgLT4gSlNDb25zdCh0 cnVlKSArIFBoYW50b20oKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTIyMzYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBkZmcvREZHRml4dXBQaGFzZS5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6Rml4 dXBQaGFzZTo6Zml4dXBOb2RlKToKKwogMjAxMy0xMC0wNCAgTWljaGFlbCBTYWJvZmYgIDxtc2Fi b2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBGVEw6Ok9TUkV4aXQ6OmNvbnZlcnRUb0ZvcndhcmQo KSBzaG91bGRuJ3QgbWlzdXNlIE9wZXJhbmRzPD46Om9wZXJhdG9yW10KZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRml4dXBQaGFzZS5jcHAgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR0ZpeHVwUGhhc2UuY3BwCmluZGV4IDQ5OWY1NmY4NjdlNzE5M2Q2OWYw ZjQ3ZDU3Yzk1NzAzYzFiZWJjNWUuLmViZDRkYzAxZTk5NTFiOWFiNzA5OTM3N2M5YTE1MjYxYzQ2 YTY1NDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRml4dXBQaGFz ZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdGaXh1cFBoYXNlLmNwcApA QCAtODg0LDcgKzg4NCwxNSBAQCBwcml2YXRlOgogICAgICAgICBjYXNlIEludDUyVG9WYWx1ZToK ICAgICAgICAgICAgIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgICAgICAgICBi cmVhazsKLSAgICAgICAgCisKKyAgICAgICAgY2FzZSBJc1N0cmluZzoKKyAgICAgICAgICAgIGlm IChub2RlLT5jaGlsZDEoKS51c2VLaW5kKCkgPT0gU3RyaW5nVXNlKSB7CisgICAgICAgICAgICAg ICAgbV9pbnNlcnRpb25TZXQuaW5zZXJ0Tm9kZShtX2luZGV4SW5CbG9jaywgU3BlY05vbmUsIFBo YW50b20sIG5vZGUtPmNvZGVPcmlnaW4sCisgICAgICAgICAgICAgICAgICAgIEVkZ2Uobm9kZS0+ Y2hpbGQxKCkubm9kZSgpLCBTdHJpbmdVc2UpKTsKKyAgICAgICAgICAgICAgICBub2RlLT5jb252 ZXJ0VG9Db25zdGFudCgxKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIGJyZWFrOworCiAj aWYgIUFTU0VSVF9ESVNBQkxFRCAgICAKICAgICAgICAgLy8gSGF2ZSB0aGVzZSBuby1vcCBjYXNl cyBoZXJlIHRvIGVuc3VyZSB0aGF0IG5vYm9keSBmb3JnZXRzIHRvIGFkZCBoYW5kbGVycyBmb3Ig bmV3IG9wY29kZXMuCiAgICAgICAgIGNhc2UgU2V0QXJndW1lbnQ6CkBAIC05MTIsNyArOTIwLDYg QEAgcHJpdmF0ZToKICAgICAgICAgY2FzZSBJc1VuZGVmaW5lZDoKICAgICAgICAgY2FzZSBJc0Jv b2xlYW46CiAgICAgICAgIGNhc2UgSXNOdW1iZXI6Ci0gICAgICAgIGNhc2UgSXNTdHJpbmc6CiAg ICAgICAgIGNhc2UgSXNPYmplY3Q6CiAgICAgICAgIGNhc2UgSXNGdW5jdGlvbjoKICAgICAgICAg Y2FzZSBDcmVhdGVBY3RpdmF0aW9uOgo= 213617 2013-10-07 14:34:47 -0700 2013-10-07 15:07:26 -0700 Patch bug-122363-20131007143446.patch text/plain 1975 nrotem U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2OTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 MWQwZGJjYzJkZTZjMTBkOGNlM2Y0ZTRhZDJkZWZhZmJiM2FiMzMwLi44YmRmZjBlMzExYmQ1OWRj ZTE5YWQ0MTE0ZjM0MDg0YzhmYjk3MzZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxMy0xMC0wNCAgTmFkYXYgUm90ZW0gIDxucm90ZW1AYXBwbGUuY29tPgor CisgICAgICAgIEZUTDogT3B0aW1pemUgSXNTdHJpbmcoQDI8U3RyaW5nPikgLT4gSlNDb25zdCh0 cnVlKSArIFBoYW50b20oKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTIyMzYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBkZmcvREZHRml4dXBQaGFzZS5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6Rml4 dXBQaGFzZTo6Zml4dXBOb2RlKToKKwogMjAxMy0xMC0wNCAgTWljaGFlbCBTYWJvZmYgIDxtc2Fi b2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBGVEw6Ok9TUkV4aXQ6OmNvbnZlcnRUb0ZvcndhcmQo KSBzaG91bGRuJ3QgbWlzdXNlIE9wZXJhbmRzPD46Om9wZXJhdG9yW10KZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRml4dXBQaGFzZS5jcHAgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR0ZpeHVwUGhhc2UuY3BwCmluZGV4IDQ5OWY1NmY4NjdlNzE5M2Q2OWYw ZjQ3ZDU3Yzk1NzAzYzFiZWJjNWUuLjU5MTI4ZDQ2YzFiZTAzMjA4OWJhYTBhOGRkODRlOWFlZTU1 NDI1ZGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRml4dXBQaGFz ZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdGaXh1cFBoYXNlLmNwcApA QCAtODg0LDggKzg4NCwxNyBAQCBwcml2YXRlOgogICAgICAgICBjYXNlIEludDUyVG9WYWx1ZToK ICAgICAgICAgICAgIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgICAgICAgICBi cmVhazsKLSAgICAgICAgCi0jaWYgIUFTU0VSVF9ESVNBQkxFRCAgICAKKworICAgICAgICBjYXNl IElzU3RyaW5nOgorICAgICAgICAgICAgaWYgKG5vZGUtPmNoaWxkMSgpLT5zaG91bGRTcGVjdWxh dGVTdHJpbmcoKSkgeworICAgICAgICAgICAgICAgIG1faW5zZXJ0aW9uU2V0Lmluc2VydE5vZGUo bV9pbmRleEluQmxvY2ssIFNwZWNOb25lLCBQaGFudG9tLCBub2RlLT5jb2RlT3JpZ2luLAorICAg ICAgICAgICAgICAgICAgICBFZGdlKG5vZGUtPmNoaWxkMSgpLm5vZGUoKSwgU3RyaW5nVXNlKSk7 CisgICAgICAgICAgICAgICAgbV9ncmFwaC5jb252ZXJ0VG9Db25zdGFudChub2RlLCBqc0Jvb2xl YW4odHJ1ZSkpOworICAgICAgICAgICAgICAgIG9ic2VydmVVc2VLaW5kT25Ob2RlPFN0cmluZ1Vz ZT4obm9kZSk7CisgICAgICAgICAgICB9CisgICAgICAgICAgICBicmVhazsKKworI2lmICFBU1NF UlRfRElTQUJMRUQKICAgICAgICAgLy8gSGF2ZSB0aGVzZSBuby1vcCBjYXNlcyBoZXJlIHRvIGVu c3VyZSB0aGF0IG5vYm9keSBmb3JnZXRzIHRvIGFkZCBoYW5kbGVycyBmb3IgbmV3IG9wY29kZXMu CiAgICAgICAgIGNhc2UgU2V0QXJndW1lbnQ6CiAgICAgICAgIGNhc2UgSlNDb25zdGFudDoKQEAg LTkxMiw3ICs5MjEsNiBAQCBwcml2YXRlOgogICAgICAgICBjYXNlIElzVW5kZWZpbmVkOgogICAg ICAgICBjYXNlIElzQm9vbGVhbjoKICAgICAgICAgY2FzZSBJc051bWJlcjoKLSAgICAgICAgY2Fz ZSBJc1N0cmluZzoKICAgICAgICAgY2FzZSBJc09iamVjdDoKICAgICAgICAgY2FzZSBJc0Z1bmN0 aW9uOgogICAgICAgICBjYXNlIENyZWF0ZUFjdGl2YXRpb246Cg==