122331 2013-10-04 10:50:25 -0700 remove dpranke from webkitpy watchlist 2013-10-04 11:32:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke bfulgham commit-queue gyuyoung.kim rniwa oldest_to_newest 936243 0 dpranke 2013-10-04 10:50:25 -0700 remove dpranke from webkitpy watchlist 936244 1 213376 dpranke 2013-10-04 10:50:39 -0700 Created attachment 213376 Patch 936245 2 dpranke 2013-10-04 10:54:20 -0700 At this point WebKit's webkitpy has diverged quite a bit from Blink's and me tracking every WebKit-side change is not all that useful. Also, it looks like Gyuyoung landed an unreviewed change to watchlist in http://trac.webkit.org/changeset/156880 that isn't correct or even syntactically valid. I can fix that as part of this change if people would prefer, or someone can revert that change, but I expect the EWS bots will explode on this patch with no action otherwise. 936249 3 213376 bfulgham 2013-10-04 10:56:42 -0700 Comment on attachment 213376 Patch r=me. 936250 4 commit-queue 2013-10-04 10:56:45 -0700 Attachment 213376 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy/common/config/watchlist']" exit_code: 1 Traceback (most recent call last): File "Tools/Scripts/check-webkit-style", line 48, in <module> sys.exit(CheckWebKitStyle().main()) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/main.py", line 154, in main patch_checker.check(patch) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/patchreader.py", line 83, in check self._text_file_reader.process_file(file_path=path, line_numbers=line_numbers) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/filereader.py", line 130, in process_file self._processor.process(lines, file_path, **kwargs) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/checker.py", line 889, in process checker.check(lines) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/checkers/watchlist.py", line 51, in check WatchListParser(log_error=log_to_style_error).parse('\n'.join(lines)) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py", line 70, in parse dictionary = self._eval_watch_list(watch_list_contents) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py", line 86, in _eval_watch_list return eval(watch_list_contents, {'__builtins__': None}, None) File "<string>", line 242 "filename": r"Source/WebCore/svg, "gyuyoung.kim@webkit.org"" ^ SyntaxError: invalid syntax If any of these errors are false positives, please file a bug against check-webkit-style. 936267 5 ap 2013-10-04 11:25:36 -0700 > Also, it looks like Gyuyoung landed an unreviewed change to watchlist in http://trac.webkit.org/changeset/156880 that isn't correct or even syntactically valid. Fixed that in r156897. 936274 6 213376 commit-queue 2013-10-04 11:32:47 -0700 Comment on attachment 213376 Patch Clearing flags on attachment: 213376 Committed r156899: <http://trac.webkit.org/changeset/156899> 936276 7 commit-queue 2013-10-04 11:32:50 -0700 All reviewed patches have been landed. Closing bug. 213376 2013-10-04 10:50:39 -0700 2013-10-04 11:32:47 -0700 Patch bug-122331-20131004105038.patch text/plain 1342 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2ODk0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWM1YmE0YTFjZDFjM2Y0Mjc1MjI4ZmJmZDVhY2NmY2Rj YTQ1NmVlYi4uZTc1ZTE0YWFmMDM4YWE3YjE3NzFiMjU4YmIzZWY1NmFmODcxNWQ2OCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDEzLTEwLTA0ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIHJlbW92ZSBkcHJhbmtlIGZyb20gd2Via2l0cHkgd2F0Y2hsaXN0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjIzMzEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv Y29tbW9uL2NvbmZpZy93YXRjaGxpc3Q6CisKIDIwMTMtMTAtMDMgIEd5dXlvdW5nIEtpbSAgPGd5 dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBBZGQgbXlzZWxm IHRvIHNvbWUgd2F0Y2hsaXN0cy4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv Y29tbW9uL2NvbmZpZy93YXRjaGxpc3QgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9j b25maWcvd2F0Y2hsaXN0CmluZGV4IDU4MDE0Y2Q4YmMyZDFlZWNmMWUyMTg3OTMxOGJjNDMxOTU4 MzcyMzcuLjdmNmQ4Mzg1ODE5YTFkNjJlODBlNTY0ZmQ4ZWNhYjY3NmI2Yzc0NWQgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy93YXRjaGxpc3QKKysrIGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL3dhdGNobGlzdApAQCAtMzg4LDcg KzM4OCw3IEBACiAgICAgICAgICJXZWJTb2NrZXQiOiBbICJ5dXRha0BjaHJvbWl1bS5vcmciLCAi dG95b3NoaW0rd2F0Y2hsaXN0QGNocm9taXVtLm9yZyIgXSwKICAgICAgICAgIlhTUyI6IFsgImRi YXRlc0B3ZWJraXQub3JnIiBdLAogICAgICAgICAid2Via2l0cGVybCI6IFsgImRiYXRlc0B3ZWJr aXQub3JnIiBdLAotICAgICAgICAid2Via2l0cHkiOiBbICJkcHJhbmtlQGNocm9taXVtLm9yZyIs ICJnbGVubkBza3luYXYuY29tIiBdLAorICAgICAgICAid2Via2l0cHkiOiBbICJnbGVubkBza3lu YXYuY29tIiBdLAogICAgIH0sCiAgICAgIk1FU1NBR0VfUlVMRVMiOiB7CiAgICAgICAgICJBcHBs ZU1hY1B1YmxpY0FwaSI6IFsgIlBsZWFzZSB3YWl0IGZvciBhcHByb3ZhbCBmcm9tIHRpbW90aHlA YXBwbGUuY29tIChvciBhbm90aGVyIG1lbWJlciAiCg==