122329 2013-10-04 10:08:47 -0700 [Mac] Don't preflight spell checker when calling -setContinuousSpellCheckingEnabled repeatedly 2013-10-04 23:39:43 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap darin enrica rniwa oldest_to_newest 936224 0 ap 2013-10-04 10:08:47 -0700 In <rdar://problem/15145394>, I observed a case where WebKit1 tests would fail to function because of repeated attempts to launch spellchecking service. DumpRenderTree calls -[WebView setContinuousSpellCheckingEnabled:YES] before each test, and this results in WebKit calling [[NSSpellChecker sharedSpellChecker] _preflightChosenSpellServer], which in turn launches the service if it's not launched yet. What I observed was that launchservicesd was busy servicing AppleSpell.service registrations, and this was making service launch time out, and this was making us try to re-launch it again and again. I'm not sure what the initial trigger for the misbehavior was, but repeatedly trying to relaunch an app that fails to launch makes little sense. 936225 1 213369 ap 2013-10-04 10:11:41 -0700 Created attachment 213369 proposed patch 936430 2 213369 darin 2013-10-04 17:00:18 -0700 Comment on attachment 213369 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=213369&action=review > Source/WebKit/mac/WebView/WebView.mm:-5547 > if (continuousSpellCheckingEnabled != flag) { > continuousSpellCheckingEnabled = flag; > [[NSUserDefaults standardUserDefaults] setBool:continuousSpellCheckingEnabled forKey:WebContinuousSpellCheckingEnabled]; > - } I think this would read better as early return than with all the code nested inside and if statement. 936528 3 ap 2013-10-04 23:39:43 -0700 > I think this would read better as early return than with all the code nested inside and if statement. Oops. Fixed and landed in <http://trac.webkit.org/r156949>. 213369 2013-10-04 10:11:41 -0700 2013-10-04 17:00:17 -0700 proposed patch SpellChecker.txt text/plain 1653 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1Njg5NCkKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTEwLTA0 ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIERvbid0IHBy ZWZsaWdodCBzcGVsbCBjaGVja2VyIHdoZW4gY2FsbGluZyAtc2V0Q29udGludW91c1NwZWxsQ2hl Y2tpbmdFbmFibGVkIHJlcGVhdGVkbHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyMjMyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogV2ViVmlldy9XZWJWaWV3Lm1tOiAoLVtXZWJWaWV3IHNldENvbnRp bnVvdXNTcGVsbENoZWNraW5nRW5hYmxlZDpdKTogRG9uJ3QgZG8gYW55CisgICAgICAgIHdvcmsg aWYgcHJlZmVyZW5jZSBkaWRuJ3QgY2hhbmdlIChjb250aW51b3VzU3BlbGxDaGVja2luZ0VuYWJs ZWQgaXMgYSBzdGF0aWMgdGhhdAorICAgICAgICBzdGFydHMgd2l0aCBmYWxzZSkuCisKIDIwMTMt MTAtMDQgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZW1vdmUgV2ViQXNzZXJ0aW9ucy5oCkluZGV4OiBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dl YlZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3 Lm1tCShyZXZpc2lvbiAxNTY4MzYpCisrKyBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZp ZXcubW0JKHdvcmtpbmcgY29weSkKQEAgLTU1NDQsMTIgKzU1NDQsMTEgQEAgLSAodm9pZClzZXRD b250aW51b3VzU3BlbGxDaGVja2luZ0VuYWJsZQogICAgIGlmIChjb250aW51b3VzU3BlbGxDaGVj a2luZ0VuYWJsZWQgIT0gZmxhZykgewogICAgICAgICBjb250aW51b3VzU3BlbGxDaGVja2luZ0Vu YWJsZWQgPSBmbGFnOwogICAgICAgICBbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJkVXNlckRlZmF1 bHRzXSBzZXRCb29sOmNvbnRpbnVvdXNTcGVsbENoZWNraW5nRW5hYmxlZCBmb3JLZXk6V2ViQ29u dGludW91c1NwZWxsQ2hlY2tpbmdFbmFibGVkXTsKLSAgICB9Ci0gICAgCi0gICAgaWYgKFtzZWxm IGlzQ29udGludW91c1NwZWxsQ2hlY2tpbmdFbmFibGVkXSkgewotICAgICAgICBbW3NlbGYgY2xh c3NdIF9wcmVmbGlnaHRTcGVsbENoZWNrZXJdOwotICAgIH0gZWxzZSB7Ci0gICAgICAgIFtbc2Vs ZiBtYWluRnJhbWVdIF91bm1hcmtBbGxNaXNzcGVsbGluZ3NdOworCisgICAgICAgIGlmIChbc2Vs ZiBpc0NvbnRpbnVvdXNTcGVsbENoZWNraW5nRW5hYmxlZF0pCisgICAgICAgICAgICBbW3NlbGYg Y2xhc3NdIF9wcmVmbGlnaHRTcGVsbENoZWNrZXJdOworICAgICAgICBlbHNlCisgICAgICAgICAg ICBbW3NlbGYgbWFpbkZyYW1lXSBfdW5tYXJrQWxsTWlzc3BlbGxpbmdzXTsKICAgICB9CiB9CiAK