122325 2013-10-04 07:18:00 -0700 Remove WTF smart pointers 'const_pointer_cast' 2013-10-04 17:24:51 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mikhail.pozdnyakov mikhail.pozdnyakov andersca commit-queue darin kling oldest_to_newest 936188 0 mikhail.pozdnyakov 2013-10-04 07:18:00 -0700 WTF smart pointers 'const_pointer_cast' functions are not used by anyone. Another reason is that const_pointer_cast functions are implemented wrongly (try to cast to a different pointer type). 936191 1 213363 mikhail.pozdnyakov 2013-10-04 07:22:08 -0700 Created attachment 213363 patch 936432 2 213363 darin 2013-10-04 17:01:14 -0700 Comment on attachment 213363 patch Seems OK. People aren’t using RefPtr<const X> anyway, and PassOwnPtr is on the way out. 936445 3 213363 commit-queue 2013-10-04 17:24:49 -0700 Comment on attachment 213363 patch Clearing flags on attachment: 213363 Committed r156931: <http://trac.webkit.org/changeset/156931> 936446 4 commit-queue 2013-10-04 17:24:51 -0700 All reviewed patches have been landed. Closing bug. 213363 2013-10-04 07:22:08 -0700 2013-10-04 17:24:48 -0700 patch bug122325 text/plain 3046 mikhail.pozdnyakov Y29tbWl0IDU4YTcwMDI4YThiOTlmOTc3NjVkNTMyYTdhNjQ0MmNiNzJhY2ViZjcKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg RnJpIE9jdCA0IDE3OjIxOjAwIDIwMTMgKzAzMDAKCiAgICBidWcxMjIzMjUKCmRpZmYgLS1naXQg YS9Tb3VyY2UvV1RGL0NoYW5nZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDA4MThi MWQuLmIxNGU0ZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTMtMTAtMDQgIE1pa2hhaWwgUG96 ZG55YWtvdiAgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CisKKyAgICAgICAgUmVtb3Zl IFdURiBzbWFydCBwb2ludGVycyAnY29uc3RfcG9pbnRlcl9jYXN0JworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIyMzI1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlZCBXVEYgc21hcnQgcG9pbnRl cnMgJ2NvbnN0X3BvaW50ZXJfY2FzdCcgZnVuY3Rpb25zIGFzOgorICAgICAgICAtIHRoZXkgd2Vy ZSBub3QgdXNlZAorICAgICAgICAtIHRoZWlyIGltcGxlbWVudGF0aW9uIHdhcyB3cm9uZyBhcyB0 aGV5IHRyaWVkIHRvIGNhc3QgdG8gYSBkaWZmZXJlbnQgcG9pbnRlciB0eXBlCisKKyAgICAgICAg KiB3dGYvUGFzc093blB0ci5oOgorICAgICAgICAqIHd0Zi9QYXNzUmVmUHRyLmg6CisgICAgICAg ICogd3RmL1JlZlB0ci5oOgorCiAyMDEzLTEwLTAyICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1A YXBwbGUuY29tPgogCiAgICAgICAgIFtXaW5dIFVwZGF0ZSBzb2x1dGlvbnMgYW5kIHByb2plY3Rz IHRvIHN1cHBvcnQgNjQtYml0IGJ1aWxkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvUGFz c093blB0ci5oIGIvU291cmNlL1dURi93dGYvUGFzc093blB0ci5oCmluZGV4IDc0MDJhOWQuLjU5 NWUyNWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1Bhc3NPd25QdHIuaAorKysgYi9Tb3Vy Y2UvV1RGL3d0Zi9QYXNzT3duUHRyLmgKQEAgLTE1NiwxMSArMTU2LDYgQEAgbmFtZXNwYWNlIFdU RiB7CiAgICAgICAgIHJldHVybiBhZG9wdFB0cihzdGF0aWNfY2FzdDxUKj4ocC5sZWFrUHRyKCkp KTsKICAgICB9CiAKLSAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBULCB0eXBlbmFtZSBVPiBpbmxpbmUg UGFzc093blB0cjxUPiBjb25zdF9wb2ludGVyX2Nhc3QoY29uc3QgUGFzc093blB0cjxVPiYgcCkg Ci0gICAgewotICAgICAgICByZXR1cm4gYWRvcHRQdHIoY29uc3RfY2FzdDxUKj4ocC5sZWFrUHRy KCkpKTsKLSAgICB9Ci0KICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBpbmxpbmUgVCogZ2V0UHRy KGNvbnN0IFBhc3NPd25QdHI8VD4mIHApCiAgICAgewogICAgICAgICByZXR1cm4gcC5nZXQoKTsK QEAgLTE3MCw3ICsxNjUsNiBAQCBuYW1lc3BhY2UgV1RGIHsKIAogdXNpbmcgV1RGOjpQYXNzT3du UHRyOwogdXNpbmcgV1RGOjphZG9wdFB0cjsKLXVzaW5nIFdURjo6Y29uc3RfcG9pbnRlcl9jYXN0 OwogdXNpbmcgV1RGOjpzdGF0aWNfcG9pbnRlcl9jYXN0OwogCiAjZW5kaWYgLy8gV1RGX1Bhc3NP d25QdHJfaApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvUGFzc1JlZlB0ci5oIGIvU291cmNl L1dURi93dGYvUGFzc1JlZlB0ci5oCmluZGV4IDFjMjBhNWUuLjg3MjllNzMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XVEYvd3RmL1Bhc3NSZWZQdHIuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9QYXNzUmVm UHRyLmgKQEAgLTE1NywxMSArMTU3LDYgQEAgbmFtZXNwYWNlIFdURiB7CiAgICAgICAgIHJldHVy biBhZG9wdFJlZihzdGF0aWNfY2FzdDxUKj4ocC5sZWFrUmVmKCkpKTsgCiAgICAgfQogCi0gICAg dGVtcGxhdGU8dHlwZW5hbWUgVCwgdHlwZW5hbWUgVT4gaW5saW5lIFBhc3NSZWZQdHI8VD4gY29u c3RfcG9pbnRlcl9jYXN0KGNvbnN0IFBhc3NSZWZQdHI8VT4mIHApIAotICAgIHsgCi0gICAgICAg IHJldHVybiBhZG9wdFJlZihjb25zdF9jYXN0PFQqPihwLmxlYWtSZWYoKSkpOyAKLSAgICB9Ci0K ICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBpbmxpbmUgVCogZ2V0UHRyKGNvbnN0IFBhc3NSZWZQ dHI8VD4mIHApCiAgICAgewogICAgICAgICByZXR1cm4gcC5nZXQoKTsKQEAgLTE3Miw2ICsxNjcs NSBAQCBuYW1lc3BhY2UgV1RGIHsKIHVzaW5nIFdURjo6UGFzc1JlZlB0cjsKIHVzaW5nIFdURjo6 YWRvcHRSZWY7CiB1c2luZyBXVEY6OnN0YXRpY19wb2ludGVyX2Nhc3Q7Ci11c2luZyBXVEY6OmNv bnN0X3BvaW50ZXJfY2FzdDsKIAogI2VuZGlmIC8vIFdURl9QYXNzUmVmUHRyX2gKZGlmZiAtLWdp dCBhL1NvdXJjZS9XVEYvd3RmL1JlZlB0ci5oIGIvU291cmNlL1dURi93dGYvUmVmUHRyLmgKaW5k ZXggYWUxYTNmYS4uNGNkYjY4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvUmVmUHRyLmgK KysrIGIvU291cmNlL1dURi93dGYvUmVmUHRyLmgKQEAgLTIwMCwxMSArMjAwLDYgQEAgbmFtZXNw YWNlIFdURiB7CiAgICAgICAgIHJldHVybiBSZWZQdHI8VD4oc3RhdGljX2Nhc3Q8VCo+KHAuZ2V0 KCkpKTsgCiAgICAgfQogCi0gICAgdGVtcGxhdGU8dHlwZW5hbWUgVCwgdHlwZW5hbWUgVT4gaW5s aW5lIFJlZlB0cjxUPiBjb25zdF9wb2ludGVyX2Nhc3QoY29uc3QgUmVmUHRyPFU+JiBwKQotICAg IHsgCi0gICAgICAgIHJldHVybiBSZWZQdHI8VD4oY29uc3RfY2FzdDxUKj4ocC5nZXQoKSkpOyAK LSAgICB9Ci0KICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBpbmxpbmUgVCogZ2V0UHRyKGNvbnN0 IFJlZlB0cjxUPiYgcCkKICAgICB7CiAgICAgICAgIHJldHVybiBwLmdldCgpOwpAQCAtMjE0LDYg KzIwOSw1IEBAIG5hbWVzcGFjZSBXVEYgewogCiB1c2luZyBXVEY6OlJlZlB0cjsKIHVzaW5nIFdU Rjo6c3RhdGljX3BvaW50ZXJfY2FzdDsKLXVzaW5nIFdURjo6Y29uc3RfcG9pbnRlcl9jYXN0Owog CiAjZW5kaWYgLy8gV1RGX1JlZlB0cl9oCg==