122303 2013-10-03 15:11:41 -0700 Add a verbose flag to binding tests 2014-06-02 23:52:04 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P4 Enhancement --- 0 matthew_hanson webkit-unassigned ap commit-queue dpranke glenn lforschler ossy webkit-bug-importer oldest_to_newest 936001 0 matthew_hanson 2013-10-03 15:11:41 -0700 While investigating Bug 122017, I found that positive BindingTests results are unconditionally printed to stdout. It is often desirable to suppress the output of these test cases since they are run often and expected to fail rarely. The BindingTests class is defined in Tools/Scripts/webkitpy/bindings/main.py. 936002 1 webkit-bug-importer 2013-10-03 15:12:04 -0700 <rdar://problem/15146102> 936007 2 213305 matthew_hanson 2013-10-03 15:36:33 -0700 Created attachment 213305 v1 Patch for 122303 Added a verbose keyword argument to the BindingsTests constructor. Verbose mode, which is on by default, prints positive results to stdout as before. When the verbose flag is set to false, positive results are not printed at all. 941153 3 213305 galpeter 2013-10-18 05:13:41 -0700 Comment on attachment 213305 v1 Patch for 122303 View in context: https://bugs.webkit.org/attachment.cgi?id=213305&action=review The 'run-bindings-test' script should be adapted for this change. Without that there is no way to disable it from command line. > Tools/Scripts/webkitpy/bindings/main.py:117 > + if self.verbose is True: A simple 'if self.verbose' is enough. Also 'is' is for identity checking see http://docs.python.org/2/library/operator.html#operator.is_ 957317 4 webkit-bug-importer 2013-12-06 11:25:59 -0800 <rdar://problem/15605926 > 960591 5 webkit-bug-importer 2013-12-17 11:24:20 -0800 <rdar://problem/15680835 > 977168 6 213305 kling 2014-02-05 17:38:02 -0800 Comment on attachment 213305 v1 Patch for 122303 r-, please fix the problems pointed out by Peter Gal. 1012413 7 232246 mtiborinf 2014-05-29 07:08:46 -0700 Created attachment 232246 Patch v2 I had finished Matthew's patch. The following changes where made: - Added --no-verbose option to the run-bindigs-test. - Changed "if self.verbose is True" to "self.verbose" as Peter Gal wanted. 1012433 8 232246 galpeter 2014-05-29 09:02:15 -0700 Comment on attachment 232246 Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=232246&action=review > Tools/Scripts/run-bindings-tests:47 > + if "--no-verbose" in argv: > + verbose = False > + else: > + verbose = True We should make this a bit simpler a one-liner, like in the line 42. Eg.: verbose = not "--no-verbose" in argv > Tools/Scripts/run-bindings-tests:52 > + 'GObject', I don't see any point of this change, why is this needed? > Tools/Scripts/webkitpy/bindings/main.py:117 > else: > - print 'PASS: (%s) %s' % (generator, output_file) > + if self.verbose: Looking at this know I realize we can merge the 'else' and 'if self.verbose' into an 'elsif self.verbose' :) 1012435 9 232246 ossy 2014-05-29 09:03:55 -0700 Comment on attachment 232246 Patch v2 r-, please fix the problems pointed out by Péter Gál. 1012599 10 232292 mtiborinf 2014-05-30 05:13:50 -0700 Created attachment 232292 Patch v3 All has been fixed, that Peter mentioned :) 1012600 11 232292 ossy 2014-05-30 05:47:09 -0700 Comment on attachment 232292 Patch v3 View in context: https://bugs.webkit.org/attachment.cgi?id=232292&action=review > Tools/Scripts/run-bindings-tests:43 > + This extra newline is unnecessary. > Tools/Scripts/webkitpy/bindings/main.py:117 > + elif self.verbose: > + print 'PASS: (%s) %s' % (generator, output_file) Please remove this extra indentation. 1012927 12 232375 mtiborinf 2014-06-02 04:14:50 -0700 Created attachment 232375 Patch v4 The newline and the extra indentation has been removed. 1013057 13 232375 commit-queue 2014-06-02 23:52:00 -0700 Comment on attachment 232375 Patch v4 Clearing flags on attachment: 232375 Committed r169558: <http://trac.webkit.org/changeset/169558> 1013058 14 commit-queue 2014-06-02 23:52:04 -0700 All reviewed patches have been landed. Closing bug. 213305 2013-10-03 15:36:33 -0700 2014-05-30 05:47:26 -0700 v1 Patch for 122303 0001-Added-a-verbose-keyword-argument-to-the-BindingsTest.patch text/plain 2642 matthew_hanson RnJvbSA1NWMxMTViODI2MmJkM2JiOGI4MTBiMjllNWI2YjU4MmJiZTBhODNmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXR0aGV3IEhhbnNvbiA8bWF0dGhld19oYW5zb25AYXBwbGUu Y29tPgpEYXRlOiBUaHUsIDMgT2N0IDIwMTMgMTU6MzE6NDAgLTA3MDAKU3ViamVjdDogW1BBVENI XSBBZGRlZCBhIHZlcmJvc2Uga2V5d29yZCBhcmd1bWVudCB0byB0aGUgQmluZGluZ3NUZXN0cwog Y29uc3RydWN0b3IuIFZlcmJvc2UgbW9kZSwgd2hpY2ggaXMgb24gYnkgZGVmYXVsdCwgcHJpbnRz IHBvc2l0aXZlIHJlc3VsdHMgdG8KIHN0ZG91dCBhcyBiZWZvcmUuIFdoZW4gdGhlIHZlcmJvc2Ug ZmxhZyBpcyBzZXQgdG8gZmFsc2UsIHBvc2l0aXZlIHJlc3VsdHMgYXJlCiBub3QgcHJpbnRlZCBh dCBhbGwuCgotLS0KIFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICB8IDE1 ICsrKysrKysrKysrKysrKwogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9iaW5kaW5ncy9tYWluLnB5 IHwgIDYgKysrKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDE5IGluc2VydGlvbnMoKyksIDIgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmlu ZGV4IGJmOTVkNDcuLjViYTI0MjEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMy0xMC0wMyAgTWF0dGhldyBIYW5z b24gIDxtYXR0aGV3X2hhbnNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGEgdmVyYm9zZSBm bGFnIHRvIGJpbmRpbmcgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyMjMwMworCisgICAgICAgIEFkZGVkIGEgdmVyYm9zZSBrZXl3b3JkIGFy Z3VtZW50IHRvIHRoZSBCaW5kaW5nc1Rlc3RzIGNvbnN0cnVjdG9yLgorICAgICAgICBWZXJib3Nl IG1vZGUsIHdoaWNoIGlzIG9uIGJ5IGRlZmF1bHQsIHByaW50cyBwb3NpdGl2ZSByZXN1bHRzIHRv IHN0ZG91dCBhcyBiZWZvcmUuCisgICAgICAgIFdoZW4gdGhlIHZlcmJvc2UgZmxhZyBpcyBzZXQg dG8gZmFsc2UsIHBvc2l0aXZlIHJlc3VsdHMgYXJlIG5vdCBwcmludGVkIGF0IGFsbC4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvYmluZGluZ3MvbWFpbi5weToKKyAgICAgICAgKEJpbmRpbmdzVGVzdHMuX19pbml0X18p OgorICAgICAgICAoQmluZGluZ3NUZXN0cy5kZXRlY3RfY2hhbmdlcyk6CisKIDIwMTMtMTAtMDMg IEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IExlYWtz Vmlld2VyIHRvIGxvYWQgbGVha3MgcmVzdWx0cyBmcm9tIE1vdW50YWluTGlvbiwgbm90IExpb24u CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2JpbmRpbmdzL21haW4ucHkgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2JpbmRpbmdzL21haW4ucHkKaW5kZXggOWM4MmI5YS4uMzY1 MjI3NyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9iaW5kaW5ncy9tYWluLnB5 CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvYmluZGluZ3MvbWFpbi5weQpAQCAtMzQsMTAg KzM0LDExIEBAIGZyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5leGVjdXRpdmUgaW1wb3J0IFNj cmlwdEVycm9yCiAKIGNsYXNzIEJpbmRpbmdzVGVzdHM6CiAKLSAgICBkZWYgX19pbml0X18oc2Vs ZiwgcmVzZXRfcmVzdWx0cywgZ2VuZXJhdG9ycywgZXhlY3V0aXZlKToKKyAgICBkZWYgX19pbml0 X18oc2VsZiwgcmVzZXRfcmVzdWx0cywgZ2VuZXJhdG9ycywgZXhlY3V0aXZlLCB2ZXJib3NlPVRy dWUpOgogICAgICAgICBzZWxmLnJlc2V0X3Jlc3VsdHMgPSByZXNldF9yZXN1bHRzCiAgICAgICAg IHNlbGYuZ2VuZXJhdG9ycyA9IGdlbmVyYXRvcnMKICAgICAgICAgc2VsZi5leGVjdXRpdmUgPSBl eGVjdXRpdmUKKyAgICAgICAgc2VsZi52ZXJib3NlID0gdmVyYm9zZQogCiAgICAgZGVmIGdlbmVy YXRlX2Zyb21faWRsKHNlbGYsIGdlbmVyYXRvciwgaWRsX2ZpbGUsIG91dHB1dF9kaXJlY3Rvcnks IHN1cHBsZW1lbnRhbF9kZXBlbmRlbmN5X2ZpbGUpOgogICAgICAgICBjbWQgPSBbJ3BlcmwnLCAn LXcnLApAQCAtMTEzLDcgKzExNCw4IEBAIGNsYXNzIEJpbmRpbmdzVGVzdHM6CiAgICAgICAgICAg ICAgICAgcHJpbnQgb3V0cHV0CiAgICAgICAgICAgICAgICAgY2hhbmdlc19mb3VuZCA9IFRydWUK ICAgICAgICAgICAgIGVsc2U6Ci0gICAgICAgICAgICAgICAgcHJpbnQgJ1BBU1M6ICglcykgJXMn ICUgKGdlbmVyYXRvciwgb3V0cHV0X2ZpbGUpCisgICAgICAgICAgICAgICAgaWYgc2VsZi52ZXJi b3NlIGlzIFRydWU6CisgICAgICAgICAgICAgICAgICAgIHByaW50ICdQQVNTOiAoJXMpICVzJyAl IChnZW5lcmF0b3IsIG91dHB1dF9maWxlKQogICAgICAgICByZXR1cm4gY2hhbmdlc19mb3VuZAog CiAgICAgZGVmIHJ1bl90ZXN0cyhzZWxmLCBnZW5lcmF0b3IsIGlucHV0X2RpcmVjdG9yeSwgcmVm ZXJlbmNlX2RpcmVjdG9yeSwgc3VwcGxlbWVudGFsX2RlcGVuZGVuY3lfZmlsZSk6Ci0tIAoxLjgu My40IChBcHBsZSBHaXQtNDcpCgo= 232246 2014-05-29 07:08:46 -0700 2014-05-30 05:13:50 -0700 Patch v2 verbose.patch text/plain 0 mtiborinf 232292 2014-05-30 05:13:50 -0700 2014-06-02 04:14:50 -0700 Patch v3 verbose.patch text/plain 3006 mtiborinf ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2Mzhj ODhiLi40OTNiYWIyIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTQtMDUtMzAgIFRpYm9yIE1lc3phcm9zICA8dG1l c3phcm9zLnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CisKKyAgICAgICAgQWRkIGEgdmVy Ym9zZSBmbGFnIHRvIGJpbmRpbmcgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEyMjMwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggd2lsbDoKKyAgICAgICAgLSBBZGQgYSB2ZXJi b3NlIGtleXdvcmQgYXJndW1lbnQgdG8gdGhlIEJpbmRpbmdzVGVzdHMgY29uc3RydWN0b3IsCisg ICAgICAgIC0gQWRkIC0tbm8tdmVyYm9zZSBvcHRpb24gdG8gdGhlIHJ1bi1iaW5kaWdzLXRlc3Qu CisgICAgICAgIFZlcmJvc2UgbW9kZSwgd2hpY2ggaXMgb24gYnkgZGVmYXVsdCwgcHJpbnRzIHBv c2l0aXZlIHJlc3VsdHMgdG8gc3Rkb3V0IGFzIGJlZm9yZS4KKyAgICAgICAgV2hlbiB0aGUgLS1u by12ZXJib3NlIG9wdGlvbiBhZGRlZCB0byBydW4tYmluZGluZ3MtdGVzdHMsIHBvc2l0aXZlIHJl c3VsdHMgYXJlIG5vdCBwcmludGVkIGF0IGFsbC4KKworICAgICAgICBPcmlnaW5hbCBwYXRjaCBm cm9tIE1hdHRoZXcgSGFuc29uIDxtYXR0aGV3X2hhbnNvbkBhcHBsZS5jb20+IAorICAgICAgICAK KyAgICAgICAgKiBTY3JpcHRzL3J1bi1iaW5kaW5ncy10ZXN0czoKKyAgICAgICAgKG1haW4pOgor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvYmluZGluZ3MvbWFpbi5weToKKyAgICAgICAgKEJp bmRpbmdzVGVzdHMuX19pbml0X18pOgorICAgICAgICAoQmluZGluZ3NUZXN0cy5kZXRlY3RfY2hh bmdlcyk6CisKIDIwMTQtMDUtMzAgIEphcmVrIEN6ZWthbHNraSAgPGphcmVrY3pla0Bwb2N6dGEu b25ldC5wbD4KIAogICAgICAgICBbQVRLXSBBZGRlZCBuZXcgYWNjZXNzaWJpbGl0eSBzaWduYWw6 IHRleHQtY2FyZXQtbW92ZWQuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3J1bi1iaW5kaW5n cy10ZXN0cyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWJpbmRpbmdzLXRlc3RzCmluZGV4IGU3MDgzOWQu LmRiNjY4MjAgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcnVuLWJpbmRpbmdzLXRlc3RzCisr KyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWJpbmRpbmdzLXRlc3RzCkBAIC00MCw2ICs0MCw4IEBAIGRl ZiBtYWluKGFyZ3YpOgogCiAgICAgIiIiCiAgICAgcmVzZXRfcmVzdWx0cyA9ICItLXJlc2V0LXJl c3VsdHMiIGluIGFyZ3YKKyAgICAKKyAgICB2ZXJib3NlID0gbm90ICItLW5vLXZlcmJvc2UiIGlu IGFyZ3YKIAogICAgIGdlbmVyYXRvcnMgPSBbCiAgICAgICAgICdKUycsCkBAIC00OSw3ICs1MSw3 IEBAIGRlZiBtYWluKGFyZ3YpOgogCiAgICAgZnJvbSB3ZWJraXRweS5iaW5kaW5ncy5tYWluIGlt cG9ydCBCaW5kaW5nc1Rlc3RzCiAKLSAgICByZXR1cm4gQmluZGluZ3NUZXN0cyhyZXNldF9yZXN1 bHRzLCBnZW5lcmF0b3JzLCBleGVjdXRpdmUuRXhlY3V0aXZlKCkpLm1haW4oKQorICAgIHJldHVy biBCaW5kaW5nc1Rlc3RzKHJlc2V0X3Jlc3VsdHMsIGdlbmVyYXRvcnMsIGV4ZWN1dGl2ZS5FeGVj dXRpdmUoKSwgdmVyYm9zZSkubWFpbigpCiAKIAogaWYgX19uYW1lX18gPT0gJ19fbWFpbl9fJzoK ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvYmluZGluZ3MvbWFpbi5weSBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvYmluZGluZ3MvbWFpbi5weQppbmRleCA5NGI4MjVjLi4zNGY4 ZjQwIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2JpbmRpbmdzL21haW4ucHkK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9iaW5kaW5ncy9tYWluLnB5CkBAIC0zNCwxMCAr MzQsMTEgQEAgZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVtLmV4ZWN1dGl2ZSBpbXBvcnQgU2Ny aXB0RXJyb3IKIAogY2xhc3MgQmluZGluZ3NUZXN0czoKIAotICAgIGRlZiBfX2luaXRfXyhzZWxm LCByZXNldF9yZXN1bHRzLCBnZW5lcmF0b3JzLCBleGVjdXRpdmUpOgorICAgIGRlZiBfX2luaXRf XyhzZWxmLCByZXNldF9yZXN1bHRzLCBnZW5lcmF0b3JzLCBleGVjdXRpdmUsIHZlcmJvc2UpOgog ICAgICAgICBzZWxmLnJlc2V0X3Jlc3VsdHMgPSByZXNldF9yZXN1bHRzCiAgICAgICAgIHNlbGYu Z2VuZXJhdG9ycyA9IGdlbmVyYXRvcnMKICAgICAgICAgc2VsZi5leGVjdXRpdmUgPSBleGVjdXRp dmUKKyAgICAgICAgc2VsZi52ZXJib3NlID0gdmVyYm9zZQogCiAgICAgZGVmIGdlbmVyYXRlX2Zy b21faWRsKHNlbGYsIGdlbmVyYXRvciwgaWRsX2ZpbGUsIG91dHB1dF9kaXJlY3RvcnksIHN1cHBs ZW1lbnRhbF9kZXBlbmRlbmN5X2ZpbGUpOgogICAgICAgICBjbWQgPSBbJ3BlcmwnLCAnLXcnLApA QCAtMTEyLDggKzExMyw4IEBAIGNsYXNzIEJpbmRpbmdzVGVzdHM6CiAgICAgICAgICAgICAgICAg cHJpbnQgJ0ZBSUw6ICglcykgJXMnICUgKGdlbmVyYXRvciwgb3V0cHV0X2ZpbGUpCiAgICAgICAg ICAgICAgICAgcHJpbnQgb3V0cHV0CiAgICAgICAgICAgICAgICAgY2hhbmdlc19mb3VuZCA9IFRy dWUKLSAgICAgICAgICAgIGVsc2U6Ci0gICAgICAgICAgICAgICAgcHJpbnQgJ1BBU1M6ICglcykg JXMnICUgKGdlbmVyYXRvciwgb3V0cHV0X2ZpbGUpCisgICAgICAgICAgICBlbGlmIHNlbGYudmVy Ym9zZToKKyAgICAgICAgICAgICAgICAgICAgcHJpbnQgJ1BBU1M6ICglcykgJXMnICUgKGdlbmVy YXRvciwgb3V0cHV0X2ZpbGUpCiAgICAgICAgIHJldHVybiBjaGFuZ2VzX2ZvdW5kCiAKICAgICBk ZWYgcnVuX3Rlc3RzKHNlbGYsIGdlbmVyYXRvciwgaW5wdXRfZGlyZWN0b3J5LCByZWZlcmVuY2Vf ZGlyZWN0b3J5LCBzdXBwbGVtZW50YWxfZGVwZW5kZW5jeV9maWxlKToK 232375 2014-06-02 04:14:50 -0700 2014-06-02 23:51:59 -0700 Patch v4 verbose_V2.patch text/plain 2808 mtiborinf ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhZDE2 YWE5Li4zMzc0YjJkIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTQtMDYtMDIgIFRpYm9yIE1lc3phcm9zICA8dG1l c3phcm9zLnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CisKKyAgICAgICAgQWRkIGEgdmVy Ym9zZSBmbGFnIHRvIGJpbmRpbmcgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEyMjMwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggd2lsbDoKKyAgICAgICAgLSBBZGQgYSB2ZXJi b3NlIGtleXdvcmQgYXJndW1lbnQgdG8gdGhlIEJpbmRpbmdzVGVzdHMgY29uc3RydWN0b3IsCisg ICAgICAgIC0gQWRkIC0tbm8tdmVyYm9zZSBvcHRpb24gdG8gdGhlIHJ1bi1iaW5kaWdzLXRlc3Qu CisgICAgICAgIFZlcmJvc2UgbW9kZSwgd2hpY2ggaXMgb24gYnkgZGVmYXVsdCwgcHJpbnRzIHBv c2l0aXZlIHJlc3VsdHMgdG8gc3Rkb3V0IGFzIGJlZm9yZS4KKyAgICAgICAgV2hlbiB0aGUgLS1u by12ZXJib3NlIG9wdGlvbiBhZGRlZCB0byBydW4tYmluZGluZ3MtdGVzdHMsIHBvc2l0aXZlIHJl c3VsdHMgYXJlIG5vdCBwcmludGVkIGF0IGFsbC4KKworICAgICAgICBPcmlnaW5hbCBwYXRjaCBm cm9tIE1hdHRoZXcgSGFuc29uIDxtYXR0aGV3X2hhbnNvbkBhcHBsZS5jb20+CisKKyAgICAgICAg KiBTY3JpcHRzL3J1bi1iaW5kaW5ncy10ZXN0czoKKyAgICAgICAgKG1haW4pOgorICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvYmluZGluZ3MvbWFpbi5weToKKyAgICAgICAgKEJpbmRpbmdzVGVz dHMuX19pbml0X18pOgorICAgICAgICAoQmluZGluZ3NUZXN0cy5kZXRlY3RfY2hhbmdlcyk6CisK IDIwMTQtMDUtMzEgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFZp ZXdwb3J0IHBlcmNlbnRhZ2UgdGVzdHMgdGhhdCByZXNpemUgdGhlIHZpZXdwb3J0IGFyZSBmbGFr eQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9ydW4tYmluZGluZ3MtdGVzdHMgYi9Ub29scy9T Y3JpcHRzL3J1bi1iaW5kaW5ncy10ZXN0cwppbmRleCBlNzA4MzlkLi5kMzE2ZmUyIDEwMDc1NQot LS0gYS9Ub29scy9TY3JpcHRzL3J1bi1iaW5kaW5ncy10ZXN0cworKysgYi9Ub29scy9TY3JpcHRz L3J1bi1iaW5kaW5ncy10ZXN0cwpAQCAtNDAsNiArNDAsNyBAQCBkZWYgbWFpbihhcmd2KToKIAog ICAgICIiIgogICAgIHJlc2V0X3Jlc3VsdHMgPSAiLS1yZXNldC1yZXN1bHRzIiBpbiBhcmd2Cisg ICAgdmVyYm9zZSA9IG5vdCAiLS1uby12ZXJib3NlIiBpbiBhcmd2CiAKICAgICBnZW5lcmF0b3Jz ID0gWwogICAgICAgICAnSlMnLApAQCAtNDksNyArNTAsNyBAQCBkZWYgbWFpbihhcmd2KToKIAog ICAgIGZyb20gd2Via2l0cHkuYmluZGluZ3MubWFpbiBpbXBvcnQgQmluZGluZ3NUZXN0cwogCi0g ICAgcmV0dXJuIEJpbmRpbmdzVGVzdHMocmVzZXRfcmVzdWx0cywgZ2VuZXJhdG9ycywgZXhlY3V0 aXZlLkV4ZWN1dGl2ZSgpKS5tYWluKCkKKyAgICByZXR1cm4gQmluZGluZ3NUZXN0cyhyZXNldF9y ZXN1bHRzLCBnZW5lcmF0b3JzLCBleGVjdXRpdmUuRXhlY3V0aXZlKCksIHZlcmJvc2UpLm1haW4o KQogCiAKIGlmIF9fbmFtZV9fID09ICdfX21haW5fXyc6CmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2JpbmRpbmdzL21haW4ucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2Jp bmRpbmdzL21haW4ucHkKaW5kZXggOTRiODI1Yy4uYjRhOGJjYiAxMDA2NDQKLS0tIGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9iaW5kaW5ncy9tYWluLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvYmluZGluZ3MvbWFpbi5weQpAQCAtMzQsMTAgKzM0LDExIEBAIGZyb20gd2Via2l0cHku Y29tbW9uLnN5c3RlbS5leGVjdXRpdmUgaW1wb3J0IFNjcmlwdEVycm9yCiAKIGNsYXNzIEJpbmRp bmdzVGVzdHM6CiAKLSAgICBkZWYgX19pbml0X18oc2VsZiwgcmVzZXRfcmVzdWx0cywgZ2VuZXJh dG9ycywgZXhlY3V0aXZlKToKKyAgICBkZWYgX19pbml0X18oc2VsZiwgcmVzZXRfcmVzdWx0cywg Z2VuZXJhdG9ycywgZXhlY3V0aXZlLCB2ZXJib3NlKToKICAgICAgICAgc2VsZi5yZXNldF9yZXN1 bHRzID0gcmVzZXRfcmVzdWx0cwogICAgICAgICBzZWxmLmdlbmVyYXRvcnMgPSBnZW5lcmF0b3Jz CiAgICAgICAgIHNlbGYuZXhlY3V0aXZlID0gZXhlY3V0aXZlCisgICAgICAgIHNlbGYudmVyYm9z ZSA9IHZlcmJvc2UKIAogICAgIGRlZiBnZW5lcmF0ZV9mcm9tX2lkbChzZWxmLCBnZW5lcmF0b3Is IGlkbF9maWxlLCBvdXRwdXRfZGlyZWN0b3J5LCBzdXBwbGVtZW50YWxfZGVwZW5kZW5jeV9maWxl KToKICAgICAgICAgY21kID0gWydwZXJsJywgJy13JywKQEAgLTExMiw3ICsxMTMsNyBAQCBjbGFz cyBCaW5kaW5nc1Rlc3RzOgogICAgICAgICAgICAgICAgIHByaW50ICdGQUlMOiAoJXMpICVzJyAl IChnZW5lcmF0b3IsIG91dHB1dF9maWxlKQogICAgICAgICAgICAgICAgIHByaW50IG91dHB1dAog ICAgICAgICAgICAgICAgIGNoYW5nZXNfZm91bmQgPSBUcnVlCi0gICAgICAgICAgICBlbHNlOgor ICAgICAgICAgICAgZWxpZiBzZWxmLnZlcmJvc2U6CiAgICAgICAgICAgICAgICAgcHJpbnQgJ1BB U1M6ICglcykgJXMnICUgKGdlbmVyYXRvciwgb3V0cHV0X2ZpbGUpCiAgICAgICAgIHJldHVybiBj aGFuZ2VzX2ZvdW5kCiAK