<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>122287</bug_id>
          
          <creation_ts>2013-10-03 11:16:35 -0700</creation_ts>
          <short_desc>Transition JITStubs functions to CCallHelper functions</short_desc>
          <delta_ts>2013-10-18 14:50:09 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>122288</dependson>
    
    <dependson>122289</dependson>
    
    <dependson>122306</dependson>
    
    <dependson>122453</dependson>
    
    <dependson>122460</dependson>
    
    <dependson>122563</dependson>
    
    <dependson>122617</dependson>
    
    <dependson>122645</dependson>
    
    <dependson>122757</dependson>
    
    <dependson>122758</dependson>
    
    <dependson>122903</dependson>
    
    <dependson>122925</dependson>
          <blocked>121756</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Saboff">msaboff</reporter>
          <assigned_to name="Michael Saboff">msaboff</assigned_to>
          <cc>fpizlo</cc>
    
    <cc>ggaren</cc>
    
    <cc>mark.lam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>935870</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Saboff">msaboff</who>
    <bug_when>2013-10-03 11:16:35 -0700</bug_when>
    <thetext>As part of our rolling over to C stack, we need to eliminate JITStubCall due to its reliance on JITStackFrame.  The JITStubs should be eliminated or converted to functions called using CCallHelpers.

-- Unused --
cti_op_is_boolean
cti_op_is_number
cti_op_is_string
cti_op_is_undefined
cti_op_resolve
cti_op_resolve_base
cti_op_resolve_base_strict_put
cti_op_resolve_with_base
cti_op_resolve_with_this
cti_op_put_to_base
cti_op_end

-- Cached related functions --
cti_op_get_by_id_getter_stub
cti_op_get_by_id
cti_op_get_by_id_array_fail
cti_op_get_by_id_custom_stub
cti_op_get_by_id_generic
cti_op_get_by_id_proto_fail
cti_op_get_by_id_proto_list
cti_op_get_by_id_proto_list_full
cti_op_get_by_id_self_fail
cti_op_get_by_id_string_fail
cti_op_get_by_val
cti_op_get_by_val_generic
cti_op_get_by_val_string
cti_op_put_by_id_transition_realloc
cti_op_put_by_id
cti_op_put_by_id_fail
cti_op_put_by_id_generic
cti_op_put_by_id_direct
cti_op_put_by_id_direct_fail
cti_op_put_by_id_direct_generic
cti_op_put_by_val
cti_op_put_by_val_generic

-- Other functions --
cti_stack_check
cti_op_call_arityCheck
cti_op_construct_arityCheck
cti_op_call_NotJSFunction
cti_op_call_eval
cti_op_construct_NotJSConstruct
cti_op_check_has_instance
cti_op_create_arguments
cti_op_del_by_id
cti_op_instanceof
cti_to_object
cti_op_new_array
cti_op_new_array_with_size
cti_op_new_array_buffer
cti_op_new_func
cti_op_new_func_exp
cti_op_new_object
cti_op_new_regexp
cti_op_push_activation
cti_op_push_name_scope
cti_op_push_with_scope
cti_op_get_pnames
cti_op_eq
cti_op_eq_strings
cti_op_jless
cti_op_jlesseq
cti_op_jgreater
cti_op_jgreatereq
cti_op_jtrue
cti_op_load_varargs
cti_handle_watchdog_timer
cti_has_property
cti_op_debug
cti_op_pop_scope
cti_op_profile_did_call
cti_op_profile_will_call
cti_op_put_by_index
cti_op_put_getter_setter
cti_op_tear_off_activation
cti_op_tear_off_arguments
cti_optimize
cti_op_call_jitCompile
cti_op_construct_jitCompile
cti_op_switch_char
cti_op_switch_imm
cti_op_switch_string
cti_vm_lazyLinkCall
cti_vm_lazyLinkClosureCall
cti_vm_lazyLinkConstruct
cti_op_resolve_scope
cti_op_get_from_scope
cti_op_put_to_scope
cti_vm_handle_exception
cti_vm_throw
cti_op_throw
cti_op_throw_static_error</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>938000</commentid>
    <comment_count>1</comment_count>
    <who name="Michael Saboff">msaboff</who>
    <bug_when>2013-10-09 11:18:05 -0700</bug_when>
    <thetext>Current state.  Remaining stubs to convert:

In progress and tracked with https://bugs.webkit.org/show_bug.cgi?id=122460
cti_op_new_array
cti_op_new_array_with_size
cti_op_new_array_buffer
cti_op_new_func
cti_op_new_func_exp
cti_op_new_object

In progress and tracked with https://bugs.webkit.org/show_bug.cgi?id=122563:
cti_op_eq
cti_op_eq_strings
cti_op_jless
cti_op_jlesseq
cti_op_jgreater
cti_op_jgreatereq
cti_op_jtrue
cti_has_property

-- Cached related functions --
cti_op_get_by_id_getter_stub
cti_op_get_by_id
cti_op_get_by_id_array_fail
cti_op_get_by_id_custom_stub
cti_op_get_by_id_generic
cti_op_get_by_id_proto_fail
cti_op_get_by_id_proto_list
cti_op_get_by_id_proto_list_full
cti_op_get_by_id_self_fail
cti_op_get_by_id_string_fail
cti_op_get_by_val
cti_op_get_by_val_generic
cti_op_get_by_val_string
cti_op_put_by_id_transition_realloc
cti_op_put_by_id
cti_op_put_by_id_fail
cti_op_put_by_id_generic
cti_op_put_by_id_direct
cti_op_put_by_id_direct_fail
cti_op_put_by_id_direct_generic
cti_op_put_by_val
cti_op_put_by_val_generic

-- Other functions --
cti_op_check_has_instance
cti_op_create_arguments
cti_op_del_by_id
cti_op_instanceof
cti_to_object
cti_op_push_activation
cti_op_push_name_scope
cti_op_push_with_scope
cti_op_get_pnames
cti_op_load_varargs
cti_handle_watchdog_timer
cti_op_debug
cti_op_pop_scope
cti_op_profile_did_call
cti_op_profile_will_call
cti_op_put_by_index
cti_op_put_getter_setter
cti_op_tear_off_activation
cti_op_tear_off_arguments
cti_optimize
cti_op_call_jitCompile
cti_op_construct_jitCompile
cti_op_switch_char
cti_op_switch_imm
cti_op_switch_string
cti_vm_lazyLinkCall
cti_vm_lazyLinkClosureCall
cti_vm_lazyLinkConstruct
cti_op_resolve_scope
cti_op_get_from_scope
cti_op_put_to_scope
cti_vm_handle_exception
cti_vm_throw
cti_op_throw
cti_op_throw_static_error</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>938510</commentid>
    <comment_count>2</comment_count>
    <who name="Michael Saboff">msaboff</who>
    <bug_when>2013-10-10 13:10:35 -0700</bug_when>
    <thetext>Transitioning the following - tracked by https://bugs.webkit.org/show_bug.cgi?id=122617
    cti_handle_watchdog_timer
    cti_op_debug
    cti_op_pop_scope
    cti_op_profile_did_call
    cti_op_profile_will_call
    cti_op_put_by_index
    cti_op_put_getter_setter
    cti_op_tear_off_activation
    cti_op_tear_off_arguments
    cti_op_throw_static_error
    cti_optimize</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>938803</commentid>
    <comment_count>3</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2013-10-11 08:29:05 -0700</bug_when>
    <thetext>Working on these next - tracked in https://bugs.webkit.org/show_bug.cgi?id=122645
    cti_op_check_has_instance
    cti_op_create_arguments
    cti_op_del_by_id
    cti_op_instanceof
    cti_to_object
    cti_op_push_activation
    cti_op_push_name_scope
    cti_op_push_with_scope
    cti_op_get_pnames
    cti_op_load_varargs</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>939480</commentid>
    <comment_count>4</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2013-10-14 09:54:37 -0700</bug_when>
    <thetext>https://bugs.webkit.org/show_bug.cgi?id=122757
Transitioning:
    cti_op_switch_char
    cti_op_switch_imm
    cti_op_switch_string
    cti_op_resolve_scope
    cti_op_get_from_scope
    cti_op_put_to_scope</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>939487</commentid>
    <comment_count>5</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2013-10-14 09:59:19 -0700</bug_when>
    <thetext>Michael will handle these in https://bugs.webkit.org/show_bug.cgi?id=122758:
    cti_vm_handle_exception
    cti_vm_throw
    cti_op_throw</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>940576</commentid>
    <comment_count>6</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2013-10-16 16:42:38 -0700</bug_when>
    <thetext>https://bugs.webkit.org/show_bug.cgi?id=122925
Transition:
    cti_op_get_by_id_generic
    cti_op_get_by_val
    cti_op_get_by_val_generic
    cti_op_get_by_val_string</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>941339</commentid>
    <comment_count>7</comment_count>
    <who name="Michael Saboff">msaboff</who>
    <bug_when>2013-10-18 14:50:09 -0700</bug_when>
    <thetext>All stubs have been transitioned.  Closing.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>