122284 2013-10-03 10:20:38 -0700 Move IDBFactoryBackend creation to DatabaseStrategy 2013-10-08 11:44:03 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 beidson beidson alecflett commit-queue jsbell sam oldest_to_newest 935843 0 beidson 2013-10-03 10:20:38 -0700 Move IDBFactoryBackend creation to DatabaseStrategy 935847 1 213274 beidson 2013-10-03 10:23:40 -0700 Created attachment 213274 Patch v1 935854 2 213274 ap 2013-10-03 10:37:08 -0700 Comment on attachment 213274 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=213274&action=review > Source/WebCore/Modules/indexeddb/IDBFactory.h:60 > + // FIXME: getDatabaseNames is no longer a web-facting API, and should be removed from IDBFactory. *web-facing* > Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:221 > + return DatabaseStrategy::createIDBFactoryBackend(); // Use the default for now. I don't think that a "for now" comment helps, it should either be more detailed, or removed. 935866 3 beidson 2013-10-03 10:53:59 -0700 http://trac.webkit.org/changeset/156842 936387 4 sam 2013-10-04 15:07:53 -0700 I don't think a PlatformStrategy is the right approach here, and I think it was the wrong to have a DatabaseStrategy in the first place. IndexDB is not a platform concept, and thus should not be referenced in Platform. I know we have some of these violations already, but we don't need to add more. Instead, I think we should stick with good old client interfaces for these (maybe add a new PageClient). 937608 5 beidson 2013-10-08 11:44:03 -0700 (In reply to comment #4) > I don't think a PlatformStrategy is the right approach here, and I think it was the wrong to have a DatabaseStrategy in the first place. IndexDB is not a platform concept, and thus should not be referenced in Platform. I know we have some of these violations already, but we don't need to add more. The backend for the IndexDB is a platform concept. Every time this comes up I ask for an actual rule to decide whether we use platform strategies or a client, and there's never really been one. > Instead, I think we should stick with good old client interfaces for these (maybe add a new PageClient). Bad name, considering a mid-term goal of phasing it out. Also, does making it a PageClient concept make sense when IDB is accessible from a (possibly shared) worker? I'll revisit this once we have the right answers, but will be moving forward with the rest of the implementation in the meantime. 213274 2013-10-03 10:23:40 -0700 2013-10-03 10:37:08 -0700 Patch v1 patch text/plain 9173 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1NWYyNjQ0Li44ZjQ3YzI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTMtMTAtMDMgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIE1vdmUgSURCRmFjdG9yeUJhY2tlbmQgY3JlYXRpb24gdG8gRGF0YWJhc2VTdHJhdGVneS4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMjI4NAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViQ29y ZS5leHAuaW46CisgICAgICAgICogV2ViQ29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qOgor CisgICAgICAgICogTW9kdWxlcy9pbmRleGVkZGIvSURCRmFjdG9yeS5oOgorICAgICAgICAqIE1v ZHVsZXMvaW5kZXhlZGRiL0lEQkZhY3RvcnlCYWNrZW5kSW50ZXJmYWNlLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OklEQkZhY3RvcnlCYWNrZW5kSW50ZXJmYWNlOjpjcmVhdGUpOgorCisgICAgICAg ICogcGxhdGZvcm0vRGF0YWJhc2VTdHJhdGVneS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEYXRh YmFzZVN0cmF0ZWd5OjpjcmVhdGVJREJGYWN0b3J5QmFja2VuZCk6IEltcGxlbWVudCBhIGRlZmF1 bHQuCisgICAgICAgICogcGxhdGZvcm0vRGF0YWJhc2VTdHJhdGVneS5oOgorCiAyMDEzLTEwLTAx ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBMZWFmIEV2ZW50 VGFyZ2V0IHN1YmNsYXNzZXMgc2hvdWxkIGJlIEZJTkFMLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCRmFjdG9yeS5oIGIvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9pbmRleGVkZGIvSURCRmFjdG9yeS5oCmluZGV4IDkwNjVkODkuLjkzYTQ3ZmQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkZhY3RvcnkuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJGYWN0b3J5LmgKQEAgLTU3LDYg KzU3LDkgQEAgcHVibGljOgogICAgIH0KICAgICB+SURCRmFjdG9yeSgpOwogCisgICAgLy8gRklY TUU6IGdldERhdGFiYXNlTmFtZXMgaXMgbm8gbG9uZ2VyIGEgd2ViLWZhY3RpbmcgQVBJLCBhbmQg c2hvdWxkIGJlIHJlbW92ZWQgZnJvbSBJREJGYWN0b3J5LgorICAgIC8vIFRoZSBXZWIgSW5zcGVj dG9yIGN1cnJlbnRseSB1c2VzIHRoaXMgdG8gZW51bWVyYXRlIHRoZSBsaXN0IG9mIGRhdGFiYXNl cywgYnV0IGlzIG1vcmUgY29tcGxpY2F0ZWQgYXMgYSByZXN1bHQuCisgICAgLy8gV2Ugc2hvdWxk IHByb3ZpZGUgYSBzaW1wbGVyIEFQSSB0byB0aGUgV2ViIEluc3BlY3RvciB0aGVuIHJlbW92ZSBn ZXREYXRhYmFzZU5hbWVzLgogICAgIFBhc3NSZWZQdHI8SURCUmVxdWVzdD4gZ2V0RGF0YWJhc2VO YW1lcyhTY3JpcHRFeGVjdXRpb25Db250ZXh0KiwgRXhjZXB0aW9uQ29kZSYpOwogCiAgICAgUGFz c1JlZlB0cjxJREJPcGVuREJSZXF1ZXN0PiBvcGVuKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqLCBj b25zdCBTdHJpbmcmIG5hbWUsIEV4Y2VwdGlvbkNvZGUmKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkZhY3RvcnlCYWNrZW5kSW50ZXJmYWNlLmNwcCBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkZhY3RvcnlCYWNrZW5kSW50ZXJm YWNlLmNwcAppbmRleCA5NjM0NGViLi42ZTdiMzdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJGYWN0b3J5QmFja2VuZEludGVyZmFjZS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCRmFjdG9yeUJhY2tlbmRJbnRlcmZh Y2UuY3BwCkBAIC0zMCw2ICszMCw5IEBACiAKICNpZiBFTkFCTEUoSU5ERVhFRF9EQVRBQkFTRSkK IAorI2luY2x1ZGUgIkRhdGFiYXNlU3RyYXRlZ3kuaCIKKyNpbmNsdWRlICJQbGF0Zm9ybVN0cmF0 ZWdpZXMuaCIKKwogI2lmIFVTRShMRVZFTERCKQogI2luY2x1ZGUgIklEQkZhY3RvcnlCYWNrZW5k TGV2ZWxEQi5oIgogI2VuZGlmCkBAIC0zOCwxMiArNDEsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAKIFBhc3NSZWZQdHI8SURCRmFjdG9yeUJhY2tlbmRJbnRlcmZhY2U+IElEQkZhY3RvcnlCYWNr ZW5kSW50ZXJmYWNlOjpjcmVhdGUoKQogewotICAgIC8vIEZJWE1FOiBOZWVkIGEgYmV0dGVyIHBs YXRmb3JtIGFic3RyYWN0aW9uIGhlcmUsIGJ1dCB0aGlzIHN0b3AgZ2FwIHdpbGwgd29yayBmb3Ig bm93LgotI2lmIFVTRShMRVZFTERCKQotICAgIHJldHVybiBJREJGYWN0b3J5QmFja2VuZExldmVs REI6OmNyZWF0ZSgpOwotI2Vsc2UKLSAgICByZXR1cm4gMDsKLSNlbmRpZgorICAgIHJldHVybiBw bGF0Zm9ybVN0cmF0ZWdpZXMoKS0+ZGF0YWJhc2VTdHJhdGVneSgpLT5jcmVhdGVJREJGYWN0b3J5 QmFja2VuZCgpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbiBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhwLmlu CmluZGV4IDc4YmMyMzAuLmZiZTFjYmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1dlYkNv cmUuZXhwLmluCisrKyBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhwLmluCkBAIC01MjgsNiAr NTI4LDcgQEAgX19aTjdXZWJDb3JlMTZBcHBsaWNhdGlvbkNhY2hlMThkaXNrVXNhZ2VGb3JPcmln aW5FUE5TXzE0U2VjdXJpdHlPcmlnaW5FCiBfX1pON1dlYkNvcmUxNkFwcGxpY2F0aW9uQ2FjaGUy MGRlbGV0ZUNhY2hlRm9yT3JpZ2luRVBOU18xNFNlY3VyaXR5T3JpZ2luRQogX19aTjdXZWJDb3Jl MTZDU1NQYXJzZXJDb250ZXh0QzFFUk5TXzhEb2N1bWVudEVSS05TXzNVUkxFUktOM1dURjZTdHJp bmdFCiBfX1pON1dlYkNvcmUxNkRhdGFiYXNlU3RyYXRlZ3kxN2dldERhdGFiYXNlU2VydmVyRXYK K19fWk43V2ViQ29yZTE2RGF0YWJhc2VTdHJhdGVneTIzY3JlYXRlSURCRmFjdG9yeUJhY2tlbmRF dgogX19aTjdXZWJDb3JlMTZEZXZpY2VNb3Rpb25EYXRhMTJBY2NlbGVyYXRpb242Y3JlYXRlRWJk YmRiZAogX19aTjdXZWJDb3JlMTZEZXZpY2VNb3Rpb25EYXRhMTJSb3RhdGlvblJhdGU2Y3JlYXRl RWJkYmRiZAogX19aTjdXZWJDb3JlMTZEZXZpY2VNb3Rpb25EYXRhNmNyZWF0ZUVOM1dURjEwUGFz c1JlZlB0cklOUzBfMTJBY2NlbGVyYXRpb25FRUVTNF9OUzJfSU5TMF8xMlJvdGF0aW9uUmF0ZUVF RWJkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnhjb2RlcHJvai9wcm9qZWN0 LnBieHByb2ogYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHBy b2oKaW5kZXggOTY5OTE2MC4uZGJjYTc4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvV2Vi Q29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCisrKyBiL1NvdXJjZS9XZWJDb3JlL1dlYkNv cmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagpAQCAtMzA4MSw3ICszMDgxLDcgQEAKIAkJOTcx MkE1Q0QxNTAwNEVEQTAwNDhBRjEwIC8qIElEQkV2ZW50RGlzcGF0Y2hlci5oIGluIEhlYWRlcnMg Ki8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gOTcxMkE1NzQxNTAwNEVEQTAwNDhB RjEwIC8qIElEQkV2ZW50RGlzcGF0Y2hlci5oICovOyB9OwogCQk5NzEyQTVDRjE1MDA0RURBMDA0 OEFGMTAgLyogSURCRmFjdG9yeS5oIGluIEhlYWRlcnMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxl OyBmaWxlUmVmID0gOTcxMkE1NzYxNTAwNEVEQTAwNDhBRjEwIC8qIElEQkZhY3RvcnkuaCAqLzsg fTsKIAkJOTcxMkE1RDMxNTAwNEVEQTAwNDhBRjEwIC8qIElEQkZhY3RvcnlCYWNrZW5kSW50ZXJm YWNlLmNwcCBpbiBTb3VyY2VzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDk3 MTJBNTdBMTUwMDRFREEwMDQ4QUYxMCAvKiBJREJGYWN0b3J5QmFja2VuZEludGVyZmFjZS5jcHAg Ki87IH07Ci0JCTk3MTJBNUQ0MTUwMDRFREEwMDQ4QUYxMCAvKiBJREJGYWN0b3J5QmFja2VuZElu dGVyZmFjZS5oIGluIEhlYWRlcnMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0g OTcxMkE1N0IxNTAwNEVEQTAwNDhBRjEwIC8qIElEQkZhY3RvcnlCYWNrZW5kSW50ZXJmYWNlLmgg Ki87IH07CisJCTk3MTJBNUQ0MTUwMDRFREEwMDQ4QUYxMCAvKiBJREJGYWN0b3J5QmFja2VuZElu dGVyZmFjZS5oIGluIEhlYWRlcnMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0g OTcxMkE1N0IxNTAwNEVEQTAwNDhBRjEwIC8qIElEQkZhY3RvcnlCYWNrZW5kSW50ZXJmYWNlLmgg Ki87IHNldHRpbmdzID0ge0FUVFJJQlVURVMgPSAoUHJpdmF0ZSwgKTsgfTsgfTsKIAkJOTcxMkE1 RDYxNTAwNEVEQTAwNDhBRjEwIC8qIElEQkluZGV4LmggaW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQ QlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA5NzEyQTU3RDE1MDA0RURBMDA0OEFGMTAgLyogSURCSW5k ZXguaCAqLzsgfTsKIAkJOTcxMkE1REMxNTAwNEVEQTAwNDhBRjEwIC8qIElEQktleS5oIGluIEhl YWRlcnMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gOTcxMkE1ODMxNTAwNEVE QTAwNDhBRjEwIC8qIElEQktleS5oICovOyB9OwogCQk5NzEyQTVERjE1MDA0RURBMDA0OEFGMTAg LyogSURCS2V5UGF0aC5oIGluIEhlYWRlcnMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxl UmVmID0gOTcxMkE1ODYxNTAwNEVEQTAwNDhBRjEwIC8qIElEQktleVBhdGguaCAqLzsgfTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0RhdGFiYXNlU3RyYXRlZ3kuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vRGF0YWJhc2VTdHJhdGVneS5jcHAKaW5kZXggM2E0Yjkw NC4uYWM3MjFmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vRGF0YWJhc2VT dHJhdGVneS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vRGF0YWJhc2VTdHJhdGVn eS5jcHAKQEAgLTI2LDE3ICsyNiwzMiBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUg IkRhdGFiYXNlU3RyYXRlZ3kuaCIKIAotI2lmIEVOQUJMRShTUUxfREFUQUJBU0UpCi0KICNpbmNs dWRlICJEYXRhYmFzZVNlcnZlci5oIgorI2luY2x1ZGUgIklEQkZhY3RvcnlCYWNrZW5kSW50ZXJm YWNlLmgiCisKKyNpZiBVU0UoTEVWRUxEQikKKyNpbmNsdWRlICJJREJGYWN0b3J5QmFja2VuZExl dmVsREIuaCIKKyNlbmRpZgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKKyNpZiBFTkFCTEUoU1FM X0RBVEFCQVNFKQogQWJzdHJhY3REYXRhYmFzZVNlcnZlciogRGF0YWJhc2VTdHJhdGVneTo6Z2V0 RGF0YWJhc2VTZXJ2ZXIoKQogewogICAgIHJldHVybiBuZXcgRGF0YWJhc2VTZXJ2ZXI7CiB9Cisj ZW5kaWYgLy8gRU5BQkxFKFNRTF9EQVRBQkFTRSkKKworI2lmIEVOQUJMRShJTkRFWEVEX0RBVEFC QVNFKQorUGFzc1JlZlB0cjxJREJGYWN0b3J5QmFja2VuZEludGVyZmFjZT4gRGF0YWJhc2VTdHJh dGVneTo6Y3JlYXRlSURCRmFjdG9yeUJhY2tlbmQoKQoreworICAgIC8vIEZJWE1FOiBOZWVkIGEg YmV0dGVyIHBsYXRmb3JtIGFic3RyYWN0aW9uIGhlcmUsIGJ1dCB0aGlzIHN0b3AgZ2FwIHdpbGwg d29yayBmb3Igbm93LgorI2lmIFVTRShMRVZFTERCKQorICAgIHJldHVybiBJREJGYWN0b3J5QmFj a2VuZExldmVsREI6OmNyZWF0ZSgpOworI2Vsc2UKKyAgICByZXR1cm4gMDsKKyNlbmRpZgorfQor I2VuZGlmIC8vIEVOQUJMRShJTkRFWEVEX0RBVEFCQVNFKQogCiB9IC8vIG5hbWVzcGFjZSBXZWJD b3JlCi0KLSNlbmRpZiAvLyBFTkFCTEUoU1FMX0RBVEFCQVNFKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vRGF0YWJhc2VTdHJhdGVneS5oIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vRGF0YWJhc2VTdHJhdGVneS5oCmluZGV4IDM5OTY3ZDQuLjk1Y2Q2NjEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0RhdGFiYXNlU3RyYXRlZ3kuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9EYXRhYmFzZVN0cmF0ZWd5LmgKQEAgLTI2LDE2ICsyNiwyMiBA QAogI2lmbmRlZiBEYXRhYmFzZVN0cmF0ZWd5X2gKICNkZWZpbmUgRGF0YWJhc2VTdHJhdGVneV9o CiAKLSNpbmNsdWRlICJBYnN0cmFjdERhdGFiYXNlU2VydmVyLmgiCi0KKyNpbmNsdWRlIDx3dGYv UGFzc1JlZlB0ci5oPgogbmFtZXNwYWNlIFdlYkNvcmUgewogCitjbGFzcyBBYnN0cmFjdERhdGFi YXNlU2VydmVyOworY2xhc3MgSURCRmFjdG9yeUJhY2tlbmRJbnRlcmZhY2U7CisKIGNsYXNzIERh dGFiYXNlU3RyYXRlZ3kgewogcHVibGljOgogI2lmIEVOQUJMRShTUUxfREFUQUJBU0UpCiAgICAg dmlydHVhbCBBYnN0cmFjdERhdGFiYXNlU2VydmVyKiBnZXREYXRhYmFzZVNlcnZlcigpOwogI2Vu ZGlmCiAKKyNpZiBFTkFCTEUoSU5ERVhFRF9EQVRBQkFTRSkKKyAgICB2aXJ0dWFsIFBhc3NSZWZQ dHI8SURCRmFjdG9yeUJhY2tlbmRJbnRlcmZhY2U+IGNyZWF0ZUlEQkZhY3RvcnlCYWNrZW5kKCk7 CisjZW5kaWYKKwogcHJvdGVjdGVkOgogICAgIHZpcnR1YWwgfkRhdGFiYXNlU3RyYXRlZ3koKSB7 IH0KIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cKaW5kZXggZWJlMTEyMi4uN2Y5MDg4YSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE0IEBACisyMDEzLTEwLTAzICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4K KworICAgICAgICBNb3ZlIElEQkZhY3RvcnlCYWNrZW5kIGNyZWF0aW9uIHRvIERhdGFiYXNlU3Ry YXRlZ3kuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MjIyODQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViUGxhdGZvcm1TdHJhdGVnaWVzLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6V2ViUGxhdGZvcm1TdHJhdGVnaWVzOjpjcmVhdGVJREJGYWN0b3J5QmFj a2VuZCk6IEZhbGxiYWNrIHRvIHRoZSBkZWZhdWx0IGZvciBub3cuCisgICAgICAgICogV2ViUHJv Y2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJQbGF0Zm9ybVN0cmF0ZWdpZXMuaDoKKwogMjAxMy0xMC0w MSAgR2Fib3IgQWJyYWhhbSAgPGFicmhtQGluZi51LXN6ZWdlZC5odT4KIAogICAgICAgICBbUXRd W1dLMl0gRml4IGJ1aWxkIGFmdGVyIHIxNTY2ODguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYlBsYXRmb3JtU3RyYXRlZ2llcy5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYlBsYXRmb3JtU3RyYXRl Z2llcy5jcHAKaW5kZXggYTgyMjYxOS4uMzgzOTAyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJQbGF0Zm9ybVN0cmF0ZWdpZXMuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViUGxhdGZvcm1T dHJhdGVnaWVzLmNwcApAQCAtNDIsNiArNDIsNyBAQAogI2luY2x1ZGUgIldlYlByb2Nlc3MuaCIK ICNpbmNsdWRlICJXZWJQcm9jZXNzUHJveHlNZXNzYWdlcy5oIgogI2luY2x1ZGUgPFdlYkNvcmUv Q29sb3IuaD4KKyNpbmNsdWRlIDxXZWJDb3JlL0lEQkZhY3RvcnlCYWNrZW5kSW50ZXJmYWNlLmg+ CiAjaW5jbHVkZSA8V2ViQ29yZS9Mb2FkZXJTdHJhdGVneS5oPgogI2luY2x1ZGUgPFdlYkNvcmUv TWFpbkZyYW1lLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9OZXR3b3JrU3RvcmFnZVNlc3Npb24uaD4K QEAgLTIxMiw3ICsyMTMsMTQgQEAgQWJzdHJhY3REYXRhYmFzZVNlcnZlciogV2ViUGxhdGZvcm1T dHJhdGVnaWVzOjpnZXREYXRhYmFzZVNlcnZlcigpCiB7CiAgICAgcmV0dXJuIERhdGFiYXNlU3Ry YXRlZ3k6OmdldERhdGFiYXNlU2VydmVyKCk7IC8vIFVzZSB0aGUgZGVmYXVsdCBmb3Igbm93Lgog fQotI2VuZGlmCisjZW5kaWYgLy8gRU5BQkxFKFNRTF9EQVRBQkFTRSkKKworI2lmIEVOQUJMRShJ TkRFWEVEX0RBVEFCQVNFKQorUGFzc1JlZlB0cjxJREJGYWN0b3J5QmFja2VuZEludGVyZmFjZT4g V2ViUGxhdGZvcm1TdHJhdGVnaWVzOjpjcmVhdGVJREJGYWN0b3J5QmFja2VuZCgpCit7CisgICAg cmV0dXJuIERhdGFiYXNlU3RyYXRlZ3k6OmNyZWF0ZUlEQkZhY3RvcnlCYWNrZW5kKCk7IC8vIFVz ZSB0aGUgZGVmYXVsdCBmb3Igbm93LgorfQorI2VuZGlmIC8vIEVOQUJMRShJTkRFWEVEX0RBVEFC QVNFKQogCiAvLyBMb2FkZXJTdHJhdGVneQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYlBsYXRmb3JtU3RyYXRlZ2llcy5oIGIvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJQbGF0Zm9ybVN0cmF0ZWdpZXMu aAppbmRleCA5NjNiNzJjLi5kZjBiNzdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYlBsYXRmb3JtU3RyYXRlZ2llcy5oCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViUGxhdGZvcm1TdHJhdGVnaWVz LmgKQEAgLTY3LDYgKzY3LDkgQEAgcHJpdmF0ZToKICNpZiBFTkFCTEUoU1FMX0RBVEFCQVNFKQog ICAgIHZpcnR1YWwgV2ViQ29yZTo6QWJzdHJhY3REYXRhYmFzZVNlcnZlciogZ2V0RGF0YWJhc2VT ZXJ2ZXIoKSBPVkVSUklERTsKICNlbmRpZgorI2lmIEVOQUJMRShJTkRFWEVEX0RBVEFCQVNFKQor ICAgIHZpcnR1YWwgUGFzc1JlZlB0cjxXZWJDb3JlOjpJREJGYWN0b3J5QmFja2VuZEludGVyZmFj ZT4gY3JlYXRlSURCRmFjdG9yeUJhY2tlbmQoKSBPVkVSUklERTsKKyNlbmRpZgogCiAgICAgLy8g V2ViQ29yZTo6TG9hZGVyU3RyYXRlZ3kKICNpZiBFTkFCTEUoTkVUV09SS19QUk9DRVNTKQo=