122267 2013-10-03 06:23:40 -0700 [EFL] [DEBUG] JavaScriptCore fails to build 2013-10-03 10:11:30 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 r.plociennik sergio commit-queue msaboff r.plociennik sergio oldest_to_newest 935762 0 r.plociennik 2013-10-03 06:23:40 -0700 Build fails due to an expression containing comparison between signed and unsigned integer. Source/JavaScriptCore/llint/LLIntData.cpp: In static member function ‘static void JSC::LLInt::Data::performAssertions(JSC::VM&)’: Source/JavaScriptCore/llint/LLIntData.cpp:128:5: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] 935766 1 213244 sergio 2013-10-03 07:24:00 -0700 Created attachment 213244 Patch 935769 2 r.plociennik 2013-10-03 07:34:46 -0700 How about changing it to: ASSERT(MarkedBlock::blockMask == ~static_cast<decltype(MarkedBlock::blockMask)>(0xffff)); 935771 3 sergio 2013-10-03 07:48:42 -0700 (In reply to comment #2) > How about changing it to: > > ASSERT(MarkedBlock::blockMask == ~static_cast<decltype(MarkedBlock::blockMask)>(0xffff)); Nice suggestion. I am going to update the patch. 935773 4 sergio 2013-10-03 07:53:14 -0700 (In reply to comment #3) > (In reply to comment #2) > > How about changing it to: > > > > ASSERT(MarkedBlock::blockMask == ~static_cast<decltype(MarkedBlock::blockMask)>(0xffff)); > > Nice suggestion. I am going to update the patch. Michael, I saw you have just r+'ed it; should I update the patch to apply Rob's suggestion? 935776 5 msaboff 2013-10-03 08:07:52 -0700 (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > How about changing it to: > > > > > > ASSERT(MarkedBlock::blockMask == ~static_cast<decltype(MarkedBlock::blockMask)>(0xffff)); > > > > Nice suggestion. I am going to update the patch. > > Michael, I saw you have just r+'ed it; should I update the patch to apply Rob's suggestion? Sure. I just CQ-. Maybe that stopped the bots. 935825 6 213271 sergio 2013-10-03 09:35:33 -0700 Created attachment 213271 Patch Updated as per Rob's suggestion. 935836 7 213271 commit-queue 2013-10-03 10:11:28 -0700 Comment on attachment 213271 Patch Clearing flags on attachment: 213271 Committed r156837: <http://trac.webkit.org/changeset/156837> 935837 8 commit-queue 2013-10-03 10:11:30 -0700 All reviewed patches have been landed. Closing bug. 213244 2013-10-03 07:24:00 -0700 2013-10-03 09:35:28 -0700 Patch bug-122267-20131003112348.patch text/plain 1500 sergio U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2ODMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 NWY2YjAwN2NhNTBjNTMxMTg1MjA5MWRkNzMxMjNiYzAxZDUzNzFhLi43NWRjZTZjNjE0ZTg4ZWU1 OWY4ODU1MTFiNTUzNzRiMzUyNzlmOTM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxMy0xMC0wMyAgU2VyZ2lvIENvcnJlaWEgIDxzZXJnaW8uY29ycmVpYUBv cGVuYm9zc2Eub3JnPgorCisgICAgICAgIFtFRkwgZGVidWddIEphdmFTY3JpcHRDb3JlIGZhaWxz IHRvIGJ1aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMjIyNjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBCdWlsZCBmYWlscyBkdWUgdG8gYW4gZXhwcmVzc2lvbiBjb250YWluaW5nIGNvbXBhcmlzb24g YmV0d2VlbiBzaWduZWQKKyAgICAgICAgYW5kIHVuc2lnbmVkIGludGVnZXIuCisKKyAgICAgICAg KiBsbGludC9MTEludERhdGEuY3BwOgorICAgICAgICAoSlNDOjpMTEludDo6RGF0YTo6cGVyZm9y bUFzc2VydGlvbnMpOiBDYXN0IH4weGZmZmYgdG8gdW5zaWduZWQgdG8KKyAgICAgICAgYXZvaWQg c2lnbmVkIHZzLiB1bnNpZ25lZCBjb21wYXJpc29uIHdhcm5pbmcuCisKIDIwMTMtMTAtMDMgIE5h ZGF2IFJvdGVtICA8bnJvdGVtQGFwcGxlLmNvbT4KIAogICAgICAgICBERkc6IENvbnN0UHJvcCB0 aGUgcGF0dGVybiBWYWx1ZVRvSW50MzIoQm9vbCh4KSkgLT4gSW50MzIoeCkKZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9MTEludERhdGEuY3BwIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2xsaW50L0xMSW50RGF0YS5jcHAKaW5kZXggYmVjOTlhNmM4NjNlMzRmNWJkNDMw ODUxNTA2YmJkMDQzNmExZTRkNS4uNjViOWZlOTZjZmY4OTFmYTU0ZjRkNGVjNWRmZGMwY2ZkYWRj MTUwMyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xMSW50RGF0YS5j cHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xMSW50RGF0YS5jcHAKQEAgLTEy NSw3ICsxMjUsNyBAQCB2b2lkIERhdGE6OnBlcmZvcm1Bc3NlcnRpb25zKFZNJiB2bSkKICAgICAK ICAgICBBU1NFUlQoUmVzb2x2ZU1vZGVBbmRUeXBlOjptYXNrID09IDB4ZmZmZik7CiAKLSAgICBB U1NFUlQoTWFya2VkQmxvY2s6OmJsb2NrTWFzayA9PSB+MHhmZmZmKTsKKyAgICBBU1NFUlQoTWFy a2VkQmxvY2s6OmJsb2NrTWFzayA9PSBzdGF0aWNfY2FzdDx1bnNpZ25lZD4ofjB4ZmZmZikpOwog CiAgICAgLy8gRklYTUU6IG1ha2UgdGhlc2UgYXNzZXJ0aW9ucyBsZXNzIGhvcnJpYmxlLgogI2lm ICFBU1NFUlRfRElTQUJMRUQK 213271 2013-10-03 09:35:33 -0700 2013-10-03 10:11:28 -0700 Patch bug-122267-20131003133521.patch text/plain 1510 sergio U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2ODM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 NWY2YjAwN2NhNTBjNTMxMTg1MjA5MWRkNzMxMjNiYzAxZDUzNzFhLi5hZThjZjNhY2RhOTUzNWMx ZWYyOWY2YzI2ZmExZDFhMDZlNjhiMDc5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxMy0xMC0wMyAgU2VyZ2lvIENvcnJlaWEgIDxzZXJnaW8uY29ycmVpYUBv cGVuYm9zc2Eub3JnPgorCisgICAgICAgIFtFRkxdIFtERUJVR10gSmF2YVNjcmlwdENvcmUgZmFp bHMgdG8gYnVpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEyMjI2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEJ1aWxkIGZhaWxzIGR1ZSB0byBhbiBleHByZXNzaW9uIGNvbnRhaW5pbmcgY29tcGFyaXNv biBiZXR3ZWVuIHNpZ25lZAorICAgICAgICBhbmQgdW5zaWduZWQgaW50ZWdlci4KKworICAgICAg ICAqIGxsaW50L0xMSW50RGF0YS5jcHA6CisgICAgICAgIChKU0M6OkxMSW50OjpEYXRhOjpwZXJm b3JtQXNzZXJ0aW9ucyk6IEFkZCBjYXN0IHRvIGF2b2lkIHNpZ25lZCB2cy4KKyAgICAgICAgdW5z aWduZWQgY29tcGFyaXNvbiB3YXJuaW5nLgorCiAyMDEzLTEwLTAzICBOYWRhdiBSb3RlbSAgPG5y b3RlbUBhcHBsZS5jb20+CiAKICAgICAgICAgREZHOiBDb25zdFByb3AgdGhlIHBhdHRlcm4gVmFs dWVUb0ludDMyKEJvb2woeCkpIC0+IEludDMyKHgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvbGxpbnQvTExJbnREYXRhLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGlu dC9MTEludERhdGEuY3BwCmluZGV4IGJlYzk5YTZjODYzZTM0ZjViZDQzMDg1MTUwNmJiZDA0MzZh MWU0ZDUuLmYwNzQyOGJjNmIyMDFlNWZhMWJhOTUyNDE3ZmQxMzZiNjVhZWJiYWMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9MTEludERhdGEuY3BwCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9sbGludC9MTEludERhdGEuY3BwCkBAIC0xMjUsNyArMTI1LDcgQEAg dm9pZCBEYXRhOjpwZXJmb3JtQXNzZXJ0aW9ucyhWTSYgdm0pCiAgICAgCiAgICAgQVNTRVJUKFJl c29sdmVNb2RlQW5kVHlwZTo6bWFzayA9PSAweGZmZmYpOwogCi0gICAgQVNTRVJUKE1hcmtlZEJs b2NrOjpibG9ja01hc2sgPT0gfjB4ZmZmZik7CisgICAgQVNTRVJUKE1hcmtlZEJsb2NrOjpibG9j a01hc2sgPT0gfnN0YXRpY19jYXN0PGRlY2x0eXBlKE1hcmtlZEJsb2NrOjpibG9ja01hc2spPigw eGZmZmYpKTsKIAogICAgIC8vIEZJWE1FOiBtYWtlIHRoZXNlIGFzc2VydGlvbnMgbGVzcyBob3Jy aWJsZS4KICNpZiAhQVNTRVJUX0RJU0FCTEVECg==