122265 2013-10-03 05:39:37 -0700 [CSS Regions] Follow-up code style change after bug #121828 All regions have layers 2013-10-03 12:51:52 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 57312 1 mmaerean mmaerean commit-queue darin esprehn+autocc glenn kondapallykalyan WebkitBugTracker oldest_to_newest 935757 0 mmaerean 2013-10-03 05:39:37 -0700 Implement the changes requested in review at bug #121828 All regions have layers https://bugs.webkit.org/show_bug.cgi?id=121828#c14 935763 1 213243 mmaerean 2013-10-03 06:33:44 -0700 Created attachment 213243 patch 935909 2 213243 darin 2013-10-03 12:24:31 -0700 Comment on attachment 213243 patch View in context: https://bugs.webkit.org/attachment.cgi?id=213243&action=review > Source/WebCore/rendering/RenderMultiColumnSet.cpp:417 > + // RenderMultiColumnSet derives from RenderRegion, but unlike the CSS Regions specification, the Multi-Columns CSS > + // specification states that the column boxes do not establish new Stacking Contexts. Missing comma here after the word "but". I’ll set commit-queue+ anyway, because we should not hold this all up just for a comma. 935931 3 213243 commit-queue 2013-10-03 12:51:50 -0700 Comment on attachment 213243 patch Clearing flags on attachment: 213243 Committed r156850: <http://trac.webkit.org/changeset/156850> 935932 4 commit-queue 2013-10-03 12:51:52 -0700 All reviewed patches have been landed. Closing bug. 213243 2013-10-03 06:33:44 -0700 2013-10-03 12:51:50 -0700 patch patch122265AllRegionsLayersFollowUp.diff text/plain 4267 mmaerean ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyZGRiYmFhLi5jYmE1NjZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTMtMTAtMDMgIE1paGFpIE1hZXJlYW4gIDxtbWFlcmVhbkBhZG9iZS5jb20+CisKKyAg ICAgICAgW0NTUyBSZWdpb25zXSBGb2xsb3ctdXAgY29kZSBzdHlsZSBjaGFuZ2UgYWZ0ZXIgYnVn ICMxMjE4MjggQWxsIHJlZ2lvbnMgaGF2ZSBsYXllcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMjI2NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIENvbW1lbnRzIG1vdmVkIHRvIHRoZSBjcHAgZmlsZSwg YXMgcmVxdWVzdGVkIGluIHRoZSByZXZpZXcgb2YgYnVnICMxMjE4MjggQWxsIHJlZ2lvbnMgaGF2 ZSBsYXllcnMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTXVsdGlDb2x1bW5TZXQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6UmVuZGVyTXVsdGlDb2x1bW5TZXQ6OnJlcXVpcmVzTGF5ZXIpOgorICAgICAgICAq IHJlbmRlcmluZy9SZW5kZXJNdWx0aUNvbHVtblNldC5oOgorICAgICAgICAqIHJlbmRlcmluZy9S ZW5kZXJSZWdpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyUmVnaW9uOjpyZXF1aXJl c0xheWVyKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyUmVnaW9uLmg6CisKIDIwMTMtMTAt MDMgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIEFkZCB0 aGUgTm90RGVsZXRhYmxlLCBPcGVyYXRpb25zTm90RGVsZXRhYmxlIElETCBhdHRyaWJ1dGVzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTXVsdGlDb2x1bW5TZXQu Y3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck11bHRpQ29sdW1uU2V0LmNwcApp bmRleCA3NzAzODU5Li4xODUyMjA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyTXVsdGlDb2x1bW5TZXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJNdWx0aUNvbHVtblNldC5jcHAKQEAgLTQxMSw2ICs0MTEsMTMgQEAgdm9pZCBSZW5k ZXJNdWx0aUNvbHVtblNldDo6cmVwYWludEZsb3dUaHJlYWRDb250ZW50KGNvbnN0IExheW91dFJl Y3QmIHJlcGFpbnRSZWMKICAgICB9CiB9CiAKK2Jvb2wgUmVuZGVyTXVsdGlDb2x1bW5TZXQ6OnJl cXVpcmVzTGF5ZXIoKSBjb25zdAoreworICAgIC8vIFJlbmRlck11bHRpQ29sdW1uU2V0IGRlcml2 ZXMgZnJvbSBSZW5kZXJSZWdpb24sIGJ1dCB1bmxpa2UgdGhlIENTUyBSZWdpb25zIHNwZWNpZmlj YXRpb24sIHRoZSBNdWx0aS1Db2x1bW5zIENTUworICAgIC8vIHNwZWNpZmljYXRpb24gc3RhdGVz IHRoYXQgdGhlIGNvbHVtbiBib3hlcyBkbyBub3QgZXN0YWJsaXNoIG5ldyBTdGFja2luZyBDb250 ZXh0cy4KKyAgICByZXR1cm4gUmVuZGVyQmxvY2tGbG93OjpyZXF1aXJlc0xheWVyKCk7Cit9CisK IHZvaWQgUmVuZGVyTXVsdGlDb2x1bW5TZXQ6OmNvbGxlY3RMYXllckZyYWdtZW50cyhMYXllckZy YWdtZW50cyYgZnJhZ21lbnRzLCBjb25zdCBMYXlvdXRSZWN0JiBsYXllckJvdW5kaW5nQm94LCBj b25zdCBMYXlvdXRSZWN0JiBkaXJ0eVJlY3QpCiB7CiAgICAgLy8gTGV0J3Mgc3RhcnQgYnkgaW50 cm9kdWNpbmcgdGhlIGRpZmZlcmVudCBjb29yZGluYXRlIHN5c3RlbXMgaW52b2x2ZWQgaGVyZS4g VGhleSBhcmUgZGlmZmVyZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyTXVsdGlDb2x1bW5TZXQuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJN dWx0aUNvbHVtblNldC5oCmluZGV4IDY2MjM2NGIuLjA3YWMwZGQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJNdWx0aUNvbHVtblNldC5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJNdWx0aUNvbHVtblNldC5oCkBAIC0xMTgsOSArMTE4LDcg QEAgcHJpdmF0ZToKICAgICAKICAgICB2aXJ0dWFsIHZvaWQgcmVwYWludEZsb3dUaHJlYWRDb250 ZW50KGNvbnN0IExheW91dFJlY3QmIHJlcGFpbnRSZWN0LCBib29sIGltbWVkaWF0ZSkgY29uc3Qg T1ZFUlJJREU7CiAKLSAgICAvLyBSZW5kZXJNdWx0aUNvbHVtblNldCBkZXJpdmVzIGZyb20gUmVu ZGVyUmVnaW9uLCBidXQgdW5saWtlIHRoZSBDU1MgUmVnaW9ucyBzcGVjaWZpY2F0aW9uLCB0aGUg TXVsdGktQ29sdW1ucyBDU1MKLSAgICAvLyBzcGVjaWZpY2F0aW9uIHN0YXRlcyB0aGF0IHRoZSBj b2x1bW4gYm94ZXMgZG8gbm90IGVzdGFibGlzaCBuZXcgU3RhY2tpbmcgQ29udGV4dHMuCi0gICAg dmlydHVhbCBib29sIHJlcXVpcmVzTGF5ZXIoKSBjb25zdCBPVkVSUklERSBGSU5BTCB7IHJldHVy biBSZW5kZXJCbG9ja0Zsb3c6OnJlcXVpcmVzTGF5ZXIoKTsgfQorICAgIHZpcnR1YWwgYm9vbCBy ZXF1aXJlc0xheWVyKCkgY29uc3QgT1ZFUlJJREU7CiAKICAgICB2aXJ0dWFsIHZvaWQgY29sbGVj dExheWVyRnJhZ21lbnRzKExheWVyRnJhZ21lbnRzJiwgY29uc3QgTGF5b3V0UmVjdCYgbGF5ZXJC b3VuZGluZ0JveCwgY29uc3QgTGF5b3V0UmVjdCYgZGlydHlSZWN0KSBPVkVSUklERTsKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclJlZ2lvbi5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUmVnaW9uLmNwcAppbmRleCBjZWUyM2UyLi4wYWU5 OGJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUmVnaW9uLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUmVnaW9uLmNwcApAQCAtMzc0 LDYgKzM3NCwxMiBAQCB2b2lkIFJlbmRlclJlZ2lvbjo6cmVwYWludEZsb3dUaHJlYWRDb250ZW50 UmVjdGFuZ2xlKGNvbnN0IExheW91dFJlY3QmIHJlcGFpbnRSZQogICAgIHJlcGFpbnRSZWN0YW5n bGUoY2xpcHBlZFJlY3QsIGltbWVkaWF0ZSk7CiB9CiAKK2Jvb2wgUmVuZGVyUmVnaW9uOjpyZXF1 aXJlc0xheWVyKCkgY29uc3QKK3sKKyAgICAvLyBBbGwgcmVnaW9ucyBjcmVhdGUgc3RhY2tpbmcg Y29udGV4dHMsIGFzIHNwZWNpZmllZCBpbiB0aGUgQ1NTIHN0YW5kYXJkLiBEbyB0aGF0IGJ5IGFs bG9jYXRpbmcgYSBzZXBhcmF0ZSBSZW5kZXJMYXllciBmb3IgZWFjaC4KKyAgICByZXR1cm4gdHJ1 ZTsKK30KKwogdm9pZCBSZW5kZXJSZWdpb246Omluc3RhbGxGbG93VGhyZWFkKCkKIHsKICAgICBt X2Zsb3dUaHJlYWQgPSAmdmlldygpLmZsb3dUaHJlYWRDb250cm9sbGVyKCkuZW5zdXJlUmVuZGVy Rmxvd1RocmVhZFdpdGhOYW1lKHN0eWxlKCktPnJlZ2lvblRocmVhZCgpKTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJSZWdpb24uaCBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJSZWdpb24uaAppbmRleCBhMjM2OTViLi45NTdkYzVhIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUmVnaW9uLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclJlZ2lvbi5oCkBAIC0xMzksOCArMTM5LDcgQEAgcHVi bGljOgogCiAgICAgdmlydHVhbCB2b2lkIGNvbGxlY3RMYXllckZyYWdtZW50cyhMYXllckZyYWdt ZW50cyYsIGNvbnN0IExheW91dFJlY3QmLCBjb25zdCBMYXlvdXRSZWN0JikgeyB9CiAKLSAgICAv LyBBbGwgcmVnaW9ucyBjcmVhdGUgc3RhY2tpbmcgY29udGV4dHMsIGFzIHNwZWNpZmllZCBpbiB0 aGUgQ1NTIHN0YW5kYXJkLiBEbyB0aGF0IGJ5IGFsbG9jYXRpbmcgYSBzZXBhcmF0ZSBSZW5kZXJM YXllciBmb3IgZWFjaC4KLSAgICB2aXJ0dWFsIGJvb2wgcmVxdWlyZXNMYXllcigpIGNvbnN0IE9W RVJSSURFIHsgcmV0dXJuIHRydWU7IH0KKyAgICB2aXJ0dWFsIGJvb2wgcmVxdWlyZXNMYXllcigp IGNvbnN0IE9WRVJSSURFOwogCiAgICAgdm9pZCBhZGRMYXlvdXRPdmVyZmxvd0ZvckJveChjb25z dCBSZW5kZXJCb3gqLCBjb25zdCBMYXlvdXRSZWN0Jik7CiAgICAgdm9pZCBhZGRWaXN1YWxPdmVy Zmxvd0ZvckJveChjb25zdCBSZW5kZXJCb3gqLCBjb25zdCBMYXlvdXRSZWN0Jik7Cg==