122264 2013-10-03 02:57:26 -0700 WebGL framebuffer-object-attachment layout test bug 2024-04-14 16:48:47 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 126538 P2 Normal --- 0 p.szymanski3 webkit-unassigned bfulgham commit-queue dino esprehn+autocc g_squelart kondapallykalyan oldest_to_newest 935747 0 p.szymanski3 2013-10-03 02:57:26 -0700 This patch fixes framebuffer-object-attachment test. It clears depth buffer if a framebuffer has depth or depth stencil attachment and is complete 935748 1 213237 p.szymanski3 2013-10-03 03:13:09 -0700 Created attachment 213237 framebuffer object attachment test fix 966423 2 213237 bfulgham 2014-01-10 10:26:35 -0800 Comment on attachment 213237 framebuffer object attachment test fix The buffer setup/clear logic is handled elsewhere. I believe the test was corrected by http://trac.webkit.org/changeset/161375. 966424 3 bfulgham 2014-01-10 10:27:18 -0800 Thanks for working on this. I think a separate fix I did while investigating similar problems covers the same case you handled here. *** This bug has been marked as a duplicate of bug 126538 *** 213237 2013-10-03 03:13:09 -0700 2014-01-10 10:26:34 -0800 framebuffer object attachment test fix framebuffer-object-attachment-fix.patch text/plain 2499 p.szymanski3 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyZGRiYmFhLi5mZTFhYjllIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTMtMTAtMDMgIFByemVteXNsYXcgU3p5bWFuc2tpICA8cC5zenltYW5za2kzQHNhbXN1 bmcuY29tPiwgWW9uZ0dlb2wgSnVuZyA8eWc0OC5qdW5nQHNhbXN1bmcuY29tPgorCisgICAgICAg IFtXZWJHTF0gV2ViR0wgZnJhbWVidWZmZXItb2JqZWN0LWF0dGFjaG1lbnQgbGF5b3V0IHRlc3Qg ZmFpbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy MjI2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo aXMgcGF0Y2ggZml4ZXMgZnJhbWVidWZmZXItb2JqZWN0LWF0dGFjaG1lbnQgdGVzdCBmYWlsZWQg Y2FzZXMuCisgICAgICAgIEl0IGNsZWFycyBkZXB0aCBidWZmZXIgaWYgYSBmcmFtZWJ1ZmZlciBo YXMgZGVwdGggb3IgZGVwdGggc3RlbmNpbCBhdHRhY2htZW50IGFuZCBpcyBjb21wbGV0ZS4KKwor ICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzOgorICAgICAgICBMYXlvdXRUZXN0cy93 ZWJnbC9yZXNvdXJjZXMvd2ViZ2xfdGVzdF9maWxlcy9jb25mb3JtYW5jZS9yZW5kZXJidWZmZXJz L2ZyYW1lYnVmZmVyLW9iamVjdC1hdHRhY2htZW50Lmh0bWwKKyAgICAgICAgTGF5b3V0VGVzdHMv d2ViZ2wvcmVzb3VyY2VzL3dlYmdsX3Rlc3RfZmlsZXMvY29uZm9ybWFuY2UvcmVuZGVyYnVmZmVy cy9mcmFtZWJ1ZmZlci1zdGF0ZS1yZXN0b3JhdGlvbi5odG1sCisgICAgICAgIExheW91dFRlc3Rz L3dlYmdsL3Jlc291cmNlcy93ZWJnbF90ZXN0X2ZpbGVzL2NvbmZvcm1hbmNlL3JlbmRlcmJ1ZmZl cnMvZnJhbWVidWZmZXItdGVzdC5odG1sCisgICAgICAgIExheW91dFRlc3RzL3dlYmdsL3Jlc291 cmNlcy93ZWJnbF90ZXN0X2ZpbGVzL2NvbmZvcm1hbmNlL3JlbmRlcmJ1ZmZlcnMvcmVuZGVyYnVm ZmVyLWluaXRpYWxpemF0aW9uLmh0bWwKKyAgICAgICAgTGF5b3V0VGVzdHMvd2ViZ2wvcmVzb3Vy Y2VzL3dlYmdsX3Rlc3RfZmlsZXMvY29uZm9ybWFuY2UvY29udGV4dC9jb250ZXh0LWF0dHJpYnV0 ZXMtYWxwaGEtZGVwdGgtc3RlbmNpbC1hbnRpYWxpYXMuaHRtbAorICAgICAgICBMYXlvdXRUZXN0 cy93ZWJnbC9yZXNvdXJjZXMvd2ViZ2xfdGVzdF9maWxlcy9jb25mb3JtYW5jZS9leHRlbnNpb25z L3dlYmdsLWRlcHRoLXRleHR1cmUuaHRtbAorCisgICAgICAgICogaHRtbC9jYW52YXMvV2ViR0xS ZW5kZXJpbmdDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYkdMUmVuZGVyaW5nQ29u dGV4dDo6ZnJhbWVidWZmZXJSZW5kZXJidWZmZXIpOgorCiAyMDEzLTEwLTAzICBaYW4gRG9iZXJz ZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBBZGQgdGhlIE5vdERlbGV0YWJs ZSwgT3BlcmF0aW9uc05vdERlbGV0YWJsZSBJREwgYXR0cmlidXRlcwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKaW5kZXggM2U4 YmFmYi4uNDg2OTVmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2Vi R0xSZW5kZXJpbmdDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9X ZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCkBAIC0yMTQ5LDYgKzIxNDksMTAgQEAgdm9pZCBXZWJH TFJlbmRlcmluZ0NvbnRleHQ6OmZyYW1lYnVmZmVyUmVuZGVyYnVmZmVyKEdDM0RlbnVtIHRhcmdl dCwgR0MzRGVudW0gYXQKICAgICAgICAgbV9jb250ZXh0LT5mcmFtZWJ1ZmZlclJlbmRlcmJ1ZmZl cih0YXJnZXQsIGF0dGFjaG1lbnQsIHJlbmRlcmJ1ZmZlcnRhcmdldCwgYnVmZmVyT2JqZWN0KTsK ICAgICB9CiAgICAgbV9mcmFtZWJ1ZmZlckJpbmRpbmctPnNldEF0dGFjaG1lbnRGb3JCb3VuZEZy YW1lYnVmZmVyKGF0dGFjaG1lbnQsIGJ1ZmZlcik7CisgICAgaWYgKGJ1ZmZlck9iamVjdCAmJiAo YXR0YWNobWVudCA9PSBHcmFwaGljc0NvbnRleHQzRDo6REVQVEhfQVRUQUNITUVOVCB8fCBhdHRh Y2htZW50ID09IEdyYXBoaWNzQ29udGV4dDNEOjpERVBUSF9TVEVOQ0lMX0FUVEFDSE1FTlQpKSB7 CisgICAgICAgIGlmIChjaGVja0ZyYW1lYnVmZmVyU3RhdHVzKHRhcmdldCkgPT0gR3JhcGhpY3ND b250ZXh0M0Q6OkZSQU1FQlVGRkVSX0NPTVBMRVRFKQorICAgICAgICAgICAgY2xlYXIoR3JhcGhp Y3NDb250ZXh0M0Q6OkRFUFRIX0JVRkZFUl9CSVQpOworICAgIH0KICAgICBhcHBseVN0ZW5jaWxU ZXN0KCk7CiAgICAgY2xlYW51cEFmdGVyR3JhcGhpY3NDYWxsKGZhbHNlKTsKIH0K