122263 2013-10-03 00:26:00 -0700 DFG: ConstProp the pattern ValueToInt32(Bool(x)) -> Int32(x) 2013-10-03 07:53:24 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 nrotem webkit-unassigned commit-queue fpizlo ggaren oldest_to_newest 935729 0 nrotem 2013-10-03 00:26:00 -0700 DFG: ConstProp the pattern ValueToInt32(Bool(x)) -> Int32(x) 935730 1 213234 nrotem 2013-10-03 00:26:43 -0700 Created attachment 213234 Patch 935734 2 213234 ggaren 2013-10-03 00:43:09 -0700 Comment on attachment 213234 Patch r=me 935742 3 213234 commit-queue 2013-10-03 01:41:48 -0700 Comment on attachment 213234 Patch Clearing flags on attachment: 213234 Committed r156830: <http://trac.webkit.org/changeset/156830> 935743 4 commit-queue 2013-10-03 01:41:50 -0700 All reviewed patches have been landed. Closing bug. 935772 5 213234 fpizlo 2013-10-03 07:48:58 -0700 Comment on attachment 213234 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213234&action=review > Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:297 > + setConstant(node, JSValue(child.asBoolean())); Is the goal here to convert the Boolean to a number? If so, does JSValue(bool) accomplish this? My guesses that if it does, it's sort of by luck and we'd want to call jsNumber() directly. 935774 6 213234 fpizlo 2013-10-03 07:53:24 -0700 Comment on attachment 213234 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213234&action=review >> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:297 >> + setConstant(node, JSValue(child.asBoolean())); > > Is the goal here to convert the Boolean to a number? If so, does JSValue(bool) accomplish this? My guesses that if it does, it's sort of by luck and we'd want to call jsNumber() directly. Ugh, yeah we don't have a JSValue(bool) overload. So this works - but I think it would be better to use jsNumber() here and in the case above. We've been considering getting rid of the JSValue(number) overloads because you can get quite confused in corner cases. 213234 2013-10-03 00:26:43 -0700 2013-10-03 07:53:24 -0700 Patch bug-122263-20131003002642.patch text/plain 2024 nrotem U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2ODI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh M2NlMDJiYzZkMWJhNGE0ZWU5MGU5MzgxNmNhMWQ0ZDcwZmQ3Zjg3Li5kMzAwYjRiNDUzMmFiOTZj OTVmNTdjMDE5NmMzYmNiOWRjNDFlZjhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxMy0xMC0wMyAgTmFkYXYgUm90ZW0gIDxucm90ZW1AYXBwbGUuY29tPgor CisgICAgICAgIERGRzogQ29uc3RQcm9wIHRoZSBwYXR0ZXJuIFZhbHVlVG9JbnQzMihCb29sKHgp KSAtPiBJbnQzMih4KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTIyMjYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBkZmcvREZHQWJzdHJhY3RJbnRlcnByZXRlcklubGluZXMuaDoKKyAgICAgICAgKEpT Qzo6REZHOjo6OmV4ZWN1dGVFZmZlY3RzKToKKwogMjAxMy0xMC0wMiAgRGFuIEJlcm5zdGVpbiAg PG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIxNTY4MTEpOiBPYmplY3Rp dmUtQyBKYXZhU2NyaXB0Q29yZSBBUEkgdGVzdCBmYWlsaW5nIG9uIE1vdW50YWluIExpb24gYm90 cwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFjdEludGVy cHJldGVySW5saW5lcy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFjdElu dGVycHJldGVySW5saW5lcy5oCmluZGV4IDA5N2M3NDZjMGE0MWEzZTA3MTM2YjkzOTc2MDBkZjIy OTA2ZjgwNmUuLmNjMDVhOTRlODUyYjc5ZTUyMTMyNDI2NzlkNWQ2ZWY1NzkyYzY0YWYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQWJzdHJhY3RJbnRlcnByZXRlcklu bGluZXMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fic3RyYWN0SW50ZXJw cmV0ZXJJbmxpbmVzLmgKQEAgLTI4NSwxMiArMjg1LDE4IEBAIGJvb2wgQWJzdHJhY3RJbnRlcnBy ZXRlcjxBYnN0cmFjdFN0YXRlVHlwZT46OmV4ZWN1dGVFZmZlY3RzKHVuc2lnbmVkIGNsb2JiZXJM aW1pCiAgICAgICAgICAgICAKICAgICBjYXNlIFZhbHVlVG9JbnQzMjogewogICAgICAgICBKU1Zh bHVlIGNoaWxkID0gZm9yTm9kZShub2RlLT5jaGlsZDEoKSkudmFsdWUoKTsKLSAgICAgICAgaWYg KGNoaWxkICYmIGNoaWxkLmlzTnVtYmVyKCkpIHsKLSAgICAgICAgICAgIGlmIChjaGlsZC5pc0lu dDMyKCkpCi0gICAgICAgICAgICAgICAgc2V0Q29uc3RhbnQobm9kZSwgY2hpbGQpOwotICAgICAg ICAgICAgZWxzZQotICAgICAgICAgICAgICAgIHNldENvbnN0YW50KG5vZGUsIEpTVmFsdWUoSlND Ojp0b0ludDMyKGNoaWxkLmFzRG91YmxlKCkpKSk7Ci0gICAgICAgICAgICBicmVhazsKKyAgICAg ICAgaWYgKGNoaWxkKSB7CisgICAgICAgICAgICBpZiAoY2hpbGQuaXNOdW1iZXIoKSkgeworICAg ICAgICAgICAgICAgIGlmIChjaGlsZC5pc0ludDMyKCkpCisgICAgICAgICAgICAgICAgICAgIHNl dENvbnN0YW50KG5vZGUsIGNoaWxkKTsKKyAgICAgICAgICAgICAgICBlbHNlCisgICAgICAgICAg ICAgICAgICAgIHNldENvbnN0YW50KG5vZGUsIEpTVmFsdWUoSlNDOjp0b0ludDMyKGNoaWxkLmFz RG91YmxlKCkpKSk7CisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICB9CisgICAg ICAgICAgICBpZiAoY2hpbGQuaXNCb29sZWFuKCkpIHsKKyAgICAgICAgICAgICAgICBzZXRDb25z dGFudChub2RlLCBKU1ZhbHVlKGNoaWxkLmFzQm9vbGVhbigpKSk7CisgICAgICAgICAgICAgICAg YnJlYWs7CisgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICAgICAgCiAgICAgICAgIGZvck5v ZGUobm9kZSkuc2V0VHlwZShTcGVjSW50MzIpOwo=