122252 2013-10-02 18:01:20 -0700 AX: Facebook wrapped a file upload button in an unfocusable ARIA button, which doesn't work with AXPress. 2013-10-07 08:08:51 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 jcraig cfleizach aboxhall apinheiro cfleizach commit-queue dmazzoni jcraig jdiggs mario webkit-bug-importer oldest_to_newest 935626 0 jcraig 2013-10-02 18:01:20 -0700 AX: Facebook wrapped a file upload button in an unfocusable ARIA button, which doesn't work with AXPress. It's dumb that Facebook does this, but we should probably still work around it in WebKit. If a File upload button is included in a custom ARIA button, either have WebKit ignore the ARIA button (just expose the native field to the AX API), or have WebKit expose the contents of the button (usually buttons children are presentational), or have AXPress on the ARIA button traverse down the DOM tree to the native element. I don't have a preference for one solution or the other. 935627 1 jcraig 2013-10-02 18:01:31 -0700 <rdar://problem/15132298> 935628 2 213219 jcraig 2013-10-02 18:03:11 -0700 Created attachment 213219 test case demonstrating bug 936378 3 213406 cfleizach 2013-10-04 14:55:51 -0700 Created attachment 213406 patch 936384 4 commit-queue 2013-10-04 15:00:32 -0700 Attachment 213406 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/accessibility/axpress-on-aria-button-expected.txt', u'LayoutTests/accessibility/axpress-on-aria-button.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AccessibilityNodeObject.cpp']" exit_code: 1 Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1001: Non-label code inside switch statements should be indented. [whitespace/indent] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 936415 5 213415 cfleizach 2013-10-04 16:18:41 -0700 Created attachment 213415 patch 937046 6 213415 commit-queue 2013-10-07 08:08:48 -0700 Comment on attachment 213415 patch Clearing flags on attachment: 213415 Committed r157038: <http://trac.webkit.org/changeset/157038> 937047 7 commit-queue 2013-10-07 08:08:51 -0700 All reviewed patches have been landed. Closing bug. 213219 2013-10-02 18:03:11 -0700 2013-10-02 18:03:11 -0700 test case demonstrating bug 15132298.htm text/html 849 jcraig PHRhYmxlIGNsYXNzPSJ1aUdyaWQgXzUxbXogZmJUYWJHcmlkIF9lYiBfNWYwbiIgY2VsbHNwYWNp bmc9IjAiIGNlbGxwYWRkaW5nPSIwIj4KCTx0Ym9keT4KCQk8dHIgY2xhc3M9Il81MW14Ij4KCQkJ PHRkIGNsYXNzPSJfNTFtLSBwYXMgYm9yZGVySXRlbSI+CgkJCQk8ZGl2IGNsYXNzPSJfNmEgX20g ZmJUYWJHcmlkSXRlbSIgaWQ9InVfZl8xIj4KCQkJCQk8YSBjbGFzcz0icHZtIGZiVGFiR3JpZEl0 ZW0iIHJlbD0iaWdub3JlIiBpZD0idV9mXzIiIHJvbGU9ImJ1dHRvbiI+CgkJCQkJCTxkaXYgY2xh c3M9InRpdGxlIGZzbCBmd2IgZmNiIj5VcGxvYWQgUGhvdG9zL1ZpZGVvPC9kaXY+CgkJCQkJCTxk aXYgY2xhc3M9Il8zamsiPjxpbnB1dCB0eXBlPSJmaWxlIiBjbGFzcz0iX24gXzVmMHYiIHRpdGxl PSJDaG9vc2UgYSBmaWxlIHRvIHVwbG9hZCIgbXVsdGlwbGU9IjEiIG5hbWU9ImNvbXBvc2VyX3Vu cHVibGlzaGVkX3Bob3RvW10iIGlkPSJqc18xOCI+PC9kaXY+CgkJCQkJPC9hPgoJCQkJPC9kaXY+ CgkJCTwvdGQ+CgkJCTx0ZCBjbGFzcz0iXzUxbS0gcGFzIF81MW13Ij4KCQkJCTxkaXYgY2xhc3M9 ImZsYXNoVXBsb2FkZXJPdmVybGF5QnV0dG9uIHN0YXRfZWxlbSBfMWRzbiIgaWQ9InVfZl81Ij4K CQkJCQk8YSBjbGFzcz0icHZtIGZiVGFiR3JpZEl0ZW0gZmx1cGxvYWRlcl9zZWxlY3QiIGhyZWY9 IiMiIGlkPSJ1X2ZfNCIgcmVsPSJhc3luYy1wb3N0IiByb2xlPSJidXR0b24iPgoJCQkJCQk8ZGl2 IGNsYXNzPSJ0aXRsZSBmc2wgZndiIGZjYiI+Q3JlYXRlIFBob3RvIEFsYnVtPC9kaXY+CgkJCQkJ PC9hPgoJCQkJPC9kaXY+CgkJCTwvdGQ+CgkJPC90cj4KCTwvdGJvZHk+CjwvdGFibGU+ 213406 2013-10-04 14:55:51 -0700 2013-10-04 16:18:41 -0700 patch patch text/plain 6739 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NjkxMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEzLTEwLTA0ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IEZhY2Vib29rIHdy YXBwZWQgYSBmaWxlIHVwbG9hZCBidXR0b24gaW4gYW4gdW5mb2N1c2FibGUgQVJJQSBidXR0b24s IHdoaWNoIGRvZXNuJ3Qgd29yayB3aXRoIEFYUHJlc3MuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjIyNTIKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGFuIGF1dGhvciB1c2VzIGEgY29udHJvbC10 eXBlIEFSSUEgcm9sZSAobGlrZSBidXR0b24pLCBidXQgdGhlbiBoaWRlcyBhIG5hdGl2ZSBjb250 cm9sLXR5cGUgaW5zaWRlLAorICAgICAgICBBWFByZXNzIG5lZWRzIHRvIG9wZXJhdGUgb24gdGhl IGluc2lkZSBub2RlIGlmIHBvc3NpYmxlLgorCisgICAgICAgIFRlc3Q6IGFjY2Vzc2liaWxpdHkv YXhwcmVzcy1vbi1hcmlhLWJ1dHRvbi5odG1sCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0Fj Y2Vzc2liaWxpdHlOb2RlT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmlzTm9kZUFjdGlv bkVsZW1lbnQpOgorICAgICAgICAoV2ViQ29yZTo6bmF0aXZlQWN0aW9uRWxlbWVudCk6CisgICAg ICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5Tm9kZU9iamVjdDo6YWN0aW9uRWxlbWVudCk6CisK IDIwMTMtMTAtMDQgIFJhbHBoIFRob21hcyAgPHJhbHBodEBnbWFpbC5jb20+CiAKICAgICAgICAg SW5zZXJ0aW5nIGEgSlMgZ2VuZXJhdGVkIGtleWZyYW1lIGFuaW1hdGlvbiBzaG91bGRuJ3QgdHJp Z2dlciBhIHdob2xlIGRvY3VtZW50IHN0eWxlIHJlY2FsYwpJbmRleDogU291cmNlL1dlYkNvcmUv YWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5Tm9kZU9iamVjdC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5Tm9kZU9iamVjdC5jcHAJ KHJldmlzaW9uIDE1Njg5MykKKysrIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNz aWJpbGl0eU5vZGVPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05NDYsMzEgKzk0Niw0OSBA QAogICAgIHJldHVybiAwOwogfQogCitzdGF0aWMgYm9vbCBpc05vZGVBY3Rpb25FbGVtZW50KE5v ZGUqIG5vZGUpCit7CisgICAgaWYgKGlzSFRNTElucHV0RWxlbWVudChub2RlKSkgeworICAgICAg ICBIVE1MSW5wdXRFbGVtZW50KiBpbnB1dCA9IHRvSFRNTElucHV0RWxlbWVudChub2RlKTsKKyAg ICAgICAgaWYgKCFpbnB1dC0+aXNEaXNhYmxlZEZvcm1Db250cm9sKCkgJiYgKGlucHV0LT5pc1Jh ZGlvQnV0dG9uKCkgfHwgaW5wdXQtPmlzQ2hlY2tib3goKSB8fCBpbnB1dC0+aXNUZXh0QnV0dG9u KCkgfHwgaW5wdXQtPmlzRmlsZVVwbG9hZCgpIHx8IGlucHV0LT5pc0ltYWdlQnV0dG9uKCkpKQor ICAgICAgICAgICAgcmV0dXJuIHRydWU7CisgICAgfSBlbHNlIGlmIChub2RlLT5oYXNUYWdOYW1l KGJ1dHRvblRhZykgfHwgbm9kZS0+aGFzVGFnTmFtZShzZWxlY3RUYWcpKQorICAgICAgICByZXR1 cm4gdHJ1ZTsKKworICAgIHJldHVybiBmYWxzZTsKK30KKyAgICAKK3N0YXRpYyBFbGVtZW50KiBu YXRpdmVBY3Rpb25FbGVtZW50KE5vZGUqIHN0YXJ0KQoreworICAgIGlmICghc3RhcnQpCisgICAg ICAgIHJldHVybiAwOworICAgIAorICAgIC8vIERvIGEgZGVlcC1kaXZlIHRvIHNlZSBpZiBhbnkg bm9kZXMgc2hvdWxkIGJlIHVzZWQgYXMgdGhlIGFjdGlvbiBlbGVtZW50LgorICAgIC8vIFdlIGhh dmUgdG8gbG9vayBhdCBOb2Rlcywgc2luY2UgdGhpcyBtZXRob2Qgc2hvdWxkIG9ubHkgYmUgY2Fs bGVkIG9uIG9iamVjdHMgdGhhdCBkbyBub3QgaGF2ZSBjaGlsZHJlbiAobGlrZSBidXR0b25zKS4K KyAgICAvLyBJdCBzb2x2ZXMgdGhlIHByb2JsZW0gd2hlbiBhdXRob3JzIHB1dCByb2xlPSJidXR0 b24iIG9uIGEgZ3JvdXAgYW5kIGxlYXZlIHRoZSBhY3R1YWwgYnV0dG9uIGluc2lkZSB0aGUgZ3Jv dXAuCisgICAgCisgICAgZm9yIChOb2RlKiBjaGlsZCA9IHN0YXJ0LT5maXJzdENoaWxkKCk7IGNo aWxkOyBjaGlsZCA9IGNoaWxkLT5uZXh0U2libGluZygpKSB7CisgICAgICAgIGlmIChpc05vZGVB Y3Rpb25FbGVtZW50KGNoaWxkKSkKKyAgICAgICAgICAgIHJldHVybiB0b0VsZW1lbnQoY2hpbGQp OworCisgICAgICAgIGlmIChFbGVtZW50KiBzdWJDaGlsZCA9IG5hdGl2ZUFjdGlvbkVsZW1lbnQo Y2hpbGQpKQorICAgICAgICAgICAgcmV0dXJuIHN1YkNoaWxkOworICAgIH0KKyAgICByZXR1cm4g MDsKK30KKyAgICAKIEVsZW1lbnQqIEFjY2Vzc2liaWxpdHlOb2RlT2JqZWN0OjphY3Rpb25FbGVt ZW50KCkgY29uc3QKIHsKICAgICBOb2RlKiBub2RlID0gdGhpcy0+bm9kZSgpOwogICAgIGlmICgh bm9kZSkKICAgICAgICAgcmV0dXJuIDA7CiAKLSAgICBpZiAoaXNIVE1MSW5wdXRFbGVtZW50KG5v ZGUpKSB7Ci0gICAgICAgIEhUTUxJbnB1dEVsZW1lbnQqIGlucHV0ID0gdG9IVE1MSW5wdXRFbGVt ZW50KG5vZGUpOwotICAgICAgICBpZiAoIWlucHV0LT5pc0Rpc2FibGVkRm9ybUNvbnRyb2woKSAm JiAoaXNDaGVja2JveE9yUmFkaW8oKSB8fCBpbnB1dC0+aXNUZXh0QnV0dG9uKCkpKQotICAgICAg ICAgICAgcmV0dXJuIGlucHV0OwotICAgIH0gZWxzZSBpZiAobm9kZS0+aGFzVGFnTmFtZShidXR0 b25UYWcpKQorICAgIGlmIChpc05vZGVBY3Rpb25FbGVtZW50KG5vZGUpKQogICAgICAgICByZXR1 cm4gdG9FbGVtZW50KG5vZGUpOwotCi0gICAgaWYgKGlzRmlsZVVwbG9hZEJ1dHRvbigpKQotICAg ICAgICByZXR1cm4gdG9FbGVtZW50KG5vZGUpOwotICAgICAgICAgICAgCisgICAgCiAgICAgaWYg KEFjY2Vzc2liaWxpdHlPYmplY3Q6OmlzQVJJQUlucHV0KGFyaWFSb2xlQXR0cmlidXRlKCkpKQog ICAgICAgICByZXR1cm4gdG9FbGVtZW50KG5vZGUpOwogCi0gICAgaWYgKGlzSW1hZ2VCdXR0b24o KSkKLSAgICAgICAgcmV0dXJuIHRvRWxlbWVudChub2RlKTsKLSAgICAKLSAgICBpZiAobm9kZS0+ aGFzVGFnTmFtZShzZWxlY3RUYWcpKQotICAgICAgICByZXR1cm4gdG9FbGVtZW50KG5vZGUpOwot CiAgICAgc3dpdGNoIChyb2xlVmFsdWUoKSkgewogICAgIGNhc2UgQnV0dG9uUm9sZToKICAgICBj YXNlIFBvcFVwQnV0dG9uUm9sZToKQEAgLTk4MCw3ICs5OTgsMTIgQEAKICAgICBjYXNlIE1lbnVJ dGVtQ2hlY2tib3hSb2xlOgogICAgIGNhc2UgTWVudUl0ZW1SYWRpb1JvbGU6CiAgICAgY2FzZSBM aXN0SXRlbVJvbGU6CisgICAgeworICAgICAgICAvLyBDaGVjayBpZiB0aGUgYXV0aG9yIGlzIGhp ZGluZyB0aGUgcmVhbCBjb250cm9sIGVsZW1lbnQgaW5zaWRlIHRoZSBBUklBIGVsZW1lbnQuCisg ICAgICAgIGlmIChFbGVtZW50KiBuYXRpdmVFbGVtZW50ID0gbmF0aXZlQWN0aW9uRWxlbWVudChu b2RlKSkKKyAgICAgICAgICAgIHJldHVybiBuYXRpdmVFbGVtZW50OwogICAgICAgICByZXR1cm4g dG9FbGVtZW50KG5vZGUpOworICAgIH0KICAgICBkZWZhdWx0OgogICAgICAgICBicmVhazsKICAg ICB9CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNTY5MTIpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJ KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMy0xMC0wNCAgQ2hyaXMgRmxlaXph Y2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgorCisgICAgICAgIEFYOiBGYWNlYm9vayB3cmFwcGVk IGEgZmlsZSB1cGxvYWQgYnV0dG9uIGluIGFuIHVuZm9jdXNhYmxlIEFSSUEgYnV0dG9uLCB3aGlj aCBkb2Vzbid0IHdvcmsgd2l0aCBBWFByZXNzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIyMjUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2F4cHJlc3Mtb24tYXJpYS1idXR0 b24tZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2F4cHJlc3Mt b24tYXJpYS1idXR0b24uaHRtbDogQWRkZWQuCisKIDIwMTMtMTAtMDQgIE9saXZlciBIdW50ICA8 b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBTdXBwb3J0IGZvci1vZiBzeW50YXgKSW5kZXg6 IExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvYXhwcmVzcy1vbi1hcmlhLWJ1dHRvbi1leHBlY3Rl ZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9heHByZXNzLW9u LWFyaWEtYnV0dG9uLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Fj Y2Vzc2liaWxpdHkvYXhwcmVzcy1vbi1hcmlhLWJ1dHRvbi1leHBlY3RlZC50eHQJKHdvcmtpbmcg Y29weSkKQEAgLTAsMCArMSwxOCBAQAorVXBsb2FkCisKK1VwbG9hZAorCitVcGxvYWQKKworVGhp cyB0ZXN0cyB0aGF0IGlmIGEgbm9uLW5hdGl2ZSBhY3Rpb24gdHlwZSBpcyBleHBvc2VkIGFzIGEg Y29udHJvbCwgdGhlbiB3ZSB3aWxsIGxvb2sgZm9yIGRlc2NlbmRhbnRzIHRvIGNhbGwgcHJlc3Mo KSBvbi4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNz YWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1ByZXNzIHBlcmZvcm1lZCBv biBmaWxldXBsb2FkCitQcmVzcyBwZXJmb3JtZWQgb24gYnV0dG9uCitQcmVzcyBwZXJmb3JtZWQg b24gY2hlY2tib3gKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01Q TEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2F4cHJlc3Mtb24tYXJpYS1i dXR0b24uaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2F4cHJl c3Mtb24tYXJpYS1idXR0b24uaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2FjY2Vz c2liaWxpdHkvYXhwcmVzcy1vbi1hcmlhLWJ1dHRvbi5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0w LDAgKzEsNDQgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQgc3Jj PSIuLi9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+ CisKKzxhIGlkPSJidXR0b24xIiByb2xlPSJidXR0b24iPgorICAgPGRpdj5VcGxvYWQ8L2Rpdj4K KyAgIDxkaXY+PGlucHV0IHR5cGU9ImZpbGUiIG9uY2xpY2s9InByZXNzUGVyZm9ybWVkKHRoaXMp OyIgdGl0bGU9IkNob29zZSBhIGZpbGUgdG8gdXBsb2FkIiBtdWx0aXBsZT0iMSIgaWQ9ImZpbGV1 cGxvYWQiPjwvZGl2PgorPC9hPgorCis8YSBpZD0iYnV0dG9uMiIgcm9sZT0iYnV0dG9uIj4KKyAg IDxkaXY+VXBsb2FkPC9kaXY+CisgICA8ZGl2PjxidXR0b24gb25jbGljaz0icHJlc3NQZXJmb3Jt ZWQodGhpcyk7IiBpZD0iYnV0dG9uIj48L2Rpdj4KKzwvYT4KKworPGEgaWQ9ImJ1dHRvbjMiIHJv bGU9ImJ1dHRvbiI+CisgICA8ZGl2PlVwbG9hZDwvZGl2PgorICAgPGRpdj48aW5wdXQgdHlwZT0i Y2hlY2tib3giIG9uY2xpY2s9InByZXNzUGVyZm9ybWVkKHRoaXMpOyBmaW5pc2hKU1Rlc3QoKTsi IGlkPSJjaGVja2JveCI+PC9kaXY+Cis8L2E+CisKKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgor PGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CisKKzxzY3JpcHQ+CisgICAgZGVzY3JpcHRpb24oIlRo aXMgdGVzdHMgdGhhdCBpZiBhIG5vbi1uYXRpdmUgYWN0aW9uIHR5cGUgaXMgZXhwb3NlZCBhcyBh IGNvbnRyb2wsIHRoZW4gd2Ugd2lsbCBsb29rIGZvciBkZXNjZW5kYW50cyB0byBjYWxsIHByZXNz KCkgb24uIik7CisgICAgCisgICAgZnVuY3Rpb24gcHJlc3NQZXJmb3JtZWQoZWxlbWVudCkgewor ICAgICAgICBkZWJ1ZygiUHJlc3MgcGVyZm9ybWVkIG9uICIgKyBlbGVtZW50LmdldEF0dHJpYnV0 ZSgiaWQiKSk7CisgICAgfQorCisgICAgd2luZG93LmpzVGVzdElzQXN5bmMgPSB0cnVlOworICAg IGlmICh3aW5kb3cuYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIpIHsKKyAgICAgICAgZm9yICh2YXIg ayA9IDE7IGsgPD0gMzsgaysrKSB7CisgICAgICAgICAgICB2YXIgYnV0dG9uID0gYWNjZXNzaWJp bGl0eUNvbnRyb2xsZXIuYWNjZXNzaWJsZUVsZW1lbnRCeUlkKCJidXR0b24iICsgayk7CisgICAg ICAgICAgICBidXR0b24ucHJlc3MoKTsKKyAgICAgICAgfQorICAgIH0KKzwvc2NyaXB0PgorCis8 c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2Jv ZHk+Cis8L2h0bWw+Cg== 213415 2013-10-04 16:18:41 -0700 2013-10-07 08:08:48 -0700 patch patch text/plain 6717 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NjkxMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEzLTEwLTA0ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IEZhY2Vib29rIHdy YXBwZWQgYSBmaWxlIHVwbG9hZCBidXR0b24gaW4gYW4gdW5mb2N1c2FibGUgQVJJQSBidXR0b24s IHdoaWNoIGRvZXNuJ3Qgd29yayB3aXRoIEFYUHJlc3MuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjIyNTIKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGFuIGF1dGhvciB1c2VzIGEgY29udHJvbC10 eXBlIEFSSUEgcm9sZSAobGlrZSBidXR0b24pLCBidXQgdGhlbiBoaWRlcyBhIG5hdGl2ZSBjb250 cm9sLXR5cGUgaW5zaWRlLAorICAgICAgICBBWFByZXNzIG5lZWRzIHRvIG9wZXJhdGUgb24gdGhl IGluc2lkZSBub2RlIGlmIHBvc3NpYmxlLgorCisgICAgICAgIFRlc3Q6IGFjY2Vzc2liaWxpdHkv YXhwcmVzcy1vbi1hcmlhLWJ1dHRvbi5odG1sCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0Fj Y2Vzc2liaWxpdHlOb2RlT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmlzTm9kZUFjdGlv bkVsZW1lbnQpOgorICAgICAgICAoV2ViQ29yZTo6bmF0aXZlQWN0aW9uRWxlbWVudCk6CisgICAg ICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5Tm9kZU9iamVjdDo6YWN0aW9uRWxlbWVudCk6CisK IDIwMTMtMTAtMDQgIFJhbHBoIFRob21hcyAgPHJhbHBodEBnbWFpbC5jb20+CiAKICAgICAgICAg SW5zZXJ0aW5nIGEgSlMgZ2VuZXJhdGVkIGtleWZyYW1lIGFuaW1hdGlvbiBzaG91bGRuJ3QgdHJp Z2dlciBhIHdob2xlIGRvY3VtZW50IHN0eWxlIHJlY2FsYwpJbmRleDogU291cmNlL1dlYkNvcmUv YWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5Tm9kZU9iamVjdC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5Tm9kZU9iamVjdC5jcHAJ KHJldmlzaW9uIDE1Njg5MykKKysrIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNz aWJpbGl0eU5vZGVPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05NDYsMzEgKzk0Niw0OSBA QAogICAgIHJldHVybiAwOwogfQogCitzdGF0aWMgYm9vbCBpc05vZGVBY3Rpb25FbGVtZW50KE5v ZGUqIG5vZGUpCit7CisgICAgaWYgKGlzSFRNTElucHV0RWxlbWVudChub2RlKSkgeworICAgICAg ICBIVE1MSW5wdXRFbGVtZW50KiBpbnB1dCA9IHRvSFRNTElucHV0RWxlbWVudChub2RlKTsKKyAg ICAgICAgaWYgKCFpbnB1dC0+aXNEaXNhYmxlZEZvcm1Db250cm9sKCkgJiYgKGlucHV0LT5pc1Jh ZGlvQnV0dG9uKCkgfHwgaW5wdXQtPmlzQ2hlY2tib3goKSB8fCBpbnB1dC0+aXNUZXh0QnV0dG9u KCkgfHwgaW5wdXQtPmlzRmlsZVVwbG9hZCgpIHx8IGlucHV0LT5pc0ltYWdlQnV0dG9uKCkpKQor ICAgICAgICAgICAgcmV0dXJuIHRydWU7CisgICAgfSBlbHNlIGlmIChub2RlLT5oYXNUYWdOYW1l KGJ1dHRvblRhZykgfHwgbm9kZS0+aGFzVGFnTmFtZShzZWxlY3RUYWcpKQorICAgICAgICByZXR1 cm4gdHJ1ZTsKKworICAgIHJldHVybiBmYWxzZTsKK30KKyAgICAKK3N0YXRpYyBFbGVtZW50KiBu YXRpdmVBY3Rpb25FbGVtZW50KE5vZGUqIHN0YXJ0KQoreworICAgIGlmICghc3RhcnQpCisgICAg ICAgIHJldHVybiAwOworICAgIAorICAgIC8vIERvIGEgZGVlcC1kaXZlIHRvIHNlZSBpZiBhbnkg bm9kZXMgc2hvdWxkIGJlIHVzZWQgYXMgdGhlIGFjdGlvbiBlbGVtZW50LgorICAgIC8vIFdlIGhh dmUgdG8gbG9vayBhdCBOb2Rlcywgc2luY2UgdGhpcyBtZXRob2Qgc2hvdWxkIG9ubHkgYmUgY2Fs bGVkIG9uIG9iamVjdHMgdGhhdCBkbyBub3QgaGF2ZSBjaGlsZHJlbiAobGlrZSBidXR0b25zKS4K KyAgICAvLyBJdCBzb2x2ZXMgdGhlIHByb2JsZW0gd2hlbiBhdXRob3JzIHB1dCByb2xlPSJidXR0 b24iIG9uIGEgZ3JvdXAgYW5kIGxlYXZlIHRoZSBhY3R1YWwgYnV0dG9uIGluc2lkZSB0aGUgZ3Jv dXAuCisgICAgCisgICAgZm9yIChOb2RlKiBjaGlsZCA9IHN0YXJ0LT5maXJzdENoaWxkKCk7IGNo aWxkOyBjaGlsZCA9IGNoaWxkLT5uZXh0U2libGluZygpKSB7CisgICAgICAgIGlmIChpc05vZGVB Y3Rpb25FbGVtZW50KGNoaWxkKSkKKyAgICAgICAgICAgIHJldHVybiB0b0VsZW1lbnQoY2hpbGQp OworCisgICAgICAgIGlmIChFbGVtZW50KiBzdWJDaGlsZCA9IG5hdGl2ZUFjdGlvbkVsZW1lbnQo Y2hpbGQpKQorICAgICAgICAgICAgcmV0dXJuIHN1YkNoaWxkOworICAgIH0KKyAgICByZXR1cm4g MDsKK30KKyAgICAKIEVsZW1lbnQqIEFjY2Vzc2liaWxpdHlOb2RlT2JqZWN0OjphY3Rpb25FbGVt ZW50KCkgY29uc3QKIHsKICAgICBOb2RlKiBub2RlID0gdGhpcy0+bm9kZSgpOwogICAgIGlmICgh bm9kZSkKICAgICAgICAgcmV0dXJuIDA7CiAKLSAgICBpZiAoaXNIVE1MSW5wdXRFbGVtZW50KG5v ZGUpKSB7Ci0gICAgICAgIEhUTUxJbnB1dEVsZW1lbnQqIGlucHV0ID0gdG9IVE1MSW5wdXRFbGVt ZW50KG5vZGUpOwotICAgICAgICBpZiAoIWlucHV0LT5pc0Rpc2FibGVkRm9ybUNvbnRyb2woKSAm JiAoaXNDaGVja2JveE9yUmFkaW8oKSB8fCBpbnB1dC0+aXNUZXh0QnV0dG9uKCkpKQotICAgICAg ICAgICAgcmV0dXJuIGlucHV0OwotICAgIH0gZWxzZSBpZiAobm9kZS0+aGFzVGFnTmFtZShidXR0 b25UYWcpKQorICAgIGlmIChpc05vZGVBY3Rpb25FbGVtZW50KG5vZGUpKQogICAgICAgICByZXR1 cm4gdG9FbGVtZW50KG5vZGUpOwotCi0gICAgaWYgKGlzRmlsZVVwbG9hZEJ1dHRvbigpKQotICAg ICAgICByZXR1cm4gdG9FbGVtZW50KG5vZGUpOwotICAgICAgICAgICAgCisgICAgCiAgICAgaWYg KEFjY2Vzc2liaWxpdHlPYmplY3Q6OmlzQVJJQUlucHV0KGFyaWFSb2xlQXR0cmlidXRlKCkpKQog ICAgICAgICByZXR1cm4gdG9FbGVtZW50KG5vZGUpOwogCi0gICAgaWYgKGlzSW1hZ2VCdXR0b24o KSkKLSAgICAgICAgcmV0dXJuIHRvRWxlbWVudChub2RlKTsKLSAgICAKLSAgICBpZiAobm9kZS0+ aGFzVGFnTmFtZShzZWxlY3RUYWcpKQotICAgICAgICByZXR1cm4gdG9FbGVtZW50KG5vZGUpOwot CiAgICAgc3dpdGNoIChyb2xlVmFsdWUoKSkgewogICAgIGNhc2UgQnV0dG9uUm9sZToKICAgICBj YXNlIFBvcFVwQnV0dG9uUm9sZToKQEAgLTk4MCw2ICs5OTgsOSBAQAogICAgIGNhc2UgTWVudUl0 ZW1DaGVja2JveFJvbGU6CiAgICAgY2FzZSBNZW51SXRlbVJhZGlvUm9sZToKICAgICBjYXNlIExp c3RJdGVtUm9sZToKKyAgICAgICAgLy8gQ2hlY2sgaWYgdGhlIGF1dGhvciBpcyBoaWRpbmcgdGhl IHJlYWwgY29udHJvbCBlbGVtZW50IGluc2lkZSB0aGUgQVJJQSBlbGVtZW50LgorICAgICAgICBp ZiAoRWxlbWVudCogbmF0aXZlRWxlbWVudCA9IG5hdGl2ZUFjdGlvbkVsZW1lbnQobm9kZSkpCisg ICAgICAgICAgICByZXR1cm4gbmF0aXZlRWxlbWVudDsKICAgICAgICAgcmV0dXJuIHRvRWxlbWVu dChub2RlKTsKICAgICBkZWZhdWx0OgogICAgICAgICBicmVhazsKSW5kZXg6IExheW91dFRlc3Rz L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9u IDE1NjkxMikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDEzLTEwLTA0ICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5j b20+CisKKyAgICAgICAgQVg6IEZhY2Vib29rIHdyYXBwZWQgYSBmaWxlIHVwbG9hZCBidXR0b24g aW4gYW4gdW5mb2N1c2FibGUgQVJJQSBidXR0b24sIHdoaWNoIGRvZXNuJ3Qgd29yayB3aXRoIEFY UHJlc3MuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MjIyNTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGFjY2Vzc2liaWxpdHkvYXhwcmVzcy1vbi1hcmlhLWJ1dHRvbi1leHBlY3RlZC50eHQ6IEFkZGVk LgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvYXhwcmVzcy1vbi1hcmlhLWJ1dHRvbi5odG1sOiBB ZGRlZC4KKwogMjAxMy0xMC0wNCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAg ICAgICAgIFN1cHBvcnQgZm9yLW9mIHN5bnRheApJbmRleDogTGF5b3V0VGVzdHMvYWNjZXNzaWJp bGl0eS9heHByZXNzLW9uLWFyaWEtYnV0dG9uLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2F4cHJlc3Mtb24tYXJpYS1idXR0b24tZXhwZWN0ZWQu dHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9heHByZXNzLW9u LWFyaWEtYnV0dG9uLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDE4IEBA CitVcGxvYWQKKworVXBsb2FkCisKK1VwbG9hZAorCitUaGlzIHRlc3RzIHRoYXQgaWYgYSBub24t bmF0aXZlIGFjdGlvbiB0eXBlIGlzIGV4cG9zZWQgYXMgYSBjb250cm9sLCB0aGVuIHdlIHdpbGwg bG9vayBmb3IgZGVzY2VuZGFudHMgdG8gY2FsbCBwcmVzcygpIG9uLgorCitPbiBzdWNjZXNzLCB5 b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVT VCBDT01QTEVURSIuCisKKworUHJlc3MgcGVyZm9ybWVkIG9uIGZpbGV1cGxvYWQKK1ByZXNzIHBl cmZvcm1lZCBvbiBidXR0b24KK1ByZXNzIHBlcmZvcm1lZCBvbiBjaGVja2JveAorUEFTUyBzdWNj ZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6IExheW91dFRl c3RzL2FjY2Vzc2liaWxpdHkvYXhwcmVzcy1vbi1hcmlhLWJ1dHRvbi5odG1sCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvYXhwcmVzcy1vbi1hcmlhLWJ1dHRvbi5odG1s CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9heHByZXNzLW9uLWFy aWEtYnV0dG9uLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw0NCBAQAorPCFET0NUWVBF IGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uL3Jlc291cmNlcy9qcy10ZXN0 LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKworPGEgaWQ9ImJ1dHRvbjEiIHJv bGU9ImJ1dHRvbiI+CisgICA8ZGl2PlVwbG9hZDwvZGl2PgorICAgPGRpdj48aW5wdXQgdHlwZT0i ZmlsZSIgb25jbGljaz0icHJlc3NQZXJmb3JtZWQodGhpcyk7IiB0aXRsZT0iQ2hvb3NlIGEgZmls ZSB0byB1cGxvYWQiIG11bHRpcGxlPSIxIiBpZD0iZmlsZXVwbG9hZCI+PC9kaXY+Cis8L2E+CisK KzxhIGlkPSJidXR0b24yIiByb2xlPSJidXR0b24iPgorICAgPGRpdj5VcGxvYWQ8L2Rpdj4KKyAg IDxkaXY+PGJ1dHRvbiBvbmNsaWNrPSJwcmVzc1BlcmZvcm1lZCh0aGlzKTsiIGlkPSJidXR0b24i PjwvZGl2PgorPC9hPgorCis8YSBpZD0iYnV0dG9uMyIgcm9sZT0iYnV0dG9uIj4KKyAgIDxkaXY+ VXBsb2FkPC9kaXY+CisgICA8ZGl2PjxpbnB1dCB0eXBlPSJjaGVja2JveCIgb25jbGljaz0icHJl c3NQZXJmb3JtZWQodGhpcyk7IGZpbmlzaEpTVGVzdCgpOyIgaWQ9ImNoZWNrYm94Ij48L2Rpdj4K KzwvYT4KKworPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rp dj4KKworPHNjcmlwdD4KKyAgICBkZXNjcmlwdGlvbigiVGhpcyB0ZXN0cyB0aGF0IGlmIGEgbm9u LW5hdGl2ZSBhY3Rpb24gdHlwZSBpcyBleHBvc2VkIGFzIGEgY29udHJvbCwgdGhlbiB3ZSB3aWxs IGxvb2sgZm9yIGRlc2NlbmRhbnRzIHRvIGNhbGwgcHJlc3MoKSBvbi4iKTsKKyAgICAKKyAgICBm dW5jdGlvbiBwcmVzc1BlcmZvcm1lZChlbGVtZW50KSB7CisgICAgICAgIGRlYnVnKCJQcmVzcyBw ZXJmb3JtZWQgb24gIiArIGVsZW1lbnQuZ2V0QXR0cmlidXRlKCJpZCIpKTsKKyAgICB9CisKKyAg ICB3aW5kb3cuanNUZXN0SXNBc3luYyA9IHRydWU7CisgICAgaWYgKHdpbmRvdy5hY2Nlc3NpYmls aXR5Q29udHJvbGxlcikgeworICAgICAgICBmb3IgKHZhciBrID0gMTsgayA8PSAzOyBrKyspIHsK KyAgICAgICAgICAgIHZhciBidXR0b24gPSBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5hY2Nlc3Np YmxlRWxlbWVudEJ5SWQoImJ1dHRvbiIgKyBrKTsKKyAgICAgICAgICAgIGJ1dHRvbi5wcmVzcygp OworICAgICAgICB9CisgICAgfQorPC9zY3JpcHQ+CisKKzxzY3JpcHQgc3JjPSIuLi9yZXNvdXJj ZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K