122244 2013-10-02 16:09:06 -0700 Make Baseline JIT exception handling work like the DFG JIT 2013-11-05 09:08:53 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 116888 1 msaboff msaboff fpizlo ggaren mark.lam oldest_to_newest 935591 0 msaboff 2013-10-02 16:09:06 -0700 The DFG JIT emits common exception code calling lookupExceptionHandler() for exceptions that are checked in generated code. The Baseline JIT should do the same think. This is in preparation for changing JIT Stubs being changed to JITOperations called via CCallHelpers code. 935593 1 213212 msaboff 2013-10-02 16:23:41 -0700 Created attachment 213212 Patch 935595 2 msaboff 2013-10-02 16:25:13 -0700 This patch was reviewed by Filip Pizlo in person. 935604 3 msaboff 2013-10-02 16:32:31 -0700 Committed r156810: <http://trac.webkit.org/changeset/156810> 947215 4 213212 ossy 2013-11-05 09:08:53 -0800 Comment on attachment 213212 Patch Cleared review? from attachment 213212 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 213212 2013-10-02 16:23:41 -0700 2013-11-05 09:08:53 -0800 Patch 122244.patch text/plain 3670 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU2ODA1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDEzLTEwLTAyICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIE1ha2UgQmFzZWxpbmUgSklUIGV4Y2VwdGlvbiBoYW5kbGluZyB3b3JrIGxpa2UgdGhlIERG RyBKSVQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy MjI0NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFk ZGVkIGEganVtcCBsaXN0IChtX2V4Y2VwdGlvbkNoZWNrcykgdG8gSklUIGFzIGEgY29tbW9uIHBs YWNlIGZvciBleGNlcHRpb24gcHJvY2Vzc2luZyB3aXRoaW4KKyAgICAgICAgZ2VuZXJhdGVkIGNv ZGUuICBBZGRlZCBleGNlcHRpb25DaGVjaygpIGhlbHBlcnMgdGhhdCBjaGVjayBmb3IgYW4gZXhj ZXB0aW9uIHdoaWNoIGFkZCBhIGJyYW5jaAorICAgICAgICB0byB0aGUgbGlzdC4KKworICAgICAg ICAqIGppdC9KSVQuY3BwOgorICAgICAgICAoSlNDOjpKSVQ6OnByaXZhdGVDb21waWxlKToKKyAg ICAgICAgKEpTQzo6SklUOjpwcml2YXRlQ29tcGlsZUV4Y2VwdGlvbkhhbmRsZXJzKToKKyAgICAg ICAgKiBqaXQvSklULmg6CisgICAgICAgIChKU0M6OkpJVDo6ZXhjZXB0aW9uQ2hlY2spOgorCiAy MDEzLTEwLTAyICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgRml4 IE1TVkMgYnVpbGQKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklULmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVC5jcHAJKHJldmlzaW9uIDE1 Njc5NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklULmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMzgsNiArMzgsNyBAQCBKU0M6Ok1hY3JvQXNzZW1ibGVyWDg2Q29tbW9uOjpTU0UyQ2hl Y2tTCiAjaW5jbHVkZSAiREZHQ2FwYWJpbGl0aWVzLmgiCiAjaW5jbHVkZSAiSW50ZXJwcmV0ZXIu aCIKICNpbmNsdWRlICJKSVRJbmxpbmVzLmgiCisjaW5jbHVkZSAiSklUT3BlcmF0aW9ucy5oIgog I2luY2x1ZGUgIkpJVFN0dWJDYWxsLmgiCiAjaW5jbHVkZSAiSlNBcnJheS5oIgogI2luY2x1ZGUg IkpTRnVuY3Rpb24uaCIKQEAgLTY2Myw2ICs2NjQsOCBAQCBDb21waWxhdGlvblJlc3VsdCBKSVQ6 OnByaXZhdGVDb21waWxlKEpJCiAKICAgICBBU1NFUlQobV9qbXBUYWJsZS5pc0VtcHR5KCkpOwog ICAgIAorICAgIHByaXZhdGVDb21waWxlRXhjZXB0aW9uSGFuZGxlcnMoKTsKKyAgICAKICAgICBp ZiAobV9kaXNhc3NlbWJsZXIpCiAgICAgICAgIG1fZGlzYXNzZW1ibGVyLT5zZXRFbmRPZkNvZGUo bGFiZWwoKSk7CiAKQEAgLTgxNiw2ICs4MTksMjYgQEAgdm9pZCBKSVQ6OmxpbmtTbG93Q2FsbChD b2RlQmxvY2sqIGNhbGxlcgogICAgIHJlcGF0Y2hCdWZmZXIucmVsaW5rKGNhbGxMaW5rSW5mby0+ Y2FsbFJldHVybkxvY2F0aW9uLCBjYWxsZXJDb2RlQmxvY2stPnZtKCktPmdldENUSVN0dWIob2xk U3R5bGVWaXJ0dWFsQ2FsbEdlbmVyYXRvcikuY29kZSgpKTsKIH0KIAordm9pZCBKSVQ6OnByaXZh dGVDb21waWxlRXhjZXB0aW9uSGFuZGxlcnMoKQoreworICAgIGlmIChtX2V4Y2VwdGlvbkNoZWNr cy5lbXB0eSgpKQorICAgICAgICByZXR1cm47CisgICAgCisgICAgbV9leGNlcHRpb25DaGVja3Mu bGluayh0aGlzKTsKKyAgICAKKyAgICAvLyBsb29rdXBFeGNlcHRpb25IYW5kbGVyIGlzIHBhc3Nl ZCBvbmUgYXJndW1lbnQsIHRoZSBleGVjICh0aGUgQ2FsbEZyYW1lKikuCisgICAgbW92ZShHUFJJ bmZvOjpjYWxsRnJhbWVSZWdpc3RlciwgR1BSSW5mbzo6YXJndW1lbnRHUFIwKTsKKyNpZiBDUFUo WDg2KQorICAgIC8vIEZJWE1FOiBzaG91bGQgdXNlIHRoZSBjYWxsIGFic3RyYWN0aW9uLCBidXQg dGhpcyBpcyBjdXJyZW50bHkgaW4gdGhlIFNwZWN1bGF0aXZlSklUIGxheWVyIQorICAgIHBva2Uo R1BSSW5mbzo6YXJndW1lbnRHUFIwKTsKKyNlbmRpZgorICAgIG1fY2FsbHMuYXBwZW5kKENhbGxS ZWNvcmQoY2FsbCgpLCAodW5zaWduZWQpLTEsIEZ1bmN0aW9uUHRyKGxvb2t1cEV4Y2VwdGlvbkhh bmRsZXIpLnZhbHVlKCkpKTsKKyAgICAvLyBsb29rdXBFeGNlcHRpb25IYW5kbGVyIGxlYXZlcyB0 aGUgaGFuZGxlciBDYWxsRnJhbWUqIGluIHRoZSByZXR1cm5WYWx1ZUdQUiwKKyAgICAvLyBhbmQg dGhlIGFkZHJlc3Mgb2YgdGhlIGhhbmRsZXIgaW4gcmV0dXJuVmFsdWVHUFIyLgorICAgIGp1bXAo R1BSSW5mbzo6cmV0dXJuVmFsdWVHUFIyKTsKK30KKworCiB9IC8vIG5hbWVzcGFjZSBKU0MKIAog I2VuZGlmIC8vIEVOQUJMRShKSVQpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJ VC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklULmgJKHJldmlz aW9uIDE1Njc5NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklULmgJKHdvcmtpbmcg Y29weSkKQEAgLTQyMSw2ICs0MjEsMTggQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIENvZGVS ZWYgcHJpdmF0ZUNvbXBpbGVDVElOYXRpdmVDYWxsKFZNKiwgTmF0aXZlRnVuY3Rpb24pOwogICAg ICAgICB2b2lkIHByaXZhdGVDb21waWxlUGF0Y2hHZXRBcnJheUxlbmd0aChSZXR1cm5BZGRyZXNz UHRyIHJldHVybkFkZHJlc3MpOwogCisgICAgICAgIHZvaWQgZXhjZXB0aW9uQ2hlY2soSnVtcCBq dW1wVG9IYW5kbGVyKQorICAgICAgICB7CisgICAgICAgICAgICBtX2V4Y2VwdGlvbkNoZWNrcy5h cHBlbmQoanVtcFRvSGFuZGxlcik7CisgICAgICAgIH0KKworICAgICAgICB2b2lkIGV4Y2VwdGlv bkNoZWNrKCkKKyAgICAgICAgeworICAgICAgICAgICAgbV9leGNlcHRpb25DaGVja3MuYXBwZW5k KGVtaXRFeGNlcHRpb25DaGVjaygpKTsKKyAgICAgICAgfQorCisgICAgICAgIHZvaWQgcHJpdmF0 ZUNvbXBpbGVFeGNlcHRpb25IYW5kbGVycygpOworCiAgICAgICAgIHN0YXRpYyBib29sIGlzRGly ZWN0UHV0QnlJZChTdHJ1Y3R1cmVTdHViSW5mbyopOwogCiAgICAgICAgIHZvaWQgYWRkU2xvd0Nh c2UoSnVtcCk7CkBAIC05MDIsNiArOTE0LDggQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIFZl Y3RvcjxTbG93Q2FzZUVudHJ5PiBtX3Nsb3dDYXNlczsKICAgICAgICAgVmVjdG9yPFN3aXRjaFJl Y29yZD4gbV9zd2l0Y2hlczsKIAorICAgICAgICBKdW1wTGlzdCBtX2V4Y2VwdGlvbkNoZWNrczsK KwogICAgICAgICB1bnNpZ25lZCBtX3Byb3BlcnR5QWNjZXNzSW5zdHJ1Y3Rpb25JbmRleDsKICAg ICAgICAgdW5zaWduZWQgbV9ieVZhbEluc3RydWN0aW9uSW5kZXg7CiAgICAgICAgIHVuc2lnbmVk IG1fY2FsbExpbmtJbmZvSW5kZXg7Cg==