122236 2013-10-02 13:38:50 -0700 [CSS Shapes] Move ShapeInsideInfo::updateSegmentsForLine implementations into the cpp 2013-10-02 14:42:55 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 89256 1 zoltan zoltan commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 935524 0 zoltan 2013-10-02 13:38:50 -0700 There is no reason for updateSegmentsForLine methods to be inline. I moved them to the cpp. 935527 1 213193 zoltan 2013-10-02 13:41:24 -0700 Created attachment 213193 proposed patch 935555 2 213193 commit-queue 2013-10-02 14:42:53 -0700 Comment on attachment 213193 proposed patch Clearing flags on attachment: 213193 Committed r156798: <http://trac.webkit.org/changeset/156798> 935556 3 commit-queue 2013-10-02 14:42:55 -0700 All reviewed patches have been landed. Closing bug. 213193 2013-10-02 13:41:24 -0700 2013-10-02 14:42:53 -0700 proposed patch movetocpp.patch text/plain 3509 zoltan ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzMzRkOGY3Li4wNzMzMTZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTMtMTAtMDIgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgW0NTUyBTaGFwZXNdIE1vdmUgU2hhcGVJbnNpZGVJbmZvOjp1cGRhdGVTZWdtZW50c0Zv ckxpbmUgaW1wbGVtZW50YXRpb25zIGludG8gdGhlIGNwcAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIyMjM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlcmUgaXMgbm8gcmVhc29uIGZvciB1cGRhdGVT ZWdtZW50c0ZvckxpbmUgbWV0aG9kcyB0byBiZSBpbmxpbmUuIEkgbW92ZWQgdGhlbSB0byB0aGUg Y3BwLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAg ICAgICogcmVuZGVyaW5nL3NoYXBlcy9TaGFwZUluc2lkZUluZm8uY3BwOgorICAgICAgICAoV2Vi Q29yZTo6U2hhcGVJbnNpZGVJbmZvOjp1cGRhdGVTZWdtZW50c0ZvckxpbmUpOgorICAgICAgICAq IHJlbmRlcmluZy9zaGFwZXMvU2hhcGVJbnNpZGVJbmZvLmg6CisKIDIwMTMtMTAtMDEgIFNhbSBX ZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBDVFRFOiBET01XcmFwcGVyV29ybGRz IHNob3VsZCBiZSBwYXNzZWQgYXJvdW5kIGJ5IHJlZmVyZW5jZQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL3NoYXBlcy9TaGFwZUluc2lkZUluZm8uY3BwIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL3NoYXBlcy9TaGFwZUluc2lkZUluZm8uY3BwCmluZGV4IGI4Y2JlZjEu LmU1NTJhZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zaGFwZXMvU2hh cGVJbnNpZGVJbmZvLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc2hhcGVzL1No YXBlSW5zaWRlSW5mby5jcHAKQEAgLTU5LDYgKzU5LDMxIEBAIGJvb2wgU2hhcGVJbnNpZGVJbmZv Ojppc0VuYWJsZWRGb3IoY29uc3QgUmVuZGVyQmxvY2sqIHJlbmRlcmVyKQogICAgIH0KIH0KIAor Ym9vbCBTaGFwZUluc2lkZUluZm86OnVwZGF0ZVNlZ21lbnRzRm9yTGluZShMYXlvdXRTaXplIGxp bmVPZmZzZXQsIExheW91dFVuaXQgbGluZUhlaWdodCkKK3sKKyAgICBtX3NlZ21lbnRSYW5nZXMu Y2xlYXIoKTsKKyAgICBib29sIHJlc3VsdCA9IHVwZGF0ZVNlZ21lbnRzRm9yTGluZShsaW5lT2Zm c2V0LmhlaWdodCgpLCBsaW5lSGVpZ2h0KTsKKyAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG1f c2VnbWVudHMuc2l6ZSgpOyBpKyspIHsKKyAgICAgICAgbV9zZWdtZW50c1tpXS5sb2dpY2FsTGVm dCAtPSBsaW5lT2Zmc2V0LndpZHRoKCk7CisgICAgICAgIG1fc2VnbWVudHNbaV0ubG9naWNhbFJp Z2h0IC09IGxpbmVPZmZzZXQud2lkdGgoKTsKKyAgICB9CisgICAgcmV0dXJuIHJlc3VsdDsKK30K KworYm9vbCBTaGFwZUluc2lkZUluZm86OnVwZGF0ZVNlZ21lbnRzRm9yTGluZShMYXlvdXRVbml0 IGxpbmVUb3AsIExheW91dFVuaXQgbGluZUhlaWdodCkKK3sKKyAgICBBU1NFUlQobGluZUhlaWdo dCA+PSAwKTsKKyAgICBtX3NoYXBlTGluZVRvcCA9IGxpbmVUb3AgLSBsb2dpY2FsVG9wT2Zmc2V0 KCk7CisgICAgbV9saW5lSGVpZ2h0ID0gbGluZUhlaWdodDsKKyAgICBtX3NlZ21lbnRzLmNsZWFy KCk7CisgICAgbV9zZWdtZW50UmFuZ2VzLmNsZWFyKCk7CisKKyAgICBpZiAobGluZU92ZXJsYXBz U2hhcGVCb3VuZHMoKSkKKyAgICAgICAgbV9zZWdtZW50cyA9IGNvbXB1dGVTZWdtZW50c0Zvckxp bmUobGluZVRvcCwgbGluZUhlaWdodCk7CisKKyAgICByZXR1cm4gbV9zZWdtZW50cy5zaXplKCk7 Cit9CisKIGJvb2wgU2hhcGVJbnNpZGVJbmZvOjphZGp1c3RMb2dpY2FsTGluZVRvcChmbG9hdCBt aW5TZWdtZW50V2lkdGgpCiB7CiAgICAgY29uc3QgU2hhcGUqIHNoYXBlID0gY29tcHV0ZWRTaGFw ZSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3NoYXBlcy9TaGFwZUlu c2lkZUluZm8uaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zaGFwZXMvU2hhcGVJbnNpZGVJ bmZvLmgKaW5kZXggODNjNjM1YS4uMDVkMDQwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL3NoYXBlcy9TaGFwZUluc2lkZUluZm8uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvc2hhcGVzL1NoYXBlSW5zaWRlSW5mby5oCkBAIC02OSwzMCArNjksOCBAQCBwdWJs aWM6CiAKICAgICBzdGF0aWMgYm9vbCBpc0VuYWJsZWRGb3IoY29uc3QgUmVuZGVyQmxvY2sqIHJl bmRlcmVyKTsKIAotICAgIGJvb2wgdXBkYXRlU2VnbWVudHNGb3JMaW5lKExheW91dFNpemUgbGlu ZU9mZnNldCwgTGF5b3V0VW5pdCBsaW5lSGVpZ2h0KQotICAgIHsKLSAgICAgICAgbV9zZWdtZW50 UmFuZ2VzLmNsZWFyKCk7Ci0gICAgICAgIGJvb2wgcmVzdWx0ID0gdXBkYXRlU2VnbWVudHNGb3JM aW5lKGxpbmVPZmZzZXQuaGVpZ2h0KCksIGxpbmVIZWlnaHQpOwotICAgICAgICBmb3IgKHNpemVf dCBpID0gMDsgaSA8IG1fc2VnbWVudHMuc2l6ZSgpOyBpKyspIHsKLSAgICAgICAgICAgIG1fc2Vn bWVudHNbaV0ubG9naWNhbExlZnQgLT0gbGluZU9mZnNldC53aWR0aCgpOwotICAgICAgICAgICAg bV9zZWdtZW50c1tpXS5sb2dpY2FsUmlnaHQgLT0gbGluZU9mZnNldC53aWR0aCgpOwotICAgICAg ICB9Ci0gICAgICAgIHJldHVybiByZXN1bHQ7Ci0gICAgfQotCi0gICAgYm9vbCB1cGRhdGVTZWdt ZW50c0ZvckxpbmUoTGF5b3V0VW5pdCBsaW5lVG9wLCBMYXlvdXRVbml0IGxpbmVIZWlnaHQpCi0g ICAgewotICAgICAgICBBU1NFUlQobGluZUhlaWdodCA+PSAwKTsKLSAgICAgICAgbV9zaGFwZUxp bmVUb3AgPSBsaW5lVG9wIC0gbG9naWNhbFRvcE9mZnNldCgpOwotICAgICAgICBtX2xpbmVIZWln aHQgPSBsaW5lSGVpZ2h0OwotICAgICAgICBtX3NlZ21lbnRzLmNsZWFyKCk7Ci0gICAgICAgIG1f c2VnbWVudFJhbmdlcy5jbGVhcigpOwotCi0gICAgICAgIGlmIChsaW5lT3ZlcmxhcHNTaGFwZUJv dW5kcygpKQotICAgICAgICAgICAgbV9zZWdtZW50cyA9IGNvbXB1dGVTZWdtZW50c0ZvckxpbmUo bGluZVRvcCwgbGluZUhlaWdodCk7Ci0KLSAgICAgICAgcmV0dXJuIG1fc2VnbWVudHMuc2l6ZSgp OwotICAgIH0KKyAgICBib29sIHVwZGF0ZVNlZ21lbnRzRm9yTGluZShMYXlvdXRTaXplIGxpbmVP ZmZzZXQsIExheW91dFVuaXQgbGluZUhlaWdodCk7CisgICAgYm9vbCB1cGRhdGVTZWdtZW50c0Zv ckxpbmUoTGF5b3V0VW5pdCBsaW5lVG9wLCBMYXlvdXRVbml0IGxpbmVIZWlnaHQpOwogCiAgICAg Ym9vbCBoYXNTZWdtZW50cygpIGNvbnN0CiAgICAgewo=