122168 2013-10-01 11:55:50 -0700 Consolidate multiple OSRExit calls into one. 2013-10-01 14:25:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 nrotem webkit-unassigned commit-queue fpizlo ggaren oldest_to_newest 935117 0 nrotem 2013-10-01 11:55:50 -0700 Consolidate multiple OSRExit calls into one. 935118 1 213105 nrotem 2013-10-01 11:56:29 -0700 Created attachment 213105 Patch 935121 2 213105 fpizlo 2013-10-01 12:06:42 -0700 Comment on attachment 213105 Patch r=me. 935184 3 nrotem 2013-10-01 13:52:18 -0700 should I cc commit-queue ? 935185 4 fpizlo 2013-10-01 14:02:12 -0700 (In reply to comment #3) > should I cc commit-queue ? You can set 'cq' to '?', and then a committer can set cq+. I presume you want to commit so I will set cq+ for you. The convention is that if a patch is sitting without cq? then it shouldn't be landed, under the assumption that the patch author is still doing some additional tests. But if the patch author sets cq?, then any committer can set cq+ to auto-land it, or land it themselves. 935199 5 213105 commit-queue 2013-10-01 14:25:13 -0700 Comment on attachment 213105 Patch Clearing flags on attachment: 213105 Committed r156734: <http://trac.webkit.org/changeset/156734> 935200 6 commit-queue 2013-10-01 14:25:16 -0700 All reviewed patches have been landed. Closing bug. 213105 2013-10-01 11:56:29 -0700 2013-10-01 14:25:13 -0700 Patch bug-122168-20131001115628.patch text/plain 3971 nrotem U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2NzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj MGFjZDZiN2Q3ZTRjMTMzNzVmZGUxYzgxNDJhMjVmMjNkMGMyNGUzLi5kZGU1N2Q1NmE0ZWU4OTVh MDNjMzIwNzA5NDkzYmE2NmFmOTE2NjI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxMy0xMC0wMSAgTmFkYXYgUm90ZW0gIDxucm90ZW1AYXBwbGUuY29tPgor CisgICAgICAgIENvbnNvbGlkYXRlIG11bHRpcGxlIE9TUkV4aXQgY2FsbHMgaW50byBvbmUuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjIxNjgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZ0bC9GVExM b3dlckRGR1RvTExWTS5jcHA6CisgICAgICAgIChKU0M6OkZUTDo6TG93ZXJERkdUb0xMVk06OmNv bXBpbGVBcml0aE11bCk6CisgICAgICAgIChKU0M6OkZUTDo6TG93ZXJERkdUb0xMVk06OmNvbXBp bGVBcml0aERpdik6CisgICAgICAgIChKU0M6OkZUTDo6TG93ZXJERkdUb0xMVk06OmNvbXBpbGVB cml0aE1vZCk6CisKIDIwMTMtMTAtMDEgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29t PgogCiAgICAgICAgIFtpT1NdIEphdmFTY3JpcHRDb3JlIGZhaWxzIHRvIGJ1aWxkIHdpdGggbmV3 ZXIgdmVyc2lvbnMgb2YgY2xhbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9m dGwvRlRMTG93ZXJERkdUb0xMVk0uY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExM b3dlckRGR1RvTExWTS5jcHAKaW5kZXggN2JkYzRhY2Y2Yjc3N2NmY2YxOTJlZDA2NDdiZTFkMzhm YjIzN2Y3MC4uY2EyOGJhNjc5YWFhOGU0ODAxNTBkZDcxYmJiNzcxYTg0MGFkYTkwMCAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvTExWTS5jcHAKKysr IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvTExWTS5jcHAKQEAgLTcz MCw4ICs3MzAsOCBAQCBwcml2YXRlOgogICAgICAgICAgICAgICAgIG1fb3V0LmJyYW5jaChtX291 dC5ub3RaZXJvMzIocmVzdWx0KSwgY29udGludWF0aW9uLCBzbG93Q2FzZSk7CiAgICAgICAgICAg ICAgICAgCiAgICAgICAgICAgICAgICAgTEJhc2ljQmxvY2sgbGFzdE5leHQgPSBtX291dC5hcHBl bmRUbyhzbG93Q2FzZSwgY29udGludWF0aW9uKTsKLSAgICAgICAgICAgICAgICBzcGVjdWxhdGUo TmVnYXRpdmVaZXJvLCBub1ZhbHVlKCksIDAsIG1fb3V0Lmxlc3NUaGFuKGxlZnQsIG1fb3V0Lmlu dDMyWmVybykpOwotICAgICAgICAgICAgICAgIHNwZWN1bGF0ZShOZWdhdGl2ZVplcm8sIG5vVmFs dWUoKSwgMCwgbV9vdXQubGVzc1RoYW4ocmlnaHQsIG1fb3V0LmludDMyWmVybykpOworICAgICAg ICAgICAgICAgIExWYWx1ZSBjb25kID0gbV9vdXQuYml0T3IobV9vdXQubGVzc1RoYW4obGVmdCwg bV9vdXQuaW50MzJaZXJvKSwgbV9vdXQubGVzc1RoYW4ocmlnaHQsIG1fb3V0LmludDMyWmVybykp OworICAgICAgICAgICAgICAgIHNwZWN1bGF0ZShOZWdhdGl2ZVplcm8sIG5vVmFsdWUoKSwgMCwg Y29uZCk7CiAgICAgICAgICAgICAgICAgbV9vdXQuanVtcChjb250aW51YXRpb24pOwogICAgICAg ICAgICAgICAgIG1fb3V0LmFwcGVuZFRvKGNvbnRpbnVhdGlvbiwgbGFzdE5leHQpOwogICAgICAg ICAgICAgfQpAQCAtNzU2LDggKzc1Niw4IEBAIHByaXZhdGU6CiAgICAgICAgICAgICAgICAgbV9v dXQuYnJhbmNoKG1fb3V0Lm5vdFplcm82NChyZXN1bHQpLCBjb250aW51YXRpb24sIHNsb3dDYXNl KTsKICAgICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICBMQmFzaWNCbG9jayBsYXN0TmV4 dCA9IG1fb3V0LmFwcGVuZFRvKHNsb3dDYXNlLCBjb250aW51YXRpb24pOwotICAgICAgICAgICAg ICAgIHNwZWN1bGF0ZShOZWdhdGl2ZVplcm8sIG5vVmFsdWUoKSwgMCwgbV9vdXQubGVzc1RoYW4o bGVmdCwgbV9vdXQuaW50NjRaZXJvKSk7Ci0gICAgICAgICAgICAgICAgc3BlY3VsYXRlKE5lZ2F0 aXZlWmVybywgbm9WYWx1ZSgpLCAwLCBtX291dC5sZXNzVGhhbihyaWdodCwgbV9vdXQuaW50NjRa ZXJvKSk7CisgICAgICAgICAgICAgICAgTFZhbHVlIGNvbmQgPSBtX291dC5iaXRPcihtX291dC5s ZXNzVGhhbihsZWZ0LCBtX291dC5pbnQ2NFplcm8pLCBtX291dC5sZXNzVGhhbihyaWdodCwgbV9v dXQuaW50NjRaZXJvKSk7CisgICAgICAgICAgICAgICAgc3BlY3VsYXRlKE5lZ2F0aXZlWmVybywg bm9WYWx1ZSgpLCAwLCBjb25kKTsKICAgICAgICAgICAgICAgICBtX291dC5qdW1wKGNvbnRpbnVh dGlvbik7CiAgICAgICAgICAgICAgICAgbV9vdXQuYXBwZW5kVG8oY29udGludWF0aW9uLCBsYXN0 TmV4dCk7CiAgICAgICAgICAgICB9CkBAIC04MDAsOCArODAwLDggQEAgcHJpdmF0ZToKICAgICAg ICAgICAgIExWYWx1ZSBuZWcyVG9UaGUzMSA9IG1fb3V0LmNvbnN0SW50MzIoLTIxNDc0ODM2NDct MSk7CiAgICAgICAgICAgICAKICAgICAgICAgICAgIGlmIChieXRlY29kZVVzZXNBc051bWJlciht X25vZGUtPmFyaXRoTm9kZUZsYWdzKCkpKSB7Ci0gICAgICAgICAgICAgICAgc3BlY3VsYXRlKE92 ZXJmbG93LCBub1ZhbHVlKCksIDAsIG1fb3V0LmlzWmVybzMyKGRlbm9taW5hdG9yKSk7Ci0gICAg ICAgICAgICAgICAgc3BlY3VsYXRlKE92ZXJmbG93LCBub1ZhbHVlKCksIDAsIG1fb3V0LmVxdWFs KG51bWVyYXRvciwgbmVnMlRvVGhlMzEpKTsKKyAgICAgICAgICAgICAgICBMVmFsdWUgY29uZCA9 IG1fb3V0LmJpdE9yKG1fb3V0LmlzWmVybzMyKGRlbm9taW5hdG9yKSwgbV9vdXQuZXF1YWwobnVt ZXJhdG9yLCBuZWcyVG9UaGUzMSkpOworICAgICAgICAgICAgICAgIHNwZWN1bGF0ZShPdmVyZmxv dywgbm9WYWx1ZSgpLCAwLCBjb25kKTsKICAgICAgICAgICAgICAgICBtX291dC5qdW1wKGNvbnRp bnVhdGlvbik7CiAgICAgICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgICAgIC8vIFRoaXMg aXMgdGhlIGNhc2Ugd2hlcmUgd2UgY29udmVydCB0aGUgcmVzdWx0IHRvIGFuIGludCBhZnRlciB3 ZSdyZSBkb25lLiBTbywKQEAgLTg5OCw4ICs4OTgsOCBAQCBwcml2YXRlOgogICAgICAgICAgICAg Ly8gRklYTUU6IC0yXjMxIC8gLTEgd2lsbCBhY3R1YWxseSB5aWVsZCBuZWdhdGl2ZSB6ZXJvLCBz byB3ZSBjb3VsZCBoYXZlIGEKICAgICAgICAgICAgIC8vIHNlcGFyYXRlIGNhc2UgZm9yIHRoYXQu IEJ1dCBpdCBwcm9iYWJseSBkb2Vzbid0IG1hdHRlciBzbyBtdWNoLgogICAgICAgICAgICAgaWYg KGJ5dGVjb2RlVXNlc0FzTnVtYmVyKG1fbm9kZS0+YXJpdGhOb2RlRmxhZ3MoKSkpIHsKLSAgICAg ICAgICAgICAgICBzcGVjdWxhdGUoT3ZlcmZsb3csIG5vVmFsdWUoKSwgMCwgbV9vdXQuaXNaZXJv MzIoZGVub21pbmF0b3IpKTsKLSAgICAgICAgICAgICAgICBzcGVjdWxhdGUoT3ZlcmZsb3csIG5v VmFsdWUoKSwgMCwgbV9vdXQuZXF1YWwobnVtZXJhdG9yLCBuZWcyVG9UaGUzMSkpOworICAgICAg ICAgICAgICAgIExWYWx1ZSBjb25kID0gbV9vdXQuYml0T3IobV9vdXQuaXNaZXJvMzIoZGVub21p bmF0b3IpLCBtX291dC5lcXVhbChudW1lcmF0b3IsIG5lZzJUb1RoZTMxKSk7CisgICAgICAgICAg ICAgICAgc3BlY3VsYXRlKE92ZXJmbG93LCBub1ZhbHVlKCksIDAsIGNvbmQpOwogICAgICAgICAg ICAgICAgIG1fb3V0Lmp1bXAoY29udGludWF0aW9uKTsKICAgICAgICAgICAgIH0gZWxzZSB7CiAg ICAgICAgICAgICAgICAgLy8gVGhpcyBpcyB0aGUgY2FzZSB3aGVyZSB3ZSBjb252ZXJ0IHRoZSBy ZXN1bHQgdG8gYW4gaW50IGFmdGVyIHdlJ3JlIGRvbmUuIFNvLAo=