122161 2013-10-01 09:06:40 -0700 [iOS] WebCore fails to build with newer versions of clang 2013-10-01 09:39:07 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dbates dbates ddkilzer mrowe oldest_to_newest 935040 0 dbates 2013-10-01 09:06:40 -0700 Make WebCore build with newer versions of clang. 935046 1 213090 dbates 2013-10-01 09:13:08 -0700 Created attachment 213090 Patch 935050 2 213090 darin 2013-10-01 09:22:40 -0700 Comment on attachment 213090 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213090&action=review > Source/WebCore/platform/network/mac/ResourceResponseMac.mm:97 > +static const size_t numberOfCommonHeaderFields = sizeof(commonHeaderFields) / sizeof(AtomicString*); Would be much nicer to use the WTF_ARRAY_LENGTH macro instead and not give a name to this. The code here actually divides the size of the array by the size of a pointer to a different type! > Source/WebCore/platform/network/mac/ResourceResponseMac.mm:135 > + for (size_t i = 0; i < numberOfCommonHeaderFields; i++) { Would just say: for (unsigned i = 0; i < WTF_ARRAY_LENGTH(commonHeaderFields); ++i) 935056 3 dbates 2013-10-01 09:30:32 -0700 (In reply to comment #2) > (From update of attachment 213090 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=213090&action=review > > > Source/WebCore/platform/network/mac/ResourceResponseMac.mm:97 > > +static const size_t numberOfCommonHeaderFields = sizeof(commonHeaderFields) / sizeof(AtomicString*); > > Would be much nicer to use the WTF_ARRAY_LENGTH macro instead and not give a name to this. The code here actually divides the size of the array by the size of a pointer to a different type! > Oops! You're right. > > Source/WebCore/platform/network/mac/ResourceResponseMac.mm:135 > > + for (size_t i = 0; i < numberOfCommonHeaderFields; i++) { > > Would just say: > > for (unsigned i = 0; i < WTF_ARRAY_LENGTH(commonHeaderFields); ++i) Will fix. 935060 4 dbates 2013-10-01 09:39:07 -0700 Committed r156715: <http://trac.webkit.org/changeset/156715> 213090 2013-10-01 09:13:08 -0700 2013-10-01 09:22:39 -0700 Patch bug-122161-20131001091308.patch text/plain 6259 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2NzExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2JkOTVjYjE4OWE2NjQ3 NjZlNjdmNzBjNGVmNjhhZDg4YzEyOTEyOC4uMDdmZmE4YjBkZTUwNmViNjI2MjQ2Nzg5ZWU5MGEw Y2M4MGFhMmIyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTEwLTAxICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBXZWJDb3JlIGZh aWxzIHRvIGJ1aWxkIHdpdGggbmV3ZXIgdmVyc2lvbnMgb2YgY2xhbmcKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMjE2MQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZWRpdGluZy9GcmFtZVNlbGVjdGlv bi5jcHA6IEFkZCBFTkFCTEUoVEVYVF9DQVJFVCktZ3VhcmQgYXJvdW5kIHNob3VsZFN0b3BCbGlu a2luZ0R1ZVRvVHlwaW5nQ29tbWFuZCgpLgorICAgICAgICAqIHBhZ2UvRXZlbnRIYW5kbGVyLmNw cDogQWRkICFQTEFURk9STShJT1MpLWd1YXJkIGFyb3VuZCBjb25zdGFudHMgY3Vyc29yVXBkYXRl SW50ZXJ2YWwgYW5kIG1heGltdW1DdXJzb3JTaXplOworICAgICAgICBhbHNvIGFkZCB0b3VjaCBl dmVudC9nZXN0dXJlIGV2ZW50IGd1YXJkIGFyb3VuZCBzaG91bGRHZXN0dXJlc1RyaWdnZXJBY3Rp dmUoKS4KKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2NmL1Jlc291cmNlUmVzcG9uc2VDRk5l dC5jcHA6IFJlbW92ZSB1bnVzZWQgZnVuY3Rpb24gZmlsZW5hbWVIYXNTYW5lRXh0ZW5zaW9uLgor ICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlUmVzcG9uc2VNYWMubW06IE9u bHkgZGVmaW5lIHN0YXRpYyB2YXJpYWJsZXMgY29tbW9uSGVhZGVyRmllbGRzIGFuZCBudW1Db21t b25IZWFkZXJGaWVsZHMKKyAgICAgICAgd2hlbiBidWlsZGluZyB3aXRob3V0IENGTmV0d29yazsg YWxzbyByZW5hbWUgbnVtQ29tbW9uSGVhZGVyRmllbGRzIHRvIG51bWJlck9mQ29tbW9uSGVhZGVy RmllbGRzIGFuZCBjaGFuZ2UKKyAgICAgICAgaXRzIGRhdGEgdHlwZSBmcm9tIGludCB0byBzaXpl X3Qgc2luY2UgaXQgY2FuIG5ldmVyIHJlcHJlc2VudCBhIG5lZ2F0aXZlIHZhbHVlLgorCiAyMDEz LTEwLTAxICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgog CiAgICAgICAgIFtUZXhtYXBdIENTUyBmaWx0ZXIgbm90IHdvcmtpbmcgb24gc29mdHdhcmUgY29t cG9zaXRlZCBsYXllcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVT ZWxlY3Rpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHAK aW5kZXggODY1NjZjMzQzMWMxY2IyMzQxOTIyZTIxZDRiZWJlMmFmNzA5MTkyNC4uNzE3MmJiYThj OGQxMzI2OWJjZWIzYTA5YzJiZDMwODg5NWYxNDc4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGlu Zy9GcmFtZVNlbGVjdGlvbi5jcHAKQEAgLTE3NDYsMTAgKzE3NDYsMTIgQEAgYm9vbCBGcmFtZVNl bGVjdGlvbjo6aXNGb2N1c2VkQW5kQWN0aXZlKCkgY29uc3QKICAgICByZXR1cm4gbV9mb2N1c2Vk ICYmIG1fZnJhbWUtPnBhZ2UoKSAmJiBtX2ZyYW1lLT5wYWdlKCktPmZvY3VzQ29udHJvbGxlcigp LmlzQWN0aXZlKCk7CiB9CiAKKyNpZiBFTkFCTEUoVEVYVF9DQVJFVCkKIGlubGluZSBzdGF0aWMg Ym9vbCBzaG91bGRTdG9wQmxpbmtpbmdEdWVUb1R5cGluZ0NvbW1hbmQoRnJhbWUqIGZyYW1lKQog ewogICAgIHJldHVybiBmcmFtZS0+ZWRpdG9yKCkubGFzdEVkaXRDb21tYW5kKCkgJiYgZnJhbWUt PmVkaXRvcigpLmxhc3RFZGl0Q29tbWFuZCgpLT5zaG91bGRTdG9wQ2FyZXRCbGlua2luZygpOwog fQorI2VuZGlmCiAKIHZvaWQgRnJhbWVTZWxlY3Rpb246OnVwZGF0ZUFwcGVhcmFuY2UoKQogewpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwIGIvU291cmNl L1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCmluZGV4IGZlYTUwZDU5ZjEyZTUzYzEwOTdm NWEyOTA2MGUyMmE3ZGYzNmM0ODYuLmNkYjkzMzM3NGIwZDEwYjliM2ZhNTg2YThjYzE0NWJkODNk MTVlNWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKQEAgLTE0NiwxMSArMTQ2 LDE0IEBAIGNvbnN0IGRvdWJsZSBmYWtlTW91c2VNb3ZlRHVyYXRpb25UaHJlc2hvbGQgPSAwLjAx OwogY29uc3QgZG91YmxlIGZha2VNb3VzZU1vdmVTaG9ydEludGVydmFsID0gMC4xOwogY29uc3Qg ZG91YmxlIGZha2VNb3VzZU1vdmVMb25nSW50ZXJ2YWwgPSAwLjI1OwogCisjaWYgIVBMQVRGT1JN KElPUykKIC8vIFRoZSBhbW91bnQgb2YgdGltZSB0byB3YWl0IGZvciBhIGN1cnNvciB1cGRhdGUg b24gc3R5bGUgYW5kIGxheW91dCBjaGFuZ2VzCiAvLyBTZXQgdG8gNTBIeiwgbm8gbmVlZCB0byBi ZSBmYXN0ZXIgdGhhbiBjb21tb24gc2NyZWVuIHJlZnJlc2ggcmF0ZQogY29uc3QgZG91YmxlIGN1 cnNvclVwZGF0ZUludGVydmFsID0gMC4wMjsKIAogY29uc3QgaW50IG1heGltdW1DdXJzb3JTaXpl ID0gMTI4OworI2VuZGlmCisKICNpZiBFTkFCTEUoTU9VU0VfQ1VSU09SX1NDQUxFKQogLy8gSXQn cyBwcmV0dHkgdW5saWtlbHkgdGhhdCBhIHNjYWxlIG9mIGxlc3MgdGhhbiBvbmUgd291bGQgZXZl ciBiZSB1c2VkLiBCdXQgYWxsIHdlIHJlYWxseQogLy8gbmVlZCB0byBlbnN1cmUgaGVyZSBpcyB0 aGF0IHRoZSBzY2FsZSBpc24ndCBzbyBzbWFsbCB0aGF0IGludGVnZXIgb3ZlcmZsb3cgY2FuIG9j Y3VyIHdoZW4KQEAgLTI4Myw2ICsyODYsNyBAQCBzdGF0aWMgaW5saW5lIGJvb2wgc2Nyb2xsTm9k ZShmbG9hdCBkZWx0YSwgU2Nyb2xsR3JhbnVsYXJpdHkgZ3JhbnVsYXJpdHksIFNjcm9sbAogICAg IHJldHVybiBlbmNsb3NpbmdCb3gtPnNjcm9sbChkZWx0YSA8IDAgPyBuZWdhdGl2ZURpcmVjdGlv biA6IHBvc2l0aXZlRGlyZWN0aW9uLCBncmFudWxhcml0eSwgYWJzRGVsdGEsIHN0b3BFbGVtZW50 KTsKIH0KIAorI2lmIChFTkFCTEUoVE9VQ0hfRVZFTlRTKSAmJiAhUExBVEZPUk0oSU9TKSkgfHwg RU5BQkxFKEdFU1RVUkVfRVZFTlRTKQogc3RhdGljIGlubGluZSBib29sIHNob3VsZEdlc3R1cmVz VHJpZ2dlckFjdGl2ZSgpCiB7CiAgICAgLy8gSWYgdGhlIHBsYXRmb3JtIHdlJ3JlIG9uIHN1cHBv cnRzIEdlc3R1cmVUYXBEb3duIGFuZCBHZXN0dXJlVGFwQ2FuY2VsIHRoZW4gd2UnbGwKQEAgLTI5 MCw2ICsyOTQsNyBAQCBzdGF0aWMgaW5saW5lIGJvb2wgc2hvdWxkR2VzdHVyZXNUcmlnZ2VyQWN0 aXZlKCkKICAgICAvLyBrbm93IGluIGFkdmFuY2Ugd2hhdCBldmVudCB0eXBlcyBhcmUgc3VwcG9y dGVkLgogICAgIHJldHVybiBmYWxzZTsKIH0KKyNlbmRpZgogCiAjaWYgIVBMQVRGT1JNKE1BQykK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9SZXNvdXJj ZVJlc3BvbnNlQ0ZOZXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9S ZXNvdXJjZVJlc3BvbnNlQ0ZOZXQuY3BwCmluZGV4IDJkNmNlMzNjY2I3NmNhNmI1NmEyYTM0ZjAw NDc1ODliNDA1NDE1YTYuLjIwNzhmZTIzYzk4NTI0NTk0MWRhODY5NmI3MTFkODQwZjMwNDIwMGIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvUmVzb3VyY2VS ZXNwb25zZUNGTmV0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2Nm L1Jlc291cmNlUmVzcG9uc2VDRk5ldC5jcHAKQEAgLTYwLDE1ICs2MCw2IEBAIENGVVJMUmVzcG9u c2VSZWYgUmVzb3VyY2VSZXNwb25zZTo6Y2ZVUkxSZXNwb25zZSgpIGNvbnN0CiAgICAgcmV0dXJu IG1fY2ZSZXNwb25zZS5nZXQoKTsKIH0KIAotc3RhdGljIGlubGluZSBib29sIGZpbGVuYW1lSGFz U2FuZUV4dGVuc2lvbihjb25zdCBTdHJpbmcmIGZpbGVuYW1lKQotewotICAgIGludCBkb3QgPSBm aWxlbmFtZS5maW5kKCcuJyk7Ci0KLSAgICAvLyBUaGUgZG90IGNhbid0IGJlIHRoZSBmaXJzdCBv ciBsYXN0IGNoYXJhY3RlciBpbiB0aGUgZmlsZW5hbWUuCi0gICAgaW50IGxlbmd0aCA9IGZpbGVu YW1lLmxlbmd0aCgpOwotICAgIHJldHVybiBkb3QgPiAwICYmIGRvdCA8IGxlbmd0aCAtIDE7Ci19 Ci0KIHZvaWQgUmVzb3VyY2VSZXNwb25zZTo6cGxhdGZvcm1MYXp5SW5pdChJbml0TGV2ZWwgaW5p dExldmVsKQogewogICAgIGlmIChtX2luaXRMZXZlbCA+IGluaXRMZXZlbCkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlUmVzcG9uc2VNYWMu bW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJjZVJlc3BvbnNl TWFjLm1tCmluZGV4IDk3ZmNmODdmNTNiNmM0ZmE2MjExZmI3NGE1MzZkYWU5OTBiZjE1ZDkuLjc3 Yjg3NTM5ZjMxZjNmMDhhOTAzZDUzYmMyY2ZmNmQ0ZjYzNmU0YTYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlUmVzcG9uc2VNYWMubW0KKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9tYWMvUmVzb3VyY2VSZXNwb25zZU1h Yy5tbQpAQCAtNDUsMTEgKzQ1LDYgQEAgdXNpbmcgbmFtZXNwYWNlIHN0ZDsKIAogbmFtZXNwYWNl IFdlYkNvcmUgewogCi1zdGF0aWMgTlNTdHJpbmcqIGNvbnN0IGNvbW1vbkhlYWRlckZpZWxkc1td ID0gewotICAgIEAiQWdlIiwgQCJDYWNoZS1Db250cm9sIiwgQCJDb250ZW50LVR5cGUiLCBAIkRh dGUiLCBAIkV0YWciLCBAIkV4cGlyZXMiLCBAIkxhc3QtTW9kaWZpZWQiLCBAIlByYWdtYSIKLX07 Ci1zdGF0aWMgY29uc3QgaW50IG51bUNvbW1vbkhlYWRlckZpZWxkcyA9IHNpemVvZihjb21tb25I ZWFkZXJGaWVsZHMpIC8gc2l6ZW9mKEF0b21pY1N0cmluZyopOwotCiB2b2lkIFJlc291cmNlUmVz cG9uc2U6OmluaXROU1VSTFJlc3BvbnNlKCkgY29uc3QKIHsKICAgICAvLyBXb3JrIGFyb3VuZCBh IG1pc3Rha2UgaW4gdGhlIE5TVVJMUmVzcG9uc2UgY2xhc3MgLSA8cmRhcjovL3Byb2JsZW0vNjg3 NTIxOT4uCkBAIC05Niw2ICs5MSwxMSBAQCBSZXNvdXJjZVJlc3BvbnNlOjpSZXNvdXJjZVJlc3Bv bnNlKE5TVVJMUmVzcG9uc2UqIG5zUmVzcG9uc2UpCiAKICNlbHNlCiAKK3N0YXRpYyBOU1N0cmlu ZyogY29uc3QgY29tbW9uSGVhZGVyRmllbGRzW10gPSB7CisgICAgQCJBZ2UiLCBAIkNhY2hlLUNv bnRyb2wiLCBAIkNvbnRlbnQtVHlwZSIsIEAiRGF0ZSIsIEAiRXRhZyIsIEAiRXhwaXJlcyIsIEAi TGFzdC1Nb2RpZmllZCIsIEAiUHJhZ21hIgorfTsKK3N0YXRpYyBjb25zdCBzaXplX3QgbnVtYmVy T2ZDb21tb25IZWFkZXJGaWVsZHMgPSBzaXplb2YoY29tbW9uSGVhZGVyRmllbGRzKSAvIHNpemVv ZihBdG9taWNTdHJpbmcqKTsKKwogTlNVUkxSZXNwb25zZSAqUmVzb3VyY2VSZXNwb25zZTo6bnNV UkxSZXNwb25zZSgpIGNvbnN0CiB7CiAgICAgaWYgKCFtX25zUmVzcG9uc2UgJiYgIW1faXNOdWxs KQpAQCAtMTMyLDcgKzEzMiw3IEBAIHZvaWQgUmVzb3VyY2VSZXNwb25zZTo6cGxhdGZvcm1MYXp5 SW5pdChJbml0TGV2ZWwgaW5pdExldmVsKQogCiAgICAgICAgICAgICBOU0RpY3Rpb25hcnkgKmhl YWRlcnMgPSBbaHR0cFJlc3BvbnNlIGFsbEhlYWRlckZpZWxkc107CiAgICAgICAgICAgICAKLSAg ICAgICAgICAgIGZvciAoaW50IGkgPSAwOyBpIDwgbnVtQ29tbW9uSGVhZGVyRmllbGRzOyBpKysp IHsKKyAgICAgICAgICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgbnVtYmVyT2ZDb21tb25IZWFk ZXJGaWVsZHM7IGkrKykgewogICAgICAgICAgICAgICAgIGlmIChOU1N0cmluZyogaGVhZGVyVmFs dWUgPSBbaGVhZGVycyBvYmplY3RGb3JLZXk6Y29tbW9uSGVhZGVyRmllbGRzW2ldXSkKICAgICAg ICAgICAgICAgICAgICAgbV9odHRwSGVhZGVyRmllbGRzLnNldChbY29tbW9uSGVhZGVyRmllbGRz W2ldIFVURjhTdHJpbmddLCBoZWFkZXJWYWx1ZSk7CiAgICAgICAgICAgICB9Cg==