122158 2013-10-01 06:46:57 -0700 [CURL] Rename URL type variables in Curl network backend 2013-10-01 10:02:44 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 davidsz webkit-unassigned bfulgham commit-queue galpeter oldest_to_newest 935001 0 davidsz 2013-10-01 06:46:57 -0700 Some variable does not match with the URL class name, this patch will rename these. 935002 1 213080 davidsz 2013-10-01 06:49:22 -0700 Created attachment 213080 Patch 935004 2 213081 davidsz 2013-10-01 06:55:58 -0700 Created attachment 213081 Fixed patch 935072 3 213081 commit-queue 2013-10-01 10:02:42 -0700 Comment on attachment 213081 Fixed patch Clearing flags on attachment: 213081 Committed r156717: <http://trac.webkit.org/changeset/156717> 935073 4 commit-queue 2013-10-01 10:02:44 -0700 All reviewed patches have been landed. Closing bug. 213080 2013-10-01 06:49:22 -0700 2013-10-01 06:54:07 -0700 Patch rename_kurl.diff text/plain 3334 davidsz ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4NGIzMjkwLi5mZTBlNWRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTMtMTAtMDEgIFN6YWJvbGNzIETDoXZpZCAgPGRhdmlkc3pAaW5mLnUtc3plZ2VkLmh1 PgorCisgICAgICAgIFJlbmFtZSBVUkwgdHlwZSB2YXJpYWJsZXMgaW4gQ3VybCBuZXR3b3JrIGJh Y2tlbmQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MjIxNTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJ IGNoYW5nZWQgdGhlIG5hbWUgb2YgdGhlIFVSTCBvYmplY3RzIHRvIG1hdGNoIHdpdGggdGhlIG5l dyBjbGFzcyBuYW1lLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNl SGFuZGxlTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpnZXRQcm90ZWN0aW9uU3BhY2Up OgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGVNYW5hZ2VyOjppbml0aWFsaXplSGFu ZGxlKToKKwogMjAxMy0xMC0wMSAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcu Y29tPgogCiAgICAgICAgIEdlbmVyYXRlIHRvQ1NTRm9vVmFsdWUgZm9yIENTU1ByaW1pdGl2ZVZh bHVlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVz b3VyY2VIYW5kbGVNYW5hZ2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv Y3VybC9SZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3BwCmluZGV4IDdkZDViNmEuLjJkODVhMTEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhh bmRsZU1hbmFnZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3Vy bC9SZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3BwCkBAIC0zMDYsMTUgKzMwNiwxNSBAQCBzdGF0aWMg Ym9vbCBnZXRQcm90ZWN0aW9uU3BhY2UoQ1VSTCogaCwgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYg cmVzcG9uc2UsIFByb3RlYwogICAgIGlmIChlcnIgIT0gQ1VSTEVfT0spCiAgICAgICAgIHJldHVy biBmYWxzZTsKIAotICAgIGNvbnN0IGNoYXIqIHVybCA9IDA7Ci0gICAgZXJyID0gY3VybF9lYXN5 X2dldGluZm8oaCwgQ1VSTElORk9fRUZGRUNUSVZFX1VSTCwgJnVybCk7CisgICAgY29uc3QgY2hh ciogZWZmZWN0aXZlVXJsID0gMDsKKyAgICBlcnIgPSBjdXJsX2Vhc3lfZ2V0aW5mbyhoLCBDVVJM SU5GT19FRkZFQ1RJVkVfVVJMLCAmZWZmZWN0aXZlVXJsKTsKICAgICBpZiAoZXJyICE9IENVUkxF X09LKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICBVUkwga3VybChQYXJzZWRVUkxTdHJp bmcsIHVybCk7CisgICAgVVJMIHVybChQYXJzZWRVUkxTdHJpbmcsIHVybCk7CiAKLSAgICBTdHJp bmcgaG9zdCA9IGt1cmwuaG9zdCgpOwotICAgIFN0cmluZyBwcm90b2NvbCA9IGt1cmwucHJvdG9j b2woKTsKKyAgICBTdHJpbmcgaG9zdCA9IHVybC5ob3N0KCk7CisgICAgU3RyaW5nIHByb3RvY29s ID0gdXJsLnByb3RvY29sKCk7CiAKICAgICBTdHJpbmcgcmVhbG07CiAKQEAgLTg3NSwyMCArODc1 LDIwIEBAIHZvaWQgUmVzb3VyY2VIYW5kbGVNYW5hZ2VyOjphcHBseUF1dGhlbnRpY2F0aW9uVG9S ZXF1ZXN0KFJlc291cmNlSGFuZGxlKiBoYW5kbGUsCiB2b2lkIFJlc291cmNlSGFuZGxlTWFuYWdl cjo6aW5pdGlhbGl6ZUhhbmRsZShSZXNvdXJjZUhhbmRsZSogam9iKQogewogICAgIHN0YXRpYyBj b25zdCBpbnQgYWxsb3dlZFByb3RvY29scyA9IENVUkxQUk9UT19GSUxFIHwgQ1VSTFBST1RPX0ZU UCB8IENVUkxQUk9UT19GVFBTIHwgQ1VSTFBST1RPX0hUVFAgfCBDVVJMUFJPVE9fSFRUUFM7Ci0g ICAgVVJMIGt1cmwgPSBqb2ItPmZpcnN0UmVxdWVzdCgpLnVybCgpOworICAgIFVSTCB1cmwgPSBq b2ItPmZpcnN0UmVxdWVzdCgpLnVybCgpOwogCiAgICAgLy8gUmVtb3ZlIGFueSBmcmFnbWVudCBw YXJ0LCBvdGhlcndpc2UgY3VybCB3aWxsIHNlbmQgaXQgYXMgcGFydCBvZiB0aGUgcmVxdWVzdC4K LSAgICBrdXJsLnJlbW92ZUZyYWdtZW50SWRlbnRpZmllcigpOworICAgIHVybC5yZW1vdmVGcmFn bWVudElkZW50aWZpZXIoKTsKIAogICAgIFJlc291cmNlSGFuZGxlSW50ZXJuYWwqIGQgPSBqb2It PmdldEludGVybmFsKCk7Ci0gICAgU3RyaW5nIHVybCA9IGt1cmwuc3RyaW5nKCk7CisgICAgU3Ry aW5nIHVybFN0cmluZyA9IHVybC5zdHJpbmcoKTsKIAotICAgIGlmIChrdXJsLmlzTG9jYWxGaWxl KCkpIHsKKyAgICBpZiAodXJsLmlzTG9jYWxGaWxlKCkpIHsKICAgICAgICAgLy8gUmVtb3ZlIGFu eSBxdWVyeSBwYXJ0IHNlbnQgdG8gYSBsb2NhbCBmaWxlLgotICAgICAgICBpZiAoIWt1cmwucXVl cnkoKS5pc0VtcHR5KCkpIHsKKyAgICAgICAgaWYgKCF1cmwucXVlcnkoKS5pc0VtcHR5KCkpIHsK ICAgICAgICAgICAgIC8vIEJ5IHNldHRpbmcgdGhlIHF1ZXJ5IHRvIGEgbnVsbCBzdHJpbmcgaXQn bGwgYmUgcmVtb3ZlZC4KLSAgICAgICAgICAgIGt1cmwuc2V0UXVlcnkoU3RyaW5nKCkpOwotICAg ICAgICAgICAgdXJsID0ga3VybC5zdHJpbmcoKTsKKyAgICAgICAgICAgIHVybC5zZXRRdWVyeShT dHJpbmcoKSk7CisgICAgICAgICAgICB1cmxTdHJpbmcgPSB1cmwuc3RyaW5nKCk7CiAgICAgICAg IH0KICAgICAgICAgLy8gRGV0ZXJtaW5lIHRoZSBNSU1FIHR5cGUgYmFzZWQgb24gdGhlIHBhdGgu CiAgICAgICAgIGQtPm1fcmVzcG9uc2Uuc2V0TWltZVR5cGUoTUlNRVR5cGVSZWdpc3RyeTo6Z2V0 TUlNRVR5cGVGb3JQYXRoKHVybCkpOwpAQCAtOTM1LDcgKzkzNSw3IEBAIHZvaWQgUmVzb3VyY2VI YW5kbGVNYW5hZ2VyOjppbml0aWFsaXplSGFuZGxlKFJlc291cmNlSGFuZGxlKiBqb2IpCiAgICAg QVNTRVJUKCFkLT5tX3VybCk7CiAKICAgICAvLyB1cmwgaXMgaW4gQVNDSUkgc28gbGF0aW4xKCkg d2lsbCBvbmx5IGNvbnZlcnQgaXQgdG8gY2hhciogd2l0aG91dCBjaGFyYWN0ZXIgdHJhbnNsYXRp b24uCi0gICAgZC0+bV91cmwgPSBmYXN0U3RyRHVwKHVybC5sYXRpbjEoKS5kYXRhKCkpOworICAg IGQtPm1fdXJsID0gZmFzdFN0ckR1cCh1cmxTdHJpbmcubGF0aW4xKCkuZGF0YSgpKTsKICAgICBj dXJsX2Vhc3lfc2V0b3B0KGQtPm1faGFuZGxlLCBDVVJMT1BUX1VSTCwgZC0+bV91cmwpOwogCiAg ICAgaWYgKG1fY29va2llSmFyRmlsZU5hbWUpCg== 213081 2013-10-01 06:55:58 -0700 2013-10-01 10:02:42 -0700 Fixed patch rename_kurl.diff text/plain 3343 davidsz ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4NGIzMjkwLi5mZTBlNWRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTMtMTAtMDEgIFN6YWJvbGNzIETDoXZpZCAgPGRhdmlkc3pAaW5mLnUtc3plZ2VkLmh1 PgorCisgICAgICAgIFJlbmFtZSBVUkwgdHlwZSB2YXJpYWJsZXMgaW4gQ3VybCBuZXR3b3JrIGJh Y2tlbmQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MjIxNTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJ IGNoYW5nZWQgdGhlIG5hbWUgb2YgdGhlIFVSTCBvYmplY3RzIHRvIG1hdGNoIHdpdGggdGhlIG5l dyBjbGFzcyBuYW1lLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNl SGFuZGxlTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpnZXRQcm90ZWN0aW9uU3BhY2Up OgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGVNYW5hZ2VyOjppbml0aWFsaXplSGFu ZGxlKToKKwogMjAxMy0xMC0wMSAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcu Y29tPgogCiAgICAgICAgIEdlbmVyYXRlIHRvQ1NTRm9vVmFsdWUgZm9yIENTU1ByaW1pdGl2ZVZh bHVlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVz b3VyY2VIYW5kbGVNYW5hZ2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv Y3VybC9SZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3BwCmluZGV4IDdkZDViNmEuLjJkODVhMTEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhh bmRsZU1hbmFnZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3Vy bC9SZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3BwCkBAIC0zMDYsMTUgKzMwNiwxNSBAQCBzdGF0aWMg Ym9vbCBnZXRQcm90ZWN0aW9uU3BhY2UoQ1VSTCogaCwgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYg cmVzcG9uc2UsIFByb3RlYwogICAgIGlmIChlcnIgIT0gQ1VSTEVfT0spCiAgICAgICAgIHJldHVy biBmYWxzZTsKIAotICAgIGNvbnN0IGNoYXIqIHVybCA9IDA7Ci0gICAgZXJyID0gY3VybF9lYXN5 X2dldGluZm8oaCwgQ1VSTElORk9fRUZGRUNUSVZFX1VSTCwgJnVybCk7CisgICAgY29uc3QgY2hh ciogZWZmZWN0aXZlVXJsID0gMDsKKyAgICBlcnIgPSBjdXJsX2Vhc3lfZ2V0aW5mbyhoLCBDVVJM SU5GT19FRkZFQ1RJVkVfVVJMLCAmZWZmZWN0aXZlVXJsKTsKICAgICBpZiAoZXJyICE9IENVUkxF X09LKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICBVUkwga3VybChQYXJzZWRVUkxTdHJp bmcsIHVybCk7CisgICAgVVJMIHVybChQYXJzZWRVUkxTdHJpbmcsIGVmZmVjdGl2ZVVybCk7CiAK LSAgICBTdHJpbmcgaG9zdCA9IGt1cmwuaG9zdCgpOwotICAgIFN0cmluZyBwcm90b2NvbCA9IGt1 cmwucHJvdG9jb2woKTsKKyAgICBTdHJpbmcgaG9zdCA9IHVybC5ob3N0KCk7CisgICAgU3RyaW5n IHByb3RvY29sID0gdXJsLnByb3RvY29sKCk7CiAKICAgICBTdHJpbmcgcmVhbG07CiAKQEAgLTg3 NSwyMCArODc1LDIwIEBAIHZvaWQgUmVzb3VyY2VIYW5kbGVNYW5hZ2VyOjphcHBseUF1dGhlbnRp Y2F0aW9uVG9SZXF1ZXN0KFJlc291cmNlSGFuZGxlKiBoYW5kbGUsCiB2b2lkIFJlc291cmNlSGFu ZGxlTWFuYWdlcjo6aW5pdGlhbGl6ZUhhbmRsZShSZXNvdXJjZUhhbmRsZSogam9iKQogewogICAg IHN0YXRpYyBjb25zdCBpbnQgYWxsb3dlZFByb3RvY29scyA9IENVUkxQUk9UT19GSUxFIHwgQ1VS TFBST1RPX0ZUUCB8IENVUkxQUk9UT19GVFBTIHwgQ1VSTFBST1RPX0hUVFAgfCBDVVJMUFJPVE9f SFRUUFM7Ci0gICAgVVJMIGt1cmwgPSBqb2ItPmZpcnN0UmVxdWVzdCgpLnVybCgpOworICAgIFVS TCB1cmwgPSBqb2ItPmZpcnN0UmVxdWVzdCgpLnVybCgpOwogCiAgICAgLy8gUmVtb3ZlIGFueSBm cmFnbWVudCBwYXJ0LCBvdGhlcndpc2UgY3VybCB3aWxsIHNlbmQgaXQgYXMgcGFydCBvZiB0aGUg cmVxdWVzdC4KLSAgICBrdXJsLnJlbW92ZUZyYWdtZW50SWRlbnRpZmllcigpOworICAgIHVybC5y ZW1vdmVGcmFnbWVudElkZW50aWZpZXIoKTsKIAogICAgIFJlc291cmNlSGFuZGxlSW50ZXJuYWwq IGQgPSBqb2ItPmdldEludGVybmFsKCk7Ci0gICAgU3RyaW5nIHVybCA9IGt1cmwuc3RyaW5nKCk7 CisgICAgU3RyaW5nIHVybFN0cmluZyA9IHVybC5zdHJpbmcoKTsKIAotICAgIGlmIChrdXJsLmlz TG9jYWxGaWxlKCkpIHsKKyAgICBpZiAodXJsLmlzTG9jYWxGaWxlKCkpIHsKICAgICAgICAgLy8g UmVtb3ZlIGFueSBxdWVyeSBwYXJ0IHNlbnQgdG8gYSBsb2NhbCBmaWxlLgotICAgICAgICBpZiAo IWt1cmwucXVlcnkoKS5pc0VtcHR5KCkpIHsKKyAgICAgICAgaWYgKCF1cmwucXVlcnkoKS5pc0Vt cHR5KCkpIHsKICAgICAgICAgICAgIC8vIEJ5IHNldHRpbmcgdGhlIHF1ZXJ5IHRvIGEgbnVsbCBz dHJpbmcgaXQnbGwgYmUgcmVtb3ZlZC4KLSAgICAgICAgICAgIGt1cmwuc2V0UXVlcnkoU3RyaW5n KCkpOwotICAgICAgICAgICAgdXJsID0ga3VybC5zdHJpbmcoKTsKKyAgICAgICAgICAgIHVybC5z ZXRRdWVyeShTdHJpbmcoKSk7CisgICAgICAgICAgICB1cmxTdHJpbmcgPSB1cmwuc3RyaW5nKCk7 CiAgICAgICAgIH0KICAgICAgICAgLy8gRGV0ZXJtaW5lIHRoZSBNSU1FIHR5cGUgYmFzZWQgb24g dGhlIHBhdGguCiAgICAgICAgIGQtPm1fcmVzcG9uc2Uuc2V0TWltZVR5cGUoTUlNRVR5cGVSZWdp c3RyeTo6Z2V0TUlNRVR5cGVGb3JQYXRoKHVybCkpOwpAQCAtOTM1LDcgKzkzNSw3IEBAIHZvaWQg UmVzb3VyY2VIYW5kbGVNYW5hZ2VyOjppbml0aWFsaXplSGFuZGxlKFJlc291cmNlSGFuZGxlKiBq b2IpCiAgICAgQVNTRVJUKCFkLT5tX3VybCk7CiAKICAgICAvLyB1cmwgaXMgaW4gQVNDSUkgc28g bGF0aW4xKCkgd2lsbCBvbmx5IGNvbnZlcnQgaXQgdG8gY2hhciogd2l0aG91dCBjaGFyYWN0ZXIg dHJhbnNsYXRpb24uCi0gICAgZC0+bV91cmwgPSBmYXN0U3RyRHVwKHVybC5sYXRpbjEoKS5kYXRh KCkpOworICAgIGQtPm1fdXJsID0gZmFzdFN0ckR1cCh1cmxTdHJpbmcubGF0aW4xKCkuZGF0YSgp KTsKICAgICBjdXJsX2Vhc3lfc2V0b3B0KGQtPm1faGFuZGxlLCBDVVJMT1BUX1VSTCwgZC0+bV91 cmwpOwogCiAgICAgaWYgKG1fY29va2llSmFyRmlsZU5hbWUpCg==