122124 2013-09-30 14:34:53 -0700 Assertion failure under -[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:] if no classes conform to JSExport 2013-09-30 15:51:22 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mitz mitz commit-queue darin mhahnenberg oldest_to_newest 934811 0 mitz 2013-09-30 14:34:53 -0700 <rdar://problem/15114974> Defining an NSBlock-valued property on a JSValue in a program that doesn’t load any classes that conform to JSExport causes an assertion failure. To reproduce, build and run this: #import <JavaScriptCore/JavaScriptCore.h> int main(int argc, const char * argv[]) { @autoreleasepool { JSContext *context = [[JSContext alloc] init]; [[context globalObject] defineProperty:@"doSomething" descriptor:@{ JSPropertyDescriptorValueKey : ^{ } }]; } return 0; } * RESULTS ASSERTION FAILED: target Source/JavaScriptCore/API/ObjcRuntimeExtras.h(47) : void forEachProtocolImplementingProtocol(Class, Protocol *, void (^)(Protocol *)) 1 0x1005d66f0 WTFCrash 2 0x1004120d0 forEachProtocolImplementingProtocol(objc_class*, Protocol*, void (Protocol*) block_pointer) 3 0x10040e92b -[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:] 4 0x10040e0ab -[JSObjCClassInfo initWithContext:forClass:superClassInfo:] 5 0x10040ff2d -[JSWrapperMap classInfoForClass:] 6 0x10040fe5e -[JSWrapperMap classInfoForClass:] 7 0x10040fe5e -[JSWrapperMap classInfoForClass:] 8 0x10041008b -[JSWrapperMap jsWrapperForObject:] 9 0x100373d57 -[JSContext(Internal) wrapperForObjCObject:] 10 0x1003f868e objectToValueWithoutCopy(JSContext*, objc_object*) 11 0x1003f7ddf ObjcContainerConvertor::convert(objc_object*) 12 0x1003f3435 objectToValue(JSContext*, objc_object*) 13 0x1003f6016 -[JSValue invokeMethod:withArguments:] 14 0x1003f51d1 -[JSValue defineProperty:descriptor:] 15 0x100000e1f main 16 0x7fff878195fd start * NOTES This happens because objc_getProtocol("JSExport") returns nil. Note that getJSExportProtocol() caches this result, which means that if a class that conforms to JSExport is loaded (or registered dynamically) later, getJSExportProtocol() would still return nil. This seems like an actual correctness issue in production builds. 934828 1 213038 mitz 2013-09-30 15:00:08 -0700 Created attachment 213038 Define a class that conforms to the JSExport protocol in JavaScriptCore. 934832 2 darin 2013-09-30 15:11:19 -0700 Is there a similar problem with the NSBlock class? If not, why not? 934836 3 mitz 2013-09-30 15:23:02 -0700 (In reply to comment #2) > Is there a similar problem with the NSBlock class? If not, why not? No. the NSBlock class is defined in Core Foundation, which JavaScriptCore links against. The only reason getNSBlockClass() doesn’t use [NSBlock self] is that the class is not declared in a public header. 934841 4 213038 commit-queue 2013-09-30 15:51:20 -0700 Comment on attachment 213038 Define a class that conforms to the JSExport protocol in JavaScriptCore. Clearing flags on attachment: 213038 Committed r156684: <http://trac.webkit.org/changeset/156684> 934842 5 commit-queue 2013-09-30 15:51:22 -0700 All reviewed patches have been landed. Closing bug. 213038 2013-09-30 15:00:08 -0700 2013-09-30 15:51:20 -0700 Define a class that conforms to the JSExport protocol in JavaScriptCore. bug-122124-20130930150018.patch text/plain 1474 mitz SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU2NjgyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDEzLTA5LTMwICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzE1MTE0OTc0PiBBc3NlcnRpb24gZmFpbHVyZSB1bmRlciAtW0pTT2Jq Q0NsYXNzSW5mbyBhbGxvY2F0ZUNvbnN0cnVjdG9yQW5kUHJvdG90eXBlV2l0aFN1cGVyQ2xhc3NJ bmZvOl0gaWYgbm8gY2xhc3NlcyBjb25mb3JtIHRvIEpTRXhwb3J0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjIxMjQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEFQSS9KU1dyYXBwZXJNYXAubW06IERl ZmluZWQgYW4gZW1wdHkgY2xhc3MgdGhhdCBjb25mb3JtcyB0byB0aGUgSlNFeHBvcnQgcHJvdG9j b2wsIHRvCisgICAgICAgIGVuc3VyZSB0aGF0IHRoZSBwcm90b2NvbCBpcyBhbHdheXMgcmVnaXN0 ZXJlZCB3aXRoIHRoZSBydW50aW1lIGJ5IHRoZSB0aW1lCisgICAgICAgIGdldEpTRXhwb3J0UHJv dG9jb2woKSBpcyBjYWxsZWQuCisKIDIwMTMtMDktMzAgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdA YXBwbGUuY29tPgogCiAgICAgICAgIFBhc3MgVk0gaW5zdGVhZCBvZiBFeGVjU3RhdGUgdG8gT2Jq ZWN0UHJvdG90eXBlIGNvbnN0cnVjdG9yLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0FQ SS9KU1dyYXBwZXJNYXAubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0FQ SS9KU1dyYXBwZXJNYXAubW0JKHJldmlzaW9uIDE1NjYwNykKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9BUEkvSlNXcmFwcGVyTWFwLm1tCSh3b3JraW5nIGNvcHkpCkBAIC01MDYsNiArNTA2LDEy IEBAIGlkIHRyeVVud3JhcE9iamNPYmplY3QoSlNHbG9iYWxDb250ZXh0UmUKICAgICByZXR1cm4g bmlsOwogfQogCisvLyBUaGlzIGNsYXNzIGVuc3VyZXMgdGhhdCB0aGUgSlNFeHBvcnQgcHJvdG9j b2wgaXMgcmVnaXN0ZXJlZCB3aXRoIHRoZSBydW50aW1lLgorTlNfUk9PVF9DTEFTUyBAaW50ZXJm YWNlIEpTRXhwb3J0IDxKU0V4cG9ydD4KK0BlbmQKK0BpbXBsZW1lbnRhdGlvbiBKU0V4cG9ydAor QGVuZAorCiBQcm90b2NvbCAqZ2V0SlNFeHBvcnRQcm90b2NvbCgpCiB7CiAgICAgc3RhdGljIFBy b3RvY29sICpwcm90b2NvbCA9IG9iamNfZ2V0UHJvdG9jb2woIkpTRXhwb3J0Iik7Cg==