122121 2013-09-30 13:12:58 -0700 Remove timeout from shouldBecome* functions in js-test-pre 2013-09-30 13:46:37 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap oldest_to_newest 934784 0 ap 2013-09-30 13:12:58 -0700 There is a family of functions in js-test-pre that check a condition every 5 milliseconds, and fail if it doesn't become true in 0.5 sec. They also take an argument for custom timeout, but there are no tests that pass it. This is not how you write regression tests - anything can take longer than 0.5 seconds. We should just use global test timeout, not roll out ad hoc flaky solutions. There is a lot of flakiness on tests such as editing/spelling/grammar-paste.html, and it seems entirely expected with a short timeout like this. 934786 1 213032 ap 2013-09-30 13:15:14 -0700 Created attachment 213032 proposed patch 934801 2 ap 2013-09-30 13:46:37 -0700 Committed <http://trac.webkit.org/r156678>. 213032 2013-09-30 13:15:14 -0700 2013-09-30 13:31:54 -0700 proposed patch timeout.txt text/plain 4179 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE1NjY3NSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA5LTMwICBBbGV4ZXkgUHJvc2t1cnlh a292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSB0aW1lb3V0IGZyb20gc2hvdWxk QmVjb21lKiBmdW5jdGlvbnMgaW4ganMtdGVzdC1wcmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMjEyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZWQgdGltZW91dC4gQSAwLjUgc2VjIHRpbWVv dXQgbmV2ZXIgbWFrZXMgc2Vuc2UsIGFuZCBpZiBzb21ldGhpbmcgaXMgc3R1Y2ssCisgICAgICAg IGEgdGVzdCBzaG91bGQganVzdCB0aW1lIG91dCBub3JtYWxseS4KKworICAgICAgICAqIHJlc291 cmNlcy9qcy10ZXN0LXByZS5qczoKKyAgICAgICAgKF93YWl0Rm9yQ29uZGl0aW9uKToKKyAgICAg ICAgKHNob3VsZEJlY29tZUVxdWFsKToKKyAgICAgICAgKHNob3VsZEJlY29tZUVxdWFsVG9TdHJp bmcpOgorICAgICAgICAoc2hvdWxkQmVjb21lRGlmZmVyZW50KToKKwogMjAxMy0wOS0zMCAgSmVy IE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xs IGJhY2sgaW4gcjE1NjU0NiB3aXRoIHJlYmFzZWxpbmVkIHRlc3RzLgpJbmRleDogTGF5b3V0VGVz dHMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3Jl c291cmNlcy9qcy10ZXN0LXByZS5qcwkocmV2aXNpb24gMTU2NTgwKQorKysgTGF5b3V0VGVzdHMv cmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0yNjQsMjcgKzI2NCwy MCBAQCBmdW5jdGlvbiBkZmdTaG91bGRCZSh0aGVGdW5jdGlvbiwgX2EsIF9iCiAgIHJldHVybiB2 YWx1ZXMubGVuZ3RoOwogfQogCi0vLyBFeGVjdXRlIGNvbmRpdGlvbiBldmVyeSA1IG1pbGxpc2Vj b25kcyB1bnRpbCBpdCBzdWNjZWVkIG9yIGZhaWx1cmVUaW1lIGlzIHJlYWNoZWQuCi0vLyBjb21w bGV0aW9uSGFuZGxlciBpcyBleGVjdXRlZCBvbiBzdWNjZXNzLCBmYWlsdXJlSGFuZGxlciBpcyBl eGVjdXRlZCBvbiB0aW1lb3V0LgotZnVuY3Rpb24gX3dhaXRGb3JDb25kaXRpb24oY29uZGl0aW9u LCBmYWlsdXJlVGltZSwgY29tcGxldGlvbkhhbmRsZXIsIGZhaWx1cmVIYW5kbGVyKQorLy8gRXhl Y3V0ZSBjb25kaXRpb24gZXZlcnkgNSBtaWxsaXNlY29uZHMgdW50aWwgaXQgc3VjY2VlZHMuCitm dW5jdGlvbiBfd2FpdEZvckNvbmRpdGlvbihjb25kaXRpb24sIGNvbXBsZXRpb25IYW5kbGVyKQog ewotICBpZiAoY29uZGl0aW9uKCkpIHsKKyAgaWYgKGNvbmRpdGlvbigpKQogICAgIGNvbXBsZXRp b25IYW5kbGVyKCk7Ci0gIH0gZWxzZSBpZiAoRGF0ZS5ub3coKSA+IGZhaWx1cmVUaW1lKSB7Ci0g ICAgZmFpbHVyZUhhbmRsZXIoKTsKLSAgfSBlbHNlIHsKLSAgICBzZXRUaW1lb3V0KF93YWl0Rm9y Q29uZGl0aW9uLCA1LCBjb25kaXRpb24sIGZhaWx1cmVUaW1lLCBjb21wbGV0aW9uSGFuZGxlciwg ZmFpbHVyZUhhbmRsZXIpOwotICB9CisgIGVsc2UKKyAgICBzZXRUaW1lb3V0KF93YWl0Rm9yQ29u ZGl0aW9uLCA1LCBjb25kaXRpb24sIGNvbXBsZXRpb25IYW5kbGVyKTsKIH0KIAotZnVuY3Rpb24g c2hvdWxkQmVjb21lRXF1YWwoX2EsIF9iLCBjb21wbGV0aW9uSGFuZGxlciwgdGltZW91dCkKK2Z1 bmN0aW9uIHNob3VsZEJlY29tZUVxdWFsKF9hLCBfYiwgY29tcGxldGlvbkhhbmRsZXIpCiB7CiAg IGlmICh0eXBlb2YgX2EgIT0gInN0cmluZyIgfHwgdHlwZW9mIF9iICE9ICJzdHJpbmciKQogICAg IGRlYnVnKCJXQVJOOiBzaG91bGRCZWNvbWVFcXVhbCgpIGV4cGVjdHMgc3RyaW5nIGFyZ3VtZW50 cyIpOwogCi0gIGlmICh0aW1lb3V0ID09PSB1bmRlZmluZWQpCi0gICAgdGltZW91dCA9IDUwMDsK LQogICB2YXIgY29uZGl0aW9uID0gZnVuY3Rpb24oKSB7CiAgICAgdmFyIGV4Y2VwdGlvbjsKICAg ICB2YXIgX2F2OwpAQCAtMzAyLDIwICsyOTUsMTUgQEAgZnVuY3Rpb24gc2hvdWxkQmVjb21lRXF1 YWwoX2EsIF9iLCBjb21wbAogICAgIH0KICAgICByZXR1cm4gZmFsc2U7CiAgIH07Ci0gIHZhciBm YWlsdXJlVGltZSA9IERhdGUubm93KCkgKyB0aW1lb3V0OwotICB2YXIgZmFpbHVyZUhhbmRsZXIg PSBmdW5jdGlvbiAoKSB7Ci0gICAgdGVzdEZhaWxlZChfYSArICIgZmFpbGVkIHRvIGNoYW5nZSB0 byAiICsgX2IgKyAiIGluICIgKyAodGltZW91dCAvIDEwMDApICsgIiBzZWNvbmRzLiIpOwotICAg IGNvbXBsZXRpb25IYW5kbGVyKCk7Ci0gIH07Ci0gIF93YWl0Rm9yQ29uZGl0aW9uKGNvbmRpdGlv biwgZmFpbHVyZVRpbWUsIGNvbXBsZXRpb25IYW5kbGVyLCBmYWlsdXJlSGFuZGxlcik7CisgIF93 YWl0Rm9yQ29uZGl0aW9uKGNvbmRpdGlvbiwgY29tcGxldGlvbkhhbmRsZXIpOwogfQogCi1mdW5j dGlvbiBzaG91bGRCZWNvbWVFcXVhbFRvU3RyaW5nKHZhbHVlLCByZWZlcmVuY2UsIGNvbXBsZXRp b25IYW5kbGVyLCB0aW1lb3V0KQorZnVuY3Rpb24gc2hvdWxkQmVjb21lRXF1YWxUb1N0cmluZyh2 YWx1ZSwgcmVmZXJlbmNlLCBjb21wbGV0aW9uSGFuZGxlcikKIHsKICAgaWYgKHR5cGVvZiB2YWx1 ZSAhPT0gInN0cmluZyIgfHwgdHlwZW9mIHJlZmVyZW5jZSAhPT0gInN0cmluZyIpCiAgICAgZGVi dWcoIldBUk46IHNob3VsZEJlY29tZUVxdWFsVG9TdHJpbmcoKSBleHBlY3RzIHN0cmluZyBhcmd1 bWVudHMiKTsKICAgdmFyIHVuZXZhbGVkU3RyaW5nID0gSlNPTi5zdHJpbmdpZnkocmVmZXJlbmNl KTsKLSAgc2hvdWxkQmVjb21lRXF1YWwodmFsdWUsIHVuZXZhbGVkU3RyaW5nLCBjb21wbGV0aW9u SGFuZGxlciwgdGltZW91dCk7CisgIHNob3VsZEJlY29tZUVxdWFsKHZhbHVlLCB1bmV2YWxlZFN0 cmluZywgY29tcGxldGlvbkhhbmRsZXIpOwogfQogCiBmdW5jdGlvbiBzaG91bGRCZVR5cGUoX2Es IF90eXBlKSB7CkBAIC0zOTcsMTIgKzM4NSwxMCBAQCBmdW5jdGlvbiBzaG91bGROb3RCZShfYSwg X2IsIHF1aWV0KQogICAgIHRlc3RGYWlsZWQoX2EgKyAiIHNob3VsZCBub3QgYmUgIiArIF9idiAr ICIuIik7CiB9CiAKLWZ1bmN0aW9uIHNob3VsZEJlY29tZURpZmZlcmVudChfYSwgX2IsIGNvbXBs ZXRpb25IYW5kbGVyLCB0aW1lb3V0KQorZnVuY3Rpb24gc2hvdWxkQmVjb21lRGlmZmVyZW50KF9h LCBfYiwgY29tcGxldGlvbkhhbmRsZXIpCiB7CiAgIGlmICh0eXBlb2YgX2EgIT0gInN0cmluZyIg fHwgdHlwZW9mIF9iICE9ICJzdHJpbmciKQogICAgIGRlYnVnKCJXQVJOOiBzaG91bGRCZWNvbWVE aWZmZXJlbnQoKSBleHBlY3RzIHN0cmluZyBhcmd1bWVudHMiKTsKLSAgaWYgKHRpbWVvdXQgPT09 IHVuZGVmaW5lZCkKLSAgICB0aW1lb3V0ID0gNTAwOwogCiAgIHZhciBjb25kaXRpb24gPSBmdW5j dGlvbigpIHsKICAgICB2YXIgZXhjZXB0aW9uOwpAQCAtNDIxLDEyICs0MDcsNyBAQCBmdW5jdGlv biBzaG91bGRCZWNvbWVEaWZmZXJlbnQoX2EsIF9iLCBjCiAgICAgfQogICAgIHJldHVybiBmYWxz ZTsKICAgfTsKLSAgdmFyIGZhaWx1cmVUaW1lID0gRGF0ZS5ub3coKSArIHRpbWVvdXQ7Ci0gIHZh ciBmYWlsdXJlSGFuZGxlciA9IGZ1bmN0aW9uICgpIHsKLSAgICB0ZXN0RmFpbGVkKF9hICsgIiBk aWQgbm90IGJlY29tZSBkaWZmZXJlbnQgZnJvbSAiICsgX2IgKyAiIGluICIgKyAodGltZW91dCAv IDEwMDApICsgIiBzZWNvbmRzLiIpOwotICAgIGNvbXBsZXRpb25IYW5kbGVyKCk7Ci0gIH07Ci0g IF93YWl0Rm9yQ29uZGl0aW9uKGNvbmRpdGlvbiwgZmFpbHVyZVRpbWUsIGNvbXBsZXRpb25IYW5k bGVyLCBmYWlsdXJlSGFuZGxlcik7CisgIF93YWl0Rm9yQ29uZGl0aW9uKGNvbmRpdGlvbiwgY29t cGxldGlvbkhhbmRsZXIpOwogfQogCiBmdW5jdGlvbiBzaG91bGRCZVRydWUoX2EpIHsgc2hvdWxk QmUoX2EsICJ0cnVlIik7IH0K