122115 2013-09-30 12:01:25 -0700 Don't attempt to destroy decoded frame if a BitmapImage doesn't have encoded raw data. 2013-09-30 14:53:03 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All Unspecified RESOLVED FIXED P2 Normal --- 1 yongjun_zhang webkit-unassigned commit-queue dbates ddkilzer koivisto yongjun_zhang oldest_to_newest 934720 0 yongjun_zhang 2013-09-30 12:01:25 -0700 With BitmapImage::create(PassNativeImagePtr, ImageObserver*), a BitmapImage could be created by passing a native image. If this image is added to memory cache, we shouldn't attempt to destroy its decoded frames since there is no encoded raw data and we won't be able to reconstruct the image again. 934739 1 213021 yongjun_zhang 2013-09-30 12:32:29 -0700 Created attachment 213021 Patch. 934802 2 213021 dbates 2013-09-30 13:47:23 -0700 Comment on attachment 213021 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=213021&action=review > Source/WebCore/ChangeLog:7 > + passing a native image. If this image is added to memory cache, we shouldn't attempt to destroy Nit: "added to memory cache" => "added to the memory cache" > Source/WebCore/ChangeLog:10 > + Reviewed by NOBODY (OOPS!). Nit: This line should come after the bug URL. > Source/WebCore/ChangeLog:13 > + No new tests for now. Currently there is no code patch to add an BitmapImage created by native image > + to memory cache, we will add this in future. The second sentence doesn't read well. Maybe: Currently there isn't a code path to add to the memory cache a BitmapImage that was created by adopting a native image. We'll add such a code path in a subsequent patch. 934805 3 213034 yongjun_zhang 2013-09-30 14:00:31 -0700 Created attachment 213034 Address review comments. 934823 4 213034 commit-queue 2013-09-30 14:53:01 -0700 Comment on attachment 213034 Address review comments. Clearing flags on attachment: 213034 Committed r156681: <http://trac.webkit.org/changeset/156681> 934824 5 commit-queue 2013-09-30 14:53:03 -0700 All reviewed patches have been landed. Closing bug. 213021 2013-09-30 12:32:29 -0700 2013-09-30 14:00:31 -0700 Patch. destroy_decoded.patch text/plain 2017 yongjun_zhang SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NjY2OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA5LTMwICBZb25nanVu IFpoYW5nICA8eW9uZ2p1bl96aGFuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgRG9uJ3QgYXR0ZW1w dCB0byBkZXN0cm95IGRlY29kZWQgZnJhbWUgaWYgYSBCaXRtYXBJbWFnZSBkb2Vzbid0IGhhdmUg ZW5jb2RlZCByYXcgZGF0YS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyMjExNQorCisgICAgICAgIFdpdGggQml0bWFwSW1hZ2U6OmNyZWF0ZShQYXNz TmF0aXZlSW1hZ2VQdHIsIEltYWdlT2JzZXJ2ZXIqKSwgYSBCaXRtYXBJbWFnZSBjb3VsZCBiZSBj cmVhdGVkIGJ5CisgICAgICAgIHBhc3NpbmcgYSBuYXRpdmUgaW1hZ2UuICBJZiB0aGlzIGltYWdl IGlzIGFkZGVkIHRvIG1lbW9yeSBjYWNoZSwgd2Ugc2hvdWxkbid0IGF0dGVtcHQgdG8gZGVzdHJv eQorICAgICAgICBpdHMgZGVjb2RlZCBmcmFtZXMgc2luY2UgdGhlcmUgaXMgbm8gZW5jb2RlZCBy YXcgZGF0YSBhbmQgd2Ugd29uJ3QgYmUgYWJsZSB0byByZWNvbnN0cnVjdCB0aGUgaW1hZ2UgYWdh aW4uCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAg ICAgICBObyBuZXcgdGVzdHMgZm9yIG5vdy4gQ3VycmVudGx5IHRoZXJlIGlzIG5vIGNvZGUgcGF0 Y2ggdG8gYWRkIGFuIEJpdG1hcEltYWdlIGNyZWF0ZWQgYnkgbmF0aXZlIGltYWdlCisgICAgICAg IHRvIG1lbW9yeSBjYWNoZSwgd2Ugd2lsbCBhZGQgdGhpcyBpbiBmdXR1cmUuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9CaXRtYXBJbWFnZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpC aXRtYXBJbWFnZTo6ZGVzdHJveURlY29kZWREYXRhSWZOZWNlc3NhcnkpOgorCiAyMDEzLTA5LTMw ICBNYXJrIFJvd2UgIDxtcm93ZUBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IHRoZSBidWlsZCB3 aGVuIGJ1aWxkaW5nIGFnYWluc3QgYW4gU0RLLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvQml0bWFwSW1hZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdlLmNwcAkocmV2aXNpb24gMTU2NjY2KQorKysg U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQml0bWFwSW1hZ2UuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC05OCw2ICs5OCwxMiBAQCB2b2lkIEJpdG1hcEltYWdlOjpkZXN0cm95RGVjb2Rl ZERhdGFJZk5lCiAgICAgLy8gQW5pbWF0ZWQgaW1hZ2VzID41TUIgYXJlIGNvbnNpZGVyZWQgbGFy Z2UgZW5vdWdoIHRoYXQgd2UnbGwgb25seSBoYW5nIG9uCiAgICAgLy8gdG8gb25lIGZyYW1lIGF0 IGEgdGltZS4KICAgICBzdGF0aWMgY29uc3QgdW5zaWduZWQgY0xhcmdlQW5pbWF0aW9uQ3V0b2Zm ID0gNTI0Mjg4MDsKKworICAgIC8vIElmIHdlIGhhdmUgZGVjb2RlZCBmcmFtZXMgYnV0IHRoZXJl IGlzIG5vIGVuY29kZWQgZGF0YSwgd2Ugc2hvdWxkbid0IGRlc3Ryb3kKKyAgICAvLyB0aGUgZGVj b2RlZCBpbWFnZSBzaW5jZSB3ZSB3b24ndCBiZSBhYmxlIHRvIHJlY29uc3RydWN0IGl0IGxhdGVy LgorICAgIGlmICghZGF0YSgpICYmIG1fZnJhbWVzLnNpemUoKSkKKyAgICAgICAgcmV0dXJuOwor CiAgICAgdW5zaWduZWQgYWxsRnJhbWVCeXRlcyA9IDA7CiAgICAgZm9yIChzaXplX3QgaSA9IDA7 IGkgPCBtX2ZyYW1lcy5zaXplKCk7ICsraSkKICAgICAgICAgYWxsRnJhbWVCeXRlcyArPSBtX2Zy YW1lc1tpXS5tX2ZyYW1lQnl0ZXM7Cg== 213034 2013-09-30 14:00:31 -0700 2013-09-30 14:53:01 -0700 Address review comments. destroy_decoded.patch text/plain 2053 yongjun_zhang SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NjY2OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA5LTMwICBZb25nanVu IFpoYW5nICA8eW9uZ2p1bl96aGFuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgRG9uJ3QgYXR0ZW1w dCB0byBkZXN0cm95IGRlY29kZWQgZnJhbWUgaWYgYSBCaXRtYXBJbWFnZSBkb2Vzbid0IGhhdmUg ZW5jb2RlZCByYXcgZGF0YS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyMjExNQorCisgICAgICAgIFJldmlld2VkIGJ5IERhbmllbCBCYXRlcy4KKwor ICAgICAgICBXaXRoIEJpdG1hcEltYWdlOjpjcmVhdGUoUGFzc05hdGl2ZUltYWdlUHRyLCBJbWFn ZU9ic2VydmVyKiksIGEgQml0bWFwSW1hZ2UgY291bGQgYmUgY3JlYXRlZCBieQorICAgICAgICBw YXNzaW5nIGEgbmF0aXZlIGltYWdlLiAgSWYgdGhpcyBpbWFnZSBpcyBhZGRlZCB0byBtZW1vcnkg Y2FjaGUsIHdlIHNob3VsZG4ndCBhdHRlbXB0IHRvIGRlc3Ryb3kKKyAgICAgICAgaXRzIGRlY29k ZWQgZnJhbWVzIHNpbmNlIHRoZXJlIGlzIG5vIGVuY29kZWQgcmF3IGRhdGEgYW5kIHdlIHdvbid0 IGJlIGFibGUgdG8gcmVjb25zdHJ1Y3QgdGhlIGltYWdlIGFnYWluLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cyBmb3Igbm93LiBDdXJyZW50bHkgdGhlcmUgaXNuJ3QgYSBjb2RlIHBhdGggdG8gYWRk IHRvIHRoZSBtZW1vcnkgY2FjaGUgYSBCaXRtYXBJbWFnZQorICAgICAgICB0aGF0IHdhcyBjcmVh dGVkIGJ5IGFkb3B0aW5nIGEgbmF0aXZlIGltYWdlLiBXZSdsbCBhZGQgc3VjaCBhIGNvZGUgcGF0 aCBpbiBhIHN1YnNlcXVlbnQgcGF0Y2guCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9C aXRtYXBJbWFnZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpCaXRtYXBJbWFnZTo6ZGVzdHJveURl Y29kZWREYXRhSWZOZWNlc3NhcnkpOgorCiAyMDEzLTA5LTMwICBNYXJrIFJvd2UgIDxtcm93ZUBh cHBsZS5jb20+CiAKICAgICAgICAgRml4IHRoZSBidWlsZCB3aGVuIGJ1aWxkaW5nIGFnYWluc3Qg YW4gU0RLLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQml0bWFwSW1h Z2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Jp dG1hcEltYWdlLmNwcAkocmV2aXNpb24gMTU2NjY2KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvQml0bWFwSW1hZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05OCw2ICs5OCwx MiBAQCB2b2lkIEJpdG1hcEltYWdlOjpkZXN0cm95RGVjb2RlZERhdGFJZk5lCiAgICAgLy8gQW5p bWF0ZWQgaW1hZ2VzID41TUIgYXJlIGNvbnNpZGVyZWQgbGFyZ2UgZW5vdWdoIHRoYXQgd2UnbGwg b25seSBoYW5nIG9uCiAgICAgLy8gdG8gb25lIGZyYW1lIGF0IGEgdGltZS4KICAgICBzdGF0aWMg Y29uc3QgdW5zaWduZWQgY0xhcmdlQW5pbWF0aW9uQ3V0b2ZmID0gNTI0Mjg4MDsKKworICAgIC8v IElmIHdlIGhhdmUgZGVjb2RlZCBmcmFtZXMgYnV0IHRoZXJlIGlzIG5vIGVuY29kZWQgZGF0YSwg d2Ugc2hvdWxkbid0IGRlc3Ryb3kKKyAgICAvLyB0aGUgZGVjb2RlZCBpbWFnZSBzaW5jZSB3ZSB3 b24ndCBiZSBhYmxlIHRvIHJlY29uc3RydWN0IGl0IGxhdGVyLgorICAgIGlmICghZGF0YSgpICYm IG1fZnJhbWVzLnNpemUoKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgdW5zaWduZWQgYWxsRnJh bWVCeXRlcyA9IDA7CiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBtX2ZyYW1lcy5zaXplKCk7 ICsraSkKICAgICAgICAgYWxsRnJhbWVCeXRlcyArPSBtX2ZyYW1lc1tpXS5tX2ZyYW1lQnl0ZXM7 Cg==