122106 2013-09-30 06:56:57 -0700 [Win] Compile errors in WebKit. 2013-09-30 12:08:01 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Unspecified RESOLVED FIXED P2 Normal --- 122078 0 peavo webkit-unassigned bfulgham commit-queue darin ossy oldest_to_newest 934575 0 peavo 2013-09-30 06:56:57 -0700 I get these compile errors when compiling WinCairo: 1>..\..\win\WebFrame.cpp(1231): error C2664: 'WebCore::AnimationController::pauseAnimationAtTime' : cannot convert parameter 1 from 'WebCore::RenderObject *' to 'WebCore::RenderElement *' Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast 1>..\..\win\WebFrame.cpp(1250): error C2664: 'WebCore::AnimationController::pauseTransitionAtTime' : cannot convert parameter 1 from 'WebCore::RenderObject *' to 'WebCore::RenderElement *' Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast 934576 1 212991 peavo 2013-09-30 07:02:55 -0700 Created attachment 212991 Patch 934666 2 212991 commit-queue 2013-09-30 10:46:00 -0700 Comment on attachment 212991 Patch Rejecting attachment 212991 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 212991, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: og patching file Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in patching file Source/WebKit/win/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/win/WebFrame.cpp Hunk #2 FAILED at 1229. Hunk #3 FAILED at 1248. 2 out of 3 hunks FAILED -- saving rejects to file Source/WebKit/win/WebFrame.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/2733116 934671 3 peavo 2013-09-30 10:52:13 -0700 Already fixed in r156655, except for the link fixes. 934674 4 darin 2013-09-30 11:01:36 -0700 OK, then someone needs to land the link fixes. 934681 5 bfulgham 2013-09-30 11:08:25 -0700 I'll land the link fixes. 934683 6 bfulgham 2013-09-30 11:13:33 -0700 Landed in http://trac.webkit.org/changeset/156667. 212991 2013-09-30 07:02:55 -0700 2013-09-30 10:46:00 -0700 Patch bug-122106-20130930160249.patch text/plain 5017 peavo SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNTY2NDkpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEzLTA5LTMwICBwZWF2b0BvdXRs b29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5dIENvbXBpbGUgZXJy b3JzIGluIFdlYktpdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEyMjEwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogV2ViS2l0LnZjeHByb2ovV2ViS2l0RXhwb3J0R2VuZXJhdG9yL1dlYktpdEV4cG9y dHMuZGVmLmluOiBFeHBvcnQgbmVlZGVkIHN5bWJvbHMuCisKIDIwMTMtMDktMjggIE1hcmsgUm93 ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBUYWtlIFhjb2RlJ3MgYWR2aWNlIGFuZCBl bmFibGUgc29tZSBleHRyYSB3YXJuaW5ncy4KSW5kZXg6IFNvdXJjZS9XZWJLaXQvV2ViS2l0LnZj eHByb2ovV2ViS2l0RXhwb3J0R2VuZXJhdG9yL1dlYktpdEV4cG9ydHMuZGVmLmluCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQvV2ViS2l0LnZjeHByb2ovV2ViS2l0RXhwb3J0R2VuZXJhdG9y L1dlYktpdEV4cG9ydHMuZGVmLmluCShyZXZpc2lvbiAxNTY2MzMpCisrKyBTb3VyY2UvV2ViS2l0 L1dlYktpdC52Y3hwcm9qL1dlYktpdEV4cG9ydEdlbmVyYXRvci9XZWJLaXRFeHBvcnRzLmRlZi5p bgkod29ya2luZyBjb3B5KQpAQCAtMzk3LDggKzM5Nyw4IEBAIEVYUE9SVFMKICAgICAgICAgc3lt Ym9sV2l0aFBvaW50ZXIoPz8wU3R5bGVTaGVldENvbnRlbnRzQFdlYkNvcmVAQEFBRUBQQVZTdHls ZVJ1bGVJbXBvcnRAMUBBQlZTdHJpbmdAV1RGQEBBQlVDU1NQYXJzZXJDb250ZXh0QDFAQFosID8/ MFN0eWxlU2hlZXRDb250ZW50c0BXZWJDb3JlQEBBRUFBQFBFQVZTdHlsZVJ1bGVJbXBvcnRAMUBB RUJWU3RyaW5nQFdURkBAQUVCVUNTU1BhcnNlckNvbnRleHRAMUBAWikKICAgICAgICAgc3ltYm9s V2l0aFBvaW50ZXIoP2FkZFVzZXJTaGVldEBEb2N1bWVudFN0eWxlU2hlZXRDb2xsZWN0aW9uQFdl YkNvcmVAQFFBRVhWPyRQYXNzUmVmUHRyQFZTdHlsZVNoZWV0Q29udGVudHNAV2ViQ29yZUBAQFdU RkBAQFosID9hZGRVc2VyU2hlZXRARG9jdW1lbnRTdHlsZVNoZWV0Q29sbGVjdGlvbkBXZWJDb3Jl QEBRRUFBWFY/JFBhc3NSZWZQdHJAVlN0eWxlU2hlZXRDb250ZW50c0BXZWJDb3JlQEBAV1RGQEBA WikKICAgICAgICAgc3ltYm9sV2l0aFBvaW50ZXIoPz8xU3R5bGVTaGVldENvbnRlbnRzQFdlYkNv cmVAQFFBRUBYWiwgPz8xU3R5bGVTaGVldENvbnRlbnRzQFdlYkNvcmVAQFFFQUFAWFopCi0gICAg ICAgIHN5bWJvbFdpdGhQb2ludGVyKD9wYXVzZUFuaW1hdGlvbkF0VGltZUBBbmltYXRpb25Db250 cm9sbGVyQFdlYkNvcmVAQFFBRV9OUEFWUmVuZGVyT2JqZWN0QDJAQUJWQXRvbWljU3RyaW5nQFdU RkBATkBaLCA/cGF1c2VBbmltYXRpb25BdFRpbWVAQW5pbWF0aW9uQ29udHJvbGxlckBXZWJDb3Jl QEBRRUFBX05QRUFWUmVuZGVyT2JqZWN0QDJAQUVCVkF0b21pY1N0cmluZ0BXVEZAQE5AWikKLSAg ICAgICAgc3ltYm9sV2l0aFBvaW50ZXIoP3BhdXNlVHJhbnNpdGlvbkF0VGltZUBBbmltYXRpb25D b250cm9sbGVyQFdlYkNvcmVAQFFBRV9OUEFWUmVuZGVyT2JqZWN0QDJAQUJWU3RyaW5nQFdURkBA TkBaLCA/cGF1c2VUcmFuc2l0aW9uQXRUaW1lQEFuaW1hdGlvbkNvbnRyb2xsZXJAV2ViQ29yZUBA UUVBQV9OUEVBVlJlbmRlck9iamVjdEAyQEFFQlZTdHJpbmdAV1RGQEBOQFopCisgICAgICAgIHN5 bWJvbFdpdGhQb2ludGVyKD9wYXVzZUFuaW1hdGlvbkF0VGltZUBBbmltYXRpb25Db250cm9sbGVy QFdlYkNvcmVAQFFBRV9OUEFWUmVuZGVyRWxlbWVudEAyQEFCVkF0b21pY1N0cmluZ0BXVEZAQE5A WiwgP3BhdXNlQW5pbWF0aW9uQXRUaW1lQEFuaW1hdGlvbkNvbnRyb2xsZXJAV2ViQ29yZUBAUUVB QV9OUEVBVlJlbmRlckVsZW1lbnRAMkBBRUJWQXRvbWljU3RyaW5nQFdURkBATkBaKQorICAgICAg ICBzeW1ib2xXaXRoUG9pbnRlcig/cGF1c2VUcmFuc2l0aW9uQXRUaW1lQEFuaW1hdGlvbkNvbnRy b2xsZXJAV2ViQ29yZUBAUUFFX05QQVZSZW5kZXJFbGVtZW50QDJAQUJWU3RyaW5nQFdURkBATkBa LCA/cGF1c2VUcmFuc2l0aW9uQXRUaW1lQEFuaW1hdGlvbkNvbnRyb2xsZXJAV2ViQ29yZUBAUUVB QV9OUEVBVlJlbmRlckVsZW1lbnRAMkBBRUJWU3RyaW5nQFdURkBATkBaKQogICAgICAgICBzeW1i b2xXaXRoUG9pbnRlcig/YWRkRnJvbUxpdGVyYWxEYXRhQEF0b21pY1N0cmluZ0BXVEZAQENBP0FW PyRQYXNzUmVmUHRyQFZTdHJpbmdJbXBsQFdURkBAQDJAUEJESUBaLCA/YWRkRnJvbUxpdGVyYWxE YXRhQEF0b21pY1N0cmluZ0BXVEZAQENBP0FWPyRQYXNzUmVmUHRyQFZTdHJpbmdJbXBsQFdURkBA QDJAUEVCRElAWikKICAgICAgICAgc3ltYm9sV2l0aFBvaW50ZXIoP21lbW9yeUNhY2hlQFdlYkNv cmVAQFlBUEFWTWVtb3J5Q2FjaGVAMUBYWiwgP21lbW9yeUNhY2hlQFdlYkNvcmVAQFlBUEVBVk1l bW9yeUNhY2hlQDFAWFopCiAgICAgICAgIHN5bWJvbFdpdGhQb2ludGVyKD9yZXNvdXJjZUZvclVS TEBNZW1vcnlDYWNoZUBXZWJDb3JlQEBRQUVQQVZDYWNoZWRSZXNvdXJjZUAyQEFCVlVSTEAyQEBa LCA/cmVzb3VyY2VGb3JVUkxATWVtb3J5Q2FjaGVAV2ViQ29yZUBAUUVBQVBFQVZDYWNoZWRSZXNv dXJjZUAyQEFFQlZVUkxAMkBAWikKSW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NjY0 OSkKKysrIFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDEzLTA5LTMwICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2su Y29tPgorCisgICAgICAgIFtXaW5dIENvbXBpbGUgZXJyb3JzIGluIFdlYktpdC4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMjEwNgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViRnJhbWUuY3BwOgor ICAgICAgICAoV2ViRnJhbWU6OnBhdXNlQW5pbWF0aW9uKTogVXNlIHRvUmVuZGVyRWxlbWVudCgp IHRvIGNhc3QgdG8gY29ycmVjdCB0eXBlLgorICAgICAgICAoV2ViRnJhbWU6OnBhdXNlVHJhbnNp dGlvbik6IERpdHRvLgorCiAyMDEzLTA5LTI3ICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBs ZS5jb20+CiAKICAgICAgICAgW1dpbmRvd3NdIFVucmV2aWV3ZWQgYnVpbGQgZml4IGZvbGxvd2lu ZyByMTU2NTYwLgpJbmRleDogU291cmNlL1dlYktpdC93aW4vV2ViRnJhbWUuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQvd2luL1dlYkZyYW1lLmNwcAkocmV2aXNpb24gMTU2NjQ3KQor KysgU291cmNlL1dlYktpdC93aW4vV2ViRnJhbWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NCw2 ICs2NCw3IEBACiAjaW5jbHVkZSA8V2ViQ29yZS9FdmVudC5oPgogI2luY2x1ZGUgPFdlYkNvcmUv RXZlbnRIYW5kbGVyLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9Gb3JtU3RhdGUuaD4KKyNpbmNsdWRl IDxXZWJDb3JlL0ZyYW1lLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9GcmFtZUxvYWRlci5oPgogI2lu Y2x1ZGUgPFdlYkNvcmUvRnJhbWVMb2FkUmVxdWVzdC5oPgogI2luY2x1ZGUgPFdlYkNvcmUvRnJh bWVUcmVlLmg+CkBAIC0xMjI4LDcgKzEyMjksNyBAQCBIUkVTVUxUIFdlYkZyYW1lOjpwYXVzZUFu aW1hdGlvbihCU1RSIGFuCiAgICAgaWYgKCFkb21Ob2RlKQogICAgICAgICByZXR1cm4gRV9GQUlM OwogCi0gICAgKmFuaW1hdGlvbldhc1J1bm5pbmcgPSBmcmFtZS0+YW5pbWF0aW9uKCkucGF1c2VB bmltYXRpb25BdFRpbWUoZG9tTm9kZS0+bm9kZSgpLT5yZW5kZXJlcigpLCBTdHJpbmcoYW5pbWF0 aW9uTmFtZSwgU3lzU3RyaW5nTGVuKGFuaW1hdGlvbk5hbWUpKSwgc2Vjb25kc0Zyb21Ob3cpOwor ICAgICphbmltYXRpb25XYXNSdW5uaW5nID0gZnJhbWUtPmFuaW1hdGlvbigpLnBhdXNlQW5pbWF0 aW9uQXRUaW1lKHRvUmVuZGVyRWxlbWVudChkb21Ob2RlLT5ub2RlKCktPnJlbmRlcmVyKCkpLCBT dHJpbmcoYW5pbWF0aW9uTmFtZSwgU3lzU3RyaW5nTGVuKGFuaW1hdGlvbk5hbWUpKSwgc2Vjb25k c0Zyb21Ob3cpOwogICAgIHJldHVybiBTX09LOwogfQogCkBAIC0xMjQ3LDcgKzEyNDgsNyBAQCBI UkVTVUxUIFdlYkZyYW1lOjpwYXVzZVRyYW5zaXRpb24oQlNUUiBwCiAgICAgaWYgKCFkb21Ob2Rl KQogICAgICAgICByZXR1cm4gRV9GQUlMOwogCi0gICAgKnRyYW5zaXRpb25XYXNSdW5uaW5nID0g ZnJhbWUtPmFuaW1hdGlvbigpLnBhdXNlVHJhbnNpdGlvbkF0VGltZShkb21Ob2RlLT5ub2RlKCkt PnJlbmRlcmVyKCksIFN0cmluZyhwcm9wZXJ0eU5hbWUsIFN5c1N0cmluZ0xlbihwcm9wZXJ0eU5h bWUpKSwgc2Vjb25kc0Zyb21Ob3cpOworICAgICp0cmFuc2l0aW9uV2FzUnVubmluZyA9IGZyYW1l LT5hbmltYXRpb24oKS5wYXVzZVRyYW5zaXRpb25BdFRpbWUodG9SZW5kZXJFbGVtZW50KGRvbU5v ZGUtPm5vZGUoKS0+cmVuZGVyZXIoKSksIFN0cmluZyhwcm9wZXJ0eU5hbWUsIFN5c1N0cmluZ0xl bihwcm9wZXJ0eU5hbWUpKSwgc2Vjb25kc0Zyb21Ob3cpOwogICAgIHJldHVybiBTX09LOwogfQog Cg==