122104 2013-09-30 06:35:07 -0700 [ATK] Expose state of aria-invalid as ATK_STATE_INVALID_ENTRY 2013-10-08 03:54:04 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 mario webkit-unassigned aboxhall apinheiro cfleizach commit-queue dmazzoni jdiggs webkit-bug-importer oldest_to_newest 934566 0 mario 2013-09-30 06:35:07 -0700 Besides exposing the value of aria-invalid as a text attribute (see bug 122015), we need to expose this attribute as well as a state for the given object, by means of ATK_STATE_INVALID_ENTRY 934567 1 webkit-bug-importer 2013-09-30 06:36:11 -0700 <rdar://problem/15110696> 934568 2 mario 2013-09-30 06:47:26 -0700 Depending on bug 122015, since the changes in DRT/WKTR will be based on the patch for that bug 935785 3 213251 mario 2013-10-03 08:45:48 -0700 Created attachment 213251 Patch proposal 935830 4 213251 cfleizach 2013-10-03 09:50:00 -0700 Comment on attachment 213251 Patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=213251&action=review > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:729 > + if (!invalidStatus.isEmpty() && invalidStatus != "false") invalidStatus should never be empty based on previous patch you submitted > Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:1045 > + // If no text attribute was found, just return what the state says. this comment is not necessary. you're just explaining what the code does rather than why it does it > Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:1051 > + if (isInvalidState != (attributeValue != "false")) this is a little confusing. maybe split this into to two if/if statements for clarity? 936150 5 213346 mario 2013-10-04 02:43:10 -0700 Created attachment 213346 Patch proposal (In reply to comment #4) > (From update of attachment 213251 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=213251&action=review > > > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:729 > > + if (!invalidStatus.isEmpty() && invalidStatus != "false") > > invalidStatus should never be empty based on previous patch you submitted Argh... true. Changed it > > Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:1045 > > + // If no text attribute was found, just return what the state says. > > this comment is not necessary. you're just explaining what the code does rather than why it does it > Removed > > Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:1051 > > + if (isInvalidState != (attributeValue != "false")) > > this is a little confusing. maybe split this into to two if/if statements for clarity? I replaced it with this: bool isAriaInvalid = attributeValue != "false"; if (isInvalidState != isAriaInvalid) { return JSStringCreateWithCharacters(0, 0); } I guess that way is more clear now. 937484 6 mario 2013-10-08 03:54:04 -0700 Committed r157096: <http://trac.webkit.org/changeset/157096> 213251 2013-10-03 08:45:48 -0700 2013-10-04 02:43:10 -0700 Patch proposal 0001-2013-09-30-Mario-Sanchez-Prada-mario.prada-samsung.c.patch text/plain 7347 mario RnJvbSBjYzVjZWY4NzJmZjUyNDUwMDE1NThlMzcyNjVhYTJiZTg0ODA1ZWI3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtYXJpby5wcmFkYUBzYW1z dW5nLmNvbT4KRGF0ZTogTW9uLCAzMCBTZXAgMjAxMyAxNDo0NDo0NiArMDEwMApTdWJqZWN0OiBb UEFUQ0hdIDIwMTMtMDktMzAgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtYXJpby5wcmFkYUBzYW1z dW5nLmNvbT4KCiAgICAgICAgW0FUS10gRXhwb3NlIHN0YXRlIG9mIGFyaWEtaW52YWxpZCBhcyBB VEtfU1RBVEVfSU5WQUxJRF9FTlRSWQogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMjIxMDQKCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CgogICAgICAgIE1hcCBpbnZhbGlkIHN0YXRlIG9mIGFuIEFjY2Vzc2liaWxpdHlPYmplY3QgdG8g dGhlIHByb3BlciBBdGtTdGF0ZS4KCiAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRB Y2Nlc3NpYmxlV3JhcHBlckF0ay5jcHA6CiAgICAgICAgKHNldEF0a1N0YXRlU2V0RnJvbUNvcmVP YmplY3QpOiBBZGQgdGhlIG1hcHBpbmcuCgoyMDEzLTA5LTMwICBNYXJpbyBTYW5jaGV6IFByYWRh ICA8bWFyaW8ucHJhZGFAc2Ftc3VuZy5jb20+CgogICAgICAgIFtBVEtdIEV4cG9zZSBzdGF0ZSBv ZiBhcmlhLWludmFsaWQgYXMgQVRLX1NUQVRFX0lOVkFMSURfRU5UUlkKICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIyMTA0CgogICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBVcGRhdGVkIHN0cmluZ0F0dHJpYnV0ZVZhbHVl IHRvIGRvdWJsZSBjaGVjayB0aGF0IHRoZSBleHBvc3VyZSBvZgogICAgICAgIGFyaWEtaW52YWxp ZCBhcyBhIHN0YXRlIGlzIGNvbnNpc3RlbnQgd2l0aCBpdHMgZXhwb3N1cmUgYXMgYSB0ZXh0CiAg ICAgICAgYXR0cmlidXRlIGFzIHdlbGwsIHdoZW4gaXQgYXBwbGllcyAoaW1wbGVtZW50YXRpb25z IG9mIEF0a1RleHQpLgoKICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2F0ay9BY2Nlc3NpYmlsaXR5 VUlFbGVtZW50QXRrLmNwcDoKICAgICAgICAoQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6c3RyaW5n QXR0cmlidXRlVmFsdWUpOiBBZGQgZG91YmxlIGNoZWNrLgogICAgICAgICogV2ViS2l0VGVzdFJ1 bm5lci9JbmplY3RlZEJ1bmRsZS9hdGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEF0ay5jcHA6CiAg ICAgICAgKFdUUjo6QWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6c3RyaW5nQXR0cmlidXRlVmFsdWUp OiBEaXR0by4KLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgfCAgIDEyICsrKysrKysrKysrKwogLi4uL2FjY2Vzc2liaWxpdHkvYXRrL1dl YktpdEFjY2Vzc2libGVXcmFwcGVyQXRrLmNwcCAgIHwgICAgNCArKysrCiBUb29scy9DaGFuZ2VM b2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE2ICsrKysrKysr KysrKysrKysKIFRvb2xzL0R1bXBSZW5kZXJUcmVlL2F0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50 QXRrLmNwcCB8ICAgMTQgKysrKysrKysrKysrKysKIC4uLi9JbmplY3RlZEJ1bmRsZS9hdGsvQWNj ZXNzaWJpbGl0eVVJRWxlbWVudEF0ay5jcHAgICB8ICAgMTQgKysrKysrKysrKysrKysKIDUgZmls ZXMgY2hhbmdlZCwgNjAgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzYTJjNDU2Li5kODE1 NGJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDktMzAgIE1hcmlvIFNhbmNo ZXogUHJhZGEgIDxtYXJpby5wcmFkYUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbQVRLXSBFeHBv c2Ugc3RhdGUgb2YgYXJpYS1pbnZhbGlkIGFzIEFUS19TVEFURV9JTlZBTElEX0VOVFJZCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjIxMDQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYXAgaW52YWxpZCBz dGF0ZSBvZiBhbiBBY2Nlc3NpYmlsaXR5T2JqZWN0IHRvIHRoZSBwcm9wZXIgQXRrU3RhdGUuCisK KyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlV3JhcHBlckF0ay5j cHA6CisgICAgICAgIChzZXRBdGtTdGF0ZVNldEZyb21Db3JlT2JqZWN0KTogQWRkIHRoZSBtYXBw aW5nLgorCiAyMDEzLTEwLTAyICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bWFyaW8ucHJhZGFAc2Ft c3VuZy5jb20+CiAKICAgICAgICAgW0FUS10gRXhwb3NlIGFyaWEtaW52YWxpZCBhcyBhIHRleHQg YXR0cmlidXRlIChub3Qgb2JqZWN0IGF0dHJpYnV0ZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVXcmFwcGVyQXRrLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVXcmFwcGVyQXRr LmNwcAppbmRleCBkYjFmNjBkLi4yNzEyZTA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlV3JhcHBlckF0ay5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZVdyYXBwZXJBdGsu Y3BwCkBAIC03MjUsNiArNzI1LDEwIEBAIHN0YXRpYyB2b2lkIHNldEF0a1N0YXRlU2V0RnJvbUNv cmVPYmplY3QoQWNjZXNzaWJpbGl0eU9iamVjdCogY29yZU9iamVjdCwgQXRrU3RhCiAgICAgaWYg KGNvcmVPYmplY3QtPmlzSW5kZXRlcm1pbmF0ZSgpKQogICAgICAgICBhdGtfc3RhdGVfc2V0X2Fk ZF9zdGF0ZShzdGF0ZVNldCwgQVRLX1NUQVRFX0lOREVURVJNSU5BVEUpOwogCisgICAgU3RyaW5n IGludmFsaWRTdGF0dXMgPSBjb3JlT2JqZWN0LT5pbnZhbGlkU3RhdHVzKCkuc3RyaW5nKCk7Cisg ICAgaWYgKCFpbnZhbGlkU3RhdHVzLmlzRW1wdHkoKSAmJiBpbnZhbGlkU3RhdHVzICE9ICJmYWxz ZSIpCisgICAgICAgIGF0a19zdGF0ZV9zZXRfYWRkX3N0YXRlKHN0YXRlU2V0LCBBVEtfU1RBVEVf SU5WQUxJRF9FTlRSWSk7CisKICAgICBpZiAoY29yZU9iamVjdC0+aXNNdWx0aVNlbGVjdGFibGUo KSkKICAgICAgICAgYXRrX3N0YXRlX3NldF9hZGRfc3RhdGUoc3RhdGVTZXQsIEFUS19TVEFURV9N VUxUSVNFTEVDVEFCTEUpOwogCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9D aGFuZ2VMb2cKaW5kZXggOWI5ZDBiMy4uY2QyNTY1MCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdl TG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA5LTMwICBN YXJpbyBTYW5jaGV6IFByYWRhICA8bWFyaW8ucHJhZGFAc2Ftc3VuZy5jb20+CisKKyAgICAgICAg W0FUS10gRXhwb3NlIHN0YXRlIG9mIGFyaWEtaW52YWxpZCBhcyBBVEtfU1RBVEVfSU5WQUxJRF9F TlRSWQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIy MTA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBk YXRlZCBzdHJpbmdBdHRyaWJ1dGVWYWx1ZSB0byBkb3VibGUgY2hlY2sgdGhhdCB0aGUgZXhwb3N1 cmUgb2YKKyAgICAgICAgYXJpYS1pbnZhbGlkIGFzIGEgc3RhdGUgaXMgY29uc2lzdGVudCB3aXRo IGl0cyBleHBvc3VyZSBhcyBhIHRleHQKKyAgICAgICAgYXR0cmlidXRlIGFzIHdlbGwsIHdoZW4g aXQgYXBwbGllcyAoaW1wbGVtZW50YXRpb25zIG9mIEF0a1RleHQpLgorCisgICAgICAgICogRHVt cFJlbmRlclRyZWUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwOgorICAgICAgICAo QWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6c3RyaW5nQXR0cmlidXRlVmFsdWUpOiBBZGQgZG91Ymxl IGNoZWNrLgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvYXRrL0Fj Y2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwOgorICAgICAgICAoV1RSOjpBY2Nlc3NpYmlsaXR5 VUlFbGVtZW50OjpzdHJpbmdBdHRyaWJ1dGVWYWx1ZSk6IERpdHRvLgorCiAyMDEzLTEwLTAyICBN YXJpbyBTYW5jaGV6IFByYWRhICA8bWFyaW8ucHJhZGFAc2Ftc3VuZy5jb20+CiAKICAgICAgICAg W0FUS10gRXhwb3NlIGFyaWEtaW52YWxpZCBhcyBhIHRleHQgYXR0cmlidXRlIChub3Qgb2JqZWN0 IGF0dHJpYnV0ZSkKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2F0ay9BY2Nlc3Np YmlsaXR5VUlFbGVtZW50QXRrLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2F0ay9BY2Nlc3Np YmlsaXR5VUlFbGVtZW50QXRrLmNwcAppbmRleCA3OGFkOWYxLi5mMGM1ODM5IDEwMDY0NAotLS0g YS9Ub29scy9EdW1wUmVuZGVyVHJlZS9hdGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEF0ay5jcHAK KysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsu Y3BwCkBAIC0xMDM4LDYgKzEwMzgsMjAgQEAgSlNTdHJpbmdSZWYgQWNjZXNzaWJpbGl0eVVJRWxl bWVudDo6c3RyaW5nQXR0cmlidXRlVmFsdWUoSlNTdHJpbmdSZWYgYXR0cmlidXRlKQogICAgIGlm IChhdHRyaWJ1dGVWYWx1ZS5pc0VtcHR5KCkgJiYgQVRLX0lTX1RFWFQobV9lbGVtZW50KSkKICAg ICAgICAgYXR0cmlidXRlVmFsdWUgPSBnZXRBdHRyaWJ1dGVTZXRWYWx1ZUZvcklkKEFUS19PQkpF Q1QobV9lbGVtZW50KSwgVGV4dEF0dHJpYnV0ZVR5cGUsIGF0a0F0dHJpYnV0ZU5hbWUpOwogCisg ICAgLy8gQWRkaXRpb25hbCBjaGVjayB0byBtYWtlIHN1cmUgdGhhdCB0aGUgZXhwb3N1cmUgb2Yg dGhlIHN0YXRlIEFUS19TVEFURV9JTlZBTElEX0VOVFJZCisgICAgLy8gaXMgY29uc2lzdGVudCB3 aXRoIHRoZSBleHBvc3VyZSBvZiBhcmlhLWludmFsaWQgYXMgYSB0ZXh0IGF0dHJpYnV0ZSwgaWYg cHJlc2VudC4KKyAgICBpZiAoYXRrQXR0cmlidXRlTmFtZSA9PSBhdHRyaWJ1dGVzTWFwW0ludmFs aWROYW1lSW5kZXhdW0F0a0RvbWFpbl0pIHsKKyAgICAgICAgYm9vbCBpc0ludmFsaWRTdGF0ZSA9 IGNoZWNrRWxlbWVudFN0YXRlKG1fZWxlbWVudCwgQVRLX1NUQVRFX0lOVkFMSURfRU5UUlkpOwor ICAgICAgICAvLyBJZiBubyB0ZXh0IGF0dHJpYnV0ZSB3YXMgZm91bmQsIGp1c3QgcmV0dXJuIHdo YXQgdGhlIHN0YXRlIHNheXMuCisgICAgICAgIGlmIChhdHRyaWJ1dGVWYWx1ZS5pc0VtcHR5KCkp CisgICAgICAgICAgICByZXR1cm4gSlNTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcoaXNJbnZh bGlkU3RhdGUgPyAidHJ1ZSIgOiAiZmFsc2UiKTsKKworICAgICAgICAvLyBJZiB0aGUgdGV4dCBh dHRyaWJ1dGUgd2FzIHRoZXJlLCBjaGVjayB0aGF0IGl0J3MgY29uc2lzdGVudCB3aXRoCisgICAg ICAgIC8vIHdoYXQgdGhlIHN0YXRlIHNheXMgb3IgZm9yY2UgdGhlIHRlc3QgdG8gZmFpbCBvdGhl cndpc2UuCisgICAgICAgIGlmIChpc0ludmFsaWRTdGF0ZSAhPSAoYXR0cmlidXRlVmFsdWUgIT0g ImZhbHNlIikpCisgICAgICAgICAgICByZXR1cm4gSlNTdHJpbmdDcmVhdGVXaXRoQ2hhcmFjdGVy cygwLCAwKTsKKyAgICB9CisKICAgICByZXR1cm4gSlNTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJp bmcoYXR0cmlidXRlVmFsdWUudXRmOCgpLmRhdGEoKSk7CiB9CiAKZGlmZiAtLWdpdCBhL1Rvb2xz L1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1l bnRBdGsuY3BwIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9hdGsvQWNj ZXNzaWJpbGl0eVVJRWxlbWVudEF0ay5jcHAKaW5kZXggMDExNzFjMi4uYjYzMjU0YSAxMDA2NDQK LS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9hdGsvQWNjZXNzaWJp bGl0eVVJRWxlbWVudEF0ay5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3Rl ZEJ1bmRsZS9hdGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEF0ay5jcHAKQEAgLTY1OCw2ICs2NTgs MjAgQEAgSlNSZXRhaW5QdHI8SlNTdHJpbmdSZWY+IEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OnN0 cmluZ0F0dHJpYnV0ZVZhbHVlKEpTU3RyaW5nUmUKICAgICBpZiAoYXR0cmlidXRlVmFsdWUuaXNF bXB0eSgpICYmIEFUS19JU19URVhUKG1fZWxlbWVudC5nZXQoKSkpCiAgICAgICAgIGF0dHJpYnV0 ZVZhbHVlID0gZ2V0QXR0cmlidXRlU2V0VmFsdWVGb3JJZChBVEtfT0JKRUNUKG1fZWxlbWVudC5n ZXQoKSksIFRleHRBdHRyaWJ1dGVUeXBlLCBhdGtBdHRyaWJ1dGVOYW1lKTsKIAorICAgIC8vIEFk ZGl0aW9uYWwgY2hlY2sgdG8gbWFrZSBzdXJlIHRoYXQgdGhlIGV4cG9zdXJlIG9mIHRoZSBzdGF0 ZSBBVEtfU1RBVEVfSU5WQUxJRF9FTlRSWQorICAgIC8vIGlzIGNvbnNpc3RlbnQgd2l0aCB0aGUg ZXhwb3N1cmUgb2YgYXJpYS1pbnZhbGlkIGFzIGEgdGV4dCBhdHRyaWJ1dGUsIGlmIHByZXNlbnQu CisgICAgaWYgKGF0a0F0dHJpYnV0ZU5hbWUgPT0gYXR0cmlidXRlc01hcFtJbnZhbGlkTmFtZUlu ZGV4XVtBdGtEb21haW5dKSB7CisgICAgICAgIGJvb2wgaXNJbnZhbGlkU3RhdGUgPSBjaGVja0Vs ZW1lbnRTdGF0ZShtX2VsZW1lbnQuZ2V0KCksIEFUS19TVEFURV9JTlZBTElEX0VOVFJZKTsKKyAg ICAgICAgLy8gSWYgbm8gdGV4dCBhdHRyaWJ1dGUgd2FzIGZvdW5kLCBqdXN0IHJldHVybiB3aGF0 IHRoZSBzdGF0ZSBzYXlzLgorICAgICAgICBpZiAoYXR0cmlidXRlVmFsdWUuaXNFbXB0eSgpKQor ICAgICAgICAgICAgcmV0dXJuIEpTU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKGlzSW52YWxp ZFN0YXRlID8gInRydWUiIDogImZhbHNlIik7CisKKyAgICAgICAgLy8gSWYgdGhlIHRleHQgYXR0 cmlidXRlIHdhcyB0aGVyZSwgY2hlY2sgdGhhdCBpdCdzIGNvbnNpc3RlbnQgd2l0aAorICAgICAg ICAvLyB3aGF0IHRoZSBzdGF0ZSBzYXlzIG9yIGZvcmNlIHRoZSB0ZXN0IHRvIGZhaWwgb3RoZXJ3 aXNlLgorICAgICAgICBpZiAoaXNJbnZhbGlkU3RhdGUgIT0gKGF0dHJpYnV0ZVZhbHVlICE9ICJm YWxzZSIpKQorICAgICAgICAgICAgcmV0dXJuIEpTU3RyaW5nQ3JlYXRlV2l0aENoYXJhY3RlcnMo MCwgMCk7CisgICAgfQorCiAgICAgcmV0dXJuIEpTU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5n KGF0dHJpYnV0ZVZhbHVlLnV0ZjgoKS5kYXRhKCkpOwogfQogCi0tIAoxLjcuMTAuNAoK 213346 2013-10-04 02:43:10 -0700 2013-10-07 12:12:58 -0700 Patch proposal 0001-2013-09-30-Mario-Sanchez-Prada-mario.prada-samsung.c.patch text/plain 7197 mario RnJvbSA5Y2Y4MjdmYTVhZDQyOGQyMmY3NWI0YTc0ZDU2MzBjZGJkY2IyNzNhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtYXJpby5wcmFkYUBzYW1z dW5nLmNvbT4KRGF0ZTogTW9uLCAzMCBTZXAgMjAxMyAxNDo0NDo0NiArMDEwMApTdWJqZWN0OiBb UEFUQ0hdIDIwMTMtMDktMzAgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtYXJpby5wcmFkYUBzYW1z dW5nLmNvbT4KCiAgICAgICAgW0FUS10gRXhwb3NlIHN0YXRlIG9mIGFyaWEtaW52YWxpZCBhcyBB VEtfU1RBVEVfSU5WQUxJRF9FTlRSWQogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMjIxMDQKCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CgogICAgICAgIE1hcCBpbnZhbGlkIHN0YXRlIG9mIGFuIEFjY2Vzc2liaWxpdHlPYmplY3QgdG8g dGhlIHByb3BlciBBdGtTdGF0ZS4KCiAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRB Y2Nlc3NpYmxlV3JhcHBlckF0ay5jcHA6CiAgICAgICAgKHNldEF0a1N0YXRlU2V0RnJvbUNvcmVP YmplY3QpOiBBZGQgdGhlIG1hcHBpbmcuCgoyMDEzLTA5LTMwICBNYXJpbyBTYW5jaGV6IFByYWRh ICA8bWFyaW8ucHJhZGFAc2Ftc3VuZy5jb20+CgogICAgICAgIFtBVEtdIEV4cG9zZSBzdGF0ZSBv ZiBhcmlhLWludmFsaWQgYXMgQVRLX1NUQVRFX0lOVkFMSURfRU5UUlkKICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIyMTA0CgogICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBVcGRhdGVkIHN0cmluZ0F0dHJpYnV0ZVZhbHVl IHRvIGRvdWJsZSBjaGVjayB0aGF0IHRoZSBleHBvc3VyZSBvZgogICAgICAgIGFyaWEtaW52YWxp ZCBhcyBhIHN0YXRlIGlzIGNvbnNpc3RlbnQgd2l0aCBpdHMgZXhwb3N1cmUgYXMgYSB0ZXh0CiAg ICAgICAgYXR0cmlidXRlIGFzIHdlbGwsIHdoZW4gaXQgYXBwbGllcyAoaW1wbGVtZW50YXRpb25z IG9mIEF0a1RleHQpLgoKICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2F0ay9BY2Nlc3NpYmlsaXR5 VUlFbGVtZW50QXRrLmNwcDoKICAgICAgICAoQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6c3RyaW5n QXR0cmlidXRlVmFsdWUpOiBBZGQgZG91YmxlIGNoZWNrLgogICAgICAgICogV2ViS2l0VGVzdFJ1 bm5lci9JbmplY3RlZEJ1bmRsZS9hdGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEF0ay5jcHA6CiAg ICAgICAgKFdUUjo6QWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6c3RyaW5nQXR0cmlidXRlVmFsdWUp OiBEaXR0by4KLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgfCAgIDEyICsrKysrKysrKysrKwogLi4uL2FjY2Vzc2liaWxpdHkvYXRrL1dl YktpdEFjY2Vzc2libGVXcmFwcGVyQXRrLmNwcCAgIHwgICAgMyArKysKIFRvb2xzL0NoYW5nZUxv ZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTYgKysrKysrKysr KysrKysrKwogVG9vbHMvRHVtcFJlbmRlclRyZWUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRB dGsuY3BwIHwgICAxNCArKysrKysrKysrKysrKwogLi4uL0luamVjdGVkQnVuZGxlL2F0ay9BY2Nl c3NpYmlsaXR5VUlFbGVtZW50QXRrLmNwcCAgIHwgICAxNCArKysrKysrKysrKysrKwogNSBmaWxl cyBjaGFuZ2VkLCA1OSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDNhMmM0NTYuLmQ4MTU0 YmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMy0wOS0zMCAgTWFyaW8gU2FuY2hl eiBQcmFkYSAgPG1hcmlvLnByYWRhQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtBVEtdIEV4cG9z ZSBzdGF0ZSBvZiBhcmlhLWludmFsaWQgYXMgQVRLX1NUQVRFX0lOVkFMSURfRU5UUlkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMjEwNAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1hcCBpbnZhbGlkIHN0 YXRlIG9mIGFuIEFjY2Vzc2liaWxpdHlPYmplY3QgdG8gdGhlIHByb3BlciBBdGtTdGF0ZS4KKwor ICAgICAgICAqIGFjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVXcmFwcGVyQXRrLmNw cDoKKyAgICAgICAgKHNldEF0a1N0YXRlU2V0RnJvbUNvcmVPYmplY3QpOiBBZGQgdGhlIG1hcHBp bmcuCisKIDIwMTMtMTAtMDIgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtYXJpby5wcmFkYUBzYW1z dW5nLmNvbT4KIAogICAgICAgICBbQVRLXSBFeHBvc2UgYXJpYS1pbnZhbGlkIGFzIGEgdGV4dCBh dHRyaWJ1dGUgKG5vdCBvYmplY3QgYXR0cmlidXRlKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZVdyYXBwZXJBdGsuY3BwIGIvU291 cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZVdyYXBwZXJBdGsu Y3BwCmluZGV4IGRiMWY2MGQuLjEwYTcyMTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Fj Y2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVXcmFwcGVyQXRrLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlV3JhcHBlckF0ay5j cHAKQEAgLTcyNSw2ICs3MjUsOSBAQCBzdGF0aWMgdm9pZCBzZXRBdGtTdGF0ZVNldEZyb21Db3Jl T2JqZWN0KEFjY2Vzc2liaWxpdHlPYmplY3QqIGNvcmVPYmplY3QsIEF0a1N0YQogICAgIGlmIChj b3JlT2JqZWN0LT5pc0luZGV0ZXJtaW5hdGUoKSkKICAgICAgICAgYXRrX3N0YXRlX3NldF9hZGRf c3RhdGUoc3RhdGVTZXQsIEFUS19TVEFURV9JTkRFVEVSTUlOQVRFKTsKIAorICAgIGlmIChjb3Jl T2JqZWN0LT5pbnZhbGlkU3RhdHVzKCkgIT0gImZhbHNlIikKKyAgICAgICAgYXRrX3N0YXRlX3Nl dF9hZGRfc3RhdGUoc3RhdGVTZXQsIEFUS19TVEFURV9JTlZBTElEX0VOVFJZKTsKKwogICAgIGlm IChjb3JlT2JqZWN0LT5pc011bHRpU2VsZWN0YWJsZSgpKQogICAgICAgICBhdGtfc3RhdGVfc2V0 X2FkZF9zdGF0ZShzdGF0ZVNldCwgQVRLX1NUQVRFX01VTFRJU0VMRUNUQUJMRSk7CiAKZGlmZiAt LWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5YjlkMGIzLi5j ZDI1NjUwIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTkgQEAKKzIwMTMtMDktMzAgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtYXJp by5wcmFkYUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbQVRLXSBFeHBvc2Ugc3RhdGUgb2YgYXJp YS1pbnZhbGlkIGFzIEFUS19TVEFURV9JTlZBTElEX0VOVFJZCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjIxMDQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGVkIHN0cmluZ0F0dHJpYnV0ZVZhbHVl IHRvIGRvdWJsZSBjaGVjayB0aGF0IHRoZSBleHBvc3VyZSBvZgorICAgICAgICBhcmlhLWludmFs aWQgYXMgYSBzdGF0ZSBpcyBjb25zaXN0ZW50IHdpdGggaXRzIGV4cG9zdXJlIGFzIGEgdGV4dAor ICAgICAgICBhdHRyaWJ1dGUgYXMgd2VsbCwgd2hlbiBpdCBhcHBsaWVzIChpbXBsZW1lbnRhdGlv bnMgb2YgQXRrVGV4dCkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9hdGsvQWNjZXNzaWJp bGl0eVVJRWxlbWVudEF0ay5jcHA6CisgICAgICAgIChBY2Nlc3NpYmlsaXR5VUlFbGVtZW50Ojpz dHJpbmdBdHRyaWJ1dGVWYWx1ZSk6IEFkZCBkb3VibGUgY2hlY2suCisgICAgICAgICogV2ViS2l0 VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9hdGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEF0ay5j cHA6CisgICAgICAgIChXVFI6OkFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OnN0cmluZ0F0dHJpYnV0 ZVZhbHVlKTogRGl0dG8uCisKIDIwMTMtMTAtMDIgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtYXJp by5wcmFkYUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbQVRLXSBFeHBvc2UgYXJpYS1pbnZhbGlk IGFzIGEgdGV4dCBhdHRyaWJ1dGUgKG5vdCBvYmplY3QgYXR0cmlidXRlKQpkaWZmIC0tZ2l0IGEv VG9vbHMvRHVtcFJlbmRlclRyZWUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwIGIv VG9vbHMvRHVtcFJlbmRlclRyZWUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwCmlu ZGV4IDc4YWQ5ZjEuLjViMzJkYjIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2F0 ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50QXRrLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJl ZS9hdGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEF0ay5jcHAKQEAgLTEwMzgsNiArMTAzOCwyMCBA QCBKU1N0cmluZ1JlZiBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50OjpzdHJpbmdBdHRyaWJ1dGVWYWx1 ZShKU1N0cmluZ1JlZiBhdHRyaWJ1dGUpCiAgICAgaWYgKGF0dHJpYnV0ZVZhbHVlLmlzRW1wdHko KSAmJiBBVEtfSVNfVEVYVChtX2VsZW1lbnQpKQogICAgICAgICBhdHRyaWJ1dGVWYWx1ZSA9IGdl dEF0dHJpYnV0ZVNldFZhbHVlRm9ySWQoQVRLX09CSkVDVChtX2VsZW1lbnQpLCBUZXh0QXR0cmli dXRlVHlwZSwgYXRrQXR0cmlidXRlTmFtZSk7CiAKKyAgICAvLyBBZGRpdGlvbmFsIGNoZWNrIHRv IG1ha2Ugc3VyZSB0aGF0IHRoZSBleHBvc3VyZSBvZiB0aGUgc3RhdGUgQVRLX1NUQVRFX0lOVkFM SURfRU5UUlkKKyAgICAvLyBpcyBjb25zaXN0ZW50IHdpdGggdGhlIGV4cG9zdXJlIG9mIGFyaWEt aW52YWxpZCBhcyBhIHRleHQgYXR0cmlidXRlLCBpZiBwcmVzZW50LgorICAgIGlmIChhdGtBdHRy aWJ1dGVOYW1lID09IGF0dHJpYnV0ZXNNYXBbSW52YWxpZE5hbWVJbmRleF1bQXRrRG9tYWluXSkg eworICAgICAgICBib29sIGlzSW52YWxpZFN0YXRlID0gY2hlY2tFbGVtZW50U3RhdGUobV9lbGVt ZW50LCBBVEtfU1RBVEVfSU5WQUxJRF9FTlRSWSk7CisgICAgICAgIGlmIChhdHRyaWJ1dGVWYWx1 ZS5pc0VtcHR5KCkpCisgICAgICAgICAgICByZXR1cm4gSlNTdHJpbmdDcmVhdGVXaXRoVVRGOENT dHJpbmcoaXNJbnZhbGlkU3RhdGUgPyAidHJ1ZSIgOiAiZmFsc2UiKTsKKworICAgICAgICAvLyBJ ZiB0aGUgdGV4dCBhdHRyaWJ1dGUgd2FzIHRoZXJlLCBjaGVjayB0aGF0IGl0J3MgY29uc2lzdGVu dCB3aXRoCisgICAgICAgIC8vIHdoYXQgdGhlIHN0YXRlIHNheXMgb3IgZm9yY2UgdGhlIHRlc3Qg dG8gZmFpbCBvdGhlcndpc2UuCisgICAgICAgIGJvb2wgaXNBcmlhSW52YWxpZCA9IGF0dHJpYnV0 ZVZhbHVlICE9ICJmYWxzZSI7CisgICAgICAgIGlmIChpc0ludmFsaWRTdGF0ZSAhPSBpc0FyaWFJ bnZhbGlkKQorICAgICAgICAgICAgcmV0dXJuIEpTU3RyaW5nQ3JlYXRlV2l0aENoYXJhY3RlcnMo MCwgMCk7CisgICAgfQorCiAgICAgcmV0dXJuIEpTU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5n KGF0dHJpYnV0ZVZhbHVlLnV0ZjgoKS5kYXRhKCkpOwogfQogCmRpZmYgLS1naXQgYS9Ub29scy9X ZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL2F0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50 QXRrLmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvYXRrL0FjY2Vz c2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwCmluZGV4IDAxMTcxYzIuLjJiNjJiNGUgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvYXRrL0FjY2Vzc2liaWxp dHlVSUVsZW1lbnRBdGsuY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRC dW5kbGUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwCkBAIC02NTgsNiArNjU4LDIw IEBAIEpTUmV0YWluUHRyPEpTU3RyaW5nUmVmPiBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50OjpzdHJp bmdBdHRyaWJ1dGVWYWx1ZShKU1N0cmluZ1JlCiAgICAgaWYgKGF0dHJpYnV0ZVZhbHVlLmlzRW1w dHkoKSAmJiBBVEtfSVNfVEVYVChtX2VsZW1lbnQuZ2V0KCkpKQogICAgICAgICBhdHRyaWJ1dGVW YWx1ZSA9IGdldEF0dHJpYnV0ZVNldFZhbHVlRm9ySWQoQVRLX09CSkVDVChtX2VsZW1lbnQuZ2V0 KCkpLCBUZXh0QXR0cmlidXRlVHlwZSwgYXRrQXR0cmlidXRlTmFtZSk7CiAKKyAgICAvLyBBZGRp dGlvbmFsIGNoZWNrIHRvIG1ha2Ugc3VyZSB0aGF0IHRoZSBleHBvc3VyZSBvZiB0aGUgc3RhdGUg QVRLX1NUQVRFX0lOVkFMSURfRU5UUlkKKyAgICAvLyBpcyBjb25zaXN0ZW50IHdpdGggdGhlIGV4 cG9zdXJlIG9mIGFyaWEtaW52YWxpZCBhcyBhIHRleHQgYXR0cmlidXRlLCBpZiBwcmVzZW50Lgor ICAgIGlmIChhdGtBdHRyaWJ1dGVOYW1lID09IGF0dHJpYnV0ZXNNYXBbSW52YWxpZE5hbWVJbmRl eF1bQXRrRG9tYWluXSkgeworICAgICAgICBib29sIGlzSW52YWxpZFN0YXRlID0gY2hlY2tFbGVt ZW50U3RhdGUobV9lbGVtZW50LmdldCgpLCBBVEtfU1RBVEVfSU5WQUxJRF9FTlRSWSk7CisgICAg ICAgIGlmIChhdHRyaWJ1dGVWYWx1ZS5pc0VtcHR5KCkpCisgICAgICAgICAgICByZXR1cm4gSlNT dHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcoaXNJbnZhbGlkU3RhdGUgPyAidHJ1ZSIgOiAiZmFs c2UiKTsKKworICAgICAgICAvLyBJZiB0aGUgdGV4dCBhdHRyaWJ1dGUgd2FzIHRoZXJlLCBjaGVj ayB0aGF0IGl0J3MgY29uc2lzdGVudCB3aXRoCisgICAgICAgIC8vIHdoYXQgdGhlIHN0YXRlIHNh eXMgb3IgZm9yY2UgdGhlIHRlc3QgdG8gZmFpbCBvdGhlcndpc2UuCisgICAgICAgIGJvb2wgaXNB cmlhSW52YWxpZCA9IGF0dHJpYnV0ZVZhbHVlICE9ICJmYWxzZSI7CisgICAgICAgIGlmIChpc0lu dmFsaWRTdGF0ZSAhPSBpc0FyaWFJbnZhbGlkKQorICAgICAgICAgICAgcmV0dXJuIEpTU3RyaW5n Q3JlYXRlV2l0aENoYXJhY3RlcnMoMCwgMCk7CisgICAgfQorCiAgICAgcmV0dXJuIEpTU3RyaW5n Q3JlYXRlV2l0aFVURjhDU3RyaW5nKGF0dHJpYnV0ZVZhbHVlLnV0ZjgoKS5kYXRhKCkpOwogfQog Ci0tIAoxLjcuMTAuNAoK