122072 2013-09-28 23:11:05 -0700 Refactor code for finding x86 scratch register. 2013-09-29 12:30:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 nrotem webkit-unassigned commit-queue oldest_to_newest 934336 0 nrotem 2013-09-28 23:11:05 -0700 Refactor code for finding x86 scratch register. 934337 1 212915 nrotem 2013-09-28 23:11:36 -0700 Created attachment 212915 Patch 934338 2 212915 buildbot 2013-09-28 23:44:26 -0700 Comment on attachment 212915 Patch Attachment 212915 did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/2635161 934340 3 212917 nrotem 2013-09-28 23:56:10 -0700 Created attachment 212917 Patch 934371 4 212917 ggaren 2013-09-29 12:06:22 -0700 Comment on attachment 212917 Patch r=me 934373 5 212917 commit-queue 2013-09-29 12:30:18 -0700 Comment on attachment 212917 Patch Clearing flags on attachment: 212917 Committed r156617: <http://trac.webkit.org/changeset/156617> 934374 6 commit-queue 2013-09-29 12:30:20 -0700 All reviewed patches have been landed. Closing bug. 212915 2013-09-28 23:11:36 -0700 2013-09-28 23:56:08 -0700 Patch bug-122072-20130928231135.patch text/plain 3601 nrotem U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2NDg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl ZjQ5MDM2MzdhYjAwNzkwMzJmYWQwNmM4ODEwYmJmMjUxNGE4MWVhLi45ZmE3NmY1Y2JlYzI5MDA5 ZDBkZmRhNzgzOTcyYjJhYThlMjI1ZTE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxMy0wOS0yOCAgTmFkYXYgUm90ZW0gIDxucm90ZW1AYXBwbGUuY29tPgor CisgICAgICAgIFJlZmFjdG9yIGNvZGUgZm9yIGZpbmRpbmcgeDg2IHNjcmF0Y2ggcmVnaXN0ZXIu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjIwNzIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGFzc2Vt Ymxlci9NYWNyb0Fzc2VtYmxlclg4NkNvbW1vbi5oOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2Vt Ymxlclg4NkNvbW1vbjo6Z2V0VW51c2VkUmVnaXN0ZXIpOgorICAgICAgICAoSlNDOjpNYWNyb0Fz c2VtYmxlclg4NkNvbW1vbjo6c3RvcmU4KToKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJY ODZDb21tb246OnN0b3JlMTYpOgorCiAyMDEzLTA5LTI2ICBDb21taXQgUXVldWUgIDxjb21taXQt cXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTU2 NDc0LgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fz c2VtYmxlclg4NkNvbW1vbi5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNy b0Fzc2VtYmxlclg4NkNvbW1vbi5oCmluZGV4IDY2YTVkYzhhYzUwYzRiMjQ4NzMzNGY2MjA2M2Qw ODk1OTM3NzNjMTAuLjllNzAxMWRlMGJkYjA3NjVlZTE0ZWQzNWY0ZjdjNzRlMzBjZTdkYjYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJY ODZDb21tb24uaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNz ZW1ibGVyWDg2Q29tbW9uLmgKQEAgLTYwMSw3ICs2MDEsMTkgQEAgcHVibGljOgogICAgICAgICBB U1NFUlQoLTEyOCA8PSBpbW0ubV92YWx1ZSAmJiBpbW0ubV92YWx1ZSA8IDEyOCk7CiAgICAgICAg IG1fYXNzZW1ibGVyLm1vdmJfaThtKGltbS5tX3ZhbHVlLCBhZGRyZXNzLm9mZnNldCwgYWRkcmVz cy5iYXNlLCBhZGRyZXNzLmluZGV4LCBhZGRyZXNzLnNjYWxlKTsKICAgICB9Ci0gICAgCisKKyAg ICBzdGF0aWMgQUxXQVlTX0lOTElORSBSZWdpc3RlcklEIGdldFVudXNlZFJlZ2lzdGVyKEJhc2VJ bmRleCBhZGRyZXNzKQorICAgIHsKKyAgICAgICAgaWYgKGFkZHJlc3MuYmFzZSAhPSBYODZSZWdp c3RlcnM6OmVheCAmJiBhZGRyZXNzLmluZGV4ICE9IFg4NlJlZ2lzdGVyczo6ZWF4KQorICAgICAg ICAgICAgcmV0dXJuIFg4NlJlZ2lzdGVyczo6ZWF4OworCisgICAgICAgIGlmIChhZGRyZXNzLmJh c2UgIT0gWDg2UmVnaXN0ZXJzOjplYnggJiYgYWRkcmVzcy5pbmRleCAhPSBYODZSZWdpc3RlcnM6 OmVieCkKKyAgICAgICAgICAgIHJldHVybiBYODZSZWdpc3RlcnM6OmVieDsKKworICAgICAgICBB U1NFUlQoYWRkcmVzcy5iYXNlICE9IFg4NlJlZ2lzdGVyczo6ZWN4ICYmIGFkZHJlc3MuaW5kZXgg IT0gWDg2UmVnaXN0ZXJzOjplY3gpOworICAgICAgICByZXR1cm4gWDg2UmVnaXN0ZXJzOjplY3g7 CisgICAgfQorCiAgICAgdm9pZCBzdG9yZTgoUmVnaXN0ZXJJRCBzcmMsIEJhc2VJbmRleCBhZGRy ZXNzKQogICAgIHsKICNpZiBDUFUoWDg2KQpAQCAtNjA5LDE1ICs2MjEsNyBAQCBwdWJsaWM6CiAg ICAgICAgIC8vIGVzcC4uZWRpIGFyZSBtYXBwZWQgdG8gdGhlICdoJyByZWdpc3RlcnMhCiAgICAg ICAgIGlmIChzcmMgPj0gNCkgewogICAgICAgICAgICAgLy8gUGljayBhIHRlbXBvcmFyeSByZWdp c3Rlci4KLSAgICAgICAgICAgIFJlZ2lzdGVySUQgdGVtcDsKLSAgICAgICAgICAgIGlmIChhZGRy ZXNzLmJhc2UgIT0gWDg2UmVnaXN0ZXJzOjplYXggJiYgYWRkcmVzcy5pbmRleCAhPSBYODZSZWdp c3RlcnM6OmVheCkKLSAgICAgICAgICAgICAgICB0ZW1wID0gWDg2UmVnaXN0ZXJzOjplYXg7Ci0g ICAgICAgICAgICBlbHNlIGlmIChhZGRyZXNzLmJhc2UgIT0gWDg2UmVnaXN0ZXJzOjplYnggJiYg YWRkcmVzcy5pbmRleCAhPSBYODZSZWdpc3RlcnM6OmVieCkKLSAgICAgICAgICAgICAgICB0ZW1w ID0gWDg2UmVnaXN0ZXJzOjplYng7Ci0gICAgICAgICAgICBlbHNlIHsKLSAgICAgICAgICAgICAg ICBBU1NFUlQoYWRkcmVzcy5iYXNlICE9IFg4NlJlZ2lzdGVyczo6ZWN4ICYmIGFkZHJlc3MuaW5k ZXggIT0gWDg2UmVnaXN0ZXJzOjplY3gpOwotICAgICAgICAgICAgICAgIHRlbXAgPSBYODZSZWdp c3RlcnM6OmVjeDsKLSAgICAgICAgICAgIH0KKyAgICAgICAgICAgIFJlZ2lzdGVySUQgdGVtcCA9 IGdldFVudXNlZFJlZ2lzdGVyKEJhc2VJbmRleCk7CiAKICAgICAgICAgICAgIC8vIFN3YXAgdG8g dGhlIHRlbXBvcmFyeSByZWdpc3RlciB0byBwZXJmb3JtIHRoZSBzdG9yZS4KICAgICAgICAgICAg IHN3YXAoc3JjLCB0ZW1wKTsKQEAgLTYzNiwxNiArNjQwLDggQEAgcHVibGljOgogICAgICAgICAv LyBlc3AuLmVkaSBhcmUgbWFwcGVkIHRvIHRoZSAnaCcgcmVnaXN0ZXJzIQogICAgICAgICBpZiAo c3JjID49IDQpIHsKICAgICAgICAgICAgIC8vIFBpY2sgYSB0ZW1wb3JhcnkgcmVnaXN0ZXIuCi0g ICAgICAgICAgICBSZWdpc3RlcklEIHRlbXA7Ci0gICAgICAgICAgICBpZiAoYWRkcmVzcy5iYXNl ICE9IFg4NlJlZ2lzdGVyczo6ZWF4ICYmIGFkZHJlc3MuaW5kZXggIT0gWDg2UmVnaXN0ZXJzOjpl YXgpCi0gICAgICAgICAgICAgICAgdGVtcCA9IFg4NlJlZ2lzdGVyczo6ZWF4OwotICAgICAgICAg ICAgZWxzZSBpZiAoYWRkcmVzcy5iYXNlICE9IFg4NlJlZ2lzdGVyczo6ZWJ4ICYmIGFkZHJlc3Mu aW5kZXggIT0gWDg2UmVnaXN0ZXJzOjplYngpCi0gICAgICAgICAgICAgICAgdGVtcCA9IFg4NlJl Z2lzdGVyczo6ZWJ4OwotICAgICAgICAgICAgZWxzZSB7Ci0gICAgICAgICAgICAgICAgQVNTRVJU KGFkZHJlc3MuYmFzZSAhPSBYODZSZWdpc3RlcnM6OmVjeCAmJiBhZGRyZXNzLmluZGV4ICE9IFg4 NlJlZ2lzdGVyczo6ZWN4KTsKLSAgICAgICAgICAgICAgICB0ZW1wID0gWDg2UmVnaXN0ZXJzOjpl Y3g7Ci0gICAgICAgICAgICB9Ci0gICAgICAgICAgICAKKyAgICAgICAgICAgIFJlZ2lzdGVySUQg dGVtcCA9IGdldFVudXNlZFJlZ2lzdGVyKEJhc2VJbmRleCk7CisKICAgICAgICAgICAgIC8vIFN3 YXAgdG8gdGhlIHRlbXBvcmFyeSByZWdpc3RlciB0byBwZXJmb3JtIHRoZSBzdG9yZS4KICAgICAg ICAgICAgIHN3YXAoc3JjLCB0ZW1wKTsKICAgICAgICAgICAgIG1fYXNzZW1ibGVyLm1vdndfcm0o dGVtcCwgYWRkcmVzcy5vZmZzZXQsIGFkZHJlc3MuYmFzZSwgYWRkcmVzcy5pbmRleCwgYWRkcmVz cy5zY2FsZSk7Cg== 212917 2013-09-28 23:56:10 -0700 2013-09-29 12:30:18 -0700 Patch bug-122072-20130928235610.patch text/plain 3597 nrotem U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2NDg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl ZjQ5MDM2MzdhYjAwNzkwMzJmYWQwNmM4ODEwYmJmMjUxNGE4MWVhLi45ZmE3NmY1Y2JlYzI5MDA5 ZDBkZmRhNzgzOTcyYjJhYThlMjI1ZTE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxMy0wOS0yOCAgTmFkYXYgUm90ZW0gIDxucm90ZW1AYXBwbGUuY29tPgor CisgICAgICAgIFJlZmFjdG9yIGNvZGUgZm9yIGZpbmRpbmcgeDg2IHNjcmF0Y2ggcmVnaXN0ZXIu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjIwNzIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGFzc2Vt Ymxlci9NYWNyb0Fzc2VtYmxlclg4NkNvbW1vbi5oOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2Vt Ymxlclg4NkNvbW1vbjo6Z2V0VW51c2VkUmVnaXN0ZXIpOgorICAgICAgICAoSlNDOjpNYWNyb0Fz c2VtYmxlclg4NkNvbW1vbjo6c3RvcmU4KToKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJY ODZDb21tb246OnN0b3JlMTYpOgorCiAyMDEzLTA5LTI2ICBDb21taXQgUXVldWUgIDxjb21taXQt cXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTU2 NDc0LgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fz c2VtYmxlclg4NkNvbW1vbi5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNy b0Fzc2VtYmxlclg4NkNvbW1vbi5oCmluZGV4IDY2YTVkYzhhYzUwYzRiMjQ4NzMzNGY2MjA2M2Qw ODk1OTM3NzNjMTAuLjJmMzNlYmVjMzcxNjI4YTUxOTk2MzkyYzIwYzU4YWFlMzQxMDNkZjQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJY ODZDb21tb24uaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNz ZW1ibGVyWDg2Q29tbW9uLmgKQEAgLTYwMSw3ICs2MDEsMTkgQEAgcHVibGljOgogICAgICAgICBB U1NFUlQoLTEyOCA8PSBpbW0ubV92YWx1ZSAmJiBpbW0ubV92YWx1ZSA8IDEyOCk7CiAgICAgICAg IG1fYXNzZW1ibGVyLm1vdmJfaThtKGltbS5tX3ZhbHVlLCBhZGRyZXNzLm9mZnNldCwgYWRkcmVz cy5iYXNlLCBhZGRyZXNzLmluZGV4LCBhZGRyZXNzLnNjYWxlKTsKICAgICB9Ci0gICAgCisKKyAg ICBzdGF0aWMgQUxXQVlTX0lOTElORSBSZWdpc3RlcklEIGdldFVudXNlZFJlZ2lzdGVyKEJhc2VJ bmRleCBhZGRyZXNzKQorICAgIHsKKyAgICAgICAgaWYgKGFkZHJlc3MuYmFzZSAhPSBYODZSZWdp c3RlcnM6OmVheCAmJiBhZGRyZXNzLmluZGV4ICE9IFg4NlJlZ2lzdGVyczo6ZWF4KQorICAgICAg ICAgICAgcmV0dXJuIFg4NlJlZ2lzdGVyczo6ZWF4OworCisgICAgICAgIGlmIChhZGRyZXNzLmJh c2UgIT0gWDg2UmVnaXN0ZXJzOjplYnggJiYgYWRkcmVzcy5pbmRleCAhPSBYODZSZWdpc3RlcnM6 OmVieCkKKyAgICAgICAgICAgIHJldHVybiBYODZSZWdpc3RlcnM6OmVieDsKKworICAgICAgICBB U1NFUlQoYWRkcmVzcy5iYXNlICE9IFg4NlJlZ2lzdGVyczo6ZWN4ICYmIGFkZHJlc3MuaW5kZXgg IT0gWDg2UmVnaXN0ZXJzOjplY3gpOworICAgICAgICByZXR1cm4gWDg2UmVnaXN0ZXJzOjplY3g7 CisgICAgfQorCiAgICAgdm9pZCBzdG9yZTgoUmVnaXN0ZXJJRCBzcmMsIEJhc2VJbmRleCBhZGRy ZXNzKQogICAgIHsKICNpZiBDUFUoWDg2KQpAQCAtNjA5LDE1ICs2MjEsNyBAQCBwdWJsaWM6CiAg ICAgICAgIC8vIGVzcC4uZWRpIGFyZSBtYXBwZWQgdG8gdGhlICdoJyByZWdpc3RlcnMhCiAgICAg ICAgIGlmIChzcmMgPj0gNCkgewogICAgICAgICAgICAgLy8gUGljayBhIHRlbXBvcmFyeSByZWdp c3Rlci4KLSAgICAgICAgICAgIFJlZ2lzdGVySUQgdGVtcDsKLSAgICAgICAgICAgIGlmIChhZGRy ZXNzLmJhc2UgIT0gWDg2UmVnaXN0ZXJzOjplYXggJiYgYWRkcmVzcy5pbmRleCAhPSBYODZSZWdp c3RlcnM6OmVheCkKLSAgICAgICAgICAgICAgICB0ZW1wID0gWDg2UmVnaXN0ZXJzOjplYXg7Ci0g ICAgICAgICAgICBlbHNlIGlmIChhZGRyZXNzLmJhc2UgIT0gWDg2UmVnaXN0ZXJzOjplYnggJiYg YWRkcmVzcy5pbmRleCAhPSBYODZSZWdpc3RlcnM6OmVieCkKLSAgICAgICAgICAgICAgICB0ZW1w ID0gWDg2UmVnaXN0ZXJzOjplYng7Ci0gICAgICAgICAgICBlbHNlIHsKLSAgICAgICAgICAgICAg ICBBU1NFUlQoYWRkcmVzcy5iYXNlICE9IFg4NlJlZ2lzdGVyczo6ZWN4ICYmIGFkZHJlc3MuaW5k ZXggIT0gWDg2UmVnaXN0ZXJzOjplY3gpOwotICAgICAgICAgICAgICAgIHRlbXAgPSBYODZSZWdp c3RlcnM6OmVjeDsKLSAgICAgICAgICAgIH0KKyAgICAgICAgICAgIFJlZ2lzdGVySUQgdGVtcCA9 IGdldFVudXNlZFJlZ2lzdGVyKGFkZHJlc3MpOwogCiAgICAgICAgICAgICAvLyBTd2FwIHRvIHRo ZSB0ZW1wb3JhcnkgcmVnaXN0ZXIgdG8gcGVyZm9ybSB0aGUgc3RvcmUuCiAgICAgICAgICAgICBz d2FwKHNyYywgdGVtcCk7CkBAIC02MzYsMTYgKzY0MCw4IEBAIHB1YmxpYzoKICAgICAgICAgLy8g ZXNwLi5lZGkgYXJlIG1hcHBlZCB0byB0aGUgJ2gnIHJlZ2lzdGVycyEKICAgICAgICAgaWYgKHNy YyA+PSA0KSB7CiAgICAgICAgICAgICAvLyBQaWNrIGEgdGVtcG9yYXJ5IHJlZ2lzdGVyLgotICAg ICAgICAgICAgUmVnaXN0ZXJJRCB0ZW1wOwotICAgICAgICAgICAgaWYgKGFkZHJlc3MuYmFzZSAh PSBYODZSZWdpc3RlcnM6OmVheCAmJiBhZGRyZXNzLmluZGV4ICE9IFg4NlJlZ2lzdGVyczo6ZWF4 KQotICAgICAgICAgICAgICAgIHRlbXAgPSBYODZSZWdpc3RlcnM6OmVheDsKLSAgICAgICAgICAg IGVsc2UgaWYgKGFkZHJlc3MuYmFzZSAhPSBYODZSZWdpc3RlcnM6OmVieCAmJiBhZGRyZXNzLmlu ZGV4ICE9IFg4NlJlZ2lzdGVyczo6ZWJ4KQotICAgICAgICAgICAgICAgIHRlbXAgPSBYODZSZWdp c3RlcnM6OmVieDsKLSAgICAgICAgICAgIGVsc2UgewotICAgICAgICAgICAgICAgIEFTU0VSVChh ZGRyZXNzLmJhc2UgIT0gWDg2UmVnaXN0ZXJzOjplY3ggJiYgYWRkcmVzcy5pbmRleCAhPSBYODZS ZWdpc3RlcnM6OmVjeCk7Ci0gICAgICAgICAgICAgICAgdGVtcCA9IFg4NlJlZ2lzdGVyczo6ZWN4 OwotICAgICAgICAgICAgfQotICAgICAgICAgICAgCisgICAgICAgICAgICBSZWdpc3RlcklEIHRl bXAgPSBnZXRVbnVzZWRSZWdpc3RlcihhZGRyZXNzKTsKKwogICAgICAgICAgICAgLy8gU3dhcCB0 byB0aGUgdGVtcG9yYXJ5IHJlZ2lzdGVyIHRvIHBlcmZvcm0gdGhlIHN0b3JlLgogICAgICAgICAg ICAgc3dhcChzcmMsIHRlbXApOwogICAgICAgICAgICAgbV9hc3NlbWJsZXIubW92d19ybSh0ZW1w LCBhZGRyZXNzLm9mZnNldCwgYWRkcmVzcy5iYXNlLCBhZGRyZXNzLmluZGV4LCBhZGRyZXNzLnNj YWxlKTsK