122058 2013-09-28 03:10:07 -0700 Generate toCSSFooValue() for CSSCanvasValue 2013-09-29 22:39:41 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim commit-queue esprehn+autocc glenn kling macpherson menard oldest_to_newest 934245 0 gyuyoung.kim 2013-09-28 03:10:07 -0700 Generate toCSSFooValue() for CSSCanvasValue, and use it. This type cast function will help to detect bad-casts. To generate toCSSCanvasValue, isCanvasValue() is added. 934251 1 212892 gyuyoung.kim 2013-09-28 03:26:08 -0700 Created attachment 212892 Patch 934460 2 212892 commit-queue 2013-09-29 22:39:38 -0700 Comment on attachment 212892 Patch Clearing flags on attachment: 212892 Committed r156633: <http://trac.webkit.org/changeset/156633> 934461 3 commit-queue 2013-09-29 22:39:41 -0700 All reviewed patches have been landed. Closing bug. 212892 2013-09-28 03:26:08 -0700 2013-09-29 22:39:38 -0700 Patch bug-122058-20130928192607.patch text/plain 4545 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2NTk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTY0MzBkNGY5Y2ZiZDEy MzE4YWVkNjg4NGIwOWZhNzM3NjI5M2YzZC4uM2YxZTBjNjZhMjhmNDdhY2YyYzYzMGI5Yzk4MmRl ZjViMmVhNjg2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEzLTA5LTI4ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgR2VuZXJhdGUg dG9DU1NGb29WYWx1ZSgpIGZvciBDU1NDYW52YXNWYWx1ZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIyMDU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR2VuZXJhdGUgdG9DU1NGb29WYWx1ZSgpIGZvciBD U1NDYW52YXNWYWx1ZSwgYW5kIHVzZSBpdC4KKyAgICAgICAgVGhpcyB0eXBlIGNhc3QgZnVuY3Rp b24gd2lsbCBoZWxwIHRvIGRldGVjdCBiYWQtY2FzdHMuCisgICAgICAgIGlzQ2FudmFzVmFsdWUo KSBpcyBhZGRlZCBpbiBvcmRlciB0byBnZW5lcmF0ZSB0b0NTU0NhbnZhc1ZhbHVlLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogY3NzL0NT U0NhbnZhc1ZhbHVlLmg6CisgICAgICAgICogY3NzL0NTU0ltYWdlR2VuZXJhdG9yVmFsdWUuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6Q1NTSW1hZ2VHZW5lcmF0b3JWYWx1ZTo6aW1hZ2UpOgorICAg ICAgICAoV2ViQ29yZTo6Q1NTSW1hZ2VHZW5lcmF0b3JWYWx1ZTo6Zml4ZWRTaXplKToKKyAgICAg ICAgKFdlYkNvcmU6OkNTU0ltYWdlR2VuZXJhdG9yVmFsdWU6OmxvYWRTdWJpbWFnZXMpOgorICAg ICAgICAqIGNzcy9DU1NWYWx1ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NWYWx1ZTo6ZGVz dHJveSk6CisgICAgICAgICogY3NzL0NTU1ZhbHVlLmg6CisgICAgICAgIChXZWJDb3JlOjpDU1NW YWx1ZTo6aXNDYW52YXNWYWx1ZSk6CisKIDIwMTMtMDktMjcgIEJyYWR5IEVpZHNvbiAgPGJlaWRz b25AYXBwbGUuY29tPgogCiAgICAgICAgIEluZGV4ZWREQiBJREwgUmVmYWN0b3JpbmcuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTQ2FudmFzVmFsdWUuaCBiL1NvdXJjZS9XZWJD b3JlL2Nzcy9DU1NDYW52YXNWYWx1ZS5oCmluZGV4IDMzM2IzMzA0MWMzYzk5ZmUzNzFjZDdjMDg0 OTYzMDNlNjZlZWJiMjkuLjU1ZWExNDU5ZDlhNzNhYzgwZTQ2NmQxZjFkN2MwODAwYWFkY2RmOTEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NDYW52YXNWYWx1ZS5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2Nzcy9DU1NDYW52YXNWYWx1ZS5oCkBAIC05NCw2ICs5NCw4IEBAIHByaXZh dGU6CiAgICAgSFRNTENhbnZhc0VsZW1lbnQqIG1fZWxlbWVudDsKIH07CiAKK0NTU19WQUxVRV9U WVBFX0NBU1RTKENhbnZhc1ZhbHVlKQorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKICNlbmRp ZiAvLyBDU1NDYW52YXNWYWx1ZV9oCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NT SW1hZ2VHZW5lcmF0b3JWYWx1ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTSW1hZ2VHZW5l cmF0b3JWYWx1ZS5jcHAKaW5kZXggZTVhNGY1OTQwMzVjMGI1MDQwYmEyYTcxNmUwYzZhYzM0MzEy ODI2NS4uNTdkYzdmYWYzNTc4YTliZDRmOWRmODc0NWJkMWJlNDJlNWZjN2VjZiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0ltYWdlR2VuZXJhdG9yVmFsdWUuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2Nzcy9DU1NJbWFnZUdlbmVyYXRvclZhbHVlLmNwcApAQCAtMTA4LDcgKzEw OCw3IEBAIFBhc3NSZWZQdHI8SW1hZ2U+IENTU0ltYWdlR2VuZXJhdG9yVmFsdWU6OmltYWdlKFJl bmRlck9iamVjdCogcmVuZGVyZXIsIGNvbnN0IEluCiB7CiAgICAgc3dpdGNoIChjbGFzc1R5cGUo KSkgewogICAgIGNhc2UgQ2FudmFzQ2xhc3M6Ci0gICAgICAgIHJldHVybiBzdGF0aWNfY2FzdDxD U1NDYW52YXNWYWx1ZSo+KHRoaXMpLT5pbWFnZShyZW5kZXJlciwgc2l6ZSk7CisgICAgICAgIHJl dHVybiB0b0NTU0NhbnZhc1ZhbHVlKHRoaXMpLT5pbWFnZShyZW5kZXJlciwgc2l6ZSk7CiAgICAg Y2FzZSBDcm9zc2ZhZGVDbGFzczoKICAgICAgICAgcmV0dXJuIHN0YXRpY19jYXN0PENTU0Nyb3Nz ZmFkZVZhbHVlKj4odGhpcyktPmltYWdlKHJlbmRlcmVyLCBzaXplKTsKICNpZiBFTkFCTEUoQ1NT X0ZJTFRFUlMpCkBAIC0xNTAsNyArMTUwLDcgQEAgSW50U2l6ZSBDU1NJbWFnZUdlbmVyYXRvclZh bHVlOjpmaXhlZFNpemUoY29uc3QgUmVuZGVyT2JqZWN0KiByZW5kZXJlcikKIHsKICAgICBzd2l0 Y2ggKGNsYXNzVHlwZSgpKSB7CiAgICAgY2FzZSBDYW52YXNDbGFzczoKLSAgICAgICAgcmV0dXJu IHN0YXRpY19jYXN0PENTU0NhbnZhc1ZhbHVlKj4odGhpcyktPmZpeGVkU2l6ZShyZW5kZXJlcik7 CisgICAgICAgIHJldHVybiB0b0NTU0NhbnZhc1ZhbHVlKHRoaXMpLT5maXhlZFNpemUocmVuZGVy ZXIpOwogICAgIGNhc2UgQ3Jvc3NmYWRlQ2xhc3M6CiAgICAgICAgIHJldHVybiBzdGF0aWNfY2Fz dDxDU1NDcm9zc2ZhZGVWYWx1ZSo+KHRoaXMpLT5maXhlZFNpemUocmVuZGVyZXIpOwogI2lmIEVO QUJMRShDU1NfRklMVEVSUykKQEAgLTIxNiw3ICsyMTYsNyBAQCB2b2lkIENTU0ltYWdlR2VuZXJh dG9yVmFsdWU6OmxvYWRTdWJpbWFnZXMoQ2FjaGVkUmVzb3VyY2VMb2FkZXIqIGNhY2hlZFJlc291 cmNlTAogICAgICAgICBzdGF0aWNfY2FzdDxDU1NDcm9zc2ZhZGVWYWx1ZSo+KHRoaXMpLT5sb2Fk U3ViaW1hZ2VzKGNhY2hlZFJlc291cmNlTG9hZGVyKTsKICAgICAgICAgYnJlYWs7CiAgICAgY2Fz ZSBDYW52YXNDbGFzczoKLSAgICAgICAgc3RhdGljX2Nhc3Q8Q1NTQ2FudmFzVmFsdWUqPih0aGlz KS0+bG9hZFN1YmltYWdlcyhjYWNoZWRSZXNvdXJjZUxvYWRlcik7CisgICAgICAgIHRvQ1NTQ2Fu dmFzVmFsdWUodGhpcyktPmxvYWRTdWJpbWFnZXMoY2FjaGVkUmVzb3VyY2VMb2FkZXIpOwogICAg ICAgICBicmVhazsKICNpZiBFTkFCTEUoQ1NTX0ZJTFRFUlMpCiAgICAgY2FzZSBGaWx0ZXJJbWFn ZUNsYXNzOgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ZhbHVlLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2Nzcy9DU1NWYWx1ZS5jcHAKaW5kZXggZWI2MTE0YjFjNjY1YWE3NzdmMDhj ZTQ5M2ZiN2U0ZGNkNjg2MDc5MC4uY2ZjMWE2ODM0ZTc2YWNjMWFkZWUyYmI0YjFkNzY2MmQxNTll M2IzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ZhbHVlLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9jc3MvQ1NTVmFsdWUuY3BwCkBAIC0zODksNyArMzg5LDcgQEAgdm9pZCBD U1NWYWx1ZTo6ZGVzdHJveSgpCiAgICAgICAgIGRlbGV0ZSBzdGF0aWNfY2FzdDxDU1NCb3JkZXJJ bWFnZVNsaWNlVmFsdWUqPih0aGlzKTsKICAgICAgICAgcmV0dXJuOwogICAgIGNhc2UgQ2FudmFz Q2xhc3M6Ci0gICAgICAgIGRlbGV0ZSBzdGF0aWNfY2FzdDxDU1NDYW52YXNWYWx1ZSo+KHRoaXMp OworICAgICAgICBkZWxldGUgdG9DU1NDYW52YXNWYWx1ZSh0aGlzKTsKICAgICAgICAgcmV0dXJu OwogICAgIGNhc2UgQ3Vyc29ySW1hZ2VDbGFzczoKICAgICAgICAgZGVsZXRlIHN0YXRpY19jYXN0 PENTU0N1cnNvckltYWdlVmFsdWUqPih0aGlzKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2Nzcy9DU1NWYWx1ZS5oIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ZhbHVlLmgKaW5kZXggNTA2 ZTI1ZDg1YWQxM2IxNTliNTU4MjBmNzg0ZWY5ZTJlZjJkOWIxMS4uMWRhYmYyOWZmZGFjNzgyY2Rm OTA3ZjFmOWRlMWVmYmUzYjUzM2I3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NT U1ZhbHVlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ZhbHVlLmgKQEAgLTcxLDYgKzcx LDcgQEAgcHVibGljOgogCiAgICAgYm9vbCBpc0FzcGVjdFJhdGlvVmFsdWUoKSBjb25zdCB7IHJl dHVybiBtX2NsYXNzVHlwZSA9PSBBc3BlY3RSYXRpb0NsYXNzOyB9CiAgICAgYm9vbCBpc0JvcmRl ckltYWdlU2xpY2VWYWx1ZSgpIGNvbnN0IHsgcmV0dXJuIG1fY2xhc3NUeXBlID09IEJvcmRlcklt YWdlU2xpY2VDbGFzczsgfQorICAgIGJvb2wgaXNDYW52YXNWYWx1ZSgpIGNvbnN0IHsgcmV0dXJu IG1fY2xhc3NUeXBlID09IENhbnZhc0NsYXNzOyB9CiAgICAgYm9vbCBpc0Nyb3NzZmFkZVZhbHVl KCkgY29uc3QgeyByZXR1cm4gbV9jbGFzc1R5cGUgPT0gQ3Jvc3NmYWRlQ2xhc3M7IH0KICAgICBi b29sIGlzQ3Vyc29ySW1hZ2VWYWx1ZSgpIGNvbnN0IHsgcmV0dXJuIG1fY2xhc3NUeXBlID09IEN1 cnNvckltYWdlQ2xhc3M7IH0KICAgICBib29sIGlzRm9udEZlYXR1cmVWYWx1ZSgpIGNvbnN0IHsg cmV0dXJuIG1fY2xhc3NUeXBlID09IEZvbnRGZWF0dXJlQ2xhc3M7IH0K