122056 2013-09-28 02:42:46 -0700 Generate toCSSFooValue() for CSSFilterImageValue and CSSInitialValue 2013-09-29 22:21:10 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim allan.jensen commit-queue esprehn+autocc glenn kling macpherson menard oldest_to_newest 934240 0 gyuyoung.kim 2013-09-28 02:42:46 -0700 Generate toCSSFooValue() for CSSFilterImageValue and CSSInitialValue, and use it. This type cast function will help to detect bad-casts. 934241 1 212890 gyuyoung.kim 2013-09-28 02:44:48 -0700 Created attachment 212890 Patch 934446 2 212890 commit-queue 2013-09-29 22:21:07 -0700 Comment on attachment 212890 Patch Clearing flags on attachment: 212890 Committed r156628: <http://trac.webkit.org/changeset/156628> 934447 3 commit-queue 2013-09-29 22:21:10 -0700 All reviewed patches have been landed. Closing bug. 212890 2013-09-28 02:44:48 -0700 2013-09-29 22:21:06 -0700 Patch bug-122056-20130928184446.patch text/plain 5589 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2NTk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTY0MzBkNGY5Y2ZiZDEy MzE4YWVkNjg4NGIwOWZhNzM3NjI5M2YzZC4uZTA0MDk4NmRkOTQ4MWMwNzQyNzMyNTMyOGFkZTE1 YzY5YWQ5YjkyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEzLTA5LTI4ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgR2VuZXJhdGUg dG9DU1NGb29WYWx1ZSgpIGZvciBDU1NGaWx0ZXJJbWFnZVZhbHVlIGFuZCBDU1NJbml0aWFsVmFs dWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMjA1 NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdlbmVy YXRlIHRvQ1NTRm9vVmFsdWUoKSBmb3IgQ1NTRmlsdGVySW1hZ2VWYWx1ZSBhbmQgQ1NTSW5pdGlh bFZhbHVlLCBhbmQgdXNlIGl0LgorICAgICAgICBUaGlzIHR5cGUgY2FzdCBmdW5jdGlvbiB3aWxs IGhlbHAgdG8gZGV0ZWN0IGJhZC1jYXN0cy4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJl aGF2aW9yIGNoYW5nZXMuCisKKyAgICAgICAgKiBjc3MvQ1NTRmlsdGVySW1hZ2VWYWx1ZS5oOgor ICAgICAgICAqIGNzcy9DU1NJbWFnZUdlbmVyYXRvclZhbHVlLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkNTU0ltYWdlR2VuZXJhdG9yVmFsdWU6OmltYWdlKToKKyAgICAgICAgKFdlYkNvcmU6OkNT U0ltYWdlR2VuZXJhdG9yVmFsdWU6OmZpeGVkU2l6ZSk6CisgICAgICAgIChXZWJDb3JlOjpDU1NJ bWFnZUdlbmVyYXRvclZhbHVlOjpsb2FkU3ViaW1hZ2VzKToKKyAgICAgICAgKiBjc3MvQ1NTSW5p dGlhbFZhbHVlLmg6CisgICAgICAgICogY3NzL0NTU1ZhbHVlLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkNTU1ZhbHVlOjpkZXN0cm95KToKKyAgICAgICAgKiBjc3MvU3R5bGVSZXNvbHZlci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpTdHlsZVJlc29sdmVyOjpnZW5lcmF0ZWRPclBlbmRpbmdGcm9t VmFsdWUpOgorCiAyMDEzLTA5LTI3ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4K IAogICAgICAgICBJbmRleGVkREIgSURMIFJlZmFjdG9yaW5nLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvY3NzL0NTU0ZpbHRlckltYWdlVmFsdWUuaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NGaWx0ZXJJbWFnZVZhbHVlLmgKaW5kZXggOWE1YmYwZWQ2MzgzMjM5Y2NlYjgxNmFiMTVlOWE1 NmFlYjQ0YmU5My4uYTU0OTEwODU2ZGNkODdjZjI0OWIwNTYxYmE4ZjllMzI1YTkxZjk5ZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0ZpbHRlckltYWdlVmFsdWUuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9jc3MvQ1NTRmlsdGVySW1hZ2VWYWx1ZS5oCkBAIC0xMTksMTEgKzExOSw3 IEBAIHByaXZhdGU6CiAgICAgRmlsdGVyU3ViaW1hZ2VPYnNlcnZlclByb3h5IG1fZmlsdGVyU3Vi aW1hZ2VPYnNlcnZlcjsKIH07CiAKLWlubGluZSBDU1NGaWx0ZXJJbWFnZVZhbHVlKiB0b0NTU0Zp bHRlckltYWdlVmFsdWUoQ1NTSW1hZ2VHZW5lcmF0b3JWYWx1ZSogdmFsdWUpCi17Ci0gICAgQVNT RVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04oIXZhbHVlIHx8IHZhbHVlLT5pc0ZpbHRlcklt YWdlVmFsdWUoKSk7Ci0gICAgcmV0dXJuIHN0YXRpY19jYXN0PENTU0ZpbHRlckltYWdlVmFsdWUq Pih2YWx1ZSk7Ci19CitDU1NfVkFMVUVfVFlQRV9DQVNUUyhGaWx0ZXJJbWFnZVZhbHVlKQogCiB9 IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NJbWFnZUdlbmVyYXRvclZhbHVlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NJbWFnZUdl bmVyYXRvclZhbHVlLmNwcAppbmRleCBlNWE0ZjU5NDAzNWMwYjUwNDBiYTJhNzE2ZTBjNmFjMzQz MTI4MjY1Li5kYmVjMzBiYWI2Y2YyYmI1ZjViOGE1MmEyZTdjNWU2YmJjODBjMTZiIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTSW1hZ2VHZW5lcmF0b3JWYWx1ZS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvY3NzL0NTU0ltYWdlR2VuZXJhdG9yVmFsdWUuY3BwCkBAIC0xMTMsNyAr MTEzLDcgQEAgUGFzc1JlZlB0cjxJbWFnZT4gQ1NTSW1hZ2VHZW5lcmF0b3JWYWx1ZTo6aW1hZ2Uo UmVuZGVyT2JqZWN0KiByZW5kZXJlciwgY29uc3QgSW4KICAgICAgICAgcmV0dXJuIHN0YXRpY19j YXN0PENTU0Nyb3NzZmFkZVZhbHVlKj4odGhpcyktPmltYWdlKHJlbmRlcmVyLCBzaXplKTsKICNp ZiBFTkFCTEUoQ1NTX0ZJTFRFUlMpCiAgICAgY2FzZSBGaWx0ZXJJbWFnZUNsYXNzOgotICAgICAg ICByZXR1cm4gc3RhdGljX2Nhc3Q8Q1NTRmlsdGVySW1hZ2VWYWx1ZSo+KHRoaXMpLT5pbWFnZShy ZW5kZXJlciwgc2l6ZSk7CisgICAgICAgIHJldHVybiB0b0NTU0ZpbHRlckltYWdlVmFsdWUodGhp cyktPmltYWdlKHJlbmRlcmVyLCBzaXplKTsKICNlbmRpZgogICAgIGNhc2UgTGluZWFyR3JhZGll bnRDbGFzczoKICAgICAgICAgcmV0dXJuIHN0YXRpY19jYXN0PENTU0xpbmVhckdyYWRpZW50VmFs dWUqPih0aGlzKS0+aW1hZ2UocmVuZGVyZXIsIHNpemUpOwpAQCAtMTU1LDcgKzE1NSw3IEBAIElu dFNpemUgQ1NTSW1hZ2VHZW5lcmF0b3JWYWx1ZTo6Zml4ZWRTaXplKGNvbnN0IFJlbmRlck9iamVj dCogcmVuZGVyZXIpCiAgICAgICAgIHJldHVybiBzdGF0aWNfY2FzdDxDU1NDcm9zc2ZhZGVWYWx1 ZSo+KHRoaXMpLT5maXhlZFNpemUocmVuZGVyZXIpOwogI2lmIEVOQUJMRShDU1NfRklMVEVSUykK ICAgICBjYXNlIEZpbHRlckltYWdlQ2xhc3M6Ci0gICAgICAgIHJldHVybiBzdGF0aWNfY2FzdDxD U1NGaWx0ZXJJbWFnZVZhbHVlKj4odGhpcyktPmZpeGVkU2l6ZShyZW5kZXJlcik7CisgICAgICAg IHJldHVybiB0b0NTU0ZpbHRlckltYWdlVmFsdWUodGhpcyktPmZpeGVkU2l6ZShyZW5kZXJlcik7 CiAjZW5kaWYKICAgICBjYXNlIExpbmVhckdyYWRpZW50Q2xhc3M6CiAgICAgICAgIHJldHVybiBz dGF0aWNfY2FzdDxDU1NMaW5lYXJHcmFkaWVudFZhbHVlKj4odGhpcyktPmZpeGVkU2l6ZShyZW5k ZXJlcik7CkBAIC0yMjAsNyArMjIwLDcgQEAgdm9pZCBDU1NJbWFnZUdlbmVyYXRvclZhbHVlOjps b2FkU3ViaW1hZ2VzKENhY2hlZFJlc291cmNlTG9hZGVyKiBjYWNoZWRSZXNvdXJjZUwKICAgICAg ICAgYnJlYWs7CiAjaWYgRU5BQkxFKENTU19GSUxURVJTKQogICAgIGNhc2UgRmlsdGVySW1hZ2VD bGFzczoKLSAgICAgICAgc3RhdGljX2Nhc3Q8Q1NTRmlsdGVySW1hZ2VWYWx1ZSo+KHRoaXMpLT5s b2FkU3ViaW1hZ2VzKGNhY2hlZFJlc291cmNlTG9hZGVyKTsKKyAgICAgICAgdG9DU1NGaWx0ZXJJ bWFnZVZhbHVlKHRoaXMpLT5sb2FkU3ViaW1hZ2VzKGNhY2hlZFJlc291cmNlTG9hZGVyKTsKICAg ICAgICAgYnJlYWs7CiAjZW5kaWYKICAgICBjYXNlIExpbmVhckdyYWRpZW50Q2xhc3M6CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTSW5pdGlhbFZhbHVlLmggYi9Tb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTSW5pdGlhbFZhbHVlLmgKaW5kZXggNmU2OTU4OGNmMTM5NDAwOWEwMDlhZDNl NGI1YWExZTc0NjUwZmY2OC4uMDM1ZWE1NTljYTY1NWE5N2M1ODgxYjU3NWI3ZDAxMGNjODA3ZDc3 MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0luaXRpYWxWYWx1ZS5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NJbml0aWFsVmFsdWUuaApAQCAtNTMsNiArNTMsOCBAQCBw cml2YXRlOgogICAgIGJvb2wgbV9pc0ltcGxpY2l0OwogfTsKIAorQ1NTX1ZBTFVFX1RZUEVfQ0FT VFMoSW5pdGlhbFZhbHVlKQorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKICNlbmRpZiAvLyBD U1NJbml0aWFsVmFsdWVfaApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ZhbHVl LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NWYWx1ZS5jcHAKaW5kZXggZWI2MTE0YjFjNjY1 YWE3NzdmMDhjZTQ5M2ZiN2U0ZGNkNjg2MDc5MC4uNWM0MzNlOGVjOTk0NzNlY2JjZjRiN2Q3ZDc1 YTI5YzJhOWJlNjUyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ZhbHVlLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTVmFsdWUuY3BwCkBAIC00MjIsNyArNDIyLDcg QEAgdm9pZCBDU1NWYWx1ZTo6ZGVzdHJveSgpCiAgICAgICAgIGRlbGV0ZSBzdGF0aWNfY2FzdDxD U1NJbmhlcml0ZWRWYWx1ZSo+KHRoaXMpOwogICAgICAgICByZXR1cm47CiAgICAgY2FzZSBJbml0 aWFsQ2xhc3M6Ci0gICAgICAgIGRlbGV0ZSBzdGF0aWNfY2FzdDxDU1NJbml0aWFsVmFsdWUqPih0 aGlzKTsKKyAgICAgICAgZGVsZXRlIHRvQ1NTSW5pdGlhbFZhbHVlKHRoaXMpOwogICAgICAgICBy ZXR1cm47CiAgICAgY2FzZSBQcmltaXRpdmVDbGFzczoKICAgICAgICAgZGVsZXRlIHN0YXRpY19j YXN0PENTU1ByaW1pdGl2ZVZhbHVlKj4odGhpcyk7CkBAIC00NjEsNyArNDYxLDcgQEAgdm9pZCBD U1NWYWx1ZTo6ZGVzdHJveSgpCiAjZW5kaWYKICNpZiBFTkFCTEUoQ1NTX0ZJTFRFUlMpCiAgICAg Y2FzZSBGaWx0ZXJJbWFnZUNsYXNzOgotICAgICAgICBkZWxldGUgc3RhdGljX2Nhc3Q8Q1NTRmls dGVySW1hZ2VWYWx1ZSo+KHRoaXMpOworICAgICAgICBkZWxldGUgdG9DU1NGaWx0ZXJJbWFnZVZh bHVlKHRoaXMpOwogICAgICAgICByZXR1cm47CiAgICAgY2FzZSBXZWJLaXRDU1NGaWx0ZXJDbGFz czoKICAgICAgICAgZGVsZXRlIHRvV2ViS2l0Q1NTRmlsdGVyVmFsdWUodGhpcyk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAKaW5kZXggYzFiNmEzMGRhNjNlNDc1N2EwNzA3ZTNlNWMw NDEyZjM0NjgxOTc4NC4uMWJiMTFkYTY5MDk1ZTYyOGI0Y2Q3ZDZkNzllNGJiYjEzNDAwZGYyOCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcApAQCAtMzEyNSw3ICszMTI1LDcgQEAg UGFzc1JlZlB0cjxTdHlsZUltYWdlPiBTdHlsZVJlc29sdmVyOjpnZW5lcmF0ZWRPclBlbmRpbmdG cm9tVmFsdWUoQ1NTUHJvcGVydHlJRAogI2lmIEVOQUJMRShDU1NfRklMVEVSUykKICAgICBpZiAo dmFsdWUtPmlzRmlsdGVySW1hZ2VWYWx1ZSgpKSB7CiAgICAgICAgIC8vIEZpbHRlckltYWdlIG5l ZWRzIHRvIGNhbGN1bGF0ZSBGaWx0ZXJPcGVyYXRpb25zLgotICAgICAgICBzdGF0aWNfY2FzdDxD U1NGaWx0ZXJJbWFnZVZhbHVlKj4odmFsdWUpLT5jcmVhdGVGaWx0ZXJPcGVyYXRpb25zKHRoaXMp OworICAgICAgICB0b0NTU0ZpbHRlckltYWdlVmFsdWUodmFsdWUpLT5jcmVhdGVGaWx0ZXJPcGVy YXRpb25zKHRoaXMpOwogICAgIH0KICNlbmRpZgogICAgIGlmICh2YWx1ZS0+aXNQZW5kaW5nKCkp IHsK