122026 2013-09-27 11:25:24 -0700 Don't retry failures on Apple MountainLion Release WK1 tester 2013-09-27 13:47:29 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 122023 1 ap ap darin ggaren lforschler oldest_to_newest 934023 0 ap 2013-09-27 11:25:24 -0700 There are no flaky tests on this bot now, and if we introduce any, we should be told about that in RED. 934024 1 212827 ap 2013-09-27 11:29:35 -0700 Created attachment 212827 proposed patch There is a potential downside to this change - run-webkit-tests forces pixel testing when retrying, so it provides pixel results for tests that failed both times. But forcing pixel tests changes a lot anyway, so I'm not sure if those pixel results were more useful or misleading. 934059 2 212827 mrowe 2013-09-27 13:29:56 -0700 Comment on attachment 212827 proposed patch Looks fine except for the obvious typo: --no-retry-faiures. Please fix that before landing. 934073 3 ap 2013-09-27 13:47:29 -0700 Committed <http://trac.webkit.org/r156571>. 212827 2013-09-27 11:29:35 -0700 2013-09-27 13:29:56 -0700 proposed patch MacBot.txt text/plain 1566 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE1NjU1NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDEzLTA5LTI3ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIERvbid0IHJldHJ5IGZhaWx1cmVzIG9uIEFwcGxlIE1vdW50YWluTGlvbiBS ZWxlYXNlIFdLMSB0ZXN0ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyMjAyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvY29u ZmlnLmpzb246IEFkZGVkIC0tbm8tcmV0cnktZmFpbHVyZXMKKyAgICAgICAgb24gdGhpcyBib3Qu CisKIDIwMTMtMDktMjcgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtYXJpby5wcmFkYUBzYW1zdW5n LmNvbT4KIAogICAgICAgICBbR1RLXSBHVEsgZG9lcyBub3QgZXhwb3NlIGhlYWRpbmcgbGV2ZWwg Y29ycmVjdGx5LiBXYXM6IGFjY2Vzc2liaWxpdHkvaGVhZGluZy1sZXZlbC5odG1sIGlzIGZhaWxp bmcKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmln L2NvbmZpZy5qc29uCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxk LndlYmtpdC5vcmctY29uZmlnL2NvbmZpZy5qc29uCShyZXZpc2lvbiAxNTY1NTApCisrKyBUb29s cy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9jb25maWcuanNvbgko d29ya2luZyBjb3B5KQpAQCAtMTE3LDYgKzExNyw3IEBACiAgICAgICAgICAgICAgICAgICAgIH0s CiAgICAgICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAiQXBwbGUgTW91bnRhaW5MaW9uIFJlbGVh c2UgV0sxIChUZXN0cykiLCAidHlwZSI6ICJUZXN0IiwgImJ1aWxkZGlyIjogIm1vdW50YWlubGlv bi1yZWxlYXNlLXRlc3RzLXdrMSIsCiAgICAgICAgICAgICAgICAgICAgICAgInBsYXRmb3JtIjog Im1hYy1tb3VudGFpbmxpb24iLCAiY29uZmlndXJhdGlvbiI6ICJyZWxlYXNlIiwgImFyY2hpdGVj dHVyZXMiOiBbIng4Nl82NCJdLAorICAgICAgICAgICAgICAgICAgICAgICJhZGRpdGlvbmFsQXJn dW1lbnRzIjogWyItLW5vLXJldHJ5LWZhaXVyZXMiXSwKICAgICAgICAgICAgICAgICAgICAgICAi c2xhdmVuYW1lcyI6IFsiYXBwbGUtbWluaS0yMDgiXQogICAgICAgICAgICAgICAgICAgICB9LAog ICAgICAgICAgICAgICAgICAgICB7ICJuYW1lIjogIkFwcGxlIE1vdW50YWluTGlvbiBSZWxlYXNl IFdLMiAoVGVzdHMpIiwgInR5cGUiOiAiVGVzdFdlYktpdDIiLCAiYnVpbGRkaXIiOiAibW91bnRh aW5saW9uLXJlbGVhc2UtdGVzdHMtd2syIiwK