121999 2013-09-26 17:41:58 -0700 [GCC] Fix build with gcc < 4.8.1, which does not have is_trivially_destructible 2013-10-10 09:29:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 121930 1 gustavo gustavo benjamin cmarcelo commit-queue jbriance ossy ryuan.choi oldest_to_newest 933804 0 gustavo 2013-09-26 17:41:58 -0700 [GCC] Fix build with gcc < 4.8.1, which does not have is_trivially_destructible 933805 1 212775 gustavo 2013-09-26 17:42:15 -0700 Created attachment 212775 Patch 933809 2 212775 benjamin 2013-09-26 17:57:14 -0700 Comment on attachment 212775 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212775&action=review > Source/WTF/wtf/StdLibExtras.h:308 > +#if (defined(_MSC_VER) && _MSC_VER < 1700) || (COMPILER(GCC) && !(__GNUC__ >= 4 && __GNUC_MINOR__ >= 8 && __GNUC_PATCHLEVEL__ >= 1)) Ins't that reimplementing GCC_VERSION_AT_LEAST? I am pretty sure Clang also matches COMPILER(GCC). > Source/WTF/wtf/StdLibExtras.h:310 > // Work-around for Pre-C++11 syntax in MSVC 2010 and prior You need to fix the comment as well. 933821 3 gustavo 2013-09-26 18:36:32 -0700 hah, I should have looked harder, I didn't know about GCC_VERSION_AT_LEAST, thanks, modified patch incoming in a bit, thanks! 933826 4 212782 gustavo 2013-09-26 18:45:25 -0700 Created attachment 212782 Patch 933838 5 212782 benjamin 2013-09-26 19:56:42 -0700 Comment on attachment 212782 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212782&action=review > Source/WTF/wtf/StdLibExtras.h:310 > +// Work-around for Pre-C++11 syntax in MSVC 2010 and prior as well as GCC < 4.8.1. Please add a comma to split "and prior as well as". 933857 6 ryuan.choi 2013-09-27 00:47:48 -0700 Committed r156529: <http://trac.webkit.org/changeset/156529> 933859 7 212782 ryuan.choi 2013-09-27 00:49:37 -0700 Comment on attachment 212782 Patch Clearing flags. I landed manually after followed comment in order to fix build break on EFL, GTK and Qt bot. Thanks. 933862 8 ossy 2013-09-27 00:55:00 -0700 *** Bug 122008 has been marked as a duplicate of this bug. *** 938379 9 ossy 2013-10-10 09:29:04 -0700 Adding the original bug (which broke the build) to blocks list. 212775 2013-09-26 17:42:15 -0700 2013-09-26 18:45:20 -0700 Patch bug-121999-20130926214213.patch text/plain 1339 gustavo U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2NTE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGIwY2YyMGMzODYzMTM1MjQ3MjU0MjI0 MTQyMzY0ZmE1N2JhOTU4NmYuLjA1OWE3MzQyYzA3Y2JmNGJiOTY0NTliN2JhNGE3MmZjMmNhNzc3 MjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTMtMDktMjYgIEd1c3Rhdm8gTm9yb25oYSBTaWx2 YSAgPGduc0Bnbm9tZS5vcmc+CisKKyAgICAgICAgW0dDQ10gRml4IGJ1aWxkIHdpdGggZ2NjIDwg NC44LjEsIHdoaWNoIGRvZXMgbm90IGhhdmUgaXNfdHJpdmlhbGx5X2Rlc3RydWN0aWJsZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIxOTk5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvU3RkTGli RXh0cmFzLmg6CisKIDIwMTMtMDktMjYgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5j b20+CiAKICAgICAgICAgW1dpbmRvd3NdIFdvcmsgYXJvdW5kIG1pc3NpbmcgQysrMTEgZmVhdHVy ZXMgb2YgTVNWQyBieSBwcm92aWRpbmcgYW4gaW1wbGVtZW50YXRpb24gZm9yCmRpZmYgLS1naXQg YS9Tb3VyY2UvV1RGL3d0Zi9TdGRMaWJFeHRyYXMuaCBiL1NvdXJjZS9XVEYvd3RmL1N0ZExpYkV4 dHJhcy5oCmluZGV4IGQyNTk4MjllZTcwMmRmNGUyNzI2OTIxNzJhMWU3NTk1MzkzMTEwMTAuLjIx NjkyZmVkNWQzYzEwMDk4ZjBhMDIyZDhlYjE3YTMzNWJiZTRjNmYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XVEYvd3RmL1N0ZExpYkV4dHJhcy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1N0ZExpYkV4dHJh cy5oCkBAIC0zMDUsNyArMzA1LDggQEAgaW5saW5lIHZvaWQqIG9wZXJhdG9yIG5ldyhzaXplX3Qs IE5vdE51bGxUYWcsIHZvaWQqIGxvY2F0aW9uKQogICAgIHJldHVybiBsb2NhdGlvbjsKIH0KIAot I2lmIGRlZmluZWQoX01TQ19WRVIpICYmIF9NU0NfVkVSIDwgMTcwMCAKKyNpZiAoZGVmaW5lZChf TVNDX1ZFUikgJiYgX01TQ19WRVIgPCAxNzAwKSB8fCAoQ09NUElMRVIoR0NDKSAmJiAhKF9fR05V Q19fID49IDQgJiYgX19HTlVDX01JTk9SX18gPj0gOCAmJiBfX0dOVUNfUEFUQ0hMRVZFTF9fID49 IDEpKQorCiAvLyBXb3JrLWFyb3VuZCBmb3IgUHJlLUMrKzExIHN5bnRheCBpbiBNU1ZDIDIwMTAg YW5kIHByaW9yCiBuYW1lc3BhY2Ugc3RkIHsKICAgICB0ZW1wbGF0ZTxjbGFzcyBUPiBzdHJ1Y3Qg aXNfdHJpdmlhbGx5X2Rlc3RydWN0aWJsZSB7Cg== 212782 2013-09-26 18:45:25 -0700 2013-09-27 00:49:36 -0700 Patch bug-121999-20130926224523.patch text/plain 1480 gustavo U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2NTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGIwY2YyMGMzODYzMTM1MjQ3MjU0MjI0 MTQyMzY0ZmE1N2JhOTU4NmYuLjA1OWE3MzQyYzA3Y2JmNGJiOTY0NTliN2JhNGE3MmZjMmNhNzc3 MjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTMtMDktMjYgIEd1c3Rhdm8gTm9yb25oYSBTaWx2 YSAgPGduc0Bnbm9tZS5vcmc+CisKKyAgICAgICAgW0dDQ10gRml4IGJ1aWxkIHdpdGggZ2NjIDwg NC44LjEsIHdoaWNoIGRvZXMgbm90IGhhdmUgaXNfdHJpdmlhbGx5X2Rlc3RydWN0aWJsZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIxOTk5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvU3RkTGli RXh0cmFzLmg6CisKIDIwMTMtMDktMjYgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5j b20+CiAKICAgICAgICAgW1dpbmRvd3NdIFdvcmsgYXJvdW5kIG1pc3NpbmcgQysrMTEgZmVhdHVy ZXMgb2YgTVNWQyBieSBwcm92aWRpbmcgYW4gaW1wbGVtZW50YXRpb24gZm9yCmRpZmYgLS1naXQg YS9Tb3VyY2UvV1RGL3d0Zi9TdGRMaWJFeHRyYXMuaCBiL1NvdXJjZS9XVEYvd3RmL1N0ZExpYkV4 dHJhcy5oCmluZGV4IGQyNTk4MjllZTcwMmRmNGUyNzI2OTIxNzJhMWU3NTk1MzkzMTEwMTAuLmY3 ODI1YmQ3NDM1ODhjNTUyMTNlNzc3MjlkMzlhNTcwNjUzMTUwZTkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XVEYvd3RmL1N0ZExpYkV4dHJhcy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1N0ZExpYkV4dHJh cy5oCkBAIC0zMDUsOCArMzA1LDkgQEAgaW5saW5lIHZvaWQqIG9wZXJhdG9yIG5ldyhzaXplX3Qs IE5vdE51bGxUYWcsIHZvaWQqIGxvY2F0aW9uKQogICAgIHJldHVybiBsb2NhdGlvbjsKIH0KIAot I2lmIGRlZmluZWQoX01TQ19WRVIpICYmIF9NU0NfVkVSIDwgMTcwMCAKLS8vIFdvcmstYXJvdW5k IGZvciBQcmUtQysrMTEgc3ludGF4IGluIE1TVkMgMjAxMCBhbmQgcHJpb3IKKyNpZiAoZGVmaW5l ZChfTVNDX1ZFUikgJiYgX01TQ19WRVIgPCAxNzAwKSB8fCAoQ09NUElMRVIoR0NDKSAmJiAhQ09N UElMRVIoQ0xBTkcpICYmICFHQ0NfVkVSU0lPTl9BVF9MRUFTVCg0LCA4LCAxKSkKKworLy8gV29y ay1hcm91bmQgZm9yIFByZS1DKysxMSBzeW50YXggaW4gTVNWQyAyMDEwIGFuZCBwcmlvciBhcyB3 ZWxsIGFzIEdDQyA8IDQuOC4xLgogbmFtZXNwYWNlIHN0ZCB7CiAgICAgdGVtcGxhdGU8Y2xhc3Mg VD4gc3RydWN0IGlzX3RyaXZpYWxseV9kZXN0cnVjdGlibGUgewogICAgICAgICBzdGF0aWMgY29u c3QgYm9vbCB2YWx1ZSA9IHN0ZDo6aGFzX3RyaXZpYWxfZGVzdHJ1Y3RvcjxUPjo6dmFsdWU7Cg==