121984 2013-09-26 14:35:48 -0700 [Qt] Fix build after r156487 2013-09-26 15:17:57 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbriance webkit-unassigned allan.jensen andersca commit-queue hausmann oldest_to_newest 933710 0 jbriance 2013-09-26 14:35:48 -0700 Fix Qt build after r156487 (http://trac.webkit.org/changeset/156487) Seen with our sh4 build bot (http://build.webkit.org/builders/Qt%20Linux%20SH4%20Release/builds/30703): /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/WebCore/bridge/qt/qt_runtime.cpp: In member function 'OpaqueJSValue* JSC::Bindings::QtRuntimeMethod::jsObjectRef(JSContextRef, const OpaqueJSValue**)': /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/WebCore/bridge/qt/qt_runtime.cpp:1304:18: error: 'PassWeak' was not declared in this scope /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/WebCore/bridge/qt/qt_runtime.cpp:1304:35: error: expected primary-expression before '>' token make[2]: *** [.obj/release-shared/bridge/qt/qt_runtime.o] Error 1 make[2]: *** Waiting for unfinished jobs.... 933716 1 212751 jbriance 2013-09-26 14:44:15 -0700 Created attachment 212751 Use Weak instead of PassWeak in WebCore/bridge/qt/qt_runtime.cpp 933738 2 212751 commit-queue 2013-09-26 15:17:55 -0700 Comment on attachment 212751 Use Weak instead of PassWeak in WebCore/bridge/qt/qt_runtime.cpp Clearing flags on attachment: 212751 Committed r156503: <http://trac.webkit.org/changeset/156503> 933739 3 commit-queue 2013-09-26 15:17:57 -0700 All reviewed patches have been landed. Closing bug. 212751 2013-09-26 14:44:15 -0700 2013-09-26 15:17:55 -0700 Use Weak instead of PassWeak in WebCore/bridge/qt/qt_runtime.cpp bug-121984.patch text/plain 1195 jbriance SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NjQ5NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA5LTI2ICBKdWxpZW4g QnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisgICAgICAgIFtRdF0gRml4IGJ1aWxk IGFmdGVyIHIxNTY0ODcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMjE5ODQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIGJyaWRnZS9xdC9xdF9ydW50aW1lLmNwcDoKKyAgICAgICAgKEpTQzo6QmluZGlu Z3M6OlF0UnVudGltZU1ldGhvZDo6anNPYmplY3RSZWYpOgorCiAyMDEzLTA5LTI2ICBBbmRlcnMg Q2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIFBhc3NXZWFr LmgKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JyaWRnZS9xdC9xdF9ydW50aW1lLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9icmlkZ2UvcXQvcXRfcnVudGltZS5jcHAJKHJldmlzaW9u IDE1NjQ5NSkKKysrIFNvdXJjZS9XZWJDb3JlL2JyaWRnZS9xdC9xdF9ydW50aW1lLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTMwMSw3ICsxMzAxLDcgQEAgSlNPYmplY3RSZWYgUXRSdW50aW1lTWV0 aG9kOjpqc09iamVjdFJlZgogICAgIEpTT2JqZWN0U2V0UHJvcGVydHkoY29udGV4dCwgb2JqZWN0 LCBjb25uZWN0U3RyLCBjb25uZWN0RnVuY3Rpb24sIGF0dHJpYnV0ZXMsIGV4Y2VwdGlvbik7CiAg ICAgSlNPYmplY3RTZXRQcm9wZXJ0eShjb250ZXh0LCBvYmplY3QsIGRpc2Nvbm5lY3RTdHIsIGRp c2Nvbm5lY3RGdW5jdGlvbiwgYXR0cmlidXRlcywgZXhjZXB0aW9uKTsKIAotICAgIG1fanNPYmpl Y3QgPSBQYXNzV2VhazxKU09iamVjdD4odG9KUyhvYmplY3QpKTsKKyAgICBtX2pzT2JqZWN0ID0g V2VhazxKU09iamVjdD4odG9KUyhvYmplY3QpKTsKIAogICAgIHJldHVybiBvYmplY3Q7CiB9Cg==