121963 2013-09-26 10:08:00 -0700 Weak should have a move constructor and move assignment operator 2013-09-26 10:32:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca commit-queue oldest_to_newest 933564 0 andersca 2013-09-26 10:08:00 -0700 Weak should have a move constructor and move assignment operator 933565 1 212720 andersca 2013-09-26 10:10:26 -0700 Created attachment 212720 Patch 933567 2 commit-queue 2013-09-26 10:13:02 -0700 Attachment 212720 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSClassRef.cpp', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/heap/Weak.h', u'Source/JavaScriptCore/heap/WeakInlines.h', u'Source/JavaScriptCore/runtime/SimpleTypedArrayController.cpp']" exit_code: 1 Source/JavaScriptCore/heap/Weak.h:60: Missing spaces around && [whitespace/operators] [3] Source/JavaScriptCore/heap/Weak.h:70: Missing spaces around && [whitespace/operators] [3] Source/JavaScriptCore/heap/WeakInlines.h:79: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 3 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 933578 3 andersca 2013-09-26 10:32:49 -0700 Committed r156469: <http://trac.webkit.org/changeset/156469> 212720 2013-09-26 10:10:26 -0700 2013-09-26 10:11:32 -0700 Patch bug-121963-20130926101026.patch text/plain 4422 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2NDYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh MmVmYWU4M2JhODNmZmM3ODc3Y2FhMGNiNjlhOWI5Zjg1MzM2MjJkLi5mM2RkM2ZlZTcyYmUxMzE5 OWQ1ZGJhNGQ4Y2M3ZmFlN2E4ZGNhZmZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxMy0wOS0yNiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUu Y29tPgorCisgICAgICAgIFdlYWsgc2hvdWxkIGhhdmUgYSBtb3ZlIGNvbnN0cnVjdG9yIGFuZCBt b3ZlIGFzc2lnbm1lbnQgb3BlcmF0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyMTk2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoaXMgaXMgdGhlIGZpcnN0IHN0ZXAgdG93YXJkcyBnZXR0aW5nIHJp ZCBvZiBQYXNzV2Vhay4KKworICAgICAgICAqIEFQSS9KU0NsYXNzUmVmLmNwcDoKKyAgICAgICAg KE9wYXF1ZUpTQ2xhc3M6OnByb3RvdHlwZSk6CisgICAgICAgICogaGVhcC9XZWFrLmg6CisgICAg ICAgICogaGVhcC9XZWFrSW5saW5lcy5oOgorICAgICAgICAoSlNDOjo6OldlYWspOgorICAgICAg ICAoSlNDOjo6OmxlYWtJbXBsKToKKyAgICAgICAgKiBydW50aW1lL1NpbXBsZVR5cGVkQXJyYXlD b250cm9sbGVyLmNwcDoKKyAgICAgICAgKEpTQzo6U2ltcGxlVHlwZWRBcnJheUNvbnRyb2xsZXI6 OnRvSlMpOgorCiAyMDEzLTA5LTI1ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4K IAogICAgICAgICBFbmFibGUgdGhlIEluZGV4ZWREQiBidWlsZCBvbiBNYWMsIGJ1dCBsZWF2ZSB0 aGUgZmVhdHVyZSBub24tZnVuY3Rpb25hbApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRD b3JlL0FQSS9KU0NsYXNzUmVmLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNDbGFz c1JlZi5jcHAKaW5kZXggNzZkMGM1YTZiYzMwYjAwYjU5ODcwZGQ3ZGJiNDJhNmVhZDhlOWYwYi4u YTI4MjVlN2I2ZDRhMDQyNzNkMDIzOGQwOTgyODAxZmJhM2M1Y2VjOCAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU0NsYXNzUmVmLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvQVBJL0pTQ2xhc3NSZWYuY3BwCkBAIC0yMDcsNiArMjA3LDYgQEAgSlNPYmplY3Qq IE9wYXF1ZUpTQ2xhc3M6OnByb3RvdHlwZShFeGVjU3RhdGUqIGV4ZWMpCiAgICAgICAgICAgICBw cm90b3R5cGUtPnNldFByb3RvdHlwZShleGVjLT52bSgpLCBwYXJlbnRQcm90b3R5cGUpOwogICAg IH0KIAotICAgIGpzQ2xhc3NEYXRhLmNhY2hlZFByb3RvdHlwZSA9IFBhc3NXZWFrPEpTT2JqZWN0 Pihwcm90b3R5cGUpOworICAgIGpzQ2xhc3NEYXRhLmNhY2hlZFByb3RvdHlwZSA9IFdlYWs8SlNP YmplY3Q+KHByb3RvdHlwZSk7CiAgICAgcmV0dXJuIHByb3RvdHlwZTsKIH0KZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL1dlYWsuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9oZWFwL1dlYWsuaAppbmRleCBjNDY1MDdhYzVhOWU4YzdkODU3ZDYwNzFmNWE0OTA0Y2MxMTFm YWQzLi5lM2Q2MWFhMTE3ZmUzNTY3NDI0N2RiMGNmYjk5Nzg2NjYzYWUyNDlhIDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9XZWFrLmgKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2hlYXAvV2Vhay5oCkBAIC01Nyw2ICs1Nyw3IEBAIHB1YmxpYzoKICAgICBib29sIGlz SGFzaFRhYmxlRGVsZXRlZFZhbHVlKCkgY29uc3Q7CiAgICAgV2VhayhIYXNoVGFibGVEZWxldGVk VmFsdWVUYWcpOwogCisgICAgV2VhayhXZWFrJiYpOwogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFU+ IFdlYWsoY29uc3QgUGFzc1dlYWs8VT4mKTsKIAogICAgIH5XZWFrKCkKQEAgLTY1LDYgKzY2LDgg QEAgcHVibGljOgogICAgIH0KIAogICAgIHZvaWQgc3dhcChXZWFrJik7CisKKyAgICBXZWFrJiBv cGVyYXRvcj0oV2VhayYmKTsKICAgICBXZWFrJiBvcGVyYXRvcj0oY29uc3QgUGFzc1dlYWs8VD4m KTsKICAgICAKICAgICBib29sIG9wZXJhdG9yISgpIGNvbnN0OwpAQCAtNzksNiArODIsNyBAQCBw dWJsaWM6CiAgICAgb3BlcmF0b3IgVW5zcGVjaWZpZWRCb29sVHlwZSooKSBjb25zdDsKIAogICAg IFBhc3NXZWFrPFQ+IHJlbGVhc2UoKTsKKyAgICBXZWFrSW1wbCogbGVha0ltcGwoKSBXQVJOX1VO VVNFRF9SRVRVUk47CiAgICAgdm9pZCBjbGVhcigpCiAgICAgewogICAgICAgICBpZiAoIW1faW1w bCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL1dlYWtJbmxpbmVzLmgg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9XZWFrSW5saW5lcy5oCmluZGV4IGM2M2E0NjU2 MDEwMTc2ZTIxNWU3YjZlNjE3ODU1NjBmNzI3YjYyZWUuLjNlODZiMjEyY2FiZTQxZTZkYTU3YzQx MjE4OTRjYTZkYzhlMTliNmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFw L1dlYWtJbmxpbmVzLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvV2Vha0lubGlu ZXMuaApAQCAtNTMsNiArNTMsMTEgQEAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gdGVtcGxhdGU8dHlw ZW5hbWUgVT4gIGlubGluZSBXZWFrPFQ+OjpXZWFrKGNvbnN0IFBhc3NXZWFrPFUKIHsKIH0KIAor dGVtcGxhdGU8dHlwZW5hbWUgVD4gaW5saW5lIFdlYWs8VD46OldlYWsoV2VhayYmIG90aGVyKQor ICAgIDogbV9pbXBsKG90aGVyLmxlYWtJbXBsKCkpCit7Cit9CisKIHRlbXBsYXRlPGNsYXNzIFQ+ IGlubGluZSB2b2lkIHN3YXAoV2VhazxUPiYgYSwgV2VhazxUPiYgYikKIHsKICAgICBhLnN3YXAo Yik7CkBAIC03MCw2ICs3NSwxMyBAQCB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBpbmxpbmUgV2VhazxU PiYgV2VhazxUPjo6b3BlcmF0b3I9KGNvbnN0IFBhc3NXZWFrPFQ+JiBvKQogICAgIHJldHVybiAq dGhpczsKIH0KIAordGVtcGxhdGU8dHlwZW5hbWUgVD4gaW5saW5lIGF1dG8gV2VhazxUPjo6b3Bl cmF0b3I9KFdlYWsmJiBvdGhlcikgLT4gV2VhayYKK3sKKyAgICBXZWFrIHdlYWsgPSBzdGQ6Om1v dmUob3RoZXIpOworICAgIHN3YXAod2Vhayk7CisgICAgcmV0dXJuICp0aGlzOworfQorCiB0ZW1w bGF0ZTx0eXBlbmFtZSBUPiBpbmxpbmUgVCogV2VhazxUPjo6b3BlcmF0b3ItPigpIGNvbnN0CiB7 CiAgICAgQVNTRVJUKG1faW1wbCAmJiBtX2ltcGwtPnN0YXRlKCkgPT0gV2Vha0ltcGw6OkxpdmUp OwpAQCAtMTExLDYgKzEyMywxMyBAQCB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBpbmxpbmUgUGFzc1dl YWs8VD4gV2VhazxUPjo6cmVsZWFzZSgpCiAgICAgcmV0dXJuIHRtcDsKIH0KIAordGVtcGxhdGU8 dHlwZW5hbWUgVD4gaW5saW5lIFdlYWtJbXBsKiBXZWFrPFQ+OjpsZWFrSW1wbCgpCit7CisgICAg V2Vha0ltcGwqIGltcGwgPSBtX2ltcGw7CisgICAgbV9pbXBsID0gbnVsbHB0cjsKKyAgICByZXR1 cm4gaW1wbDsKK30KKwogdGVtcGxhdGU8dHlwZW5hbWUgVD4gaW5saW5lIFdlYWtJbXBsKiBXZWFr PFQ+OjpoYXNoVGFibGVEZWxldGVkVmFsdWUoKQogewogICAgIHJldHVybiByZWludGVycHJldF9j YXN0PFdlYWtJbXBsKj4oLTEpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvU2ltcGxlVHlwZWRBcnJheUNvbnRyb2xsZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvU2ltcGxlVHlwZWRBcnJheUNvbnRyb2xsZXIuY3BwCmluZGV4IDJjNjcyNGE5 MGY5MTRkZDFhNDgzYWFjZjY2YWIxNTZkYzJlZTMzZDAuLmU0YjU0ZTY2MTUxMmVlYTNjNmFmOWUz OGQxMzA2MGQyMzMzMTBlMjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL1NpbXBsZVR5cGVkQXJyYXlDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9TaW1wbGVUeXBlZEFycmF5Q29udHJvbGxlci5jcHAKQEAgLTQ0LDcgKzQ0 LDcgQEAgSlNBcnJheUJ1ZmZlciogU2ltcGxlVHlwZWRBcnJheUNvbnRyb2xsZXI6OnRvSlMoCiAg ICAgCiAgICAgSlNBcnJheUJ1ZmZlciogcmVzdWx0ID0gSlNBcnJheUJ1ZmZlcjo6Y3JlYXRlKAog ICAgICAgICBleGVjLT52bSgpLCBnbG9iYWxPYmplY3QtPmFycmF5QnVmZmVyU3RydWN0dXJlKCks IG5hdGl2ZSk7Ci0gICAgbmF0aXZlLT5tX3dyYXBwZXIgPSBQYXNzV2VhazxKU0FycmF5QnVmZmVy PihyZXN1bHQpOworICAgIG5hdGl2ZS0+bV93cmFwcGVyID0gV2VhazxKU0FycmF5QnVmZmVyPihy ZXN1bHQpOwogICAgIHJldHVybiByZXN1bHQ7CiB9CiAK