121956 2013-09-26 07:32:47 -0700 [Qt] Mock implementations of positioning and orientation not used 2013-09-27 04:56:42 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen abecsi commit-queue hausmann kadam ossy zarvai oldest_to_newest 933486 0 allan.jensen 2013-09-26 07:32:47 -0700 A regression on the bots was introduced by the patch for bug #121089. The problem is the state of production_build is not known at the time detectFeatures is run. 933487 1 212705 allan.jensen 2013-09-26 07:34:46 -0700 Created attachment 212705 Patch 933885 2 212705 ossy 2013-09-27 04:09:17 -0700 Comment on attachment 212705 Patch LGTM, r=me. 933886 3 zarvai 2013-09-27 04:12:14 -0700 (In reply to comment #2) > (From update of attachment 212705 [details]) > LGTM, r=me. Yes, the related test are not failing on local my system with this patch. 933894 4 212705 commit-queue 2013-09-27 04:56:39 -0700 Comment on attachment 212705 Patch Clearing flags on attachment: 212705 Committed r156534: <http://trac.webkit.org/changeset/156534> 933895 5 commit-queue 2013-09-27 04:56:42 -0700 All reviewed patches have been landed. Closing bug. 212705 2013-09-26 07:34:46 -0700 2013-09-27 04:56:39 -0700 Patch bug-121956-20130926163445.patch text/plain 3666 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2NDAwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTczYjRhZmQyNjNkM2QwZGY3OTI5YmU5YmMwMzI1Y2Ew MmEzZTdlYy4uMzk0ZjM3NDY2MWFmMjE5MGIyMTdjOWZkM2YyOGE5MDYzODE4Y2NkYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTA5LTI2ICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGln aWEuY29tPgorCisgICAgICAgIFtRdF0gTW9jayBpbXBsZW1lbnRhdGlvbnMgb2YgcG9zaXRpb25p bmcgYW5kIG9yaWVudGF0aW9uIG5vdCB1c2VkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMjE5NTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBNb3ZlIHByb2R1Y3Rpb25fYnVpbGQgY2hlY2tzIHRvIHNhbml0 aXplRmVhdHVyZXMgd2hlcmUgaXRzIHZhbHVlIGlzIGFjdHVhbGx5IGtub3duLgorCisgICAgICAg ICogcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy9mZWF0dXJlcy5wcmY6CisgICAgICAgICogcW1ha2Uv bWtzcGVjcy9mZWF0dXJlcy9mZWF0dXJlcy5wcmk6CisKIDIwMTMtMDktMjUgIEFsbGFuIFNhbmRm ZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBkaWdpYS5jb20+CiAKICAgICAgICAgW1F0XSBGaXgg YnVpbGQgd2l0aCBRdCA1LjIgUXRQb3NpdGlvbiBtb2R1bGUKZGlmZiAtLWdpdCBhL1Rvb2xzL3Ft YWtlL21rc3BlY3MvZmVhdHVyZXMvZmVhdHVyZXMucHJmIGIvVG9vbHMvcW1ha2UvbWtzcGVjcy9m ZWF0dXJlcy9mZWF0dXJlcy5wcmYKaW5kZXggZTdjN2M2OTAxMDMyZDYzNDI3YzM4NDU1MmM4NWJm ZDI0MTBkZDYyNS4uYzUzMmZjZjZmMTgzNTRlNGFhYmE3ODJlMDU1MTM5YzM0MTMzY2VmMSAxMDA2 NDQKLS0tIGEvVG9vbHMvcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy9mZWF0dXJlcy5wcmYKKysrIGIv VG9vbHMvcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy9mZWF0dXJlcy5wcmYKQEAgLTk3LDE0ICs5Nyw2 IEBAIGRlZmluZVRlc3QoZGV0ZWN0RmVhdHVyZXMpIHsKICAgICAjIEVuYWJsZSBDU1Mgc2hhZGVy cyB3aGVuIENTUyBmaWx0ZXJzIGFuZCBXZWJHTCBhcmUgZW5hYmxlZAogICAgIGVuYWJsZT8oY3Nz X2ZpbHRlcnMpOmVuYWJsZT8od2ViZ2wpOiBXRUJLSVRfQ09ORklHICs9IGNzc19zaGFkZXJzCiAK LSAgICAjIEdlb2xvY2F0aW9uIHN1cHBvcnQgaWYgUXRQb3NpdGlvbmluZyBleGlzdHMgb3IgaWYg d2UncmUgZG9pbmcgYSBkZXZlbG9wZXIgYnVpbGQgKE1vY2sgaW1wbGVtZW50YXRpb24gZXhpc3Rz Ci0gICAgIyBhbmQgdXNlZCBmb3IgbGF5b3V0IHRlc3RzKQotICAgIGhhdmU/KHF0cG9zaXRpb25p bmcpfCFwcm9kdWN0aW9uX2J1aWxkOiBXRUJLSVRfQ09ORklHICs9IGdlb2xvY2F0aW9uCi0KLSAg ICAjIE9yaWVudGF0aW9uIHN1cHBvcnQgaWYgUXRTZW5zb3JzIGV4aXN0cyBvciBpZiB3ZSdyZSBk b2luZyBhIGRldmVsb3BlciBidWlsZCAoTW9jayBpbXBsZW1lbnRhdGlvbiBleGlzdHMKLSAgICAj IGFuZCB1c2VkIGZvciBsYXlvdXQgdGVzdHMpCi0gICAgaGF2ZT8ocXRzZW5zb3JzKXwhcHJvZHVj dGlvbl9idWlsZDogV0VCS0lUX0NPTkZJRyArPSBvcmllbnRhdGlvbl9ldmVudHMgZGV2aWNlX29y aWVudGF0aW9uCi0KICAgICAjIEhUTUw1IE1lZGlhIFN1cHBvcnQgZm9yIG5vbi1NYWMgYnVpbGRz CiAgICAgIW1hYyB7CiAgICAgICAgICFjb250YWlucyhRVF9DT05GSUcsIG5vLXBrZy1jb25maWcp IHsKQEAgLTE1NSw2ICsxNDcsMTIgQEAgZGVmaW5lVGVzdChkZXRlY3RGZWF0dXJlcykgewogfQog CiBkZWZpbmVUZXN0KHNhbnRpemVGZWF0dXJlcykgeworICAgICMgSWYgd2UgYXJlIGRvaW5nIGEg cHJvZHVjdGlvbl9idWlsZCB3ZSBzaG91bGQgb25seSBlbmFibGUgR2VvbG9jYXRpb24gc3VwcG9y dCBpZiBRdFBvc2l0aW9uaW5nIGV4aXN0cy4gSW4gZGV2ZWxvcGVyIGJ1aWxkcyB3ZSBjYW4gdXNl IE1vY2sgaW1wbGVtZW50YXRpb25zLgorICAgIHByb2R1Y3Rpb25fYnVpbGQ6IWhhdmU/KHF0cG9z aXRpb25pbmcpOiBXRUJLSVRfQ09ORklHIC09IGdlb2xvY2F0aW9uCisKKyAgICAjIElmIHdlIGFy ZSBkb2luZyBhIHByb2R1Y3Rpb25fYnVpbGQgd2Ugc2hvdWxkIG9ubHkgZW5hYmxlIE9yaWVudGF0 aW9uIHN1cHBvcnQgaWYgUXRTZW5zb3JzIGV4aXN0cy4gSW4gZGV2ZWxvcGVyIGJ1aWxkcyB3ZSBj YW4gdXNlIE1vY2sgaW1wbGVtZW50YXRpb25zLgorICAgIHByb2R1Y3Rpb25fYnVpbGQ6IWhhdmU/ KHF0c2Vuc29ycyk6IFdFQktJVF9DT05GSUcgLT0gb3JpZW50YXRpb25fZXZlbnRzIGRldmljZV9v cmllbnRhdGlvbgorCiAgICAgIyBEaXNhYmxlIFNWRyBmb250cyBpZiBTVkcgaXMgZGlzYWJsZWQK ICAgICAhZW5hYmxlPyhzdmcpOiBXRUJLSVRfQ09ORklHIC09IHN2Z19mb250cwogCmRpZmYgLS1n aXQgYS9Ub29scy9xbWFrZS9ta3NwZWNzL2ZlYXR1cmVzL2ZlYXR1cmVzLnByaSBiL1Rvb2xzL3Ft YWtlL21rc3BlY3MvZmVhdHVyZXMvZmVhdHVyZXMucHJpCmluZGV4IDllYzQzNzE1NWU0ZjllOGM2 M2ZjMDU4M2RhNjhjY2FmNTBkNjhhM2UuLmNiYTViNGJmODRhNGJmYjBmYzY2MTg3ZmVmNGZjODEz ZTgzMzcwOTcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvZmVhdHVy ZXMucHJpCisrKyBiL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvZmVhdHVyZXMucHJpCkBA IC00NSw3ICs0NSw3IEBAIEZFQVRVUkVfREVGQVVMVFMgPSBcCiAgICAgRU5BQkxFX0RBVEFMSVNU X0VMRU1FTlQ9MSBcCiAgICAgRU5BQkxFX0RBVEFfVFJBTlNGRVJfSVRFTVM9MCBcCiAgICAgRU5B QkxFX0RFVEFJTFNfRUxFTUVOVD0xIFwKLSAgICBFTkFCTEVfREVWSUNFX09SSUVOVEFUSU9OPTAg XAorICAgIEVOQUJMRV9ERVZJQ0VfT1JJRU5UQVRJT049MSBcCiAgICAgRU5BQkxFX0RJUkVDVE9S WV9VUExPQUQ9MCBcCiAgICAgRU5BQkxFX0RPTTRfRVZFTlRTX0NPTlNUUlVDVE9SPTAgXAogICAg IEVOQUJMRV9ET1dOTE9BRF9BVFRSSUJVVEU9MCBcCkBAIC01Nyw3ICs1Nyw3IEBAIEZFQVRVUkVf REVGQVVMVFMgPSBcCiAgICAgRU5BQkxFX0ZUUERJUj0xIFwKICAgICBFTkFCTEVfRlVMTFNDUkVF Tl9BUEk9MSBcCiAgICAgRU5BQkxFX0dBTUVQQUQ9MCBcCi0gICAgRU5BQkxFX0dFT0xPQ0FUSU9O PTAgXAorICAgIEVOQUJMRV9HRU9MT0NBVElPTj0xIFwKICAgICBFTkFCTEVfR0VTVFVSRV9FVkVO VFM9MSBcCiAgICAgRU5BQkxFX0hJR0hfRFBJX0NBTlZBUz0wIFwKICAgICBFTkFCTEVfSUNPTkRB VEFCQVNFPTEgXApAQCAtOTQsNyArOTQsNyBAQCBGRUFUVVJFX0RFRkFVTFRTID0gXAogICAgIEVO QUJMRV9OT1NOSUZGPTAgXAogICAgIEVOQUJMRV9OT1RJRklDQVRJT05TPTEgXAogICAgIEVOQUJM RV9PUEVOQ0w9MCBcCi0gICAgRU5BQkxFX09SSUVOVEFUSU9OX0VWRU5UUz0wIFwKKyAgICBFTkFC TEVfT1JJRU5UQVRJT05fRVZFTlRTPTEgXAogICAgIEVOQUJMRV9QQUdFX1ZJU0lCSUxJVFlfQVBJ PTEgXAogICAgIEVOQUJMRV9QRVJGT1JNQU5DRV9USU1FTElORT0wIFwKICAgICBFTkFCTEVfUFJP R1JFU1NfRUxFTUVOVD0xIFwK