121945 2013-09-26 01:53:51 -0700 Fix ordered comparison warnings in BitmapImage::drawPattern 2013-09-26 09:52:48 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 seokju seokju commit-queue gyuyoung.kim oldest_to_newest 933408 0 seokju 2013-09-26 01:53:51 -0700 gcc 4.7 warns about the pointer to integer comparison. Debug build breaks on EFL. WebKit/Source/WebCore/platform/graphics/BitmapImage.cpp:509:9: error: ordered comparison of pointer with integer zero [-Werror=extra] 933409 1 212676 seokju 2013-09-26 01:56:49 -0700 Created attachment 212676 Patch 933412 2 seokju 2013-09-26 01:59:05 -0700 CCing gyuyoung 933540 3 212676 darin 2013-09-26 09:25:30 -0700 Comment on attachment 212676 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212676&action=review > Source/WebCore/platform/graphics/BitmapImage.cpp:509 > + ASSERT(buffer.get()); ASSERT(buffer) should work without the get(). 933554 4 212676 commit-queue 2013-09-26 09:52:46 -0700 Comment on attachment 212676 Patch Clearing flags on attachment: 212676 Committed r156465: <http://trac.webkit.org/changeset/156465> 933555 5 commit-queue 2013-09-26 09:52:48 -0700 All reviewed patches have been landed. Closing bug. 212676 2013-09-26 01:56:49 -0700 2013-09-26 09:52:46 -0700 Patch bug-121945-20130926175648.patch text/plain 1434 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2NDUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGVhNGI2NmQyYzBlM2Uy YzM0YmJkNGMwNjZiMWU0MTVhYTIzOTMyNi4uYzdiZGFlNGUwY2FmMWM5MWE3NTBmNzFjMWI5NDFh NWI3Zjc0YjMwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA5LTI2ICBTZW9r anUgS3dvbiAgPHNlb2tqdUB3ZWJraXQub3JnPgorCisgICAgICAgIEZpeCBvcmRlcmVkIGNvbXBh cmlzb24gd2FybmluZ3MgaW4gQml0bWFwSW1hZ2U6OmRyYXdQYXR0ZXJuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjE5NDUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2 aW9yIGNoYW5nZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdlLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkJpdG1hcEltYWdlOjpkcmF3UGF0dGVybik6CisKIDIwMTMt MDktMjYgIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CiAKICAgICAgICAgW0NT U1JlZ2lvbnNdIFVuYWJsZSB0byBjb2xsZWN0IGh0bWwgZWxlbWVudCBpbiBhIG5hbWVkIGZsb3cK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdl LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdlLmNwcApp bmRleCA1Mzk1YWYzNTg0MzVmMjVlMmZjOWFjMjhmMzFiOTY3NDQ5OGVlODhmLi5iZDBjNGUxYjY0 ODllNTBkNmZhYTliNjBkMTE3ZDE0NTE0OTA0NjY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9CaXRtYXBJbWFnZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvQml0bWFwSW1hZ2UuY3BwCkBAIC01MDYsNyArNTA2LDcgQEAgdm9p ZCBCaXRtYXBJbWFnZTo6ZHJhd1BhdHRlcm4oR3JhcGhpY3NDb250ZXh0KiBjdHh0LCBjb25zdCBG bG9hdFJlY3QmIHRpbGVSZWN0LAogICAgIH0KICAgICBpZiAoIW1fY2FjaGVkSW1hZ2UpIHsKICAg ICAgICAgT3duUHRyPEltYWdlQnVmZmVyPiBidWZmZXIgPSBJbWFnZUJ1ZmZlcjo6Y3JlYXRlKGV4 cGFuZGVkSW50U2l6ZSh0aWxlUmVjdC5zaXplKCkpKTsKLSAgICAgICAgQVNTRVJUKGJ1ZmZlci5n ZXQoKSA+IDApOworICAgICAgICBBU1NFUlQoYnVmZmVyLmdldCgpKTsKIAogICAgICAgICBJbWFn ZU9ic2VydmVyKiBvYnNlcnZlciA9IGltYWdlT2JzZXJ2ZXIoKTsKICAgICAgICAgQVNTRVJUKG9i c2VydmVyKTsK